NFC - Moved AffineOps related transforms
Change AffineOps Dialect structure to better group both IR and Tranforms. This included extracting transforms directly related to AffineOps. Also move AffineOps to Affine.
Paths
| Differential D76161
NFC - Moved AffineOps IR / Transforms ClosedPublic Authored by rsuderman on Mar 13 2020, 1:55 PM.
Details Summary NFC - Moved AffineOps related transforms Change AffineOps Dialect structure to better group both IR and Tranforms. This included extracting transforms directly related to AffineOps. Also move AffineOps to Affine.
Diff Detail
Event TimelineComment Actions I think this has a lot of conflict potential with a revision by @ftynse, maybe check with him? Comment Actions Updated CMake build to pass. Updating D76161: Moved AffineOps IR / TransformsChange AffineOps Dialect structure to better group both IR and Tranforms. This Comment Actions Typo Updating D76161: Moved AffineOps IR / TransformsChange AffineOps Dialect structure to better group both IR and Tranforms. This Comment Actions
I'll make sure to loop him in on the review. rsuderman retitled this revision from Moved AffineOps IR / Transforms
Change AffineOps Dialect structure to better group both IR and Tranforms. This
included extracting transforms direclty related to AffineOps to Moved AffineOps IR / TransformsChange AffineOps Dialect structure to better group both IR and Tranforms. Thisincluded extracting transforms direclty related to AffineOps.Mar 13 2020, 4:34 PM rsuderman edited reviewers, added: rriddle, ftynse; removed: mravishankar, nicolasvasilache, herhut.Mar 13 2020, 4:34 PM
Comment Actions Please see this discussion started by @ftynse This revision now requires changes to proceed.Mar 13 2020, 9:04 PM Comment Actions @rsuderman @mehdi_amini @bondhugula the renaming AffineOps -> Affine is part of the conflicting changes @ftynse has in flight and was holding off on submitting because internal integration would be impacted. Comment Actions
Its been over a week, that isn't great justification. I'm pretty sure he's just on vacation.
rsuderman retitled this revision from Moved AffineOps IR / TransformsChange AffineOps Dialect structure to better group both IR and Tranforms. Thisincluded extracting transforms direclty related to AffineOps to NFC - Moved AffineOps IR / Transforms.Mar 16 2020, 11:21 AM This revision is now accepted and ready to land.Mar 19 2020, 6:41 PM Closed by commit rGe708471395b6: [mlir][NFC] Cleanup AffineOps directory structure (authored by rsuderman, committed by rriddle). · Explain WhyMar 20 2020, 2:40 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 251715 mlir/docs/Interfaces.md
mlir/docs/Tutorials/Toy/Ch-5.md
mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp
mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp
mlir/examples/toy/Ch6/mlir/LowerToLLVM.cpp
mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp
mlir/examples/toy/Ch7/mlir/LowerToLLVM.cpp
mlir/include/mlir/Dialect/Affine/EDSC/Builders.h
mlir/include/mlir/Dialect/Affine/EDSC/Intrinsics.h
mlir/include/mlir/Dialect/Affine/IR/AffineOps.h
mlir/include/mlir/Dialect/Affine/IR/AffineOps.td
mlir/include/mlir/Dialect/Affine/IR/AffineOpsBase.td
mlir/include/mlir/Dialect/Affine/IR/AffineValueMap.h
mlir/include/mlir/Dialect/Affine/IR/CMakeLists.txt
mlir/include/mlir/Dialect/Affine/Passes.h
mlir/include/mlir/Dialect/AffineOps/AffineOps.h
mlir/include/mlir/Dialect/AffineOps/AffineOps.td
mlir/include/mlir/Dialect/AffineOps/AffineOpsBase.td
mlir/include/mlir/Dialect/AffineOps/AffineValueMap.h
mlir/include/mlir/Dialect/AffineOps/CMakeLists.txt
mlir/include/mlir/Dialect/AffineOps/EDSC/Builders.h
mlir/include/mlir/Dialect/AffineOps/EDSC/Intrinsics.h
mlir/include/mlir/Dialect/CMakeLists.txt
mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td
mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransformPatterns.td
mlir/include/mlir/Dialect/Vector/VectorOps.td
mlir/include/mlir/Dialect/VectorOps/VectorOps.td
mlir/include/mlir/InitAllDialects.h
mlir/include/mlir/InitAllPasses.h
mlir/include/mlir/Transforms/Passes.h
mlir/lib/Analysis/AffineAnalysis.cpp
mlir/lib/Analysis/AffineStructures.cpp
mlir/lib/Analysis/CMakeLists.txt
mlir/lib/Analysis/LoopAnalysis.cpp
mlir/lib/Analysis/NestedMatcher.cpp
mlir/lib/Analysis/SliceAnalysis.cpp
mlir/lib/Analysis/Utils.cpp
mlir/lib/Conversion/AffineToStandard/AffineToStandard.cpp
mlir/lib/Conversion/AffineToStandard/CMakeLists.txt
mlir/lib/Conversion/LoopsToGPU/CMakeLists.txt
mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp
mlir/lib/Conversion/LoopsToGPU/LoopsToGPUPass.cpp
mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp
mlir/lib/Dialect/Affine/CMakeLists.txt
mlir/lib/Dialect/Affine/EDSC/Builders.cpp
mlir/lib/Dialect/Affine/EDSC/CMakeLists.txt
mlir/lib/Dialect/Affine/IR/AffineOps.cpp
mlir/lib/Dialect/Affine/IR/AffineValueMap.cpp
mlir/lib/Dialect/Affine/IR/CMakeLists.txt
mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp
mlir/lib/Dialect/Affine/Transforms/AffineLoopInvariantCodeMotion.cpp
mlir/lib/Dialect/Affine/Transforms/CMakeLists.txt
mlir/lib/Dialect/Affine/Transforms/SimplifyAffineStructures.cpp
mlir/lib/Dialect/AffineOps/AffineOps.cpp
mlir/lib/Dialect/AffineOps/AffineValueMap.cpp
mlir/lib/Dialect/AffineOps/CMakeLists.txt
mlir/lib/Dialect/AffineOps/EDSC/Builders.cpp
mlir/lib/Dialect/CMakeLists.txt
mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
mlir/lib/Dialect/Linalg/EDSC/CMakeLists.txt
mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt
mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp
mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
mlir/lib/Dialect/Linalg/Utils/CMakeLists.txt
mlir/lib/Dialect/Linalg/Utils/Utils.cpp
mlir/lib/Dialect/LoopOps/Transforms/CMakeLists.txt
mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopSpecialization.cpp
mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopTiling.cpp
mlir/lib/Dialect/Vector/CMakeLists.txt
mlir/lib/Dialect/Vector/VectorTransforms.cpp
mlir/lib/Dialect/Vector/VectorUtils.cpp
mlir/lib/Dialect/VectorOps/VectorTransforms.cpp
mlir/lib/Dialect/VectorOps/VectorUtils.cpp
mlir/lib/Transforms/AffineDataCopyGeneration.cpp
mlir/lib/Transforms/AffineLoopInvariantCodeMotion.cpp
mlir/lib/Transforms/CMakeLists.txt
mlir/lib/Transforms/LoopFusion.cpp
mlir/lib/Transforms/LoopTiling.cpp
mlir/lib/Transforms/LoopUnroll.cpp
mlir/lib/Transforms/LoopUnrollAndJam.cpp
mlir/lib/Transforms/MemRefDataFlowOpt.cpp
mlir/lib/Transforms/PipelineDataTransfer.cpp
mlir/lib/Transforms/SimplifyAffineStructures.cpp
mlir/lib/Transforms/Utils/CMakeLists.txt
mlir/lib/Transforms/Utils/LoopFusionUtils.cpp
mlir/lib/Transforms/Utils/LoopUtils.cpp
mlir/lib/Transforms/Utils/Utils.cpp
mlir/lib/Transforms/Vectorize.cpp
mlir/test/Dialect/Affine/canonicalize.mlir
mlir/test/Dialect/Affine/dma.mlir
mlir/test/Dialect/Affine/inlining.mlir
mlir/test/Dialect/Affine/invalid.mlir
mlir/test/Dialect/Affine/load-store-invalid.mlir
mlir/test/Dialect/Affine/load-store.mlir
mlir/test/Dialect/Affine/memref-stride-calculation.mlir
mlir/test/Dialect/Affine/ops.mlir
mlir/test/Dialect/AffineOps/canonicalize.mlir
mlir/test/Dialect/AffineOps/inlining.mlir
mlir/test/Dialect/AffineOps/invalid.mlir
mlir/test/Dialect/AffineOps/load-store-invalid.mlir
mlir/test/Dialect/AffineOps/load-store.mlir
mlir/test/Dialect/AffineOps/memref-stride-calculation.mlir
mlir/test/EDSC/CMakeLists.txt
mlir/test/EDSC/builder-api-test.cpp
mlir/test/lib/Dialect/Affine/CMakeLists.txt
mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
mlir/test/lib/Dialect/CMakeLists.txt
mlir/test/lib/Transforms/CMakeLists.txt
mlir/test/lib/Transforms/TestAffineDataCopy.cpp
mlir/test/lib/Transforms/TestConstantFold.cpp
mlir/test/lib/Transforms/TestLoopFusion.cpp
mlir/test/lib/Transforms/TestMemRefBoundCheck.cpp
mlir/test/lib/Transforms/TestMemRefDependenceCheck.cpp
mlir/test/lib/Transforms/TestParallelismDetection.cpp
mlir/test/lib/Transforms/TestVectorizationUtils.cpp
mlir/tools/mlir-opt/CMakeLists.txt
|
Can you update each of these header guard comments now?