Page MenuHomePhabricator

rsuderman (Rob Suderman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 2 2020, 10:50 AM (129 w, 6 d)

Recent Activity

Wed, Jun 15

rsuderman committed rG640973f2b99b: [tosa] Lower tosa.slice to tensor.slice for dynamic case (authored by rsuderman).
[tosa] Lower tosa.slice to tensor.slice for dynamic case
Wed, Jun 15, 10:02 AM · Restricted Project, Restricted Project
rsuderman closed D127704: [tosa] Lower tosa.slice to tensor.slice for dynamic case.
Wed, Jun 15, 10:01 AM · Restricted Project, Restricted Project

Mon, Jun 13

rsuderman added a reviewer for D127704: [tosa] Lower tosa.slice to tensor.slice for dynamic case: NatashaKnk.
Mon, Jun 13, 4:03 PM · Restricted Project, Restricted Project
rsuderman requested review of D127704: [tosa] Lower tosa.slice to tensor.slice for dynamic case.
Mon, Jun 13, 4:02 PM · Restricted Project, Restricted Project

Wed, Jun 8

rsuderman requested changes to D127332: [mlir][tosa] Update TOSA transpose_conv2d to match spec.
Wed, Jun 8, 4:38 PM · Restricted Project, Restricted Project

Mon, Jun 6

rsuderman added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Hello all.
Any more comments on this? @jpienaar @rsuderman @stellaraccident

Mon, Jun 6, 12:55 PM · Restricted Project, Restricted Project

Wed, Jun 1

rsuderman added inline comments to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.
Wed, Jun 1, 11:52 AM · Restricted Project, Restricted Project
rsuderman committed rGf3bdb56d61e3: [mlir][math] Add math.ctlz expansion to control flow + arith operations (authored by rsuderman).
[mlir][math] Add math.ctlz expansion to control flow + arith operations
Wed, Jun 1, 11:50 AM · Restricted Project, Restricted Project
rsuderman closed D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.
Wed, Jun 1, 11:50 AM · Restricted Project, Restricted Project

May 26 2022

rsuderman added a comment to D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.

Update for natashaknk@'s comments.

May 26 2022, 4:45 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.

Woops, slight typo

May 26 2022, 4:45 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.

Changed var name to be more correct.

May 26 2022, 4:44 PM · Restricted Project, Restricted Project

May 24 2022

rsuderman accepted D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Appears good to me - @jpienaar any remaining comments?

May 24 2022, 10:35 AM · Restricted Project, Restricted Project

May 23 2022

rsuderman added a reviewer for D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations: NatashaKnk.
May 23 2022, 5:33 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.

Added missing newline

May 23 2022, 5:32 PM · Restricted Project, Restricted Project
rsuderman requested review of D126261: [mlir][math] Add math.ctlz expansion to control flow + arith operations.
May 23 2022, 5:31 PM · Restricted Project, Restricted Project
rsuderman committed rGbedd3ee88152: [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse. (authored by NatashaKnk).
[mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse.
May 23 2022, 11:30 AM · Restricted Project, Restricted Project
rsuderman closed D126212: [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse..
May 23 2022, 11:30 AM · Restricted Project, Restricted Project
rsuderman accepted D126212: [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse..
May 23 2022, 10:56 AM · Restricted Project, Restricted Project
rsuderman retitled D126212: [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse. from [mlir][tosa] Change depthwise_conv2d reshape at the end of the lowering to a collapse. to [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse..
May 23 2022, 10:54 AM · Restricted Project, Restricted Project
rsuderman retitled D126212: [mlir][tosa] Change tosa.depthwise_conv2d's ending reshape to a collapse. from [mlir][tosa] change the reshape at the end of the depthwise_conv2d lowering to a collapse. to [mlir][tosa] Change depthwise_conv2d reshape at the end of the lowering to a collapse..
May 23 2022, 10:51 AM · Restricted Project, Restricted Project

May 17 2022

rsuderman committed rG9294a1e9a8ab: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit (authored by Robert Suderman <suderman@google.com>).
[mlir][tosa] Rework tosa.apply_scale lowering for 32-bit
May 17 2022, 4:13 PM · Restricted Project, Restricted Project
rsuderman closed D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.
May 17 2022, 4:13 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Update relative benefit

May 17 2022, 1:53 PM · Restricted Project, Restricted Project
rsuderman added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Good point about potentially expensive operations here, I wonder: why is/was this a canonicalization pattern rather than fold implementation?

Not sure @jpienaar why this was registered as a canonicalization originally. Can comment though that have noticed this being quite expensive. Moreover, a similar folding step takes place at Linalg level from what I recall.

May 17 2022, 11:59 AM · Restricted Project, Restricted Project
rsuderman updated the diff for D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Resyncing

May 17 2022, 11:42 AM · Restricted Project, Restricted Project

May 16 2022

rsuderman added inline comments to D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.
May 16 2022, 5:55 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Added default 32-bit setting.

May 16 2022, 5:54 PM · Restricted Project, Restricted Project
rsuderman added inline comments to D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.
May 16 2022, 2:15 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Updated for change how TosaToArith target 32-bit vs 64-bit.

May 16 2022, 1:59 PM · Restricted Project, Restricted Project
rsuderman committed rGcb4a5eae1eb3: [mlir][tosa] Use math.ctlz intrinsic for tosa.clz (authored by Robert Suderman <suderman@google.com>).
[mlir][tosa] Use math.ctlz intrinsic for tosa.clz
May 16 2022, 12:05 PM · Restricted Project, Restricted Project
rsuderman closed D125592: [mlir][tosa] Use math.ctlz intrinsic for tosa.clz.
May 16 2022, 12:05 PM · Restricted Project, Restricted Project

May 13 2022

rsuderman updated the diff for D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Dag-ified the checks

May 13 2022, 4:37 PM · Restricted Project, Restricted Project
rsuderman added a reviewer for D125592: [mlir][tosa] Use math.ctlz intrinsic for tosa.clz: mravishankar.
May 13 2022, 4:35 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D125592: [mlir][tosa] Use math.ctlz intrinsic for tosa.clz.

Removed the old implementation.

May 13 2022, 4:34 PM · Restricted Project, Restricted Project
rsuderman requested review of D125592: [mlir][tosa] Use math.ctlz intrinsic for tosa.clz.
May 13 2022, 4:33 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Tweaked the 64-bit path to slightly decrease the amount of IR.

May 13 2022, 2:59 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.

Tweaked to clean up a bit.

May 13 2022, 2:19 PM · Restricted Project, Restricted Project
rsuderman added reviewers for D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit: dcaballe, mravishankar.
May 13 2022, 1:37 PM · Restricted Project, Restricted Project
rsuderman requested review of D125583: [mlir][tosa] Rework tosa.apply_scale lowering for 32-bit.
May 13 2022, 1:36 PM · Restricted Project, Restricted Project

May 5 2022

rsuderman added a comment to D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..

Seeing a failure when cherry-picked into IREE head. Do we know that TensorReshape has a lowering path for dynamic shapes?

May 5 2022, 11:55 AM · Restricted Project, Restricted Project

May 4 2022

rsuderman added a comment to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Second observation - can you include this pass after the canonicalizer when lowering to linalg?

May 4 2022, 12:02 PM · Restricted Project, Restricted Project

Apr 29 2022

rsuderman accepted D124578: [mlir][tosa] Change tosa.reshape lowering to use the tensor.reshape op..
Apr 29 2022, 11:37 AM · Restricted Project, Restricted Project
rsuderman requested changes to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.
Apr 29 2022, 11:31 AM · Restricted Project, Restricted Project
rsuderman added inline comments to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.
Apr 29 2022, 11:31 AM · Restricted Project, Restricted Project

Apr 7 2022

rsuderman committed rGfac9f45e0500: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa… (authored by NatashaKnk).
[tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa…
Apr 7 2022, 10:51 AM · Restricted Project, Restricted Project
rsuderman closed D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.
Apr 7 2022, 10:51 AM · Restricted Project, Restricted Project

Apr 4 2022

rsuderman committed rG126e7eaf0d4e: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard (authored by rsuderman).
[tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard
Apr 4 2022, 12:30 PM · Restricted Project, Restricted Project
rsuderman closed D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard.
Apr 4 2022, 12:30 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard.

Updated for cleanup comments.

Apr 4 2022, 11:21 AM · Restricted Project, Restricted Project

Apr 1 2022

rsuderman added inline comments to D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard.
Apr 1 2022, 7:08 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard.

Added the additional comments in.

Apr 1 2022, 7:07 PM · Restricted Project, Restricted Project
rsuderman updated the diff for D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard.

Split TosaToStandard split to TosaToArith and TosaToTensor

Apr 1 2022, 7:01 PM · Restricted Project, Restricted Project
rsuderman added a reviewer for D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard: jpienaar.
Apr 1 2022, 5:10 PM · Restricted Project, Restricted Project
rsuderman requested review of D122948: [tosa] Add option to disable tosa.apply_scale lowering in TosaToStandard.
Apr 1 2022, 5:04 PM · Restricted Project, Restricted Project

Mar 21 2022

rsuderman added inline comments to D121872: [tosa][mlir] Add dynamic width/height support for depthwise convolution in tosa-to-linalg.
Mar 21 2022, 11:25 AM · Restricted Project, Restricted Project

Mar 2 2022

rsuderman committed rG8d7a833eed1a: [tosa][mlir] Add support for dynamic width/height for Conv2D inputs in tosa-to… (authored by NatashaKnk).
[tosa][mlir] Add support for dynamic width/height for Conv2D inputs in tosa-to…
Mar 2 2022, 12:23 PM · Restricted Project
rsuderman closed D119977: [tosa][mlir] Add support for dynamic width/height for Conv2D inputs in tosa-to-linalg.
Mar 2 2022, 12:23 PM · Restricted Project, Restricted Project

Feb 28 2022

rsuderman committed rGfd2550d80cf5: Adds a flag to optionally disable tosa decompositions (authored by not-jenni).
Adds a flag to optionally disable tosa decompositions
Feb 28 2022, 3:45 PM
rsuderman closed D120338: Adds a flag to optionally disable tosa decompositions.
Feb 28 2022, 3:45 PM · Restricted Project
rsuderman accepted D120338: Adds a flag to optionally disable tosa decompositions.
Feb 28 2022, 3:28 PM · Restricted Project

Feb 22 2022

rsuderman added inline comments to D119977: [tosa][mlir] Add support for dynamic width/height for Conv2D inputs in tosa-to-linalg.
Feb 22 2022, 4:49 PM · Restricted Project, Restricted Project

Feb 17 2022

rsuderman accepted D120020: [mlir] Propagate NaNs in PolynomialApproximation.
Feb 17 2022, 10:47 AM · Restricted Project

Feb 4 2022

rsuderman added a comment to D118968: [mlir][math] Expand coverage of atan2 expansion.

Mind changing the atan2 test to run on f16? It should handle all possible cases that way.

Feb 4 2022, 10:56 AM · Restricted Project

Jan 27 2022

rsuderman committed rG024a1fab5c35: [tosa][mlir] Add dynamic shape support for remaining ops (authored by NatashaKnk).
[tosa][mlir] Add dynamic shape support for remaining ops
Jan 27 2022, 11:36 AM
rsuderman closed D118397: [tosa][mlir] Add dynamic shape support for remaining ops.
Jan 27 2022, 11:36 AM · Restricted Project
rsuderman accepted D118397: [tosa][mlir] Add dynamic shape support for remaining ops.
Jan 27 2022, 11:25 AM · Restricted Project

Jan 25 2022

rsuderman committed rG7c984be21a35: [mlir] Propagate arith.index_cast past tensor.extract (authored by rsuderman).
[mlir] Propagate arith.index_cast past tensor.extract
Jan 25 2022, 10:19 PM
rsuderman closed D118204: [mlir] Propagate arith.index_cast past tensor.extract.
Jan 25 2022, 10:19 PM · Restricted Project
rsuderman updated the diff for D118204: [mlir] Propagate arith.index_cast past tensor.extract.

Updated comment and type information.

Jan 25 2022, 10:14 PM · Restricted Project
rsuderman added inline comments to D118204: [mlir] Propagate arith.index_cast past tensor.extract.
Jan 25 2022, 5:10 PM · Restricted Project
rsuderman added a comment to D118204: [mlir] Propagate arith.index_cast past tensor.extract.

Missing a test?

Jan 25 2022, 5:06 PM · Restricted Project
rsuderman updated the diff for D118204: [mlir] Propagate arith.index_cast past tensor.extract.

Added missing test.

Jan 25 2022, 5:06 PM · Restricted Project
rsuderman added a reviewer for D118204: [mlir] Propagate arith.index_cast past tensor.extract: rriddle.
Jan 25 2022, 4:55 PM · Restricted Project
rsuderman requested review of D118204: [mlir] Propagate arith.index_cast past tensor.extract.
Jan 25 2022, 4:54 PM · Restricted Project
rsuderman committed rGd81a3c51e7f7: [mlir] Fold tensor.reshape operations into tensor.from_elements. (authored by rsuderman).
[mlir] Fold tensor.reshape operations into tensor.from_elements.
Jan 25 2022, 3:57 PM
rsuderman closed D118201: [mlir] Fold tensor.reshape operations into tensor.from_elements..
Jan 25 2022, 3:57 PM · Restricted Project
rsuderman added a reviewer for D118201: [mlir] Fold tensor.reshape operations into tensor.from_elements.: rriddle.
Jan 25 2022, 3:51 PM · Restricted Project
rsuderman updated the diff for D118201: [mlir] Fold tensor.reshape operations into tensor.from_elements..

Simplified getDefiningOp behavior.

Jan 25 2022, 3:50 PM · Restricted Project
rsuderman updated the diff for D118201: [mlir] Fold tensor.reshape operations into tensor.from_elements..

Synced to head.

Jan 25 2022, 3:47 PM · Restricted Project
rsuderman added a reviewer for D118201: [mlir] Fold tensor.reshape operations into tensor.from_elements.: NatashaKnk.
Jan 25 2022, 3:38 PM · Restricted Project
rsuderman requested review of D118201: [mlir] Fold tensor.reshape operations into tensor.from_elements..
Jan 25 2022, 3:38 PM · Restricted Project

Jan 24 2022

rsuderman committed rG3e746c6d9ef0: [mlir] Add support for ExpM1 to GLSL/OpenCL SPIRV Backends (authored by rsuderman).
[mlir] Add support for ExpM1 to GLSL/OpenCL SPIRV Backends
Jan 24 2022, 3:42 PM
rsuderman closed D118081: [mlir] Add support for ExpM1 to GLSL/OpenCL SPIRV Backends.
Jan 24 2022, 3:42 PM · Restricted Project
rsuderman updated the diff for D118081: [mlir] Add support for ExpM1 to GLSL/OpenCL SPIRV Backends.

Fixed for nits.

Jan 24 2022, 3:37 PM · Restricted Project
rsuderman updated the diff for D118081: [mlir] Add support for ExpM1 to GLSL/OpenCL SPIRV Backends.

Synced to head.

Jan 24 2022, 3:10 PM · Restricted Project
rsuderman requested review of D118081: [mlir] Add support for ExpM1 to GLSL/OpenCL SPIRV Backends.
Jan 24 2022, 2:55 PM · Restricted Project

Jan 21 2022

rsuderman committed rG08574ce4d625: [mlir][tosa] Add clamp + clamp as single clamp canonicalization (authored by not-jenni).
[mlir][tosa] Add clamp + clamp as single clamp canonicalization
Jan 21 2022, 4:27 PM
rsuderman closed D117934: [mlir][tosa] Add clamp + clamp as single clamp canonicalization.
Jan 21 2022, 4:27 PM · Restricted Project
rsuderman accepted D117934: [mlir][tosa] Add clamp + clamp as single clamp canonicalization.
Jan 21 2022, 4:16 PM · Restricted Project
rsuderman committed rG2f9f9afa4e12: [mlir] Add polynomial approximation for atan and atan2 (authored by rsuderman).
[mlir] Add polynomial approximation for atan and atan2
Jan 21 2022, 12:31 PM
rsuderman closed D115682: [mlir] Add polynomial approximation for atan and atan2.
Jan 21 2022, 12:31 PM · Restricted Project

Jan 20 2022

rsuderman committed rGcd2d7369639e: [mlir][tosa] Limit right-shift to 31 bits (authored by rsuderman).
[mlir][tosa] Limit right-shift to 31 bits
Jan 20 2022, 2:42 PM
rsuderman closed D117732: [mlir][tosa] Limit right-shift to 31 bits.
Jan 20 2022, 2:42 PM · Restricted Project

Jan 19 2022

rsuderman added a reviewer for D117732: [mlir][tosa] Limit right-shift to 31 bits: mehdi_amini.
Jan 19 2022, 4:34 PM · Restricted Project
rsuderman requested review of D117732: [mlir][tosa] Limit right-shift to 31 bits.
Jan 19 2022, 4:34 PM · Restricted Project
rsuderman committed rGb9b10c0e615f: [tosa][mlir] Lowering for dynamic shapes in the reduce_x ops in tosa-to-linalg (authored by NatashaKnk).
[tosa][mlir] Lowering for dynamic shapes in the reduce_x ops in tosa-to-linalg
Jan 19 2022, 11:19 AM
rsuderman closed D117691: [tosa][mlir] Lowering for dynamic shapes in the reduce_x ops in tosa-to-linalg.
Jan 19 2022, 11:18 AM · Restricted Project
rsuderman accepted D117691: [tosa][mlir] Lowering for dynamic shapes in the reduce_x ops in tosa-to-linalg.
Jan 19 2022, 11:05 AM · Restricted Project

Jan 18 2022

rsuderman committed rG41d05e29c04f: [mlir][tosa] Add tosa.clamp as no-op canonicalization (authored by not-jenni).
[mlir][tosa] Add tosa.clamp as no-op canonicalization
Jan 18 2022, 11:18 PM