Page MenuHomePhabricator

rsuderman (Rob Suderman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 2 2020, 10:50 AM (77 w, 10 h)

Recent Activity

Mon, Jun 21

rsuderman committed rGad1a9d629b75: [mlir][tosa] Enable tosa.div for TosaMakeBroadcastable (authored by rsuderman).
[mlir][tosa] Enable tosa.div for TosaMakeBroadcastable
Mon, Jun 21, 4:19 PM
rsuderman closed D104157: [mlir][tosa] Enable tosa.div for TosaMakeBroadcastable.
Mon, Jun 21, 4:19 PM · Restricted Project
rsuderman added a reviewer for D104493: [mlir][tosa] Add InferReturnTypes for N-ary operations: NatashaKnk.
Mon, Jun 21, 11:01 AM · Restricted Project

Thu, Jun 17

rsuderman requested review of D104493: [mlir][tosa] Add InferReturnTypes for N-ary operations.
Thu, Jun 17, 3:59 PM · Restricted Project

Mon, Jun 14

rsuderman added a comment to D104224: [mlir][linalg] Adapt yaml codegen to support scalar parameters..

Mind rebasing this on head? Presubmits are failing due to not being on a commited CL.

Mon, Jun 14, 9:59 AM · Restricted Project

Fri, Jun 11

rsuderman added a reviewer for D104157: [mlir][tosa] Enable tosa.div for TosaMakeBroadcastable: NatashaKnk.
Fri, Jun 11, 4:30 PM · Restricted Project
rsuderman requested review of D104157: [mlir][tosa] Enable tosa.div for TosaMakeBroadcastable.
Fri, Jun 11, 4:29 PM · Restricted Project

Wed, Jun 9

rsuderman committed rG0e083cef7003: [mlir][tosa] Update tosa.matmul lowering to linalg.batch_matmul (authored by rsuderman).
[mlir][tosa] Update tosa.matmul lowering to linalg.batch_matmul
Wed, Jun 9, 11:12 AM
rsuderman closed D103937: [mlir][tosa] Update tosa.matmul lowering to linalg.batch_matmul.
Wed, Jun 9, 11:12 AM · Restricted Project
rsuderman added inline comments to D103937: [mlir][tosa] Update tosa.matmul lowering to linalg.batch_matmul.
Wed, Jun 9, 10:05 AM · Restricted Project

Tue, Jun 8

rsuderman added a reviewer for D103937: [mlir][tosa] Update tosa.matmul lowering to linalg.batch_matmul: NatashaKnk.
Tue, Jun 8, 5:33 PM · Restricted Project
rsuderman requested review of D103937: [mlir][tosa] Update tosa.matmul lowering to linalg.batch_matmul.
Tue, Jun 8, 5:32 PM · Restricted Project
rsuderman committed rG05cadc6f7155: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul (authored by sjarus).
[mlir][tosa] Temporarily support 2D and 3D tensor types in matmul
Tue, Jun 8, 4:06 PM
rsuderman closed D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.
Tue, Jun 8, 4:06 PM · Restricted Project
rsuderman accepted D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.
Tue, Jun 8, 3:57 PM · Restricted Project
rsuderman abandoned D103931: Re-test windows pre-merge check for tosa changes.[DO NOT REVIEW]This is purely to rerun pre-merge checks on a submitted CL.The pre-merge checks appear to be unrelated and this was theeasiest way to repro on windows..
Tue, Jun 8, 3:46 PM · Restricted Project
rsuderman updated subscribers of D103931: Re-test windows pre-merge check for tosa changes.[DO NOT REVIEW]This is purely to rerun pre-merge checks on a submitted CL.The pre-merge checks appear to be unrelated and this was theeasiest way to repro on windows..
Tue, Jun 8, 3:28 PM · Restricted Project
rsuderman retitled D103931: Re-test windows pre-merge check for tosa changes.[DO NOT REVIEW]This is purely to rerun pre-merge checks on a submitted CL.The pre-merge checks appear to be unrelated and this was theeasiest way to repro on windows. from Re-test windows pre-merge check for tosa changes. [DO NOT REVIEW] This is purely to rerun pre-merge checks on a submitted CL. The pre-merge checks appear to be unrelated and this was the easiest way to repro on windows. to Re-test windows pre-merge check for tosa changes.[DO NOT REVIEW]This is purely to rerun pre-merge checks on a submitted CL.The pre-merge checks appear to be unrelated and this was theeasiest way to repro on windows..
Tue, Jun 8, 3:28 PM · Restricted Project
rsuderman requested review of D103931: Re-test windows pre-merge check for tosa changes.[DO NOT REVIEW]This is purely to rerun pre-merge checks on a submitted CL.The pre-merge checks appear to be unrelated and this was theeasiest way to repro on windows..
Tue, Jun 8, 3:27 PM · Restricted Project
rsuderman added a comment to D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.

Updated description as external projects are not relevant for LLVM updates.

Tue, Jun 8, 3:17 PM · Restricted Project
rsuderman updated the summary of D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.
Tue, Jun 8, 3:13 PM · Restricted Project
rsuderman added a comment to D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.

Looks good, I am just checking why the windows build failed (and whether its unrelated).

Tue, Jun 8, 2:42 PM · Restricted Project
rsuderman added a comment to D103854: [mlir][tosa] Temporarily support 2D and 3D tensor types in matmul.

Something appears to be wrong with your patch as its based on a revision not in the LLVM tree. Could you verify your diff history or resubmit based on head?

Tue, Jun 8, 11:15 AM · Restricted Project

Fri, Jun 4

rsuderman committed rGd86ef4364fb5: [mlir][tosa] Update tosa.rescale for i48 input type (authored by rsuderman).
[mlir][tosa] Update tosa.rescale for i48 input type
Fri, Jun 4, 4:38 PM
rsuderman closed D102659: [mlir][tosa] Update tosa.rescale for i48 input type.
Fri, Jun 4, 4:38 PM · Restricted Project

Tue, Jun 1

rsuderman committed rG422c7036d5fa: [mlir] Updated depthwise conv to support kernel dilation (authored by rsuderman).
[mlir] Updated depthwise conv to support kernel dilation
Tue, Jun 1, 1:26 PM
rsuderman closed D103219: [mlir] Updated depthwise conv to support kernel dilation.
Tue, Jun 1, 1:26 PM · Restricted Project

Wed, May 26

rsuderman requested review of D103219: [mlir] Updated depthwise conv to support kernel dilation.
Wed, May 26, 6:04 PM · Restricted Project

May 25 2021

rsuderman committed rGe5d227e95ca1: [NFC][MLIR][TOSA] Replaced tosa linalg.indexed_generic lowerings with linalg. (authored by rsuderman).
[NFC][MLIR][TOSA] Replaced tosa linalg.indexed_generic lowerings with linalg.
May 25 2021, 3:35 PM
rsuderman closed D103110: [NFC][MLIR][TOSA] Replaced tosa linalg.indexed_generic lowerings with linalg.index.
May 25 2021, 3:35 PM · Restricted Project
rsuderman added a reviewer for D103110: [NFC][MLIR][TOSA] Replaced tosa linalg.indexed_generic lowerings with linalg.index: NatashaKnk.
May 25 2021, 12:30 PM · Restricted Project
rsuderman requested review of D103110: [NFC][MLIR][TOSA] Replaced tosa linalg.indexed_generic lowerings with linalg.index.
May 25 2021, 12:29 PM · Restricted Project

May 17 2021

rsuderman committed rGa91fb4328f25: [mlir][tosa] Cleanup of tosa.rescale lowering to linalg (authored by rsuderman).
[mlir][tosa] Cleanup of tosa.rescale lowering to linalg
May 17 2021, 5:32 PM
rsuderman closed D102651: [mlir][tosa] Cleanup of tosa.rescale lowering to linalg.
May 17 2021, 5:32 PM · Restricted Project
rsuderman added a reviewer for D102659: [mlir][tosa] Update tosa.rescale for i48 input type: NatashaKnk.
May 17 2021, 5:20 PM · Restricted Project
rsuderman requested review of D102659: [mlir][tosa] Update tosa.rescale for i48 input type.
May 17 2021, 5:09 PM · Restricted Project
rsuderman added a reviewer for D102651: [mlir][tosa] Cleanup of tosa.rescale lowering to linalg: NatashaKnk.
May 17 2021, 1:41 PM · Restricted Project
rsuderman requested review of D102651: [mlir][tosa] Cleanup of tosa.rescale lowering to linalg.
May 17 2021, 1:41 PM · Restricted Project
rsuderman committed rG08068ddba7f5: [mlir][tosa] Fix tosa.avg_pool2d lowering to normalize correctly (authored by rsuderman).
[mlir][tosa] Fix tosa.avg_pool2d lowering to normalize correctly
May 17 2021, 10:06 AM
rsuderman closed D102540: [mlir][tosa] Fix tosa.avg_pool2d lowering to normalize correctly.
May 17 2021, 10:06 AM · Restricted Project

May 14 2021

rsuderman added a reviewer for D102540: [mlir][tosa] Fix tosa.avg_pool2d lowering to normalize correctly: NatashaKnk.
May 14 2021, 4:40 PM · Restricted Project
rsuderman requested review of D102540: [mlir][tosa] Fix tosa.avg_pool2d lowering to normalize correctly.
May 14 2021, 4:39 PM · Restricted Project

May 13 2021

rsuderman committed rGf97d970a49fb: [mlir][tosa] Add lowering to tosa.abs for integer cases (authored by rsuderman).
[mlir][tosa] Add lowering to tosa.abs for integer cases
May 13 2021, 1:56 PM
rsuderman closed D101809: [mlir][tosa] Add lowering to tosa.abs for integer cases.
May 13 2021, 1:56 PM · Restricted Project
rsuderman updated the diff for D101809: [mlir][tosa] Add lowering to tosa.abs for integer cases.

Updated test to pass.

May 13 2021, 1:50 PM · Restricted Project
rsuderman committed rG0831793ed962: [mlir][tosa] Add tosa.div integer lowering to linalg.generic. (authored by NatashaKnk).
[mlir][tosa] Add tosa.div integer lowering to linalg.generic.
May 13 2021, 1:21 PM
rsuderman closed D102430: [mlir][tosa] Add tosa.div integer lowering to linalg.generic..
May 13 2021, 1:21 PM · Restricted Project
rsuderman accepted D102430: [mlir][tosa] Add tosa.div integer lowering to linalg.generic..
May 13 2021, 12:10 PM · Restricted Project
rsuderman retitled D102430: [mlir][tosa] Add tosa.div integer lowering to linalg.generic. from [mlir][tosa] Add tosa.div lowering to linalg.generic. Currently only the integer version is implemented. to [mlir][tosa] Add tosa.div integer lowering to linalg.generic..
May 13 2021, 12:10 PM · Restricted Project

May 12 2021

rsuderman committed rG3f8aafd79027: [mlir][tosa] Fix tosa.cast semantics to perform rounding/clipping (authored by rsuderman).
[mlir][tosa] Fix tosa.cast semantics to perform rounding/clipping
May 12 2021, 10:00 PM
rsuderman closed D102375: [mlir][tosa] Fix tosa.cast semantics to perform rounding/clipping.
May 12 2021, 10:00 PM · Restricted Project
rsuderman added inline comments to D102375: [mlir][tosa] Fix tosa.cast semantics to perform rounding/clipping.
May 12 2021, 6:39 PM · Restricted Project
rsuderman added a reviewer for D102375: [mlir][tosa] Fix tosa.cast semantics to perform rounding/clipping: silvas.
May 12 2021, 3:28 PM · Restricted Project
rsuderman requested review of D102375: [mlir][tosa] Fix tosa.cast semantics to perform rounding/clipping.
May 12 2021, 3:26 PM · Restricted Project
rsuderman committed rG4b014352308f: [mlir][tosa] Remove tosa.identityn operator (authored by sjarus).
[mlir][tosa] Remove tosa.identityn operator
May 12 2021, 12:47 PM
rsuderman closed D102329: [mlir][tosa] Remove tosa.identityn operator.
May 12 2021, 12:47 PM · Restricted Project
rsuderman accepted D102329: [mlir][tosa] Remove tosa.identityn operator.
May 12 2021, 12:33 PM · Restricted Project
rsuderman updated the summary of D102329: [mlir][tosa] Remove tosa.identityn operator.
May 12 2021, 12:33 PM · Restricted Project
rsuderman committed rG7b5751750792: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types (authored by rsuderman).
[mlir][linalg] Fixed issue generating reassociation map with Rank-0 types
May 12 2021, 11:07 AM
rsuderman closed D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.
May 12 2021, 11:07 AM · Restricted Project

May 11 2021

rsuderman updated the diff for D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.

Fixed for second round of review

May 11 2021, 5:25 PM · Restricted Project
rsuderman added a comment to D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.

Is it possible to get a small repro for the issue. Basically looking for the example where you hit this. I know why this might have happened, but want to make sure it is the expected case.

May 11 2021, 4:26 PM · Restricted Project
rsuderman updated the diff for D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.

Updated to add tensor reshape canonicalization test.

May 11 2021, 4:25 PM · Restricted Project
rsuderman added a reviewer for D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types: mravishankar.
May 11 2021, 3:32 PM · Restricted Project
rsuderman requested review of D102282: [mlir][linalg] Fixed issue generating reassociation map with Rank-0 types.
May 11 2021, 3:32 PM · Restricted Project
rsuderman committed rG764ad3b3fafb: [mlir][tosa] Tosa elementwise broadcasting had some minor bugs (authored by rsuderman).
[mlir][tosa] Tosa elementwise broadcasting had some minor bugs
May 11 2021, 2:04 PM
rsuderman closed D102276: [mlir][tosa] Tosa elementwise broadcasting had some minor bugs.
May 11 2021, 2:04 PM · Restricted Project
rsuderman updated the diff for D102276: [mlir][tosa] Tosa elementwise broadcasting had some minor bugs.

Added test comment

May 11 2021, 1:57 PM · Restricted Project
rsuderman added a reviewer for D102276: [mlir][tosa] Tosa elementwise broadcasting had some minor bugs: scotttodd.
May 11 2021, 1:48 PM · Restricted Project
rsuderman requested review of D102276: [mlir][tosa] Tosa elementwise broadcasting had some minor bugs.
May 11 2021, 1:47 PM · Restricted Project

May 6 2021

rsuderman committed rGd3e987c38917: [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22… (authored by rsuderman).
[mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22…
May 6 2021, 4:03 PM
rsuderman closed D101958: [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment..
May 6 2021, 4:03 PM · Restricted Project
rsuderman accepted D101958: [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment..
May 6 2021, 3:55 PM · Restricted Project
rsuderman added a comment to D101958: [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment..

The implementation looks good however the description needs work. Be more specific than a TOSA version and preface with [mlir][tosa]. It helps contributors to note if this is a CL they should be interested with. Description should be along the lines of "Added tosa.div op and remove tosa.placeholder". For the LLVM repo the summary should focus on what is specifically changing.

Seems I can use 'edit revision' to do this - and it shows as updated. I assume that takes care of this request ?

May 6 2021, 3:54 PM · Restricted Project

May 5 2021

rsuderman added a comment to D101958: [mlir][tosa] Added div op, variadic concat. Removed placeholder. Spec v0.22 alignment..

The implementation looks good however the description needs work. Be more specific than a TOSA version and preface with [mlir][tosa]. It helps contributors to note if this is a CL they should be interested with. Description should be along the lines of "Added tosa.div op and remove tosa.placeholder". For the LLVM repo the summary should focus on what is specifically changing.

May 5 2021, 8:40 PM · Restricted Project
rsuderman committed rG7abb56c78ba7: [mlir][tosa] Add tosa.depthwise lowering to existing linalg.depthwise_conv (authored by rsuderman).
[mlir][tosa] Add tosa.depthwise lowering to existing linalg.depthwise_conv
May 5 2021, 1:32 PM
rsuderman closed D101579: [mlir][tosa] Add tosa.depthwise lowering to existing linalg.depthwise_conv.
May 5 2021, 1:32 PM · Restricted Project
rsuderman updated the diff for D101579: [mlir][tosa] Add tosa.depthwise lowering to existing linalg.depthwise_conv.

Updated reshape in tests.

May 5 2021, 1:29 PM · Restricted Project
rsuderman added a comment to D101579: [mlir][tosa] Add tosa.depthwise lowering to existing linalg.depthwise_conv.

It seems like some transposes are introduced to account for the variant of convolution seen in TOSA. Is the plan to eventually have that as a named op without having to do the transpose?

May 5 2021, 9:59 AM · Restricted Project

May 4 2021

rsuderman committed rG1f7adf8cb1d7: [mlir][tosa] Fix tosa.concat by inserting linalg.fill after linalg.init (authored by rsuderman).
[mlir][tosa] Fix tosa.concat by inserting linalg.fill after linalg.init
May 4 2021, 2:32 PM
rsuderman closed D101848: [mlir][tosa] Fix tosa.concat by inserting linalg.fill after linalg.init.
May 4 2021, 2:32 PM · Restricted Project
rsuderman updated the diff for D101848: [mlir][tosa] Fix tosa.concat by inserting linalg.fill after linalg.init.

Fixed tosa-to-linalg-on-tensors test

May 4 2021, 2:21 PM · Restricted Project
rsuderman added a reviewer for D101848: [mlir][tosa] Fix tosa.concat by inserting linalg.fill after linalg.init: benvanik.
May 4 2021, 12:44 PM · Restricted Project
rsuderman requested review of D101848: [mlir][tosa] Fix tosa.concat by inserting linalg.fill after linalg.init.
May 4 2021, 12:43 PM · Restricted Project

May 3 2021

rsuderman added a reviewer for D101809: [mlir][tosa] Add lowering to tosa.abs for integer cases: NatashaKnk.
May 3 2021, 6:53 PM · Restricted Project
rsuderman requested review of D101809: [mlir][tosa] Add lowering to tosa.abs for integer cases.
May 3 2021, 6:53 PM · Restricted Project
rsuderman committed rG07ce5c99d791: [mlir][tosa] Add lowerings for tosa.equal and tosa.arithmetic_right_shift (authored by NatashaKnk).
[mlir][tosa] Add lowerings for tosa.equal and tosa.arithmetic_right_shift
May 3 2021, 6:31 PM
rsuderman closed D101804: [mlir][tosa] Add lowerings for tosa.equal and tosa.arithmetic_right_shift.
May 3 2021, 6:31 PM · Restricted Project
rsuderman accepted D101804: [mlir][tosa] Add lowerings for tosa.equal and tosa.arithmetic_right_shift.
May 3 2021, 6:06 PM · Restricted Project

Apr 29 2021

rsuderman added a reviewer for D101579: [mlir][tosa] Add tosa.depthwise lowering to existing linalg.depthwise_conv: mravishankar.
Apr 29 2021, 3:30 PM · Restricted Project
rsuderman committed rGbe01b091afd8: [mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings (authored by rsuderman).
[mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings
Apr 29 2021, 3:23 PM
rsuderman closed D101418: [mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings.
Apr 29 2021, 3:23 PM · Restricted Project
rsuderman added inline comments to D101418: [mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings.
Apr 29 2021, 3:05 PM · Restricted Project
rsuderman updated the diff for D101418: [mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings.

Updated for Mahesh's comments.

Apr 29 2021, 3:02 PM · Restricted Project
rsuderman requested review of D101579: [mlir][tosa] Add tosa.depthwise lowering to existing linalg.depthwise_conv.
Apr 29 2021, 2:54 PM · Restricted Project

Apr 27 2021

rsuderman added a reviewer for D101418: [mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings: mravishankar.
Apr 27 2021, 6:31 PM · Restricted Project
rsuderman updated the diff for D101418: [mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings.

Fixed final remaining ConstExpr for reduce

Apr 27 2021, 6:31 PM · Restricted Project
rsuderman requested review of D101418: [mlir][tosa] Remove constant-0 dim expr values from TOSA lowerings.
Apr 27 2021, 5:45 PM · Restricted Project
rsuderman committed rGcc1ae54ebcc4: [tosa][mlir] Fix FullyConnected to correctly order dimensions (authored by rsuderman).
[tosa][mlir] Fix FullyConnected to correctly order dimensions
Apr 27 2021, 5:33 PM
rsuderman closed D101220: [tosa][mlir] Fix FullyConnected to correctly order dimensions.
Apr 27 2021, 5:33 PM · Restricted Project