Page MenuHomePhabricator

[DebugInfo] Handle generic type DW_OP_convert ops in dsymutil
ClosedPublic

Authored by dstenb on Mar 13 2020, 9:51 AM.

Details

Summary

This is a preparatory change for allowing LLVM to emit DW_OP_convert
operations converting to the generic type.

If DW_OP_convert's operand is 0, it converts the top of the stack to the
generic type, as specified by DWARFv5 section 2.5.1.6:

"[...] takes one operand, which is an unsigned LEB128 integer that
represents the offset of a debugging information entry in the current
compilation unit, or value 0 which represents the generic type."

This adds support for such operations to dsymutil.

I have no knowledge of dsymutil, so I have been guided in the dark by
completely by D58534.

Diff Detail

Event Timeline

dstenb created this revision.Mar 13 2020, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2020, 9:51 AM
aprantl accepted this revision.Mar 13 2020, 10:43 AM

Thanks!

This revision is now accepted and ready to land.Mar 13 2020, 10:43 AM
JDevlieghere accepted this revision.Mar 13 2020, 10:55 AM
dstenb updated this revision to Diff 250507.Mar 16 2020, 3:47 AM
dstenb edited the summary of this revision. (Show Details)

Remove binary file from diff due to issues with arc patch. I'll add the file back when landing this, which I plan to do shortly.

This revision was automatically updated to reflect the committed changes.