Page MenuHomePhabricator

[Sema][SVE] Reject sizeless types in exception specs
ClosedPublic

Authored by rsandifo-arm on Mar 12 2020, 11:50 AM.

Details

Summary

The same rules for throwing and catching incomplete types also
apply to sizeless types. This patch enforces that for explicit
exception specs.

(In practice, throwing pointers to sizeless types could probably
be handled without problems. It would be an odd thing to do though,
and so it didn't seem worth treating as a special case.)

Diff Detail

Event Timeline

rsandifo-arm created this revision.Mar 12 2020, 11:50 AM

Allow pointers to sizeless types to be thrown.

In response to Eli's comments in D76088.

efriedma accepted this revision.Mar 12 2020, 3:19 PM

LGTM

In theory, we actually could allow throwing sizeless types; as far as I know, nothing in the ABI actually blocks it. But probably not worth the work to implement it.

This revision is now accepted and ready to land.Mar 12 2020, 3:19 PM
This revision was automatically updated to reflect the committed changes.