Page MenuHomePhabricator

[ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics
ClosedPublic

Authored by pratlucas on Feb 18 2020, 6:42 AM.

Details

Summary

The range checks performed for the vqrdmulh_lane and vqrdmulh_lane Neon
intrinsics were incorrectly using their return type as the base type for
the range check performed on their 'lane' argument.

This patch updates those intrisics to use the type of the proper reference
argument to perform the range checks.

Diff Detail

Event Timeline

pratlucas created this revision.Feb 18 2020, 6:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2020, 6:42 AM
dnsampaio added inline comments.
clang/test/CodeGen/arm-neon-range-checks.c
284–285

As the previous one, could we have it testing the actual ranges?

pratlucas updated this revision to Diff 249346.Tue, Mar 10, 5:59 AM

Adding check for valid range on tests.

pratlucas marked an inline comment as done.Tue, Mar 10, 5:59 AM
pratlucas updated this revision to Diff 249392.Tue, Mar 10, 8:20 AM

Clang-format.

This revision is now accepted and ready to land.Wed, Mar 18, 11:18 PM
This revision was automatically updated to reflect the committed changes.