Page MenuHomePhabricator

dnsampaio (Diogo N. Sampaio)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 22 2017, 3:13 PM (73 w, 3 d)

Recent Activity

Fri, Jan 25

dnsampaio committed rL352203: [NFC][Clang] Add driver tests for sb and predres.
[NFC][Clang] Add driver tests for sb and predres
Fri, Jan 25, 6:57 AM
dnsampaio committed rC352203: [NFC][Clang] Add driver tests for sb and predres.
[NFC][Clang] Add driver tests for sb and predres
Fri, Jan 25, 6:57 AM
dnsampaio closed D57060: [NFC][Clang] Add driver tests for sb and predres.
Fri, Jan 25, 6:57 AM

Tue, Jan 22

dnsampaio created D57060: [NFC][Clang] Add driver tests for sb and predres.
Tue, Jan 22, 8:44 AM

Jan 9 2019

dnsampaio committed rL350702: [AArch64] Move feature predctrl to predres.
[AArch64] Move feature predctrl to predres
Jan 9 2019, 3:28 AM
dnsampaio closed D56484: [AArch64] Move feature predctrl to predres.
Jan 9 2019, 3:28 AM
dnsampaio retitled D56484: [AArch64] Move feature predctrl to predres from [AArch64][NFC] Move feature predctrl to predres to [AArch64] Move feature predctrl to predres.
Jan 9 2019, 3:03 AM
dnsampaio created D56484: [AArch64] Move feature predctrl to predres.
Jan 9 2019, 2:42 AM

Jan 7 2019

dnsampaio committed rL350553: [ARM] ComputeKnownBits to handle extract vectors.
[ARM] ComputeKnownBits to handle extract vectors
Jan 7 2019, 11:05 AM
dnsampaio closed D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.
Jan 7 2019, 11:05 AM

Jan 4 2019

dnsampaio added inline comments to D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.
Jan 4 2019, 9:09 AM
dnsampaio updated the diff for D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.

Removed treatment for out of bounds constant, as it is simplified to poison before being transformed to VGETLANE.
Also removed treatment for variable index, as it is not accepted by VGETLANE.
Added extra tests.

Jan 4 2019, 9:08 AM
dnsampaio committed rL350385: [AArch64] Add command-line option predres.
[AArch64] Add command-line option predres
Jan 4 2019, 3:08 AM
dnsampaio closed D56007: [AArch64] Add command-line option for Execution and Data Prediction Instructions.
Jan 4 2019, 3:08 AM

Jan 3 2019

dnsampaio committed rL350302: [NFC] Fix missing testfile change of rL350299.
[NFC] Fix missing testfile change of rL350299
Jan 3 2019, 4:51 AM
dnsampaio committed rL350299: [ARM] Add command-line option for SB.
[ARM] Add command-line option for SB
Jan 3 2019, 4:12 AM
dnsampaio closed D55990: [ARM] Add command-line option for SB.
Jan 3 2019, 4:12 AM

Dec 29 2018

dnsampaio added inline comments to D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.
Dec 29 2018, 9:36 AM

Dec 28 2018

dnsampaio abandoned D54146: [NFC] Add missing test file.

Done elsewhere.

Dec 28 2018, 9:40 AM
dnsampaio abandoned D50704: [Inline-cost] Teach cost function to account for accumulative code-size growth.
Dec 28 2018, 9:31 AM
dnsampaio abandoned D48278: [SelectionDAG] Fold redundant masking operations of shifted value.
Dec 28 2018, 9:27 AM
dnsampaio abandoned D46749: [SelectionDAG]Reduce masked data movement chains and memory access widths.
Dec 28 2018, 9:27 AM
dnsampaio abandoned D47730: [SelectionDAG]Reduce masked data movement chains and memory access widths pt3.
Dec 28 2018, 9:25 AM · Restricted Project
dnsampaio committed rL350126: [AArch64] Add command-line option for SB.
[AArch64] Add command-line option for SB
Dec 28 2018, 9:18 AM
dnsampaio closed D55921: [AArch64] Add command-line option for SB.
Dec 28 2018, 9:18 AM
dnsampaio added inline comments to D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.
Dec 28 2018, 7:01 AM
dnsampaio updated the diff for D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.

Track a single element if the index is a constant.

Dec 28 2018, 6:40 AM
dnsampaio updated the diff for D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.
Dec 28 2018, 4:33 AM
dnsampaio added inline comments to D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.
Dec 28 2018, 4:21 AM

Dec 27 2018

dnsampaio created D56098: [ARM] Teach ComputeKnownBitsTarget to handle extract vectors.
Dec 27 2018, 4:20 AM
dnsampaio added a comment to D55921: [AArch64] Add command-line option for SB.

Ping

Dec 27 2018, 3:35 AM

Dec 21 2018

dnsampaio added a reviewer for D55921: [AArch64] Add command-line option for SB: t.p.northover.
Dec 21 2018, 2:48 PM
dnsampaio added a parent revision for D56007: [AArch64] Add command-line option for Execution and Data Prediction Instructions: D55921: [AArch64] Add command-line option for SB.
Dec 21 2018, 8:28 AM
dnsampaio added a child revision for D55921: [AArch64] Add command-line option for SB: D56007: [AArch64] Add command-line option for Execution and Data Prediction Instructions.
Dec 21 2018, 8:28 AM
dnsampaio created D56007: [AArch64] Add command-line option for Execution and Data Prediction Instructions.
Dec 21 2018, 8:27 AM
dnsampaio updated the diff for D55990: [ARM] Add command-line option for SB.

Remove empty feature. Rename a few more test files to have sb instead of specRest.

Dec 21 2018, 4:00 AM
dnsampaio updated the diff for D55921: [AArch64] Add command-line option for SB.

Removed empty feature

Dec 21 2018, 3:43 AM
dnsampaio added inline comments to D55921: [AArch64] Add command-line option for SB.
Dec 21 2018, 3:01 AM
dnsampaio created D55990: [ARM] Add command-line option for SB.
Dec 21 2018, 2:07 AM

Dec 20 2018

dnsampaio created D55921: [AArch64] Add command-line option for SB.
Dec 20 2018, 5:02 AM

Dec 6 2018

dnsampaio committed rL348493: [NFC][AArch64] Split out backend features.
[NFC][AArch64] Split out backend features
Dec 6 2018, 7:43 AM
dnsampaio updated the diff for D54633: [NFC][AArch64] Split out backend features.

Trying to fix a windows bot failing test, dividing the test into multiple files and using full line matching.

Dec 6 2018, 7:19 AM
dnsampaio added a comment to rL348121: [NFC][AArch64] Split out backend features.

@dnsampaio This broke the buildbots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/14363

Are you looking at this or should I revert?

@dnsampaio Reverted at rL348249

Dec 6 2018, 2:27 AM

Dec 3 2018

dnsampaio committed rL348121: [NFC][AArch64] Split out backend features.
[NFC][AArch64] Split out backend features
Dec 3 2018, 3:11 AM
dnsampaio closed D54633: [NFC][AArch64] Split out backend features.
Dec 3 2018, 3:11 AM

Nov 28 2018

dnsampaio updated the diff for D54633: [NFC][AArch64] Split out backend features.

Fixed one comment.

Nov 28 2018, 3:30 AM

Nov 27 2018

dnsampaio updated the diff for D54633: [NFC][AArch64] Split out backend features.

NIT in the v8.4a trace tests.

Nov 27 2018, 10:16 AM
dnsampaio updated the diff for D54633: [NFC][AArch64] Split out backend features.

Fix the tlb-rmi feature argument and test file.

Nov 27 2018, 10:13 AM
dnsampaio updated the diff for D54633: [NFC][AArch64] Split out backend features.

Removed the register (system operand) constraint, and associated test case.
Fixed PAN, RCPC dependencies and instructions that depend on PA, not PAN.
Changed some names to be more meaningful.
Removed the prefix "has" from the features flags.
Fixed tests

Nov 27 2018, 10:03 AM
dnsampaio added inline comments to D54633: [NFC][AArch64] Split out backend features.
Nov 27 2018, 10:03 AM

Nov 26 2018

dnsampaio updated the diff for D54633: [NFC][AArch64] Split out backend features.

Fixed:
the features implications/dependencies.
the name of the JavaScript conversion feature.
some test files.

Nov 26 2018, 9:02 AM

Nov 23 2018

dnsampaio added a comment to D54633: [NFC][AArch64] Split out backend features.

Hi @olista01 and @bryanpkc. Thanks for the reviews.

Have you discussed these feature names with the GCC devs? I know we can change the user-facing names used by clang in in TargetParser, but it's easier for us if they match.

Indeed I did not. As you said, they are not visible to the user. I'll check with the gcc devs how they have these features split and named though.

For the feature registers (ISAR6 and MMFR2), maybe we should just make these registers always available? These registers are all defined to read as all-zeroes in older architectures, which means no features described by that register are implemented. If we continue like this then we will have to add an extra feature to pretty much every new architectural feature for the ID register.

Indeed it seems the case for the ID_ISAR6_EL1 exist, so I'll just remove the constraints over it.
However, the ID_AA64MMFR2_EL1 register was added in v8.2. So I believe we should check as to warn the user if he might get undefined behavior by accessing it when not present.

Nov 23 2018, 4:34 AM

Nov 19 2018

dnsampaio updated the diff for D54633: [NFC][AArch64] Split out backend features.

Added FeatureRASv8_4 implies RAS.
NIT fix.

Nov 19 2018, 3:47 AM
dnsampaio added inline comments to D54633: [NFC][AArch64] Split out backend features.
Nov 19 2018, 3:30 AM

Nov 16 2018

dnsampaio created D54633: [NFC][AArch64] Split out backend features.
Nov 16 2018, 8:41 AM

Nov 7 2018

dnsampaio committed rC346303: [NFC][Clang][Aarch64] Add missing test file.
[NFC][Clang][Aarch64] Add missing test file
Nov 7 2018, 3:44 AM
dnsampaio committed rL346303: [NFC][Clang][Aarch64] Add missing test file.
[NFC][Clang][Aarch64] Add missing test file
Nov 7 2018, 3:44 AM
dnsampaio closed D54148: [NFC][Clang][Aarch64] Add missing test file.
Nov 7 2018, 3:44 AM

Nov 6 2018

dnsampaio created D54148: [NFC][Clang][Aarch64] Add missing test file.
Nov 6 2018, 6:00 AM
dnsampaio added a comment to D54146: [NFC] Add missing test file.

Ups, it was ment to be a clang patch, not a llvm one. Sry

Nov 6 2018, 3:55 AM
dnsampaio created D54146: [NFC] Add missing test file.
Nov 6 2018, 3:54 AM

Oct 30 2018

dnsampaio committed rL345601: [FIX][AArch64] Add support for UDF instruction.
[FIX][AArch64] Add support for UDF instruction
Oct 30 2018, 7:02 AM
dnsampaio committed rLLD345592: [FIX][AArch64] lld test change.
[FIX][AArch64] lld test change
Oct 30 2018, 5:23 AM
dnsampaio committed rL345592: [FIX][AArch64] lld test change.
[FIX][AArch64] lld test change
Oct 30 2018, 5:23 AM
dnsampaio committed rL345587: [FIX][AArch64] Add support for UDF instruction.
[FIX][AArch64] Add support for UDF instruction
Oct 30 2018, 4:41 AM
dnsampaio committed rL345581: [AArch64] Add support for UDF instruction.
[AArch64] Add support for UDF instruction
Oct 30 2018, 4:09 AM
dnsampaio closed D53319: Add support for AArch64 UDF instruction.
Oct 30 2018, 4:09 AM
dnsampaio updated the diff for D53319: Add support for AArch64 UDF instruction.

Added blank lines at end of test files.

Oct 30 2018, 3:35 AM

Oct 29 2018

dnsampaio updated the diff for D53319: Add support for AArch64 UDF instruction.

Re-inserted the missing tests. Small refactoring as to look alike neighbor code.

Oct 29 2018, 4:25 AM

Oct 23 2018

dnsampaio updated the diff for D53319: Add support for AArch64 UDF instruction.

Refactoring.

Oct 23 2018, 3:45 AM

Oct 19 2018

dnsampaio added a comment to D53319: Add support for AArch64 UDF instruction.

Ping.

Oct 19 2018, 9:07 AM

Oct 16 2018

dnsampaio updated the diff for D53319: Add support for AArch64 UDF instruction.

No custom decoding is required

Oct 16 2018, 10:57 AM
dnsampaio added inline comments to D53319: Add support for AArch64 UDF instruction.
Oct 16 2018, 10:22 AM
dnsampaio updated the diff for D53319: Add support for AArch64 UDF instruction.

Fixed the tests as to check boundaries, and one value in the middle.
Changed tests ordering as they generated empty lines not treated by FileCheck.

Oct 16 2018, 4:50 AM
dnsampaio added a comment to D53319: Add support for AArch64 UDF instruction.

To send patch....

Oct 16 2018, 4:29 AM
dnsampaio created D53319: Add support for AArch64 UDF instruction.
Oct 16 2018, 3:18 AM

Oct 11 2018

dnsampaio committed rL344248: [AARCH64][FIX] Emit data symbol for constant pool data.
[AARCH64][FIX] Emit data symbol for constant pool data
Oct 11 2018, 7:13 AM
dnsampaio closed D53132: [AARCH64][FIX] Emit data symbol for constant pool data.
Oct 11 2018, 7:13 AM
dnsampaio updated the diff for D53132: [AARCH64][FIX] Emit data symbol for constant pool data.

Removed processor and specific triple target from test.

Oct 11 2018, 6:27 AM
dnsampaio added a reviewer for D53132: [AARCH64][FIX] Emit data symbol for constant pool data: pbarrio.
Oct 11 2018, 4:34 AM
dnsampaio created D53132: [AARCH64][FIX] Emit data symbol for constant pool data.
Oct 11 2018, 4:26 AM

Oct 2 2018

dnsampaio committed rLLD343604: [NFC][BUG-FIX][ARM] Add missing data symbol.
[NFC][BUG-FIX][ARM] Add missing data symbol
Oct 2 2018, 9:55 AM
dnsampaio committed rL343604: [NFC][BUG-FIX][ARM] Add missing data symbol.
[NFC][BUG-FIX][ARM] Add missing data symbol
Oct 2 2018, 9:54 AM
dnsampaio committed rL343594: [ARM] Emmit data symbol for constant pool data.
[ARM] Emmit data symbol for constant pool data
Oct 2 2018, 7:59 AM
dnsampaio closed D52737: [ARM] Emmit data symbol for constant pool data.
Oct 2 2018, 7:59 AM
dnsampaio updated the diff for D52737: [ARM] Emmit data symbol for constant pool data.

Updated test to use llvm-mc instead of clang.

Oct 2 2018, 3:39 AM
dnsampaio updated the diff for D52737: [ARM] Emmit data symbol for constant pool data.

Simplified tests. Using the standard function for emitting data symbols, if required.

Oct 2 2018, 2:54 AM
dnsampaio added inline comments to D52737: [ARM] Emmit data symbol for constant pool data.
Oct 2 2018, 2:53 AM

Oct 1 2018

dnsampaio created D52737: [ARM] Emmit data symbol for constant pool data.
Oct 1 2018, 11:26 AM

Sep 12 2018

dnsampaio committed rL342061: [ARM] Tighten f64<->f16 conversion requirements.
[ARM] Tighten f64<->f16 conversion requirements
Sep 12 2018, 9:26 AM
dnsampaio closed D51631: [ARM] Tighten f64<->f16 conversion requirements.
Sep 12 2018, 9:26 AM

Sep 7 2018

dnsampaio added a comment to D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89.

Correct. The protected name is double underscore as both suffix and prefix.

Sep 7 2018, 2:47 AM
dnsampaio committed rC341644: Replaces __inline by __inline__ / C89 compatible.
Replaces __inline by __inline__ / C89 compatible
Sep 7 2018, 2:41 AM
dnsampaio committed rL341644: Replaces __inline by __inline__ / C89 compatible.
Replaces __inline by __inline__ / C89 compatible
Sep 7 2018, 2:41 AM

Sep 6 2018

dnsampaio committed rL341548: Fix march triple used test from rL341475.
Fix march triple used test from rL341475
Sep 6 2018, 7:14 AM
dnsampaio committed rC341548: Fix march triple used test from rL341475.
Fix march triple used test from rL341475
Sep 6 2018, 7:14 AM
dnsampaio updated the diff for D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89.
Sep 6 2018, 6:10 AM
dnsampaio updated the diff for D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89.

Fix test march triple.

Sep 6 2018, 5:59 AM
dnsampaio added inline comments to D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89.
Sep 6 2018, 3:05 AM

Sep 5 2018

dnsampaio committed rC341475: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89.
Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89
Sep 5 2018, 7:57 AM