Page MenuHomePhabricator

dnsampaio (Diogo N. Sampaio)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 22 2017, 3:13 PM (99 w, 3 d)

Recent Activity

Wed, Aug 14

dnsampaio added inline comments to D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature.
Wed, Aug 14, 6:29 AM · Restricted Project
dnsampaio added a comment to D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.

Is there any fix patch proposed to track/fix the regression? @dnsampaio

Wed, Aug 14, 3:59 AM · Restricted Project

Thu, Aug 8

dnsampaio committed rGdd591977e0fe: [FIX][NFC] Update clang sema test (authored by dnsampaio).
[FIX][NFC] Update clang sema test
Thu, Aug 8, 7:47 AM
dnsampaio committed rL368301: [FIX][NFC] Update clang sema test.
[FIX][NFC] Update clang sema test
Thu, Aug 8, 7:47 AM
dnsampaio added a comment to rG9427aa2d543b: [ARM] Set default alignment to 64bits.

Just seen that this breaks clang/test/Sema/struct-packed-align.c, working on it.

Thu, Aug 8, 7:09 AM
dnsampaio committed rG9427aa2d543b: [ARM] Set default alignment to 64bits (authored by dnsampaio).
[ARM] Set default alignment to 64bits
Thu, Aug 8, 5:52 AM
dnsampaio committed rL368288: [ARM] Set default alignment to 64bits.
[ARM] Set default alignment to 64bits
Thu, Aug 8, 5:50 AM
dnsampaio closed D65000: [ARM] Set default alignment to 64bits.
Thu, Aug 8, 5:49 AM · Restricted Project, Restricted Project

Tue, Aug 6

dnsampaio added a comment to D65000: [ARM] Set default alignment to 64bits.

I have tested this in our MacOS and linux environments. @thakis @thegameg @phosek, would it be possible for you to check if this works for you?

Tue, Aug 6, 2:05 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D65000: [ARM] Set default alignment to 64bits.

Fix test

Tue, Aug 6, 2:03 AM · Restricted Project, Restricted Project
dnsampaio reopened D65000: [ARM] Set default alignment to 64bits.

Hi, first thanks for those that looked into this and sorry for the delay.
We have investigated the errors and seems that the test was, first in the wrong folder, inside CodeGen where it should be in CodeGenCXX and we should use clang_cc1.

Tue, Aug 6, 2:03 AM · Restricted Project, Restricted Project

Tue, Jul 23

dnsampaio updated subscribers of D65000: [ARM] Set default alignment to 64bits.
Tue, Jul 23, 3:52 AM · Restricted Project, Restricted Project

Mon, Jul 22

dnsampaio added a comment to D65000: [ARM] Set default alignment to 64bits.

True. Thx again.

Mon, Jul 22, 9:39 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D65000: [ARM] Set default alignment to 64bits.
  • Joined assignments for default alignments and neon_vector alignment
  • Added missing align 8 test
Mon, Jul 22, 9:39 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D65000: [ARM] Set default alignment to 64bits.
  • Joined assignments for default alignments and neon_vector alignment
Mon, Jul 22, 8:10 AM · Restricted Project, Restricted Project
dnsampaio added a comment to D65000: [ARM] Set default alignment to 64bits.

Set android-abi default to 128. Added tests for android and not-android.

Mon, Jul 22, 3:10 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D65000: [ARM] Set default alignment to 64bits.
  • Set androideabi alignment to 128 bits
Mon, Jul 22, 2:45 AM · Restricted Project, Restricted Project

Jul 19 2019

dnsampaio created D65000: [ARM] Set default alignment to 64bits.
Jul 19 2019, 9:02 AM · Restricted Project, Restricted Project

Jul 18 2019

dnsampaio committed rG11512e742b28: [ARM][DAGCOMBINE][FIX] PerformVMOVRRDCombine (authored by dnsampaio).
[ARM][DAGCOMBINE][FIX] PerformVMOVRRDCombine
Jul 18 2019, 3:07 AM
dnsampaio committed rL366423: [ARM][DAGCOMBINE][FIX] PerformVMOVRRDCombine.
[ARM][DAGCOMBINE][FIX] PerformVMOVRRDCombine
Jul 18 2019, 3:05 AM
dnsampaio closed D64870: [ARM][DAGCOMBINE][FIX] PerformVMOVRRDCombine.
Jul 18 2019, 3:05 AM · Restricted Project

Jul 17 2019

dnsampaio created D64870: [ARM][DAGCOMBINE][FIX] PerformVMOVRRDCombine.
Jul 17 2019, 7:58 AM · Restricted Project

Jul 12 2019

dnsampaio accepted rL365911: Support for dumping current PrettyStackTrace on SIGINFO (Ctrl-T).

Was fixed just after if the include <atomic>

Jul 12 2019, 9:28 AM
dnsampaio raised a concern with rL365911: Support for dumping current PrettyStackTrace on SIGINFO (Ctrl-T).

I am getting this error with gcc 8.2

/work/bf/LLVM/local/src/lib/Support/PrettyStackTrace.cpp:57:39: error: variable ‘volatile std::atomic<unsigned int> GlobalSigInfoGenerationCounter’ has initializer but incomplete type
 static volatile std::atomic<unsigned> GlobalSigInfoGenerationCounter =
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Jul 12 2019, 9:20 AM

Jul 10 2019

dnsampaio committed rG71cac61d0188: [AArch64] Fix vector vuqadd intrinsics operands (authored by dnsampaio).
[AArch64] Fix vector vuqadd intrinsics operands
Jul 10 2019, 3:00 AM
dnsampaio committed rGa8ce16101080: [NFC][AArch64] Fix vector vsqadd intrinsics operands (authored by dnsampaio).
[NFC][AArch64] Fix vector vsqadd intrinsics operands
Jul 10 2019, 2:59 AM
dnsampaio committed rL365609: [AArch64] Fix vector vuqadd intrinsics operands.
[AArch64] Fix vector vuqadd intrinsics operands
Jul 10 2019, 2:58 AM
dnsampaio closed D64211: [AArch64] Fix vector vuqadd intrinsics operands.
Jul 10 2019, 2:58 AM · Restricted Project, Restricted Project
dnsampaio committed rL365608: [NFC][AArch64] Fix vector vsqadd intrinsics operands.
[NFC][AArch64] Fix vector vsqadd intrinsics operands
Jul 10 2019, 2:58 AM
dnsampaio closed D64210: [NFC][AArch64] Fix vector vsqadd intrinsics operands.
Jul 10 2019, 2:58 AM · Restricted Project, Restricted Project
dnsampaio committed rG3490aab63af3: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand (authored by dnsampaio).
[NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand
Jul 10 2019, 1:18 AM
dnsampaio committed rL365598: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand.
[NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand
Jul 10 2019, 1:16 AM
dnsampaio closed D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand.
Jul 10 2019, 1:16 AM · Restricted Project, Restricted Project

Jul 8 2019

dnsampaio committed rG4ec445b813a1: [AArch64] Fix scalar vuqadd intrinsics operands (authored by dnsampaio).
[AArch64] Fix scalar vuqadd intrinsics operands
Jul 8 2019, 1:49 AM
dnsampaio committed rL365300: [AArch64] Fix scalar vuqadd intrinsics operands.
[AArch64] Fix scalar vuqadd intrinsics operands
Jul 8 2019, 1:48 AM
dnsampaio closed D64242: [AArch64] Fix scalar vuqadd intrinsics operands.
Jul 8 2019, 1:47 AM · Restricted Project, Restricted Project
dnsampaio committed rG0464e07c8f6e: [AArch64] Fix vsqadd scalar intrinsics operands (authored by dnsampaio).
[AArch64] Fix vsqadd scalar intrinsics operands
Jul 8 2019, 1:38 AM
dnsampaio committed rL365298: [AArch64] Fix vsqadd scalar intrinsics operands.
[AArch64] Fix vsqadd scalar intrinsics operands
Jul 8 2019, 1:38 AM
dnsampaio closed D64239: [AArch64] Fix vsqadd scalar intrinsics operands.
Jul 8 2019, 1:38 AM · Restricted Project, Restricted Project
dnsampaio updated the summary of D64239: [AArch64] Fix vsqadd scalar intrinsics operands.
Jul 8 2019, 1:19 AM · Restricted Project, Restricted Project

Jul 5 2019

dnsampaio created D64243: [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand.
Jul 5 2019, 5:08 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D64242: [AArch64] Fix scalar vuqadd intrinsics operands.
  • Fix previously existing tests
Jul 5 2019, 4:29 AM · Restricted Project, Restricted Project
dnsampaio created D64242: [AArch64] Fix scalar vuqadd intrinsics operands.
Jul 5 2019, 4:24 AM · Restricted Project, Restricted Project
dnsampaio created D64239: [AArch64] Fix vsqadd scalar intrinsics operands.
Jul 5 2019, 3:59 AM · Restricted Project, Restricted Project
dnsampaio retitled D64210: [NFC][AArch64] Fix vector vsqadd intrinsics operands from [NFC][ARM] Fix vector vsqadd intrinsics operands to [NFC][AArch64] Fix vector vsqadd intrinsics operands.
Jul 5 2019, 3:46 AM · Restricted Project, Restricted Project
dnsampaio retitled D64211: [AArch64] Fix vector vuqadd intrinsics operands from [ARM] Fix vector vuqadd intrinsics operands to [AArch64] Fix vector vuqadd intrinsics operands.
Jul 5 2019, 3:46 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D64211: [AArch64] Fix vector vuqadd intrinsics operands.
  • Added tests
Jul 5 2019, 2:33 AM · Restricted Project, Restricted Project
dnsampaio retitled D64210: [NFC][AArch64] Fix vector vsqadd intrinsics operands from [ARM] Fix vector vsqadd intrinsics operands to [NFC][ARM] Fix vector vsqadd intrinsics operands.
Jul 5 2019, 1:45 AM · Restricted Project, Restricted Project
dnsampaio added a comment to D64210: [NFC][AArch64] Fix vector vsqadd intrinsics operands.

Are there some changes/addition to tests attached to this?

Jul 5 2019, 1:45 AM · Restricted Project, Restricted Project

Jul 4 2019

dnsampaio created D64211: [AArch64] Fix vector vuqadd intrinsics operands.
Jul 4 2019, 8:46 AM · Restricted Project, Restricted Project
dnsampaio created D64210: [NFC][AArch64] Fix vector vsqadd intrinsics operands.
Jul 4 2019, 8:16 AM · Restricted Project, Restricted Project

Jun 28 2019

dnsampaio abandoned D49229: [AggressiveInstCombine] Fold redundant masking operations of shifted value.
Jun 28 2019, 8:10 AM
dnsampaio added a comment to D49229: [AggressiveInstCombine] Fold redundant masking operations of shifted value.

Perhaps this makes it clearer:
https://rise4fun.com/Alive/4TLv

Jun 28 2019, 7:36 AM
dnsampaio added a comment to D49229: [AggressiveInstCombine] Fold redundant masking operations of shifted value.

Hi @lebedev.ri,
Nice you looked this one as I am not quite sure what to do about it. Any suggestions?

Jun 28 2019, 7:33 AM

Jun 18 2019

dnsampaio committed rG0265716b272d: [NFC] Improve triple match of scripts that update tests (authored by dnsampaio).
[NFC] Improve triple match of scripts that update tests
Jun 18 2019, 3:03 AM
dnsampaio committed rL363656: [NFC] Improve triple match of scripts that update tests.
[NFC] Improve triple match of scripts that update tests
Jun 18 2019, 3:02 AM
dnsampaio closed D63145: [NFC] Improve triple match of scripts that update tests.
Jun 18 2019, 3:01 AM · Restricted Project
dnsampaio updated the diff for D63145: [NFC] Improve triple match of scripts that update tests.

Fixed inline requests

Jun 18 2019, 2:35 AM · Restricted Project

Jun 13 2019

dnsampaio abandoned D63150: [NFC] Update tests to be used as reference for shrink wrapping changes.

Already part of D63152

Jun 13 2019, 6:55 AM · Restricted Project
dnsampaio committed rG0be2d25ecc7d: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the… (authored by dnsampaio).
[FIX] Forces shrink wrapping to consider any memory access as aliasing with the…
Jun 13 2019, 6:54 AM
dnsampaio committed rL363265: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the….
[FIX] Forces shrink wrapping to consider any memory access as aliasing with the…
Jun 13 2019, 6:54 AM
dnsampaio removed a parent revision for D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack: D63150: [NFC] Update tests to be used as reference for shrink wrapping changes.
Jun 13 2019, 6:54 AM · Restricted Project
dnsampaio removed a child revision for D63150: [NFC] Update tests to be used as reference for shrink wrapping changes: D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
Jun 13 2019, 6:54 AM · Restricted Project
dnsampaio closed D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
Jun 13 2019, 6:54 AM · Restricted Project
dnsampaio added a comment to D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.

Thanks for the reviews. I'm changing the new test to take a mir obtained just before shrink-wrap pass and validating just that one pass.

Jun 13 2019, 3:46 AM · Restricted Project

Jun 12 2019

dnsampaio updated subscribers of D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.

Hi @thegameg,
My initial thoughts on how to optimize this was to use alias analysis to check that load and stores for sure do not alias with the stack of the current function. It seems that the current api accepts two memory operands, and then turns them into memory regions. I don't know if it possible, as we might not know the sp value it self, but my idea was to create a function that accepts a memory access and a memory region, which would be set to [SP, SP + stackSize].
In pr42136, @eli.friedman also mentioned that might be quite simple to prove that a load accesses a global variable, as well possible to prove that the address of some particular stack objects doesn't escape (also pointed by @chill) .

Jun 12 2019, 2:55 AM · Restricted Project
dnsampaio updated the diff for D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
  • - Added specific shrink wrapping test for pr37472
Jun 12 2019, 2:34 AM · Restricted Project

Jun 11 2019

dnsampaio added a parent revision for D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack: D63150: [NFC] Update tests to be used as reference for shrink wrapping changes.
Jun 11 2019, 10:51 AM · Restricted Project
dnsampaio added a child revision for D63150: [NFC] Update tests to be used as reference for shrink wrapping changes: D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
Jun 11 2019, 10:51 AM · Restricted Project
dnsampaio created D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
Jun 11 2019, 10:47 AM · Restricted Project
dnsampaio created D63150: [NFC] Update tests to be used as reference for shrink wrapping changes.
Jun 11 2019, 10:26 AM · Restricted Project
dnsampaio created D63145: [NFC] Improve triple match of scripts that update tests.
Jun 11 2019, 9:30 AM · Restricted Project

Jun 5 2019

dnsampaio abandoned D60828: [ARM] Fix armv8 features tree and add fp16fml.

Fixed.

Jun 5 2019, 9:13 AM · Restricted Project

Jun 3 2019

dnsampaio committed rGdf92f841105e: [ARM][FIX] Ran out of registers due tail recursion (authored by dnsampaio).
[ARM][FIX] Ran out of registers due tail recursion
Jun 3 2019, 1:56 AM
dnsampaio committed rL362366: [ARM][FIX] Ran out of registers due tail recursion.
[ARM][FIX] Ran out of registers due tail recursion
Jun 3 2019, 1:55 AM
dnsampaio closed D62683: [ARM][FIX] Ran out of registers due tail recursion.
Jun 3 2019, 1:55 AM · Restricted Project

May 31 2019

dnsampaio added inline comments to D62683: [ARM][FIX] Ran out of registers due tail recursion.
May 31 2019, 1:11 AM · Restricted Project
dnsampaio updated the diff for D62683: [ARM][FIX] Ran out of registers due tail recursion.

[ARM][FIX] Ran out of registers due tail recursion

May 31 2019, 1:11 AM · Restricted Project

May 30 2019

dnsampaio created D62683: [ARM][FIX] Ran out of registers due tail recursion.
May 30 2019, 8:30 AM · Restricted Project

May 9 2019

dnsampaio committed rG86cfedce1c44: [FIX] Change test to read file instead (authored by dnsampaio).
[FIX] Change test to read file instead
May 9 2019, 4:21 AM
dnsampaio committed rL360329: [FIX] Change test to read file instead.
[FIX] Change test to read file instead
May 9 2019, 4:21 AM
dnsampaio committed rC360329: [FIX] Change test to read file instead.
[FIX] Change test to read file instead
May 9 2019, 4:21 AM
dnsampaio committed rG543913c3b41f: [ARM] Fix the extensions implied by a cpu name (authored by dnsampaio).
[ARM] Fix the extensions implied by a cpu name
May 9 2019, 3:23 AM
dnsampaio committed rC360324: [ARM] Fix the extensions implied by a cpu name.
[ARM] Fix the extensions implied by a cpu name
May 9 2019, 3:22 AM
dnsampaio committed rL360324: [ARM] Fix the extensions implied by a cpu name.
[ARM] Fix the extensions implied by a cpu name
May 9 2019, 3:22 AM
dnsampaio closed D61668: [ARM] Fix the extensions implied by a cpu name.
May 9 2019, 3:22 AM · Restricted Project, Restricted Project

May 8 2019

dnsampaio updated the summary of D61668: [ARM] Fix the extensions implied by a cpu name.
May 8 2019, 2:56 AM · Restricted Project, Restricted Project
dnsampaio added reviewers for D61668: [ARM] Fix the extensions implied by a cpu name: keith.walker.arm, DavidSpickett, carwil.
May 8 2019, 2:27 AM · Restricted Project, Restricted Project
dnsampaio created D61668: [ARM] Fix the extensions implied by a cpu name.
May 8 2019, 2:27 AM · Restricted Project, Restricted Project

Apr 29 2019

dnsampaio committed rGd95abb170bdd: [ARM] Add bitcast/extract_subvec. of fp16 vectors (authored by dnsampaio).
[ARM] Add bitcast/extract_subvec. of fp16 vectors
Apr 29 2019, 3:27 AM
dnsampaio committed rL359433: [ARM] Add bitcast/extract_subvec. of fp16 vectors.
[ARM] Add bitcast/extract_subvec. of fp16 vectors
Apr 29 2019, 3:27 AM
dnsampaio closed D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.
Apr 29 2019, 3:27 AM · Restricted Project
dnsampaio committed rG2078eb745d91: [ARM] Add v4f16 and v8f16 types to the CallingConv (authored by dnsampaio).
[ARM] Add v4f16 and v8f16 types to the CallingConv
Apr 29 2019, 3:10 AM
dnsampaio committed rL359431: [ARM] Add v4f16 and v8f16 types to the CallingConv.
[ARM] Add v4f16 and v8f16 types to the CallingConv
Apr 29 2019, 3:09 AM
dnsampaio closed D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
Apr 29 2019, 3:09 AM · Restricted Project

Apr 25 2019

dnsampaio updated the diff for D60413: SExt -> ZExt when no sign bits is used with multiple uses.

Moved conversion to the existing folding loop

Apr 25 2019, 10:12 AM · Restricted Project
dnsampaio updated the diff for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.

Removed duplicated %s in test file.

Apr 25 2019, 10:06 AM · Restricted Project
dnsampaio updated the diff for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.

Fixes requested

Apr 25 2019, 9:43 AM · Restricted Project
dnsampaio updated the diff for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
  • removed old apcs
Apr 25 2019, 9:31 AM · Restricted Project

Apr 24 2019

dnsampaio updated the diff for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.

Added new conversions, tests, and different float-abi

Apr 24 2019, 9:54 AM · Restricted Project