Page MenuHomePhabricator

dnsampaio (Diogo N. Sampaio)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 22 2017, 3:13 PM (90 w, 2 d)

Recent Activity

Thu, Jun 13

dnsampaio abandoned D63150: [NFC] Update tests to be used as reference for shrink wrapping changes.

Already part of D63152

Thu, Jun 13, 6:55 AM · Restricted Project
dnsampaio committed rG0be2d25ecc7d: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the… (authored by dnsampaio).
[FIX] Forces shrink wrapping to consider any memory access as aliasing with the…
Thu, Jun 13, 6:54 AM
dnsampaio committed rL363265: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the….
[FIX] Forces shrink wrapping to consider any memory access as aliasing with the…
Thu, Jun 13, 6:54 AM
dnsampaio removed a parent revision for D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack: D63150: [NFC] Update tests to be used as reference for shrink wrapping changes.
Thu, Jun 13, 6:54 AM · Restricted Project
dnsampaio removed a child revision for D63150: [NFC] Update tests to be used as reference for shrink wrapping changes: D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
Thu, Jun 13, 6:54 AM · Restricted Project
dnsampaio closed D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
Thu, Jun 13, 6:54 AM · Restricted Project
dnsampaio added a comment to D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.

Thanks for the reviews. I'm changing the new test to take a mir obtained just before shrink-wrap pass and validating just that one pass.

Thu, Jun 13, 3:46 AM · Restricted Project

Wed, Jun 12

dnsampaio updated subscribers of D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.

Hi @thegameg,
My initial thoughts on how to optimize this was to use alias analysis to check that load and stores for sure do not alias with the stack of the current function. It seems that the current api accepts two memory operands, and then turns them into memory regions. I don't know if it possible, as we might not know the sp value it self, but my idea was to create a function that accepts a memory access and a memory region, which would be set to [SP, SP + stackSize].
In pr42136, @eli.friedman also mentioned that might be quite simple to prove that a load accesses a global variable, as well possible to prove that the address of some particular stack objects doesn't escape (also pointed by @chill) .

Wed, Jun 12, 2:55 AM · Restricted Project
dnsampaio updated the diff for D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
  • - Added specific shrink wrapping test for pr37472
Wed, Jun 12, 2:34 AM · Restricted Project

Tue, Jun 11

dnsampaio added a parent revision for D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack: D63150: [NFC] Update tests to be used as reference for shrink wrapping changes.
Tue, Jun 11, 10:51 AM · Restricted Project
dnsampaio added a child revision for D63150: [NFC] Update tests to be used as reference for shrink wrapping changes: D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
Tue, Jun 11, 10:51 AM · Restricted Project
dnsampaio created D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack.
Tue, Jun 11, 10:47 AM · Restricted Project
dnsampaio created D63150: [NFC] Update tests to be used as reference for shrink wrapping changes.
Tue, Jun 11, 10:26 AM · Restricted Project
dnsampaio created D63145: [NFC] Improve triple match of scripts that update tests.
Tue, Jun 11, 9:30 AM · Restricted Project

Wed, Jun 5

dnsampaio abandoned D60828: [ARM] Fix armv8 features tree and add fp16fml.

Fixed.

Wed, Jun 5, 9:13 AM · Restricted Project

Mon, Jun 3

dnsampaio committed rGdf92f841105e: [ARM][FIX] Ran out of registers due tail recursion (authored by dnsampaio).
[ARM][FIX] Ran out of registers due tail recursion
Mon, Jun 3, 1:56 AM
dnsampaio committed rL362366: [ARM][FIX] Ran out of registers due tail recursion.
[ARM][FIX] Ran out of registers due tail recursion
Mon, Jun 3, 1:55 AM
dnsampaio closed D62683: [ARM][FIX] Ran out of registers due tail recursion.
Mon, Jun 3, 1:55 AM · Restricted Project

Fri, May 31

dnsampaio added inline comments to D62683: [ARM][FIX] Ran out of registers due tail recursion.
Fri, May 31, 1:11 AM · Restricted Project
dnsampaio updated the diff for D62683: [ARM][FIX] Ran out of registers due tail recursion.

[ARM][FIX] Ran out of registers due tail recursion

Fri, May 31, 1:11 AM · Restricted Project

Thu, May 30

dnsampaio created D62683: [ARM][FIX] Ran out of registers due tail recursion.
Thu, May 30, 8:30 AM · Restricted Project

May 9 2019

dnsampaio committed rG86cfedce1c44: [FIX] Change test to read file instead (authored by dnsampaio).
[FIX] Change test to read file instead
May 9 2019, 4:21 AM
dnsampaio committed rL360329: [FIX] Change test to read file instead.
[FIX] Change test to read file instead
May 9 2019, 4:21 AM
dnsampaio committed rC360329: [FIX] Change test to read file instead.
[FIX] Change test to read file instead
May 9 2019, 4:21 AM
dnsampaio committed rG543913c3b41f: [ARM] Fix the extensions implied by a cpu name (authored by dnsampaio).
[ARM] Fix the extensions implied by a cpu name
May 9 2019, 3:23 AM
dnsampaio committed rC360324: [ARM] Fix the extensions implied by a cpu name.
[ARM] Fix the extensions implied by a cpu name
May 9 2019, 3:22 AM
dnsampaio committed rL360324: [ARM] Fix the extensions implied by a cpu name.
[ARM] Fix the extensions implied by a cpu name
May 9 2019, 3:22 AM
dnsampaio closed D61668: [ARM] Fix the extensions implied by a cpu name.
May 9 2019, 3:22 AM · Restricted Project, Restricted Project

May 8 2019

dnsampaio updated the summary of D61668: [ARM] Fix the extensions implied by a cpu name.
May 8 2019, 2:56 AM · Restricted Project, Restricted Project
dnsampaio added reviewers for D61668: [ARM] Fix the extensions implied by a cpu name: keith.walker.arm, DavidSpickett, carwil.
May 8 2019, 2:27 AM · Restricted Project, Restricted Project
dnsampaio created D61668: [ARM] Fix the extensions implied by a cpu name.
May 8 2019, 2:27 AM · Restricted Project, Restricted Project

Apr 29 2019

dnsampaio committed rGd95abb170bdd: [ARM] Add bitcast/extract_subvec. of fp16 vectors (authored by dnsampaio).
[ARM] Add bitcast/extract_subvec. of fp16 vectors
Apr 29 2019, 3:27 AM
dnsampaio committed rL359433: [ARM] Add bitcast/extract_subvec. of fp16 vectors.
[ARM] Add bitcast/extract_subvec. of fp16 vectors
Apr 29 2019, 3:27 AM
dnsampaio closed D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.
Apr 29 2019, 3:27 AM · Restricted Project
dnsampaio committed rG2078eb745d91: [ARM] Add v4f16 and v8f16 types to the CallingConv (authored by dnsampaio).
[ARM] Add v4f16 and v8f16 types to the CallingConv
Apr 29 2019, 3:10 AM
dnsampaio committed rL359431: [ARM] Add v4f16 and v8f16 types to the CallingConv.
[ARM] Add v4f16 and v8f16 types to the CallingConv
Apr 29 2019, 3:09 AM
dnsampaio closed D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
Apr 29 2019, 3:09 AM · Restricted Project

Apr 25 2019

dnsampaio updated the diff for D60413: SExt -> ZExt when no sign bits is used with multiple uses.

Moved conversion to the existing folding loop

Apr 25 2019, 10:12 AM · Restricted Project
dnsampaio updated the diff for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.

Removed duplicated %s in test file.

Apr 25 2019, 10:06 AM · Restricted Project
dnsampaio updated the diff for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.

Fixes requested

Apr 25 2019, 9:43 AM · Restricted Project
dnsampaio updated the diff for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
  • removed old apcs
Apr 25 2019, 9:31 AM · Restricted Project

Apr 24 2019

dnsampaio updated the diff for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.

Added new conversions, tests, and different float-abi

Apr 24 2019, 9:54 AM · Restricted Project
dnsampaio added a parent revision for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors: D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
Apr 24 2019, 9:50 AM · Restricted Project
dnsampaio added a child revision for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv: D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.
Apr 24 2019, 9:50 AM · Restricted Project
dnsampaio removed a parent revision for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv: D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.
Apr 24 2019, 6:38 AM · Restricted Project
dnsampaio removed a child revision for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors: D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
Apr 24 2019, 6:38 AM · Restricted Project
dnsampaio updated the diff for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.

Tests updated

Apr 24 2019, 4:34 AM · Restricted Project

Apr 23 2019

dnsampaio committed rG2619f399f995: [ARM][FIX] Add missing f16.lane.vldN/vstN lowering (authored by dnsampaio).
[ARM][FIX] Add missing f16.lane.vldN/vstN lowering
Apr 23 2019, 2:38 AM
dnsampaio committed rL358962: [ARM][FIX] Add missing f16.lane.vldN/vstN lowering.
[ARM][FIX] Add missing f16.lane.vldN/vstN lowering
Apr 23 2019, 2:34 AM
dnsampaio closed D60874: [ARM][FIX] Add missing f16.lane.vldN/vstN lowering.
Apr 23 2019, 2:34 AM · Restricted Project

Apr 18 2019

dnsampaio created D60874: [ARM][FIX] Add missing f16.lane.vldN/vstN lowering.
Apr 18 2019, 8:47 AM · Restricted Project
dnsampaio updated the diff for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.

Fixed duplicates

Apr 18 2019, 3:31 AM · Restricted Project
dnsampaio planned changes to D60828: [ARM] Fix armv8 features tree and add fp16fml.

Waiting for the outcome of D60691.

Apr 18 2019, 2:29 AM · Restricted Project
dnsampaio added inline comments to D60828: [ARM] Fix armv8 features tree and add fp16fml.
Apr 18 2019, 1:59 AM · Restricted Project

Apr 17 2019

dnsampaio created D60828: [ARM] Fix armv8 features tree and add fp16fml.
Apr 17 2019, 8:54 AM · Restricted Project

Apr 16 2019

dnsampaio updated the diff for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
  • Added big-endian tests
Apr 16 2019, 4:28 AM · Restricted Project
dnsampaio edited reviewers for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv, added: ostannard; removed: olista01.
Apr 16 2019, 4:28 AM · Restricted Project
dnsampaio added a parent revision for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv: D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.
Apr 16 2019, 4:23 AM · Restricted Project
dnsampaio added a child revision for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors: D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
Apr 16 2019, 4:23 AM · Restricted Project
dnsampaio abandoned D60721: [ARM] Check codegen of v8.2a intrinsics.

Moved tests to D60720

Apr 16 2019, 4:22 AM · Restricted Project
dnsampaio updated the diff for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
  • Added tests
Apr 16 2019, 4:00 AM · Restricted Project
dnsampaio edited reviewers for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors, added: ostannard; removed: olista01.
Apr 16 2019, 2:27 AM · Restricted Project

Apr 15 2019

dnsampaio added a parent revision for D60721: [ARM] Check codegen of v8.2a intrinsics: D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
Apr 15 2019, 10:11 AM · Restricted Project
dnsampaio added a child revision for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv: D60721: [ARM] Check codegen of v8.2a intrinsics.
Apr 15 2019, 10:11 AM · Restricted Project
dnsampaio created D60721: [ARM] Check codegen of v8.2a intrinsics.
Apr 15 2019, 10:11 AM · Restricted Project
dnsampaio added reviewers for D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv: olista01, miyuki.
Apr 15 2019, 10:02 AM · Restricted Project
dnsampaio created D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv.
Apr 15 2019, 10:02 AM · Restricted Project

Apr 12 2019

dnsampaio resigned from D60616: Make parseBitcodeFile use a named StructType, if it exists and matches..

Sorry, I don't believe I ever touched these files before.

Apr 12 2019, 8:20 AM · Restricted Project
dnsampaio added reviewers for D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors: olista01, SjoerdMeijer, DavidSpickett, t.p.northover.
Apr 12 2019, 8:02 AM · Restricted Project
dnsampaio created D60618: [ARM] Add bitcast/extract_subvec. of fp16 vectors.
Apr 12 2019, 8:02 AM · Restricted Project
dnsampaio committed rGeb312ddfdf81: [Aarch64] Add v8.2-a half precision element extract intrinsics (authored by dnsampaio).
[Aarch64] Add v8.2-a half precision element extract intrinsics
Apr 12 2019, 3:45 AM
dnsampaio committed rC358276: [Aarch64] Add v8.2-a half precision element extract intrinsics.
[Aarch64] Add v8.2-a half precision element extract intrinsics
Apr 12 2019, 3:45 AM
dnsampaio committed rL358276: [Aarch64] Add v8.2-a half precision element extract intrinsics.
[Aarch64] Add v8.2-a half precision element extract intrinsics
Apr 12 2019, 3:45 AM
dnsampaio closed D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics.
Apr 12 2019, 3:44 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics.
  • Used clang-format-diff
Apr 12 2019, 2:57 AM · Restricted Project, Restricted Project

Apr 11 2019

dnsampaio updated the diff for D60413: SExt -> ZExt when no sign bits is used with multiple uses.
Apr 11 2019, 8:59 AM · Restricted Project
dnsampaio updated the diff for D60413: SExt -> ZExt when no sign bits is used with multiple uses.

Moved to agressiveInstCombine.

Apr 11 2019, 8:59 AM · Restricted Project
dnsampaio committed rG8ddfd46c61ab: [AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64 (authored by dnsampaio).
[AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64
Apr 11 2019, 7:20 AM
dnsampaio committed rL358171: [AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64.
[AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64
Apr 11 2019, 7:20 AM
dnsampaio closed D60259: [AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64.
Apr 11 2019, 7:19 AM · Restricted Project
dnsampaio added a comment to D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics.

Ping

Apr 11 2019, 3:14 AM · Restricted Project, Restricted Project
dnsampaio added a comment to D60259: [AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64.

Ping

Apr 11 2019, 3:13 AM · Restricted Project

Apr 10 2019

dnsampaio committed rGaae424a2d266: [AArch64] Add lowering pattern for scalar fp16 facge and facgt (authored by dnsampaio).
[AArch64] Add lowering pattern for scalar fp16 facge and facgt
Apr 10 2019, 6:34 AM
dnsampaio committed rL358083: [AArch64] Add lowering pattern for scalar fp16 facge and facgt.
[AArch64] Add lowering pattern for scalar fp16 facge and facgt
Apr 10 2019, 6:34 AM
dnsampaio closed D60212: [AArch64] Add lowering pattern for scalar fp16 facge and facgt.
Apr 10 2019, 6:34 AM · Restricted Project
dnsampaio committed rG651463e4a8fe: [ARM] [FIX] Add missing f16 vector operations lowering (authored by dnsampaio).
[ARM] [FIX] Add missing f16 vector operations lowering
Apr 10 2019, 6:28 AM
dnsampaio committed rL358081: [ARM] [FIX] Add missing f16 vector operations lowering.
[ARM] [FIX] Add missing f16 vector operations lowering
Apr 10 2019, 6:28 AM
dnsampaio closed D60319: [ARM] [FIX] Add missing f16 vector operations lowering.
Apr 10 2019, 6:28 AM · Restricted Project

Apr 8 2019

dnsampaio updated the diff for D60413: SExt -> ZExt when no sign bits is used with multiple uses.

Added transformation for comparing.

Apr 8 2019, 10:29 AM · Restricted Project
dnsampaio created D60413: SExt -> ZExt when no sign bits is used with multiple uses.
Apr 8 2019, 10:23 AM · Restricted Project
dnsampaio updated the diff for D60319: [ARM] [FIX] Add missing f16 vector operations lowering.
Apr 8 2019, 3:31 AM · Restricted Project
dnsampaio updated the diff for D60319: [ARM] [FIX] Add missing f16 vector operations lowering.

Moved tests to existing vector test file.

Apr 8 2019, 3:28 AM · Restricted Project

Apr 5 2019

dnsampaio created D60319: [ARM] [FIX] Add missing f16 vector operations lowering.
Apr 5 2019, 8:36 AM · Restricted Project
dnsampaio added a comment to D60212: [AArch64] Add lowering pattern for scalar fp16 facge and facgt.

Ping.
I know the usual time is a week, but for such a small bug-fix I don't believe much more people would care.

Apr 5 2019, 4:37 AM · Restricted Project

Apr 4 2019

dnsampaio created D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics.
Apr 4 2019, 8:49 AM · Restricted Project, Restricted Project
dnsampaio added a comment to D60259: [AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64.

Would it be possible to see the surrounding tests for fp16_intrinic_scalar_2op? It'd be good to double check formatting

Apr 4 2019, 6:19 AM · Restricted Project
dnsampaio added a parent revision for D60259: [AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64: D60212: [AArch64] Add lowering pattern for scalar fp16 facge and facgt.
Apr 4 2019, 4:11 AM · Restricted Project
dnsampaio added a child revision for D60212: [AArch64] Add lowering pattern for scalar fp16 facge and facgt: D60259: [AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64.
Apr 4 2019, 4:11 AM · Restricted Project
dnsampaio created D60259: [AArch64] Add lowering pattern for llvm.aarch64.neon.vcvtfxs2fp.f16.i64.
Apr 4 2019, 4:11 AM · Restricted Project
dnsampaio updated the diff for D60212: [AArch64] Add lowering pattern for scalar fp16 facge and facgt.

Attended requests.

Apr 4 2019, 1:59 AM · Restricted Project