Page MenuHomePhabricator

dnsampaio (Diogo N. Sampaio)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 22 2017, 3:13 PM (132 w, 2 h)

Recent Activity

Yesterday

dnsampaio added a comment to D75622: [FIX][libc++][Regex] Using regex_constants match_prev_avail | match_not_bol | match_not_bow.

Ping

Thu, Apr 2, 2:06 PM · Restricted Project
dnsampaio added inline comments to D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement.
Thu, Apr 2, 2:06 PM · Restricted Project

Wed, Apr 1

dnsampaio added inline comments to D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement.
Wed, Apr 1, 11:48 AM · Restricted Project

Tue, Mar 31

dnsampaio added inline comments to D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement.
Tue, Mar 31, 4:56 AM · Restricted Project

Fri, Mar 27

dnsampaio added a comment to D75622: [FIX][libc++][Regex] Using regex_constants match_prev_avail | match_not_bol | match_not_bow.

Gentle Ping. I believe all issues with this fix have been fulfilled.

Fri, Mar 27, 4:50 AM · Restricted Project

Mon, Mar 23

dnsampaio updated the diff for D75622: [FIX][libc++][Regex] Using regex_constants match_prev_avail | match_not_bol | match_not_bow.
  • Fixed tests to use "\\b" instead of "\b".
Mon, Mar 23, 4:53 AM · Restricted Project

Wed, Mar 18

dnsampaio accepted D74766: [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics.

LGTM

Wed, Mar 18, 11:19 PM · Restricted Project
dnsampaio added a comment to D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments.

Hi,
thanks for looking into this. The patch LGTM, but regarding the indentation, I don't know what would be the best practice here. We tend to like to preserve the line-git-history, but if we start ignoring the formater check, then it has no sense in they being here.
Perhaps @t.p.northover or @olista01 could share their thoughts here.

Wed, Mar 18, 5:57 AM · Restricted Project

Tue, Mar 17

dnsampaio added inline comments to D73638: [AST] Move dependence computations into a separate file.
Tue, Mar 17, 2:17 AM · Restricted Project

Mon, Mar 16

dnsampaio added a comment to D75622: [FIX][libc++][Regex] Using regex_constants match_prev_avail | match_not_bol | match_not_bow.

Ping.

Mon, Mar 16, 1:40 PM · Restricted Project

Fri, Mar 13

dnsampaio committed rG83cdb654e475: [AArch64][Fix] LdSt optimization generate premature stack-popping (authored by dnsampaio).
[AArch64][Fix] LdSt optimization generate premature stack-popping
Fri, Mar 13, 7:26 PM
dnsampaio closed D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.
Fri, Mar 13, 7:26 PM · Restricted Project
dnsampaio updated the diff for D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.
  • Removed incorrect spacing changes
Fri, Mar 13, 10:44 AM · Restricted Project
dnsampaio updated the diff for D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.
  • Removed unecessary changes
Fri, Mar 13, 8:33 AM · Restricted Project
dnsampaio updated the diff for D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.
  • Do not allow a instruction that may load or store between the LdSt[SP] and the SP update.
Fri, Mar 13, 8:01 AM · Restricted Project

Thu, Mar 12

dnsampaio updated the diff for D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.
  • Do not use pseudo-value
Thu, Mar 12, 4:30 AM · Restricted Project
dnsampaio added a comment to D75622: [FIX][libc++][Regex] Using regex_constants match_prev_avail | match_not_bol | match_not_bow.

Hi @EricWF, thanks for the review.
Indeed there seems to have some other unrelated issue for matching the word boundary \b. Perhaps I wrongly assumed that it should also match line beginning and end.
For example, I would expect all these matches to succeed:

Thu, Mar 12, 2:19 AM · Restricted Project

Wed, Mar 11

dnsampaio updated the diff for D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.
  • Correct mayAlias to isStack
Wed, Mar 11, 6:54 PM · Restricted Project
dnsampaio updated the diff for D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.
  • Fixed tests
  • Avoid optimization when target is Windows with CFI, as we need to correctly update unwind information
Wed, Mar 11, 4:30 PM · Restricted Project
dnsampaio added a comment to D75622: [FIX][libc++][Regex] Using regex_constants match_prev_avail | match_not_bol | match_not_bow.

Ping.

Wed, Mar 11, 5:08 AM · Restricted Project

Tue, Mar 10

dnsampaio accepted D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions.

LGTM, after a nit inline.

Tue, Mar 10, 8:39 AM · Restricted Project

Mon, Mar 9

dnsampaio updated the diff for D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.

Do not optimize post-increment SP in windows targets

Mon, Mar 9, 4:48 AM · Restricted Project
dnsampaio added inline comments to D74766: [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics.
Mon, Mar 9, 4:48 AM · Restricted Project
dnsampaio added inline comments to D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments.
Mon, Mar 9, 3:11 AM · Restricted Project

Sun, Mar 8

dnsampaio added a comment to D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.

I think there's a secondary problem here: if we move an SP adjustment, we might also need to adjust the unwind/debug info. This is particularly nasty on Windows, where messing up the unwind info can actually cause a miscompile.

If you don't want to spend the time to try to figure that out, I'd be happy to just completely forbid optimizing sp adjustments here. It should be rare enough that it doesn't matter much in practice.

Sun, Mar 8, 2:56 PM · Restricted Project

Fri, Mar 6

dnsampaio created D75755: [AArch64][Fix] LdSt optimization generate premature stack-popping.
Fri, Mar 6, 8:46 AM · Restricted Project

Thu, Mar 5

dnsampaio added inline comments to D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions.
Thu, Mar 5, 3:51 AM · Restricted Project
dnsampaio added a comment to D74617: [ARM] Keeping sign information on bitcasts for Neon vdot_lane intrinsics.

Is this missing a test?

Thu, Mar 5, 3:18 AM · Restricted Project
dnsampaio accepted D74616: [ARM] Setting missing isLaneQ attribute on Neon Intrisics definitions.

LGTM with a nit: we can save some space using sintax like this:

let isLaneQ = 1 in
def UDOT_LANEQ : SOpInst<"vdot_laneq", "..(<<)(<<Q)I", "iUiQiQUi", OP_DOT_LNQ>;

or concatenating those that are just one after the other:

let isLaneQ = 1 in {
  def VFMLAL_LANEQ_LOW  : SOpInst<"vfmlal_laneq_low",  "(F>)(F>)F(FQ)I", "hQh", OP_FMLAL_LN>;
   def VFMLSL_LANEQ_LOW  : SOpInst<"vfmlsl_laneq_low",  "(F>)(F>)F(FQ)I", "hQh", OP_FMLSL_LN>;
   def VFMLAL_LANEQ_HIGH : SOpInst<"vfmlal_laneq_high", "(F>)(F>)F(FQ)I", "hQh", OP_FMLAL_LN_Hi>;
   def VFMLSL_LANEQ_HIGH : SOpInst<"vfmlsl_laneq_high", "(F>)(F>)F(FQ)I", "hQh", OP_FMLSL_LN_Hi>;
}
Thu, Mar 5, 2:46 AM · Restricted Project

Mar 4 2020

dnsampaio created D75622: [FIX][libc++][Regex] Using regex_constants match_prev_avail | match_not_bol | match_not_bow.
Mar 4 2020, 9:32 AM · Restricted Project

Feb 14 2020

dnsampaio committed rG8bc790f9e6a6: [AArch64][FPenv] Update chain of int to fp conversion (authored by dnsampaio).
[AArch64][FPenv] Update chain of int to fp conversion
Feb 14 2020, 9:11 PM
dnsampaio closed D74597: [AArch64][FPenv] Update chain of int to fp conversion.
Feb 14 2020, 9:11 PM · Restricted Project
dnsampaio updated the diff for D74597: [AArch64][FPenv] Update chain of int to fp conversion.

Changes requested: IR test, chain changed depending on isStrictFPOpcode, signed and unsigned tests

Feb 14 2020, 8:05 AM · Restricted Project
dnsampaio created D74597: [AArch64][FPenv] Update chain of int to fp conversion.
Feb 14 2020, 2:12 AM · Restricted Project

Feb 11 2020

dnsampaio added a comment to D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.

Hi @ostannard, thanks for your review.
I updated the patch so it won't act when the computed volatile bit-field access will overlap a zero length bit-field, avoiding the conflict. We can update it accordingly to future versions of the AAPCS if required.

Feb 11 2020, 7:14 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
  • Fixing comments and removing some tests changes not required
Feb 11 2020, 7:14 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
  • Add test that the volatile access does not cross a border defined by a zero lenght bit-field, defined by C11, avoiding race-conditions
Feb 11 2020, 6:55 AM · Restricted Project, Restricted Project

Feb 10 2020

dnsampaio added a comment to D73970: [ARM] Fix non-determenistic behaviour.

Do you think it's worth cherry-picking this to 10.0? CC @hans

Also, it looks like the test got dropped in the commit.

Feb 10 2020, 12:24 AM · Restricted Project

Feb 7 2020

dnsampaio updated the diff for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.

Added opt-out flag

Feb 7 2020, 9:40 AM · Restricted Project, Restricted Project
dnsampaio committed rG9d869180c4ad: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields (authored by dnsampaio).
[ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields
Feb 7 2020, 2:13 AM
dnsampaio closed D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields.
Feb 7 2020, 2:13 AM · Restricted Project
dnsampaio updated the diff for D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields.

Revordered some tests adding and definition of the "isAAPCS" function from patch D72932

Feb 7 2020, 2:10 AM · Restricted Project
dnsampaio removed a parent revision for D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields: D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
Feb 7 2020, 2:04 AM · Restricted Project
dnsampaio removed a child revision for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width: D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields.
Feb 7 2020, 2:04 AM · Restricted Project, Restricted Project

Feb 6 2020

dnsampaio committed rG8ba2b6281075: [ARM] Fix non-determenistic behaviour (authored by dnsampaio).
[ARM] Fix non-determenistic behaviour
Feb 6 2020, 1:23 AM
dnsampaio closed D73970: [ARM] Fix non-determenistic behaviour.
Feb 6 2020, 1:23 AM · Restricted Project
dnsampaio planned changes to D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.

Updated wrong patch here.

Feb 6 2020, 1:23 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D73970: [ARM] Fix non-determenistic behaviour.
  • Removed test
  • Added clear at the end of run as well, to clear waste
  • Moved clearing to a more sensible position
Feb 6 2020, 1:23 AM · Restricted Project
dnsampaio updated the diff for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
  • Removed test
  • Added clear at the end of run as well, to clear waste
  • Moved clearing to a more sensible position
Feb 6 2020, 12:56 AM · Restricted Project, Restricted Project

Feb 5 2020

dnsampaio added a comment to D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
Feb 5 2020, 1:35 AM · Restricted Project, Restricted Project
dnsampaio added a comment to D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.

Ping :-)

Feb 5 2020, 12:59 AM · Restricted Project, Restricted Project

Feb 4 2020

dnsampaio updated the summary of D73970: [ARM] Fix non-determenistic behaviour.
Feb 4 2020, 9:17 AM · Restricted Project
dnsampaio added a comment to D73970: [ARM] Fix non-determenistic behaviour.

Does the test work without debug info? Would be good to cut down the size of it.

Feb 4 2020, 9:17 AM · Restricted Project
dnsampaio created D73970: [ARM] Fix non-determenistic behaviour.
Feb 4 2020, 8:22 AM · Restricted Project

Jan 30 2020

dnsampaio retitled D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields from [ARM] Follow AACPS standard for volatile bitfields to [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields.
Jan 30 2020, 9:10 AM · Restricted Project
dnsampaio updated the diff for D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields.
  • Added flag to allow user to opt-in
Jan 30 2020, 9:10 AM · Restricted Project
dnsampaio added a parent revision for D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields: D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
Jan 30 2020, 8:41 AM · Restricted Project
dnsampaio added a child revision for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width: D67399: [ARM] Follow AACPS for preserving number of loads/stores of volatile bit-fields.
Jan 30 2020, 8:41 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
  • Do not generate special volatile access if the record alignment is smaller than the bit-field declared type
Jan 30 2020, 8:41 AM · Restricted Project, Restricted Project
dnsampaio updated the diff for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
  • Moved computation of volatile accesses to the record layout builder
Jan 30 2020, 5:36 AM · Restricted Project, Restricted Project

Jan 24 2020

dnsampaio committed rGbce360b7048c: Detect source location overflow due includes (authored by dnsampaio).
Detect source location overflow due includes
Jan 24 2020, 3:59 PM
dnsampaio closed D70183: Detect source location overflow due includes.
Jan 24 2020, 3:59 PM · Restricted Project

Jan 22 2020

dnsampaio added a comment to D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.

Why are you doing this in CodeGen, rather than adjusting the existing layout code in CGRecordLowering? Doing it this way will result in AdjustAAPCSBitfieldLValue being called for every access to the bitfield, rather than just once. This is probably more fragile too, because it's spreading the logic across multiple parts of the codebase, and has to undo some of the layout done by CGRecordLowering.

Jan 22 2020, 2:03 AM · Restricted Project, Restricted Project
dnsampaio added a comment to D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
Jan 22 2020, 1:45 AM · Restricted Project, Restricted Project

Jan 21 2020

dnsampaio reopened D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.

Sorry, submitted using ide by mistake. Already reverted it.

Jan 21 2020, 7:37 AM · Restricted Project, Restricted Project
dnsampaio committed rG2147703bde1e: Revert "[ARM] Follow AACPS standard for volatile bit-fields access width" (authored by dnsampaio).
Revert "[ARM] Follow AACPS standard for volatile bit-fields access width"
Jan 21 2020, 7:35 AM
dnsampaio added a reverting change for rG6a24339a4524: [ARM] Follow AACPS standard for volatile bit-fields access width: rG2147703bde1e: Revert "[ARM] Follow AACPS standard for volatile bit-fields access width".
Jan 21 2020, 7:35 AM
dnsampaio committed rG6a24339a4524: [ARM] Follow AACPS standard for volatile bit-fields access width (authored by dnsampaio).
[ARM] Follow AACPS standard for volatile bit-fields access width
Jan 21 2020, 7:35 AM
dnsampaio closed D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
Jan 21 2020, 7:35 AM · Restricted Project, Restricted Project

Jan 20 2020

dnsampaio added a comment to D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.

Why are you doing this in CodeGen, rather than adjusting the existing layout code in CGRecordLowering? Doing it this way will result in AdjustAAPCSBitfieldLValue being called for every access to the bit-field, rather than just once. This is probably more fragile too, because it's spreading the logic across multiple parts of the codebase, and has to undo some of the layout done by CGRecordLowering.

Jan 20 2020, 11:22 AM · Restricted Project, Restricted Project

Jan 19 2020

dnsampaio added a reviewer for D72932: [ARM] Follow AACPS standard for volatile bit-fields access width: eli.friedman.
Jan 19 2020, 2:00 PM · Restricted Project, Restricted Project

Jan 17 2020

dnsampaio updated the diff for D70183: Detect source location overflow due includes.
  • Fixed to return correct token
Jan 17 2020, 11:11 AM · Restricted Project
dnsampaio updated the diff for D70183: Detect source location overflow due includes.

Created a early exit when a source location overflow is detected,
avoiding further processing or reaching other assert failures.
For that, it was required to create a 'Failure' kind for includes,
as well add return points along the callstack.

Jan 17 2020, 10:51 AM · Restricted Project
dnsampaio created D72932: [ARM] Follow AACPS standard for volatile bit-fields access width.
Jan 17 2020, 9:06 AM · Restricted Project, Restricted Project

Jan 14 2020

dnsampaio committed rGd94d079a6a5b: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP (authored by dnsampaio).
[ARM][Thumb2] Fix ADD/SUB invalid writes to SP
Jan 14 2020, 3:50 AM
dnsampaio closed D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.
Jan 14 2020, 3:50 AM · Restricted Project

Jan 13 2020

dnsampaio updated the diff for D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.
  • Fixed the destination register class when converting ADDrr to ADDri or ADDspImm. Added test
  • Fixed the number of arguments when converting t2SUBspImm to tSUBspi by adding a register at the end. Else, it would break llvm-mca that expects the number of operands to follow the table-gen, even when not used by the instruction.
Jan 13 2020, 3:38 AM · Restricted Project
dnsampaio reopened D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.
Jan 13 2020, 3:38 AM · Restricted Project

Jan 10 2020

dnsampaio committed rGb1bb5ce96d34: Reverting, broke some bots. Need further investigation. (authored by dnsampaio).
Reverting, broke some bots. Need further investigation.
Jan 10 2020, 5:47 AM
dnsampaio added a reverting change for rG8c12769f3046: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP: rGb1bb5ce96d34: Reverting, broke some bots. Need further investigation..
Jan 10 2020, 5:47 AM
dnsampaio added a comment to D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.

Looking into CodeGen/Thumb2/thumb2-mov.ll test failure.

Jan 10 2020, 4:21 AM · Restricted Project
dnsampaio added a comment to D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.

Looking into CodeGen/Thumb2/thumb2-mov.ll test failure.

Jan 10 2020, 3:46 AM · Restricted Project
dnsampaio committed rG8c12769f3046: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP (authored by dnsampaio).
[ARM][Thumb2] Fix ADD/SUB invalid writes to SP
Jan 10 2020, 3:34 AM
dnsampaio closed D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.
Jan 10 2020, 3:34 AM · Restricted Project

Jan 9 2020

dnsampaio added inline comments to D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.
Jan 9 2020, 1:49 AM · Restricted Project
dnsampaio updated the diff for D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.

Requested fixes

Jan 9 2020, 1:49 AM · Restricted Project

Jan 8 2020

dnsampaio updated the diff for D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.

Requested fixes:

Jan 8 2020, 2:29 AM · Restricted Project

Jan 7 2020

dnsampaio added inline comments to D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.
Jan 7 2020, 8:12 AM · Restricted Project

Jan 6 2020

dnsampaio updated the diff for D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.

Removed dead/wrong tablegen t2InstSubst, defining a t2ADDri12 using t2_so_imm_neg instead of imm0_4095_neg

Jan 6 2020, 5:49 AM · Restricted Project

Dec 30 2019

dnsampaio abandoned D71557: [WIP] [ARM][Fix] Thumb2 add / sub aliases failing in multiple cases..
Dec 30 2019, 10:23 AM · Restricted Project
dnsampaio updated the diff for D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.
  • undo some clang-format-diff changes
Dec 30 2019, 10:14 AM · Restricted Project
dnsampaio updated the diff for D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.

Added fixme to ARMLoadStoreOptimizer due negative offset

Added test-cases for all added (and fixed existing) thumb2 add/sub alias
Dec 30 2019, 10:05 AM · Restricted Project
dnsampaio committed rGf33fd9648c44: [ARM][Thumb][FIX] Add unwinding information to t4 (authored by dnsampaio).
[ARM][Thumb][FIX] Add unwinding information to t4
Dec 30 2019, 8:04 AM
dnsampaio closed D72000: [ARM][Thumb][FIX] Add unwinding information to t4.
Dec 30 2019, 8:04 AM · Restricted Project
dnsampaio updated the diff for D72000: [ARM][Thumb][FIX] Add unwinding information to t4.

Added test

Dec 30 2019, 7:45 AM · Restricted Project
dnsampaio created D72000: [ARM][Thumb][FIX] Add unwinding information to t4.
Dec 30 2019, 6:20 AM · Restricted Project
dnsampaio added inline comments to D70680: [ARM][Thumb2] Fix ADD/SUB invalid writes to SP.
Dec 30 2019, 3:21 AM · Restricted Project
dnsampaio committed rG8232497c313e: [ARM][THUMB2] Allow emitting T3 types of add and sub (authored by dnsampaio).
[ARM][THUMB2] Allow emitting T3 types of add and sub
Dec 30 2019, 3:09 AM
dnsampaio closed D71361: [ARM][THUMB2] Allow emitting T3 types of add and sub.
Dec 30 2019, 3:09 AM · Restricted Project

Dec 16 2019

dnsampaio added a parent revision for D71557: [WIP] [ARM][Fix] Thumb2 add / sub aliases failing in multiple cases.: D71361: [ARM][THUMB2] Allow emitting T3 types of add and sub.
Dec 16 2019, 9:39 AM · Restricted Project