Page MenuHomePhabricator

jmolloy (James Molloy)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 12 2012, 3:50 AM (384 w, 6 d)

Recent Activity

Thu, Jan 23

jmolloy added inline comments to D73068: Reapply Avoid creating an immutable map in the Automaton class..
Thu, Jan 23, 4:50 AM · Restricted Project

Thu, Jan 16

jmolloy accepted D72682: Avoid creating an immutable map in the Automaton class..

Nice cleanup, thanks!

Thu, Jan 16, 5:57 AM · Restricted Project

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rG250a11ae0f9b: [llvm] Allow GlobalOp to take a region for complex initializers (authored by jmolloy).
[llvm] Allow GlobalOp to take a region for complex initializers
Dec 23 2019, 9:12 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG6b534ecbcb24: [llvm] Add initial import of LLVM modules to mlir-translate (authored by jmolloy).
[llvm] Add initial import of LLVM modules to mlir-translate
Dec 23 2019, 9:12 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG96531e2f871d: [mlir][llvm] Add missing cast ops (authored by jmolloy).
[mlir][llvm] Add missing cast ops
Dec 23 2019, 9:12 PM

Dec 10 2019

jmolloy accepted D71210: [MC] Widen the functional unit type from 32 to 64 bits..

In general anything moving from 32-bit to 64-bit bitmasks in the backend LGTM. I'd even go further and suggest using std::bitset to remove this problem Once And For All, but that would require significantly more benchmarking.

Dec 10 2019, 3:09 AM · Restricted Project
jmolloy added a comment to D71210: [MC] Widen the functional unit type from 32 to 64 bits..

In fact, one concrete improvement we could do with this CL (which clearly found everything we needed to patch) is introduce a typedef for "A bitmask of functional units". This would allow us to find all the instances again in future, and highlight the point of the bitwidth to users.

Dec 10 2019, 3:09 AM · Restricted Project

Dec 6 2019

jmolloy accepted D71122: [ModuloSchedule] Fix data types in ModuloScheduleExpander::isLoopCarried.
Dec 6 2019, 8:38 AM · Restricted Project

Nov 22 2019

jmolloy accepted D70213: [ModuloSchedule] Fix a bug in experimental expander during prologue/epilogue stitching..

LGTM, sorry for the delay.

Nov 22 2019, 8:07 AM · Restricted Project

Nov 20 2019

jmolloy added a reviewer for D70493: [StackMaps] Avoid crash when a call follows a patchpoint: ributzka.
Nov 20 2019, 7:47 AM · Restricted Project
jmolloy created D70493: [StackMaps] Avoid crash when a call follows a patchpoint.
Nov 20 2019, 7:18 AM · Restricted Project

Nov 14 2019

jmolloy added inline comments to D70213: [ModuloSchedule] Fix a bug in experimental expander during prologue/epilogue stitching..
Nov 14 2019, 1:00 AM · Restricted Project

Nov 12 2019

jmolloy added a comment to D70113: Mark llvm::ConstantExpr::getAsInstruction as const.

Hi Alex,

Nov 12 2019, 5:32 AM · Restricted Project
jmolloy accepted D70113: Mark llvm::ConstantExpr::getAsInstruction as const.

LGTM, but in which cases are we enforcing const-correctness? const-correctness is not a property LLVM enforces almost anywhere because of its virality.

Nov 12 2019, 5:14 AM · Restricted Project

Nov 6 2019

jmolloy accepted D69538: [ModuloSchedule] Fix experimental modulo expansion for data loop carried dependencies..
Nov 6 2019, 3:15 PM · Restricted Project
jmolloy added a comment to D69538: [ModuloSchedule] Fix experimental modulo expansion for data loop carried dependencies..

Thanks Thomas!

Nov 6 2019, 1:28 PM · Restricted Project
jmolloy accepted D69912: [ModuloSchedule] Do target loop analysis before peeling..

LGTM, thanks!

Nov 6 2019, 11:16 AM · Restricted Project

Nov 5 2019

jmolloy committed rG041f35c46808: [Automaton] Make Automaton thread-safe (authored by jmolloy).
[Automaton] Make Automaton thread-safe
Nov 5 2019, 3:06 PM
jmolloy committed rG39525a672385: [DFAPacketizer] Allow up to 64 functional units (authored by jmolloy).
[DFAPacketizer] Allow up to 64 functional units
Nov 5 2019, 7:42 AM
jmolloy closed D69110: [DFAPacketizer] Allow up to 64 functional units.
Nov 5 2019, 7:42 AM · Restricted Project

Oct 18 2019

jmolloy committed rGd5afdbe5a456: [DFAPacketizer] Fix large compile-time regression for VLIW targets (authored by jmolloy).
[DFAPacketizer] Fix large compile-time regression for VLIW targets
Oct 18 2019, 7:51 AM
jmolloy updated the diff for D69110: [DFAPacketizer] Allow up to 64 functional units.

Updated based on David's comments.

Oct 18 2019, 1:54 AM · Restricted Project
jmolloy added a comment to D69110: [DFAPacketizer] Allow up to 64 functional units.

Thanks David!

Oct 18 2019, 1:54 AM · Restricted Project

Oct 17 2019

jmolloy added reviewers for D69110: [DFAPacketizer] Allow up to 64 functional units: ThomasRaoux, kparzysz, majnemer.
Oct 17 2019, 7:21 AM · Restricted Project
jmolloy created D69110: [DFAPacketizer] Allow up to 64 functional units.
Oct 17 2019, 7:21 AM · Restricted Project
jmolloy committed rG12092a9691a9: [DFAPacketizer] Use DFAEmitter. NFC. (authored by jmolloy).
[DFAPacketizer] Use DFAEmitter. NFC.
Oct 17 2019, 1:35 AM
jmolloy closed D68992: [DFAPacketizer] Use DFAEmitter. NFC..
Oct 17 2019, 1:35 AM · Restricted Project
jmolloy added a comment to D68992: [DFAPacketizer] Use DFAEmitter. NFC..

Thanks Thomas! Done.

Oct 17 2019, 1:35 AM · Restricted Project
jmolloy accepted D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node.

Thanks Graham for taking my feedback on board. I agree with Simon's request too.

Oct 17 2019, 1:27 AM · Restricted Project

Oct 15 2019

jmolloy added reviewers for D68992: [DFAPacketizer] Use DFAEmitter. NFC.: ThomasRaoux, majnemer, kparzysz.
Oct 15 2019, 7:59 AM · Restricted Project
jmolloy created D68992: [DFAPacketizer] Use DFAEmitter. NFC..
Oct 15 2019, 7:59 AM · Restricted Project

Oct 9 2019

jmolloy committed rG9948fe6997bc: [TableGen] Fix crash when using HwModes in CodeEmitterGen (authored by jmolloy).
[TableGen] Fix crash when using HwModes in CodeEmitterGen
Oct 9 2019, 2:20 AM

Oct 7 2019

jmolloy committed rGbeb696e2a68c: [TableGen] Pacify gcc-5.4 more (authored by jmolloy).
[TableGen] Pacify gcc-5.4 more
Oct 7 2019, 1:22 AM

Oct 5 2019

jmolloy committed rGb1f0183e572b: [UnitTests] Try and pacify gcc-5 (authored by jmolloy).
[UnitTests] Try and pacify gcc-5
Oct 5 2019, 1:57 AM

Oct 4 2019

jmolloy committed rG717e540f7ea1: [Automaton] Fix invalid iterator reference (authored by jmolloy).
[Automaton] Fix invalid iterator reference
Oct 4 2019, 10:17 AM
jmolloy committed rG9baac83a2e71: [ModuloSchedule] Do not remap terminators (authored by jmolloy).
[ModuloSchedule] Do not remap terminators
Oct 4 2019, 10:16 AM
jmolloy added a comment to D68463: [ARM] Generate vcmp instead of vcmpe.

Fine from my perspective. The original changes were due to some language-lawyering to fix an awkward testcase, and I can completely believe my lawyering was wrong :)

Oct 4 2019, 6:59 AM · Restricted Project
jmolloy committed rGe667401055ed: [TableGen] Introduce a generic automaton (DFA) backend (authored by jmolloy).
[TableGen] Introduce a generic automaton (DFA) backend
Oct 4 2019, 2:03 AM

Oct 3 2019

jmolloy committed rG9972c992ebee: [ModuloSchedule] removeBranch() *before* creating the trip count condition (authored by jmolloy).
[ModuloSchedule] removeBranch() *before* creating the trip count condition
Oct 3 2019, 10:11 AM

Oct 2 2019

jmolloy committed rG9026518e7398: [ModuloSchedule] Peel out prologs and epilogs, generate actual code (authored by jmolloy).
[ModuloSchedule] Peel out prologs and epilogs, generate actual code
Oct 2 2019, 5:46 AM
jmolloy added inline comments to D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node.
Oct 2 2019, 2:47 AM · Restricted Project

Oct 1 2019

jmolloy updated the diff for D67968: [TableGen] Introduce a generic automaton (DFA) backend.

Address review comments.

Oct 1 2019, 5:24 AM · Restricted Project
jmolloy added a comment to D67968: [TableGen] Introduce a generic automaton (DFA) backend.

Hi Daniel,

Oct 1 2019, 5:23 AM · Restricted Project
jmolloy added a comment to D68205: [ModuloSchedule] Peel out prologs and epilogs, generate actual code.

Hi Thomas,

Oct 1 2019, 5:14 AM · Restricted Project

Sep 30 2019

jmolloy accepted D68219: Support MemoryLocation::UnknownSize in TargetLowering::IntrinsicInfo.

Looks trivially good to me.

Sep 30 2019, 7:12 AM · Restricted Project
jmolloy added inline comments to D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node.
Sep 30 2019, 5:58 AM · Restricted Project
jmolloy requested changes to D47775: [AArch64][SVE] Add SPLAT_VECTOR ISD Node.

Hi Graham,

Sep 30 2019, 4:42 AM · Restricted Project
jmolloy added a reviewer for D68205: [ModuloSchedule] Peel out prologs and epilogs, generate actual code: ThomasRaoux.
Sep 30 2019, 3:57 AM · Restricted Project
jmolloy created D68205: [ModuloSchedule] Peel out prologs and epilogs, generate actual code.
Sep 30 2019, 3:53 AM · Restricted Project
jmolloy added inline comments to D67968: [TableGen] Introduce a generic automaton (DFA) backend.
Sep 30 2019, 2:56 AM · Restricted Project
jmolloy updated the diff for D67968: [TableGen] Introduce a generic automaton (DFA) backend.

Thanks David - I missed your comments, sorry this is a late response.

Sep 30 2019, 2:20 AM · Restricted Project

Sep 26 2019

jmolloy added a reviewer for D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable: SjoerdMeijer.

This feels like it could cause a pretty serious regression. This essentially disables global merging with -fdata-sections, which I know at least one linker relies upon for code size.

Sep 26 2019, 1:23 PM · Restricted Project

Sep 25 2019

jmolloy added a reviewer for D67968: [TableGen] Introduce a generic automaton (DFA) backend: dsanders.

Hi Daniel,

Sep 25 2019, 7:08 AM · Restricted Project

Sep 24 2019

jmolloy accepted D67564: [IR] allow fast-math-flags on phi of FP values.

LGTM, sorry for the long latency.

Sep 24 2019, 11:02 AM · Restricted Project
jmolloy created D67968: [TableGen] Introduce a generic automaton (DFA) backend.
Sep 24 2019, 8:51 AM · Restricted Project

Sep 21 2019

jmolloy committed rG8a74eca398a0: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount (authored by jmolloy).
[MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount
Sep 21 2019, 1:19 AM

Sep 20 2019

jmolloy added a comment to rL372376: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.

Thanks for pushing the revert. Apologies!

Sep 20 2019, 1:44 PM
jmolloy added a comment to rL372425: Revert "[MachinePipeliner] Improve the TargetInstrInfo API….

Thanks for pushing the rollback Mitch!

Sep 20 2019, 1:33 PM
jmolloy committed rG15e27b0b6d9d: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount (authored by jmolloy).
[MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount
Sep 20 2019, 1:58 AM
jmolloy accepted D67167: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.

Thanks Jinsong! I've committed this as rL372376.

Sep 20 2019, 1:56 AM · Restricted Project
jmolloy closed D67167: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.
Sep 20 2019, 1:56 AM · Restricted Project

Sep 19 2019

jmolloy accepted D67766: [Float2Int] avoid crashing on unreachable code (PR38502).
Sep 19 2019, 8:26 AM · Restricted Project
jmolloy closed D67544: [TableGen] Support encoding and decoding per-HwMode.

Thanks! rL372320.

Sep 19 2019, 7:09 AM · Restricted Project
jmolloy committed rG88a5fbfcea79: [TableGen] Support encoding per-HwMode (authored by jmolloy).
[TableGen] Support encoding per-HwMode
Sep 19 2019, 6:41 AM
jmolloy added a comment to D67544: [TableGen] Support encoding and decoding per-HwMode.

Hi Simon,

Sep 19 2019, 2:05 AM · Restricted Project

Sep 18 2019

jmolloy accepted D67315: [SimplifyCFG] mergeConditionalStoreToAddress(): consider cost, not instruction count.
Sep 18 2019, 11:02 AM · Restricted Project
jmolloy added a comment to D67686: Fix compile-time regression caused by rL371928.

Ah great, thanks for the context, and I'm glad this patch helps you out!

Sep 18 2019, 10:54 AM · Restricted Project
jmolloy updated the diff for D67544: [TableGen] Support encoding and decoding per-HwMode.

Thanks Simon! The patch was uploaded with -U999, but this one's with -U9999 just in case :)

Sep 18 2019, 10:06 AM · Restricted Project
jmolloy added a comment to D67544: [TableGen] Support encoding and decoding per-HwMode.

Thanks Krzysztof!

Sep 18 2019, 1:54 AM · Restricted Project
jmolloy accepted D67686: Fix compile-time regression caused by rL371928.

Thankyou Daniel! Looks great!

Sep 18 2019, 1:39 AM · Restricted Project

Sep 17 2019

jmolloy updated the diff for D67544: [TableGen] Support encoding and decoding per-HwMode.

Thanks Simon!

Sep 17 2019, 1:08 AM · Restricted Project

Sep 16 2019

jmolloy added a comment to D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost.

I will be very surprised if this does not cause any regressions at all.

Sep 16 2019, 2:40 AM · Restricted Project
jmolloy accepted D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost.

I can think of a rationale for the current behaviour. A lopsided if-triangle could indicate it might be better to emit a branch than speculate. Especially as this transform is context-free, input code that contains the same pattern many times can cause an explosion in code size and the transform was likely designed to be conservative.

Sep 16 2019, 1:57 AM · Restricted Project

Sep 15 2019

jmolloy committed rGa088b95f8917: [CodeEmitter] Improve testing for APInt encoding (authored by jmolloy).
[CodeEmitter] Improve testing for APInt encoding
Sep 15 2019, 1:50 AM
jmolloy committed rG60aadd19cbff: [CodeEmitter] Support instruction widths > 64 bits (authored by jmolloy).
[CodeEmitter] Support instruction widths > 64 bits
Sep 15 2019, 1:36 AM
jmolloy edited reviewers for D67544: [TableGen] Support encoding and decoding per-HwMode, added: RKSimon, kparzysz; removed: chandlerc, jfb.

Adding Simon and Krzysztof as the original authors of InfoByHwMode.

Sep 15 2019, 1:15 AM · Restricted Project

Sep 13 2019

jmolloy added a comment to D67544: [TableGen] Support encoding and decoding per-HwMode.

Hi Roman,

Sep 13 2019, 5:03 AM · Restricted Project
jmolloy added a comment to D67544: [TableGen] Support encoding and decoding per-HwMode.

Hi Roman,

Sep 13 2019, 4:08 AM · Restricted Project
jmolloy created D67544: [TableGen] Support encoding and decoding per-HwMode.
Sep 13 2019, 3:59 AM · Restricted Project

Sep 12 2019

jmolloy added inline comments to D67167: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.
Sep 12 2019, 5:17 AM · Restricted Project
jmolloy updated the diff for D67167: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.

Thanks for the great feedback Jinsong! I've addressed your comments.

Sep 12 2019, 5:17 AM · Restricted Project
jmolloy created D67487: [CodeEmitter] Support instruction widths > 64 bits.
Sep 12 2019, 3:25 AM · Restricted Project

Sep 9 2019

jmolloy committed rGb6c7fce67add: [DFAPacketizer] Reapply: Track resources for packetized instructions (authored by jmolloy).
[DFAPacketizer] Reapply: Track resources for packetized instructions
Sep 9 2019, 6:18 AM

Sep 6 2019

jmolloy committed rGdb2fa0672210: [DFAPacketizer] Track resources for packetized instructions (authored by jmolloy).
[DFAPacketizer] Track resources for packetized instructions
Sep 6 2019, 5:21 AM
jmolloy closed D66936: [DFAPacketizer] Track resources for packetized instructions.
Sep 6 2019, 5:21 AM · Restricted Project

Sep 5 2019

jmolloy added a comment to D66936: [DFAPacketizer] Track resources for packetized instructions.

Hi Thomas,

Sep 5 2019, 2:32 AM · Restricted Project

Sep 4 2019

jmolloy created D67167: [MachinePipeliner] Improve the TargetInstrInfo API analyzeLoop/reduceLoopCount.
Sep 4 2019, 6:27 AM · Restricted Project
jmolloy committed rG11f0f7f583c9: [ModuloSchedule] Fix no-asserts build (authored by jmolloy).
[ModuloSchedule] Fix no-asserts build
Sep 4 2019, 5:58 AM
jmolloy added a comment to D67081: [ModuloSchedule] Introduce PeelingModuloScheduleExpander.

No-asserts build fixed in rL370894. Apologies for the breakage, I was holding git wrong.

Sep 4 2019, 5:57 AM · Restricted Project
jmolloy committed rGfef9f5905579: [ModuloSchedule] Introduce PeelingModuloScheduleExpander (authored by jmolloy).
[ModuloSchedule] Introduce PeelingModuloScheduleExpander
Sep 4 2019, 5:54 AM
jmolloy added a comment to D67081: [ModuloSchedule] Introduce PeelingModuloScheduleExpander.

Done, thanks!

Sep 4 2019, 5:52 AM · Restricted Project
jmolloy added a comment to D67121: [TargetLowering] Make allowsMemoryAccess methode virtual..

On the other hand, I don't really want to spend much time thinking about how to make SelectionDAG better at this point.

Sep 4 2019, 1:53 AM · Restricted Project

Sep 3 2019

jmolloy added a comment to D67121: [TargetLowering] Make allowsMemoryAccess methode virtual..

Your problem sounds more like we need a better system for checking if a store/trunc store is legal

Sep 3 2019, 12:03 PM · Restricted Project
jmolloy added a comment to D67121: [TargetLowering] Make allowsMemoryAccess methode virtual..

(for more context, this is in the context of https://reviews.llvm.org/rL370576 . It's entirely possible I picked a suboptimal target hook, but allowsMemoryAccess seemed correct to me.).

Sep 3 2019, 11:39 AM · Restricted Project
jmolloy added a comment to D67121: [TargetLowering] Make allowsMemoryAccess methode virtual..

Aren't the targets intended to override allowsMisalignedMemoryAccesses? Does that not work for your usage?

Sep 3 2019, 11:33 AM · Restricted Project
jmolloy added inline comments to D67081: [ModuloSchedule] Introduce PeelingModuloScheduleExpander.
Sep 3 2019, 3:04 AM · Restricted Project
jmolloy updated the diff for D67081: [ModuloSchedule] Introduce PeelingModuloScheduleExpander.

Thanks for the review Thomas!

Sep 3 2019, 3:04 AM · Restricted Project
jmolloy committed rG935499579c2d: [MachinePipeliner] Add a way to unit-test the schedule emitter (authored by jmolloy).
[MachinePipeliner] Add a way to unit-test the schedule emitter
Sep 3 2019, 1:22 AM
jmolloy closed D67011: [MachinePipeliner] Add a way to unit-test the schedule emitter.

Landed in rL370705. Thanks Thomas!

Sep 3 2019, 1:19 AM · Restricted Project

Sep 2 2019

jmolloy created D67081: [ModuloSchedule] Introduce PeelingModuloScheduleExpander.
Sep 2 2019, 8:19 AM · Restricted Project