This is an archive of the discontinued LLVM Phabricator instance.

[VE] enable unaligned load/store isel
ClosedPublic

Authored by simoll on Jan 27 2020, 1:03 AM.

Details

Summary

Enable unaligned load/store isel for iN and fp32/64 and tests.

Diff Detail

Event Timeline

simoll created this revision.Jan 27 2020, 1:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2020, 1:03 AM

Unit tests: pass. 62198 tests passed, 0 failed and 823 were skipped.

clang-tidy: fail. clang-tidy found 2 errors and 0 warnings. 0 of them are added as review comments below (why?).

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

simoll updated this revision to Diff 240490.Jan 27 2020, 1:23 AM
  • clang-format

Unit tests: pass. 62198 tests passed, 0 failed and 823 were skipped.

clang-tidy: fail. clang-tidy found 2 errors and 0 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

arsenm added inline comments.Jan 27 2020, 6:14 AM
llvm/lib/Target/VE/VEInstrInfo.td
777 ↗(On Diff #240490)

There's a new dedicated Alignment predicate on patfrags, so you can avoid the code predicate

simoll planned changes to this revision.Jan 27 2020, 8:33 AM
simoll marked an inline comment as done.
  • unaligned pattern rewrite
simoll updated this revision to Diff 240610.Jan 27 2020, 8:49 AM
simoll retitled this revision from [VE] unaligned load/store isel patterns to [VE] enable unaligned load/store isel.
simoll edited the summary of this revision. (Show Details)
  • Stripped redundant unaligned load/store patterns..

Unit tests: pass. 62222 tests passed, 0 failed and 824 were skipped.

clang-tidy: fail. clang-tidy found 2 errors and 0 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

arsenm accepted this revision.Jan 27 2020, 10:52 AM
This revision is now accepted and ready to land.Jan 27 2020, 10:52 AM
This revision was automatically updated to reflect the committed changes.