Page MenuHomePhabricator

[VE] aligned load/store isel patterns
ClosedPublic

Authored by simoll on Thu, Jan 23, 8:47 AM.

Details

Summary

Aligned load/store isel patterns and tests for
i1/i8/16/32/64 (including extension and truncation) and fp32/64.

Diff Detail

Event Timeline

simoll created this revision.Thu, Jan 23, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jan 23, 8:47 AM
arsenm added inline comments.Thu, Jan 23, 8:49 AM
llvm/lib/Target/VE/VEISelDAGToDAG.cpp
59

Indentation

62

This can reuse the existing type

71–72

Should use isBaseWithConstantOffset

78

Reuse the type

simoll updated this revision to Diff 240117.Fri, Jan 24, 1:07 AM
simoll marked 4 inline comments as done.

More mature SelectADDRri implementation..

Unit tests: fail. 62153 tests passed, 5 failed and 813 were skipped.

failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongord/strongord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakeq/cmp.weakeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakord/weakord.pass.cpp

clang-tidy: fail. clang-tidy found 1 errors and 2 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

simoll planned changes to this revision.Fri, Jan 24, 3:55 AM
simoll marked an inline comment as done.
simoll added inline comments.
llvm/lib/Target/VE/VEISelDAGToDAG.cpp
72

Will be replaced with a cast.. we know that the operand is a constant.

Unit tests: fail. 62158 tests passed, 5 failed and 813 were skipped.

failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_strongord/strongord.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakeq/cmp.weakeq.pass.cpp
failed: libc++.std/language_support/cmp/cmp_weakord/weakord.pass.cpp

clang-tidy: fail. clang-tidy found 1 errors and 2 warnings. 0 of them are added as review comments below (why?).

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

arsenm accepted this revision.Fri, Jan 24, 5:50 AM

LGTM

This revision is now accepted and ready to land.Fri, Jan 24, 5:50 AM
This revision was automatically updated to reflect the committed changes.