Add, sub, left/right shift isel patterns and tests for i32/i64 and fp32/fp64.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/VE/VEInstrInfo.td | ||
---|---|---|
258 | Shouldn't define a different class unless the operand structure is actually different. You can just use a null_frag default parameter to the pattern for example |
Unit tests: pass. 62108 tests passed, 0 failed and 812 were skipped.
clang-tidy: unknown.
clang-format: pass.
Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
I'll split off the null_frag changes to the upstream code in a seperate patch before picking this one up again.
llvm/lib/Target/VE/VEInstrInfo.td | ||
---|---|---|
258 | null_frag works like a charm. I'll rewrite this patch without redundant matcher classes. |
- This patch includes the changes of (https://reviews.llvm.org/D73259), which should go in first.
- Re-wrote using null_frag
Unit tests: pass. 62130 tests passed, 0 failed and 812 were skipped.
clang-tidy: fail. clang-tidy found 0 errors and 1 warnings.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
llvm/lib/Target/VE/VEInstrInfo.td | ||
---|---|---|
258 | Leftover comment |
Unit tests: pass. 62133 tests passed, 0 failed and 812 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.
Unit tests: pass. 62137 tests passed, 0 failed and 812 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.
Unit tests: pass. 62137 tests passed, 0 failed and 812 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.
- Rebased
- Removed ADS for`add` isel pattern (which also wasn't triggered by any tests)
Thanks!
Unit tests: pass. 62134 tests passed, 0 failed and 812 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.
Shouldn't define a different class unless the operand structure is actually different. You can just use a null_frag default parameter to the pattern for example