Page MenuHomePhabricator

[VE] add, sub, left/right shift isel patterns
ClosedPublic

Authored by simoll on Wed, Jan 22, 8:48 AM.

Details

Summary

Add, sub, left/right shift isel patterns and tests for i32/i64 and fp32/fp64.

Diff Detail

Event Timeline

simoll created this revision.Wed, Jan 22, 8:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptWed, Jan 22, 8:48 AM
arsenm added inline comments.Wed, Jan 22, 8:52 AM
llvm/lib/Target/VE/VEInstrInfo.td
258

Shouldn't define a different class unless the operand structure is actually different. You can just use a null_frag default parameter to the pattern for example

Unit tests: pass. 62108 tests passed, 0 failed and 812 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

simoll planned changes to this revision.Wed, Jan 22, 9:31 AM
simoll marked an inline comment as done.

I'll split off the null_frag changes to the upstream code in a seperate patch before picking this one up again.

llvm/lib/Target/VE/VEInstrInfo.td
258

null_frag works like a charm. I'll rewrite this patch without redundant matcher classes.

simoll updated this revision to Diff 239827.Thu, Jan 23, 2:42 AM

Unit tests: pass. 62130 tests passed, 0 failed and 812 were skipped.

clang-tidy: fail. clang-tidy found 0 errors and 1 warnings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

simoll updated this revision to Diff 239867.Thu, Jan 23, 5:32 AM
  • OpNode=null_frag to last position
  • rebased
arsenm added inline comments.Thu, Jan 23, 6:05 AM
llvm/lib/Target/VE/VEInstrInfo.td
258

Leftover comment

Unit tests: pass. 62133 tests passed, 0 failed and 812 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

simoll updated this revision to Diff 239881.Thu, Jan 23, 6:36 AM
  • rebased
  • updated for null_frag
simoll updated this revision to Diff 239883.Thu, Jan 23, 6:40 AM

stripped leftover comment

simoll marked 2 inline comments as done.Thu, Jan 23, 6:40 AM

Unit tests: pass. 62137 tests passed, 0 failed and 812 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

arsenm accepted this revision.Thu, Jan 23, 6:53 AM
This revision is now accepted and ready to land.Thu, Jan 23, 6:53 AM

Unit tests: pass. 62137 tests passed, 0 failed and 812 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

simoll updated this revision to Diff 239889.Thu, Jan 23, 6:59 AM
  • Rebased
  • Removed ADS for`add` isel pattern (which also wasn't triggered by any tests)

Thanks!

This revision was automatically updated to reflect the committed changes.

Unit tests: pass. 62134 tests passed, 0 failed and 812 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.