Page MenuHomePhabricator

[VE][NFC] re-write RR* isel class using null_frag
ClosedPublic

Authored by simoll on Jan 23 2020, 2:10 AM.

Details

Summary

Re-write RR* using null_frag to avoid duplication in upcoming patches.

Diff Detail

Event Timeline

simoll created this revision.Jan 23 2020, 2:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2020, 2:10 AM
simoll planned changes to this revision.Jan 23 2020, 2:12 AM
  • more de-duplication..
simoll updated this revision to Diff 239820.Jan 23 2020, 2:23 AM
simoll retitled this revision from [VE][NFC] re-write RRm isel class using null_frag to [VE][NFC] re-write RR* isel class using null_frag.
simoll edited the summary of this revision. (Show Details)
  • map RRNDm to RRm with null_frag

Unit tests: pass. 62129 tests passed, 0 failed and 808 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Unit tests: pass. 62129 tests passed, 0 failed and 808 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Unit tests: pass. 62130 tests passed, 0 failed and 808 were skipped.

clang-tidy: fail. clang-tidy found 0 errors and 1 warnings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

arsenm added inline comments.Jan 23 2020, 4:44 AM
llvm/lib/Target/VE/VEInstrInfo.td
227

Usually this is the last parameter with a default value of null_frag

simoll updated this revision to Diff 239860.Jan 23 2020, 5:13 AM
  • moved OpNode=null_frag to last position.
  • Stripped RRNDm
arsenm accepted this revision.Jan 23 2020, 5:32 AM
This revision is now accepted and ready to land.Jan 23 2020, 5:32 AM

Unit tests: pass. 62133 tests passed, 0 failed and 808 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

This revision was automatically updated to reflect the committed changes.