This is an archive of the discontinued LLVM Phabricator instance.

[Codegen][X86] Modernize/regenerate old tests. NFCI.
ClosedPublic

Authored by xbolva00 on Dec 9 2019, 7:48 AM.

Details

Summary

Switch to FileCheck where possible.
Adjust tests so they can be easily regenerated by update scripts.

Diff Detail

Event Timeline

xbolva00 created this revision.Dec 9 2019, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2019, 7:48 AM
xbolva00 retitled this revision from [Codegen][X86] Modernize/regenerated old tests. NFCI. to [Codegen][X86] Modernize/regenerate old tests. NFCI..Dec 9 2019, 7:51 AM
spatel accepted this revision.Dec 9 2019, 2:15 PM

I just spot checked about 10 of the files, and the changes seem mostly mechanical, so LGTM. Up to you whether you want to try this in 1 commit and risk breaking bots or split into bite-size chunks. :)

This revision is now accepted and ready to land.Dec 9 2019, 2:15 PM
This revision was automatically updated to reflect the committed changes.

I just spot checked about 10 of the files, and the changes seem mostly mechanical, so LGTM. Up to you whether you want to try this in 1 commit and risk breaking bots or split into bite-size chunks. :)

Thanks. Bots are fine with this one huge commit, it seems :) I will watch bots for any issues.

llvm/test/CodeGen/X86/shift-coalesce.ll