This is found during https://reviews.llvm.org/D70758
All the other record forms are having suffix o at the end.
ANDIo8 and ANDISo8 are the only two that put o before 8.
This patch rename them to be consistent with others.
Paths
| Differential D70928
[PowerPC][NFC] Rename ANDI(S)o8 to ANDI(S)8o ClosedPublic Authored by jsji on Dec 2 2019, 2:48 PM.
Details
Summary This is found during https://reviews.llvm.org/D70758 This patch rename them to be consistent with others.
Diff Detail
Event Timelinejsji added a child revision: D70758: [PowerPC][NFC] Rename record instructions to use _rec suffix instead of o.Dec 2 2019, 8:14 PM This revision is now accepted and ready to land.Dec 3 2019, 7:43 AM Comment Actions Thanks @jhibbits !
Comment Actions Build result: pass - 60520 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt, CMakeCache.txt Closed by commit rG3d41a58eac13: [PowerPC][NFC] Rename ANDI(S)o8 to ANDI(S)8o (authored by jsji). · Explain WhyDec 9 2019, 11:29 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 231783 llvm/lib/Target/PowerPC/P9InstrResources.td
llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/lib/Target/PowerPC/PPCInstr64Bit.td
llvm/lib/Target/PowerPC/PPCInstrInfo.cpp
llvm/lib/Target/PowerPC/PPCInstrVSX.td
llvm/test/CodeGen/PowerPC/convert-rr-to-ri-instrs-out-of-range.mir
llvm/test/CodeGen/PowerPC/convert-rr-to-ri-instrs.mir
llvm/test/CodeGen/PowerPC/ifcvt-diamond-ret.mir
llvm/test/CodeGen/PowerPC/opt-cmp-inst-cr0-live.ll
llvm/test/CodeGen/PowerPC/peephole-miscompile-extswsli.mir
llvm/test/CodeGen/PowerPC/rlwinm_rldicl_to_andi.mir
|
It looks to me like we need another change for P9InstrResources.td (not entirely related to this one), to fix some of these regex's to add the '(o)' suffix as well (ADDC, SUBF, SUBFC appear to need that)