Details

Reviewers

hfinkel
jdoerfert

Summary

This is part of the series started by D68484.

Note: this is a stable point and tests should run fine with the patches applied up to this point.
Note: D68492 has been incorporated.

Diff Detail

Event Timeline

jeroen.dobbelaere created this revision.Oct 4 2019, 2:36 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 4 2019, 2:36 PM

Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript

lebedev.ri added a parent revision: D68492: [PATCH 09/38] [noalias] D9376: llvm.noalias - handling of dead intrinsics.Oct 5 2019, 9:46 AM

lebedev.ri added a child revision: D68494: [PATCH 11/38] [noalias] D9377: llvm.noalias - don't block EarlyCSE.

Comments need more work i think. Also, they are phrases, they should be grammatically correct, start with Uppercase letter.

jeroen.dobbelaere mentioned this in D68492: [PATCH 09/38] [noalias] D9376: llvm.noalias - handling of dead intrinsics.Oct 14 2019, 4:51 AM

jeroen.dobbelaere marked 2 inline comments as done.Oct 14 2019, 4:54 AM

jeroen.dobbelaere added inline comments.

llvm/lib/Analysis/InstructionSimplify.cpp
5148	As mentioned by a.elivikov in D68492: we should not propagate `null` through the intrinsics.
5225	Also here, we should not propagate `null`.

Do not propagate null. Improved tests.

Rebased

jeroen.dobbelaere updated this revision to Diff 270420.Jun 12 2020, 9:15 AM

jeroen.dobbelaere retitled this revision from [PATCH 10/38] [noalias] simplify noalias intrinsics to [PATCH 6/26] [noalias] simplify noalias intrinsics.

jeroen.dobbelaere edited the summary of this revision. (Show Details)

jeroen.dobbelaere retitled this revision from [PATCH 6/26] [noalias] simplify noalias intrinsics to [PATCH 06/26] [noalias] simplify noalias intrinsics.Jun 12 2020, 9:18 AM

jeroen.dobbelaere added a parent revision: D68491: [PATCH 06/27] [noalias] [IR] IRBuilder support for noalias intrinsics..Jun 12 2020, 11:36 AM

jeroen.dobbelaere edited child revisions, added: D68495: [PATCH 08/27] [noalias] EarlyCSE: learn about noalias intrinsics; removed: D68494: [PATCH 11/38] [noalias] D9377: llvm.noalias - don't block EarlyCSE.

jeroen.dobbelaere removed a parent revision: D68492: [PATCH 09/38] [noalias] D9376: llvm.noalias - handling of dead intrinsics.Jun 12 2020, 11:45 AM

Rebased to c06b7e2ab5167ad031745a706204abed1aefd823 (July 14, 2020)