Page MenuHomePhabricator

Out-of-tree machine IR passes
Needs ReviewPublic

Authored by aguinet on Sep 5 2019, 11:40 PM.

Details

Summary

This patch add the possibilities to create out-of-tree MIR passes. This is based on how IR out-of-tree passes work.
If this is something that could be upstreamed, I could factorize the code between the two system, as they are very similar!

Diff Detail

Event Timeline

aguinet created this revision.Sep 5 2019, 11:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2019, 11:40 PM

As a side remark, I have tested this with an out of tree MIR pass that dump MIR, and it works well. Should I add this test within the test suite? I didn't find such test for the current out-of-tree IR system (but chances are I missed it!).

Could you add some documentation, probably in docs/MIRLangRef.rst? Also you lack a test case, probably in ./CodeGen/MIR/Generic/