Page MenuHomePhabricator

[Parser] Avoid spurious 'missing template' error in presence of typos
Needs ReviewPublic

Authored by ilya-biryukov on Aug 1 2019, 10:28 AM.

Details

Reviewers
rsmith
Summary

Suppress those diagnostics if lhs of a member expression contains
errors. Typo correction produces dependent expressions even in
non-template code, that led to spurious diagnostics before.

Also includes a small refactoring to improve code calling
ParseUnqualifiedId and ParseOptionalCXXScopeSpecifier in the common case
when ObjectType is null. This allows to avoid boiler plate required to
propagate whether lhs of a member expression had any errors in the
common code path.