Page MenuHomePhabricator

nridge (Nathan Ridge)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2018, 8:41 PM (103 w, 1 d)

Recent Activity

Thu, Jan 23

nridge updated the diff for D67537: [clangd] Client-side support for inactive regions.

Inject the inactive code decoration type into Highligher.decorationTypes

Thu, Jan 23, 3:21 PM · Restricted Project
nridge added a comment to D67537: [clangd] Client-side support for inactive regions.

there is some significant progress about semantic highlighting on VSCode, VSCode now provides an experimental semantic token API, but no LSP binding yet (is not far away I think). When it is ready, we'd like to switch to that and get rid of our own implementation.

Thu, Jan 23, 2:20 PM · Restricted Project
nridge added a comment to D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request.

Ilya / others if interested, I would like to revive this patch.

Thu, Jan 23, 1:52 PM · Restricted Project
nridge updated the diff for D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request.

Rebase

Thu, Jan 23, 1:52 PM · Restricted Project
nridge committed rGcbcd07a4815f: [clangd] Add C++20 concepts support to TargetFinder (authored by nridge).
[clangd] Add C++20 concepts support to TargetFinder
Thu, Jan 23, 12:18 PM
nridge closed D73140: [clangd] Add C++20 concepts support to TargetFinder.
Thu, Jan 23, 12:17 PM · Restricted Project
nridge committed rGc6c5dbc824c5: [clangd] Add C++20 concepts support to findExplicitReferences() and semantic… (authored by nridge).
[clangd] Add C++20 concepts support to findExplicitReferences() and semantic…
Thu, Jan 23, 12:17 PM
nridge closed D73124: [clangd] Add C++20 concepts support to findExplicitReferences() and semantic highlighting.
Thu, Jan 23, 12:17 PM · Restricted Project

Tue, Jan 21

nridge created D73140: [clangd] Add C++20 concepts support to TargetFinder.
Tue, Jan 21, 2:05 PM · Restricted Project
nridge planned changes to D72874: [clangd] Add a textual fallback for go-to-definition.

Thanks for taking a look!

Tue, Jan 21, 12:32 PM · Restricted Project
nridge retitled D73124: [clangd] Add C++20 concepts support to findExplicitReferences() and semantic highlighting from [clangd] Add C++20 concepts support to FindTarget and semantic highlighting to [clangd] Add C++20 concepts support to findExplicitReferences() and semantic highlighting.
Tue, Jan 21, 10:39 AM · Restricted Project
nridge created D73124: [clangd] Add C++20 concepts support to findExplicitReferences() and semantic highlighting.
Tue, Jan 21, 10:29 AM · Restricted Project
nridge added inline comments to D72874: [clangd] Add a textual fallback for go-to-definition.
Tue, Jan 21, 8:42 AM · Restricted Project

Thu, Jan 16

nridge created D72874: [clangd] Add a textual fallback for go-to-definition.
Thu, Jan 16, 1:36 PM · Restricted Project

Tue, Jan 14

nridge updated the diff for D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times.

Revise the approach to treat non-first expansions as not-selected

Tue, Jan 14, 1:56 PM · Restricted Project
nridge added a comment to D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times.
  • the allSelectedNodes API on SelectionTree feels non-orthogonal: it's only meaningful here because the input happened to be a point and thus touches a single token and therefore node. If the input was a range, then this API doesn't help, because it loses the sense of "topmost" node.
Tue, Jan 14, 1:38 PM · Restricted Project

Sun, Jan 12

nridge committed rG79a09d8bf4d5: [clangd] Show template arguments in type hierarchy when possible (authored by nridge).
[clangd] Show template arguments in type hierarchy when possible
Sun, Jan 12, 7:35 PM
nridge closed D71533: [clangd] Show template arguments in type hierarchy when possible.
Sun, Jan 12, 7:35 PM · Restricted Project
nridge updated the diff for D71533: [clangd] Show template arguments in type hierarchy when possible.

Address nit

Sun, Jan 12, 7:35 PM · Restricted Project
nridge committed rG1ad1308b69b8: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no… (authored by nridge).
[clangd] Assert that the testcases in FindExplicitReferencesTest.All have no…
Sun, Jan 12, 7:19 PM
nridge closed D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics.
Sun, Jan 12, 7:19 PM · Restricted Project
nridge added inline comments to D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics.
Sun, Jan 12, 7:19 PM · Restricted Project
nridge updated the diff for D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics.

Address nit

Sun, Jan 12, 7:19 PM · Restricted Project

Thu, Jan 9

nridge added inline comments to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Thu, Jan 9, 3:25 PM · Restricted Project
nridge planned changes to D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times.
Thu, Jan 9, 2:28 PM · Restricted Project
nridge added reviewers for D67537: [clangd] Client-side support for inactive regions: kadircet, ilya-biryukov, sammccall.

Review ping again :)

Thu, Jan 9, 2:19 PM · Restricted Project
nridge updated the diff for D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics.

Address review comments

Thu, Jan 9, 2:09 PM · Restricted Project
nridge updated the diff for D71533: [clangd] Show template arguments in type hierarchy when possible.

Address latest review comment

Thu, Jan 9, 1:41 PM · Restricted Project
nridge committed rG6a69d3c6b3da: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder (authored by nridge).
[clangd] Handle DeducedTemplateSpecializationType in TargetFinder
Thu, Jan 9, 1:23 PM
nridge closed D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder.
Thu, Jan 9, 1:23 PM · Restricted Project

Tue, Jan 7

nridge updated the diff for D71533: [clangd] Show template arguments in type hierarchy when possible.

Address review comments

Tue, Jan 7, 1:18 PM · Restricted Project
nridge created D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics.
Tue, Jan 7, 11:51 AM · Restricted Project
nridge updated the diff for D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder.

Address review comments

Tue, Jan 7, 11:51 AM · Restricted Project
nridge updated the diff for D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder.

Remove no longer used flag from XRefTests.cpp

Tue, Jan 7, 11:51 AM · Restricted Project
nridge committed rG16f47cf607c7: [clangd] Heuristically resolve dependent call through smart pointer type (authored by nridge).
[clangd] Heuristically resolve dependent call through smart pointer type
Tue, Jan 7, 9:57 AM
nridge closed D71644: [clangd] Heuristically resolve dependent call through smart pointer type.
Tue, Jan 7, 9:56 AM · Restricted Project
nridge updated the diff for D71644: [clangd] Heuristically resolve dependent call through smart pointer type.

Address review comments

Tue, Jan 7, 9:55 AM · Restricted Project
nridge committed rG751d4dae3284: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics (authored by nridge).
[clangd] Assert that the testcases in LocateSymbol.All have no diagnostics
Tue, Jan 7, 9:18 AM
nridge closed D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics.
Tue, Jan 7, 9:18 AM · Restricted Project
nridge updated the diff for D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics.

Address nits

Tue, Jan 7, 9:08 AM · Restricted Project

Sat, Jan 4

nridge added a comment to D67224: [clangd] Enable completions with fixes in VSCode.

Just throwing a wild idea out there: what if we used textDocument/onTypeFormatting to replace the . with -> as soon as it's typed?

Sat, Jan 4, 7:15 PM · Restricted Project

Thu, Jan 2

nridge created D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder.
Thu, Jan 2, 5:19 PM · Restricted Project
nridge updated the diff for D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics.

Address review comments

Thu, Jan 2, 4:50 PM · Restricted Project

Wed, Jan 1

nridge created D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics.
Wed, Jan 1, 10:15 PM · Restricted Project

Tue, Dec 31

nridge updated the summary of D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times.
Tue, Dec 31, 3:17 PM · Restricted Project
nridge created D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times.
Tue, Dec 31, 2:22 PM · Restricted Project

Dec 19 2019

nridge removed a reviewer for D71533: [clangd] Show template arguments in type hierarchy when possible: sammccall.
Dec 19 2019, 2:23 PM · Restricted Project
nridge updated the diff for D71533: [clangd] Show template arguments in type hierarchy when possible.

Address most review comments

Dec 19 2019, 2:21 PM · Restricted Project
nridge added inline comments to D71533: [clangd] Show template arguments in type hierarchy when possible.
Dec 19 2019, 2:21 PM · Restricted Project
nridge added a comment to D71644: [clangd] Heuristically resolve dependent call through smart pointer type.

Shopping around to other reviewers while Sam's OOO.

Dec 19 2019, 1:22 PM · Restricted Project
nridge edited reviewers for D71644: [clangd] Heuristically resolve dependent call through smart pointer type, added: ilya-biryukov, kadircet, hokein; removed: sammccall.
Dec 19 2019, 1:14 PM · Restricted Project

Dec 17 2019

nridge added inline comments to D71644: [clangd] Heuristically resolve dependent call through smart pointer type.
Dec 17 2019, 8:39 PM · Restricted Project
nridge created D71644: [clangd] Heuristically resolve dependent call through smart pointer type.
Dec 17 2019, 8:29 PM · Restricted Project
nridge added a comment to D71533: [clangd] Show template arguments in type hierarchy when possible.

I think this requires changes in other places too, for example when querying index for the children we rather want to query using the symbolid of template pattern, not the instantiation.

Dec 17 2019, 8:01 PM · Restricted Project
nridge updated the diff for D71533: [clangd] Show template arguments in type hierarchy when possible.

Address review comments

Dec 17 2019, 8:01 PM · Restricted Project

Dec 15 2019

nridge created D71533: [clangd] Show template arguments in type hierarchy when possible.
Dec 15 2019, 10:18 PM · Restricted Project

Dec 13 2019

nridge added a comment to D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails..

Indeed, sorry - I meant that if we incorporated it into an LSP server, there'd be no way to target it in methods that take a position rather than a selection (go to defn, hover etc).

Dec 13 2019, 8:24 AM · Restricted Project
nridge added a comment to D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails..

(though personally I'd find it frustrating to have no way to target b in a+b+c).

Dec 13 2019, 7:20 AM · Restricted Project

Dec 12 2019

nridge added a comment to D71240: [clangd] Heuristically resolve dependent method calls.

Probably needs the usual -fno-delayed-template-parsing workaround, see other clangd tests.

Thanks for the suggestion! Fix at https://reviews.llvm.org/D71444

Dec 12 2019, 5:47 PM · Restricted Project
nridge committed rG4f732a3d49ac: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to… (authored by nridge).
[clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to…
Dec 12 2019, 5:38 PM
nridge closed D71444: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to LocateSymbol.Ambiguous.
Dec 12 2019, 5:37 PM · Restricted Project
nridge created D71444: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to LocateSymbol.Ambiguous.
Dec 12 2019, 4:59 PM · Restricted Project
nridge added a comment to D71240: [clangd] Heuristically resolve dependent method calls.

Probably needs the usual -fno-delayed-template-parsing workaround, see other clangd tests.

Dec 12 2019, 4:59 PM · Restricted Project
nridge committed rGecaa9363303e: [clangd] Heuristically resolve dependent method calls (authored by nridge).
[clangd] Heuristically resolve dependent method calls
Dec 12 2019, 3:56 PM
nridge closed D71240: [clangd] Heuristically resolve dependent method calls.
Dec 12 2019, 3:56 PM · Restricted Project
nridge added a comment to D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails..

How do you feel about the approach here?

Dec 12 2019, 3:22 PM · Restricted Project
nridge added inline comments to D71240: [clangd] Heuristically resolve dependent method calls.
Dec 12 2019, 2:15 PM · Restricted Project
nridge updated the diff for D71240: [clangd] Heuristically resolve dependent method calls.

Fix a typo and address one remaining comment

Dec 12 2019, 2:15 PM · Restricted Project
nridge updated the diff for D71240: [clangd] Heuristically resolve dependent method calls.

Address review comments

Dec 12 2019, 2:13 PM · Restricted Project
nridge added a comment to D71240: [clangd] Heuristically resolve dependent method calls.

unique_ptr is harder to get to work than it might appear at first blush :)

Dec 12 2019, 1:45 PM · Restricted Project

Dec 11 2019

nridge added a comment to D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails..

I tried to do a less general version of this (for go-to-definition only) in D70727 :)

Dec 11 2019, 4:00 PM · Restricted Project

Dec 9 2019

nridge updated the diff for D71240: [clangd] Heuristically resolve dependent method calls.

Fix typo

Dec 9 2019, 9:06 PM · Restricted Project
nridge updated the diff for D71240: [clangd] Heuristically resolve dependent method calls.

Add github issue number

Dec 9 2019, 8:57 PM · Restricted Project
nridge updated the summary of D71240: [clangd] Heuristically resolve dependent method calls.
Dec 9 2019, 8:57 PM · Restricted Project
nridge created D71240: [clangd] Heuristically resolve dependent method calls.
Dec 9 2019, 8:57 PM · Restricted Project

Dec 7 2019

nridge added inline comments to D71090: [clangd] Navigation from definition of template specialization to primary template.
Dec 7 2019, 9:51 PM · Restricted Project
nridge committed rGe8716a6df7ab: [clangd] Navigation from definition of template specialization to primary… (authored by nridge).
[clangd] Navigation from definition of template specialization to primary…
Dec 7 2019, 9:42 PM
nridge closed D71090: [clangd] Navigation from definition of template specialization to primary template.
Dec 7 2019, 9:42 PM · Restricted Project
nridge updated the diff for D71090: [clangd] Navigation from definition of template specialization to primary template.

Address comment

Dec 7 2019, 9:42 PM · Restricted Project
nridge added inline comments to D71090: [clangd] Navigation from definition of template specialization to primary template.
Dec 7 2019, 9:42 PM · Restricted Project

Dec 5 2019

nridge created D71090: [clangd] Navigation from definition of template specialization to primary template.
Dec 5 2019, 1:40 PM · Restricted Project
nridge added a comment to D67537: [clangd] Client-side support for inactive regions.

Review ping :)

Dec 5 2019, 12:29 PM · Restricted Project
nridge abandoned D61842: [clangd] [WIP] [Not ready for review] Semantic highlighting.

Abandoning as all of the functionality in this prototype is now present in mainline (except for the ability to color declarations differently from references, which is blocked on a spec change as discussed in D66990).

Dec 5 2019, 12:28 PM · Restricted Project
nridge committed rGde3dbc4f4166: [clangd] Highlighting dependent types in more contexts (authored by nridge).
[clangd] Highlighting dependent types in more contexts
Dec 5 2019, 11:32 AM
nridge closed D70746: [clangd] Highlighting dependent types in more contexts.
Dec 5 2019, 11:32 AM · Restricted Project
nridge committed rG1a4ee4c88f21: [clangd] Find reference to template parameter in 'sizeof...' expression (authored by nridge).
[clangd] Find reference to template parameter in 'sizeof...' expression
Dec 5 2019, 11:32 AM
nridge closed D70740: [clangd] Find reference to template parameter in 'sizeof...' expression.
Dec 5 2019, 11:31 AM · Restricted Project

Dec 3 2019

nridge updated the diff for D70746: [clangd] Highlighting dependent types in more contexts.

Address nit

Dec 3 2019, 4:28 PM · Restricted Project
nridge updated the diff for D70740: [clangd] Find reference to template parameter in 'sizeof...' expression.

Add FindExplicitReferences test

Dec 3 2019, 4:19 PM · Restricted Project

Nov 30 2019

nridge abandoned D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194).
Nov 30 2019, 9:29 PM · Restricted Project
nridge added a comment to D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194).

By the way, may I get permissions to assign issues to myself (and make other such metadata changes to issues) on github?

sure, we just sent you an invitation to the clangd org.

Nov 30 2019, 9:29 PM · Restricted Project
nridge updated the diff for D70746: [clangd] Highlighting dependent types in more contexts.

Address review comments

Nov 30 2019, 9:29 PM · Restricted Project
nridge updated the diff for D70740: [clangd] Find reference to template parameter in 'sizeof...' expression.

Address review comment

Nov 30 2019, 9:11 PM · Restricted Project

Nov 26 2019

nridge created D70746: [clangd] Highlighting dependent types in more contexts.
Nov 26 2019, 2:36 PM · Restricted Project
nridge added a comment to D70740: [clangd] Find reference to template parameter in 'sizeof...' expression.

Fixes https://github.com/clangd/clangd/issues/213

Nov 26 2019, 12:31 PM · Restricted Project
nridge created D70740: [clangd] Find reference to template parameter in 'sizeof...' expression.
Nov 26 2019, 12:25 PM · Restricted Project
nridge added a comment to D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194).

By the way, may I get permissions to assign issues to myself (and make other such metadata changes to issues) on github?

Nov 26 2019, 10:21 AM · Restricted Project
nridge created D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194).
Nov 26 2019, 9:44 AM · Restricted Project

Nov 21 2019

nridge added inline comments to D67537: [clangd] Client-side support for inactive regions.
Nov 21 2019, 10:34 PM · Restricted Project
nridge retitled D67537: [clangd] Client-side support for inactive regions from [WIP] [clangd] Client-side support for inactive regions to [clangd] Client-side support for inactive regions.
Nov 21 2019, 9:09 PM · Restricted Project