Page MenuHomePhabricator

nridge (Nathan Ridge)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2018, 8:41 PM (137 w, 5 h)

Recent Activity

Yesterday

nridge retitled D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls from [clangd] When finding refs for a template specialization, do not return refs to other specializations to [clangd] When finding refs for a renaming alias, do not return refs to underlying decls.
Sun, Sep 20, 6:13 PM · Restricted Project
nridge updated the diff for D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls.

Take a different fix approach, as suggested in the issue discussion

Sun, Sep 20, 6:12 PM · Restricted Project
nridge updated the diff for D87256: [clangd] Avoid relations being overwritten in a header shard.

Address review comments

Sun, Sep 20, 5:23 PM · Restricted Project
nridge committed rG90a8c44d92b2: [clangd] Fix typo in field name (authored by nridge).
[clangd] Fix typo in field name
Sun, Sep 20, 4:53 PM
nridge closed D87995: [clangd] Fix typo in field name.
Sun, Sep 20, 4:53 PM · Restricted Project
nridge accepted D87995: [clangd] Fix typo in field name.
Sun, Sep 20, 4:52 PM · Restricted Project
nridge requested review of D87995: [clangd] Fix typo in field name.
Sun, Sep 20, 4:51 PM · Restricted Project
nridge updated the diff for D87257: [clang] Traverse init-captures while indexing.

Add clang test

Sun, Sep 20, 3:47 PM · Restricted Project
nridge added a comment to D87257: [clang] Traverse init-captures while indexing.

I did try to add a test to clang/test/Index/Core/index-source.cpp, however the output of c-index-test does not seem to be changed by adding this reference.

Could you check clang/test/Index/cxx14-lambdas.cpp, looks like that file is testing lambda.

Sun, Sep 20, 3:46 PM · Restricted Project

Sat, Sep 19

nridge requested review of D87979: [clangd] Link libclangdSupport into clangd-index-server.
Sat, Sep 19, 6:27 PM · Restricted Project

Tue, Sep 8

nridge added a comment to D87253: [libTooling] Change CDB heuristic to look further for files in a given language..

How can I make sure I will receive updates on this issue (or any prolongation of it)?

Tue, Sep 8, 12:36 PM · Restricted Project

Mon, Sep 7

nridge updated the diff for D87257: [clang] Traverse init-captures while indexing.

Fix typo

Mon, Sep 7, 5:13 PM · Restricted Project
nridge added a reviewer for D87257: [clang] Traverse init-captures while indexing: hokein.

I did try to add a test to clang/test/Index/Core/index-source.cpp, however the output of c-index-test does not seem to be changed by adding this reference.

Mon, Sep 7, 5:13 PM · Restricted Project
nridge requested review of D87257: [clang] Traverse init-captures while indexing.
Mon, Sep 7, 5:11 PM · Restricted Project
nridge requested review of D87256: [clangd] Avoid relations being overwritten in a header shard.
Mon, Sep 7, 3:56 PM · Restricted Project

Sun, Sep 6

nridge requested review of D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls.
Sun, Sep 6, 11:29 PM · Restricted Project

Tue, Sep 1

nridge committed rGca842c825a1c: [clangd] Handle templates more consistently in type hierarchy (authored by nridge).
[clangd] Handle templates more consistently in type hierarchy
Tue, Sep 1, 4:19 PM
nridge closed D86861: [clangd] Handle templates more consistently in type hierarchy.
Tue, Sep 1, 4:19 PM · Restricted Project
nridge committed rG7cd6b0c3b5db: [clang] Do not consider the template arguments of bases to be bases themselves (authored by nridge).
[clang] Do not consider the template arguments of bases to be bases themselves
Tue, Sep 1, 4:18 PM
nridge closed D86424: [clang] Do not consider the template arguments of bases to be bases themselves.
Tue, Sep 1, 4:18 PM · Restricted Project
nridge added a comment to D86861: [clangd] Handle templates more consistently in type hierarchy.

IIUC, you're mostly fixing the issues mentioned in https://github.com/clangd/vscode-clangd/pull/44#issuecomment-669092168. If it just contains two fixes (this, and https://reviews.llvm.org/D86424), I think it might make sense to cherry-pick in release 11.

Tue, Sep 1, 9:39 AM · Restricted Project

Mon, Aug 31

nridge updated the summary of D86424: [clang] Do not consider the template arguments of bases to be bases themselves.
Mon, Aug 31, 1:05 AM · Restricted Project
nridge requested review of D86861: [clangd] Handle templates more consistently in type hierarchy.
Mon, Aug 31, 12:02 AM · Restricted Project

Sun, Aug 30

nridge updated the diff for D86424: [clang] Do not consider the template arguments of bases to be bases themselves.

format

Sun, Aug 30, 6:14 PM · Restricted Project
nridge updated the diff for D86424: [clang] Do not consider the template arguments of bases to be bases themselves.

Address review comments

Sun, Aug 30, 6:11 PM · Restricted Project

Mon, Aug 24

nridge added inline comments to D86424: [clang] Do not consider the template arguments of bases to be bases themselves.
Mon, Aug 24, 8:28 AM · Restricted Project

Sun, Aug 23

nridge updated the diff for D86424: [clang] Do not consider the template arguments of bases to be bases themselves.

Fix a typo

Sun, Aug 23, 8:37 PM · Restricted Project
nridge requested review of D86424: [clang] Do not consider the template arguments of bases to be bases themselves.
Sun, Aug 23, 7:15 PM · Restricted Project

Aug 18 2020

nridge committed rGe33ec9d90400: [clangd] Target member of dependent base made visible via a using-decl (authored by nridge).
[clangd] Target member of dependent base made visible via a using-decl
Aug 18 2020, 12:04 AM
nridge closed D86047: [clangd] Target member of dependent base made visible via a using-decl.
Aug 18 2020, 12:04 AM · Restricted Project

Aug 17 2020

nridge updated the diff for D86047: [clangd] Target member of dependent base made visible via a using-decl.

Address review comments

Aug 17 2020, 9:42 PM · Restricted Project
nridge committed rG00d7b7d014f9: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter (authored by nridge).
[clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter
Aug 17 2020, 9:33 PM
nridge closed D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.
Aug 17 2020, 9:32 PM · Restricted Project
nridge committed rG15673d748acd: [clangd] Index refs to main-file symbols as well (authored by nridge).
[clangd] Index refs to main-file symbols as well
Aug 17 2020, 9:30 PM
nridge closed D83536: [clangd] Index refs to main-file symbols as well.
Aug 17 2020, 9:30 PM · Restricted Project
nridge added inline comments to D83536: [clangd] Index refs to main-file symbols as well.
Aug 17 2020, 8:43 AM · Restricted Project
nridge updated the diff for D86047: [clangd] Target member of dependent base made visible via a using-decl.

Update a comment

Aug 17 2020, 12:00 AM · Restricted Project

Aug 16 2020

nridge requested review of D86047: [clangd] Target member of dependent base made visible via a using-decl.
Aug 16 2020, 11:59 PM · Restricted Project
nridge updated the diff for D83536: [clangd] Index refs to main-file symbols as well.

Rebase

Aug 16 2020, 11:15 PM · Restricted Project
nridge added inline comments to D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.
Aug 16 2020, 4:23 PM · Restricted Project
nridge updated the diff for D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.

Update test

Aug 16 2020, 4:23 PM · Restricted Project
nridge updated the diff for D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.

Only visit the TypeConstraint if the immediately-declared-constraint is null

Aug 16 2020, 4:20 PM · Restricted Project
nridge updated the diff for D83536: [clangd] Index refs to main-file symbols as well.

Address review comments

Aug 16 2020, 3:22 PM · Restricted Project

Aug 11 2020

nridge accepted D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid..
Aug 11 2020, 10:34 PM · Restricted Project

Aug 10 2020

nridge updated the diff for D83536: [clangd] Index refs to main-file symbols as well.

Address review comments

Aug 10 2020, 10:06 PM · Restricted Project
nridge added a comment to D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc.

Please run clang/docs/tools/dump_ast_matchers.py script to update the LibASTMatchersReference.html file.

Done. Note, it looks like this script needs to be run with python 2. Should we document this somewhere?

Given that python2 is EOL I think the correct course of action is to make it work with python3.

Aug 10 2020, 9:42 PM · Restricted Project
nridge added inline comments to D85645: [AST] Fix the CXXFoldExpr source range when parentheses range is invalid..
Aug 10 2020, 9:36 PM · Restricted Project
nridge added a comment to D85635: [clangd] Compute the inactive code range for semantic highlighting..

Do you mean "inactive" (instead of "interactive") in the commit message?

Aug 10 2020, 3:32 PM · Restricted Project
nridge committed rG70d583ad1287: [clangd] Have template template arguments target their referenced template decl (authored by nridge).
[clangd] Have template template arguments target their referenced template decl
Aug 10 2020, 10:28 AM
nridge closed D85503: [clangd] Have template template arguments target their referenced template decl.
Aug 10 2020, 10:27 AM · Restricted Project
nridge updated the diff for D85503: [clangd] Have template template arguments target their referenced template decl.

Add Selection test

Aug 10 2020, 12:32 AM · Restricted Project
nridge committed rGb1c7f84643ff: [clang] Allow DynTypedNode to store a TemplateArgumentLoc (authored by nridge).
[clang] Allow DynTypedNode to store a TemplateArgumentLoc
Aug 10 2020, 12:10 AM
nridge closed D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc.
Aug 10 2020, 12:09 AM · Restricted Project
nridge added a comment to D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc.

Please run clang/docs/tools/dump_ast_matchers.py script to update the LibASTMatchersReference.html file.

Aug 10 2020, 12:07 AM · Restricted Project
nridge updated the diff for D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc.

Run script to update AST matcher docs

Aug 10 2020, 12:06 AM · Restricted Project

Aug 9 2020

nridge updated the diff for D83536: [clangd] Index refs to main-file symbols as well.

Add the requested flag

Aug 9 2020, 11:56 PM · Restricted Project
nridge added a comment to D85503: [clangd] Have template template arguments target their referenced template decl.

I've added the matcher and split the clang parts into D85621

Aug 9 2020, 5:41 PM · Restricted Project
nridge updated the diff for D85503: [clangd] Have template template arguments target their referenced template decl.

Address review comments

Aug 9 2020, 5:40 PM · Restricted Project
nridge requested review of D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc.
Aug 9 2020, 5:39 PM · Restricted Project

Aug 7 2020

nridge accepted D85282: [Concepts] Dump template arguments for immediately declared constraint..

Ok, sounds reasonable to me. Thanks!

Aug 7 2020, 8:28 AM · Restricted Project
nridge committed rG57f9518bf032: [clangd] Highlight structured bindings at local scope as LocalVariable (authored by nridge).
[clangd] Highlight structured bindings at local scope as LocalVariable
Aug 7 2020, 12:23 AM
nridge closed D85500: [clangd] Highlight structured bindings at local scope as LocalVariable.
Aug 7 2020, 12:23 AM · Restricted Project
nridge updated the diff for D85500: [clangd] Highlight structured bindings at local scope as LocalVariable.

Fix clang-tidy warning

Aug 7 2020, 12:22 AM · Restricted Project
nridge requested review of D85503: [clangd] Have template template arguments target their referenced template decl.
Aug 7 2020, 12:17 AM · Restricted Project

Aug 6 2020

nridge requested review of D85500: [clangd] Highlight structured bindings at local scope as LocalVariable.
Aug 6 2020, 10:31 PM · Restricted Project
nridge committed rGf4ba7a100a56: [clangd] Semantic highlighting for dependent template name in template argument (authored by nridge).
[clangd] Semantic highlighting for dependent template name in template argument
Aug 6 2020, 6:24 PM
nridge closed D85272: [clangd] Semantic highlighting for dependent template name in template argument.
Aug 6 2020, 6:24 PM · Restricted Project
nridge updated the summary of D85272: [clangd] Semantic highlighting for dependent template name in template argument.
Aug 6 2020, 6:23 PM · Restricted Project
nridge added inline comments to D85272: [clangd] Semantic highlighting for dependent template name in template argument.
Aug 6 2020, 6:22 PM · Restricted Project
nridge updated the diff for D85272: [clangd] Semantic highlighting for dependent template name in template argument.

Address nit

Aug 6 2020, 6:22 PM · Restricted Project

Aug 5 2020

nridge added inline comments to D85282: [Concepts] Dump template arguments for immediately declared constraint..
Aug 5 2020, 11:56 PM · Restricted Project
nridge added a comment to D85282: [Concepts] Dump template arguments for immediately declared constraint..

This patch has helped me understand the difference between the two ConceptReferences in the AST (the TypeConstraint and the ConceptSpecializationExpr).

Aug 5 2020, 11:51 PM · Restricted Project
nridge added inline comments to D85272: [clangd] Semantic highlighting for dependent template name in template argument.
Aug 5 2020, 8:11 AM · Restricted Project

Aug 4 2020

nridge planned changes to D83536: [clangd] Index refs to main-file symbols as well.

Still need to add the flag.

Aug 4 2020, 11:40 PM · Restricted Project
nridge updated the diff for D83536: [clangd] Index refs to main-file symbols as well.

Rebase

Aug 4 2020, 11:40 PM · Restricted Project
nridge requested review of D85272: [clangd] Semantic highlighting for dependent template name in template argument.
Aug 4 2020, 8:34 PM · Restricted Project
nridge added inline comments to D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.
Aug 4 2020, 12:10 AM · Restricted Project

Aug 3 2020

nridge updated the diff for D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.

Rebase on top of D85108

Aug 3 2020, 11:55 PM · Restricted Project
nridge committed rG4ede39684981: [clang] Include trailing-requires-clause in FunctionDecl's source range (authored by nridge).
[clang] Include trailing-requires-clause in FunctionDecl's source range
Aug 3 2020, 11:52 PM
nridge closed D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range.
Aug 3 2020, 11:52 PM · Restricted Project
nridge updated the diff for D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range.

Rebase to avoid dependency on D84136

Aug 3 2020, 11:51 PM · Restricted Project
nridge updated the diff for D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range.

Address review comment

Aug 3 2020, 11:37 PM · Restricted Project
nridge accepted D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr.
Aug 3 2020, 11:28 PM · Restricted Project
nridge requested review of D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range.
Aug 3 2020, 12:21 AM · Restricted Project

Aug 2 2020

nridge added a comment to D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.

(This should be ready for another round of review.)

Aug 2 2020, 6:18 PM · Restricted Project

Jul 29 2020

nridge accepted D84455: [Concepts] Fix a deserialization crash..

btw, getTypeConstraint and hasTypeConstraint APIs are quite easy to be misused (there is another similar bug in getAssociatedConstraints), I think we need to refine them (rename or so) to make them less confusing.

Jul 29 2020, 11:44 PM · Restricted Project
nridge accepted D84837: [clangd] Fix an assertion failure in TargetFinder's heuristic resolution of dependent type..

Thanks!

Jul 29 2020, 10:01 AM · Restricted Project
nridge committed rG89247792c5bd: [clang] Fix ConceptSpecializationExpr::getEndLoc() (authored by nridge).
[clang] Fix ConceptSpecializationExpr::getEndLoc()
Jul 29 2020, 4:05 AM
nridge closed D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc().
Jul 29 2020, 4:05 AM · Restricted Project

Jul 27 2020

nridge updated the diff for D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc().

Address review comment

Jul 27 2020, 11:45 PM · Restricted Project
nridge accepted D84461: [Concepts] Fix ast dump for immediately declared constraint..
Jul 27 2020, 11:27 PM · Restricted Project
nridge retitled D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter from [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter to [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.
Jul 27 2020, 12:07 AM · Restricted Project
nridge added a reviewer for D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter: hokein.
Jul 27 2020, 12:07 AM · Restricted Project
nridge added inline comments to D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.
Jul 27 2020, 12:07 AM · Restricted Project
nridge updated the diff for D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.

Finish addressing review comments

Jul 27 2020, 12:06 AM · Restricted Project

Jul 26 2020

nridge added inline comments to D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.
Jul 26 2020, 11:35 PM · Restricted Project
nridge planned changes to D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.
Jul 26 2020, 7:59 PM · Restricted Project
nridge updated the summary of D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.
Jul 26 2020, 7:59 PM · Restricted Project
nridge updated the diff for D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.

Spun off the source-location issue to D84613.

Jul 26 2020, 7:58 PM · Restricted Project
nridge added a comment to D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc().

Spun off from D84136. Depends on D84461.

Jul 26 2020, 7:51 PM · Restricted Project