Page MenuHomePhabricator

nridge (Nathan Ridge)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2018, 8:41 PM (84 w, 7 h)

Recent Activity

Yesterday

nridge planned changes to D67537: [WIP] [clangd] Client-side support for inactive regions.
Sun, Sep 15, 8:01 PM · Restricted Project
nridge planned changes to D67536: [WIP] [clangd] Add support for an inactive regions notification.

Ok, I can try formulating this as part of / an extension to semantic highlighting.

Sun, Sep 15, 8:00 PM · Restricted Project
nridge added a comment to D67358: [clangd] Implement semantic selections..

Which LSP feature is this related to?

Sun, Sep 15, 8:00 PM · Restricted Project, Restricted Project

Thu, Sep 12

nridge added a comment to D67536: [WIP] [clangd] Add support for an inactive regions notification.

For reference, I also posted a proof-of-concept client impl in D67537, which I used to test/validate this patch.

Thu, Sep 12, 10:37 PM · Restricted Project
nridge added a comment to D67537: [WIP] [clangd] Client-side support for inactive regions.

This is not for review yet, I'm just posting it to illustrate the client side of D67536.

Thu, Sep 12, 10:36 PM · Restricted Project
nridge created D67537: [WIP] [clangd] Client-side support for inactive regions.
Thu, Sep 12, 10:36 PM · Restricted Project
nridge added a comment to D67536: [WIP] [clangd] Add support for an inactive regions notification.

This patch adds server-side support for greying out code in inactive preprocessor branches (issue #132).

Thu, Sep 12, 10:31 PM · Restricted Project
nridge created D67536: [WIP] [clangd] Add support for an inactive regions notification.
Thu, Sep 12, 10:31 PM · Restricted Project

Tue, Sep 3

nridge added a comment to D66990: [clangd] Add distinct highlightings for declarations of functions and methods.

I was hoping though that a patch like this, which would bring us largely to parity with Eclipse CDT's highlightings, wouldn't need to blocked on a change to the upstream protocol proposal, which could take a while.

Is feature parity a hard requirement? Having slightly different highlightings in that case should not be too disruptive.

Tue, Sep 3, 12:21 PM · Restricted Project

Mon, Sep 2

nridge added a comment to D66990: [clangd] Add distinct highlightings for declarations of functions and methods.

I think this makes sense, but it should be done for all declarations and not just functions.
But doing that in the current design would mean we need to double the number of styles. In addition to field, method, function, we would need field-declaration, method-declaration, function-declaration, etc.
Combinatorial explosion of that kind is bad, so I would rather avoid it.

Mon, Sep 2, 2:49 PM · Restricted Project
nridge committed rL370685: Request commit access for nridge.
Request commit access for nridge
Mon, Sep 2, 2:16 PM

Sat, Aug 31

nridge added inline comments to D66516: [clangd] Highlight typedefs to template parameters as template parameters.
Sat, Aug 31, 9:57 PM · Restricted Project, Restricted Project
nridge added a comment to D66990: [clangd] Add distinct highlightings for declarations of functions and methods.

There is precedent for highlighting declarations and uses differently in other C++ editors. For example, Eclipse CDT has separate highlightings for function and functions declarations (see screenshot below).

Sat, Aug 31, 9:54 PM · Restricted Project

Thu, Aug 29

nridge created D66990: [clangd] Add distinct highlightings for declarations of functions and methods.
Thu, Aug 29, 9:42 PM · Restricted Project
nridge committed rGbd0f840f83e5: [clangd] Add distinct highlightings for static fields and methods (authored by nridge).
[clangd] Add distinct highlightings for static fields and methods
Thu, Aug 29, 8:37 PM
nridge committed rL370429: [clangd] Add distinct highlightings for static fields and methods.
[clangd] Add distinct highlightings for static fields and methods
Thu, Aug 29, 8:37 PM
nridge closed D66828: [clangd] Add distinct highlightings for static fields and methods.
Thu, Aug 29, 8:37 PM · Restricted Project, Restricted Project

Tue, Aug 27

nridge created D66828: [clangd] Add distinct highlightings for static fields and methods.
Tue, Aug 27, 1:44 PM · Restricted Project, Restricted Project
nridge committed rL370103: [clangd] Add a distinct highlighting for local variables.
[clangd] Add a distinct highlighting for local variables
Tue, Aug 27, 12:55 PM
nridge committed rG86a4a530f435: [clangd] Add a distinct highlighting for local variables (authored by nridge).
[clangd] Add a distinct highlighting for local variables
Tue, Aug 27, 12:48 PM
nridge closed D66723: [clangd] Add a distinct highlighting for local variables.
Tue, Aug 27, 12:48 PM · Restricted Project

Sun, Aug 25

nridge created D66723: [clangd] Add a distinct highlighting for local variables.
Sun, Aug 25, 2:47 PM · Restricted Project

Sun, Aug 18

nridge committed rGdfe5f3eb0a00: [clangd] Update features table in the docs with links to LSP extension proposals (authored by nridge).
[clangd] Update features table in the docs with links to LSP extension proposals
Sun, Aug 18, 10:16 PM
nridge committed rL369229: [clangd] Update features table in the docs with links to LSP extension proposals.
[clangd] Update features table in the docs with links to LSP extension proposals
Sun, Aug 18, 10:10 PM
nridge closed D65373: [clangd] Update features table in the docs with links to LSP extension proposals.
Sun, Aug 18, 10:10 PM · Restricted Project, Restricted Project
nridge updated the summary of D65373: [clangd] Update features table in the docs with links to LSP extension proposals.
Sun, Aug 18, 10:09 PM · Restricted Project, Restricted Project
nridge added inline comments to D65373: [clangd] Update features table in the docs with links to LSP extension proposals.
Sun, Aug 18, 10:09 PM · Restricted Project, Restricted Project
nridge updated the diff for D65373: [clangd] Update features table in the docs with links to LSP extension proposals.

Address review comments

Sun, Aug 18, 10:05 PM · Restricted Project, Restricted Project

Aug 11 2019

nridge added a comment to D65373: [clangd] Update features table in the docs with links to LSP extension proposals.

Review ping :)

Aug 11 2019, 4:30 PM · Restricted Project, Restricted Project

Aug 6 2019

nridge added a comment to D63672: Added Delta IR Reduction Tool.

This change is breaking shared library builds with linker errors like:

Aug 6 2019, 7:32 PM · Restricted Project

Aug 3 2019

nridge added a comment to D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension..

Do you plan to support text decorations other than color, e.g. bold / underline / italic?

Aug 3 2019, 6:02 PM · Restricted Project
nridge added a comment to D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request.

Thanks for having a look! I filed an issue so some folks who don't necessarily have an LLVM Phabricator account can weigh in, let's continue the discussion there.

Aug 3 2019, 4:54 PM · Restricted Project

Aug 1 2019

nridge added a comment to D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request.

As background, some discussion of this took place on the mailing list a few months ago: http://lists.llvm.org/pipermail/clangd-dev/2019-January/000232.html

Aug 1 2019, 6:00 PM · Restricted Project
nridge created D65625: [clangd] Allow the client to specify multiple compilation databases in the 'initialize' request.
Aug 1 2019, 6:00 PM · Restricted Project

Jul 27 2019

nridge added inline comments to D65373: [clangd] Update features table in the docs with links to LSP extension proposals.
Jul 27 2019, 6:56 PM · Restricted Project, Restricted Project
nridge created D65373: [clangd] Update features table in the docs with links to LSP extension proposals.
Jul 27 2019, 6:53 PM · Restricted Project, Restricted Project
nridge added a comment to D64922: [clangd] Added option to enable semantic highlighting via an experimental capability.

I believe this is not necessary. You can add text document capabilities in the vscode client extension like this:

Jul 27 2019, 5:26 PM · Restricted Project

Jul 17 2019

nridge committed rGe61d0257ede2: [clangd] Type hierarchy: don't resolve parents if the client only asked for… (authored by nridge).
[clangd] Type hierarchy: don't resolve parents if the client only asked for…
Jul 17 2019, 8:28 AM
nridge committed rL366338: [clangd] Type hierarchy: don't resolve parents if the client only asked for….
[clangd] Type hierarchy: don't resolve parents if the client only asked for…
Jul 17 2019, 8:27 AM
nridge closed D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children.
Jul 17 2019, 8:27 AM · Restricted Project, Restricted Project

Jul 16 2019

nridge added a comment to D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children.

(Changed reviewer to Kadir as he reviewed the previous version.)

Jul 16 2019, 4:39 AM · Restricted Project, Restricted Project
nridge edited reviewers for D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children, added: kadircet; removed: sammccall.
Jul 16 2019, 4:39 AM · Restricted Project, Restricted Project

Jul 12 2019

nridge added inline comments to D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children.
Jul 12 2019, 9:09 PM · Restricted Project, Restricted Project
nridge updated the summary of D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children.
Jul 12 2019, 9:09 PM · Restricted Project, Restricted Project
nridge updated the diff for D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children.

Address review comment

Jul 12 2019, 9:08 PM · Restricted Project, Restricted Project
nridge added inline comments to D64614: [clangd] Mark type hierarchy as a supported feature in the docs.
Jul 12 2019, 9:08 PM · Restricted Project, Restricted Project
nridge added inline comments to D64614: [clangd] Mark type hierarchy as a supported feature in the docs.
Jul 12 2019, 8:29 PM · Restricted Project, Restricted Project
nridge committed rGd1fdadb22685: [clangd] Mark type hierarchy as a supported feature in the docs (authored by nridge).
[clangd] Mark type hierarchy as a supported feature in the docs
Jul 12 2019, 8:26 PM
nridge committed rG087b044c4915: [clangd] Implement typeHierarchy/resolve for subtypes (authored by nridge).
[clangd] Implement typeHierarchy/resolve for subtypes
Jul 12 2019, 8:25 PM
nridge committed rL365987: [clangd] Mark type hierarchy as a supported feature in the docs.
[clangd] Mark type hierarchy as a supported feature in the docs
Jul 12 2019, 8:25 PM
nridge closed D64614: [clangd] Mark type hierarchy as a supported feature in the docs.
Jul 12 2019, 8:25 PM · Restricted Project, Restricted Project
nridge committed rL365986: [clangd] Implement typeHierarchy/resolve for subtypes.
[clangd] Implement typeHierarchy/resolve for subtypes
Jul 12 2019, 8:25 PM
nridge closed D64308: [clangd] Implement typeHierarchy/resolve for subtypes.
Jul 12 2019, 8:25 PM · Restricted Project, Restricted Project
nridge updated the diff for D64308: [clangd] Implement typeHierarchy/resolve for subtypes.

Fix Windows test failure

Jul 12 2019, 7:46 PM · Restricted Project, Restricted Project
nridge reopened D64308: [clangd] Implement typeHierarchy/resolve for subtypes.

This was backed out due to a Windows test failure. Seems to be related to the hint path having a different format on Windows. I guess I should not hard-code it, but get it from the TestTU.

Jul 12 2019, 10:34 AM · Restricted Project, Restricted Project

Jul 11 2019

nridge added inline comments to D64614: [clangd] Mark type hierarchy as a supported feature in the docs.
Jul 11 2019, 8:35 PM · Restricted Project, Restricted Project
nridge created D64614: [clangd] Mark type hierarchy as a supported feature in the docs.
Jul 11 2019, 8:33 PM · Restricted Project, Restricted Project
nridge added a comment to D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children.

This is an issue I noticed while writing the unit test for D64308.

Jul 11 2019, 8:30 PM · Restricted Project, Restricted Project
nridge added inline comments to D64308: [clangd] Implement typeHierarchy/resolve for subtypes.
Jul 11 2019, 8:29 PM · Restricted Project, Restricted Project
nridge created D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children.
Jul 11 2019, 8:29 PM · Restricted Project, Restricted Project
nridge committed rG5b9484e559d4: [clangd] Implement typeHierarchy/resolve for subtypes (authored by nridge).
[clangd] Implement typeHierarchy/resolve for subtypes
Jul 11 2019, 8:28 PM
nridge committed rL365867: [clangd] Implement typeHierarchy/resolve for subtypes.
[clangd] Implement typeHierarchy/resolve for subtypes
Jul 11 2019, 8:26 PM
nridge closed D64308: [clangd] Implement typeHierarchy/resolve for subtypes.
Jul 11 2019, 8:26 PM · Restricted Project, Restricted Project
nridge committed rG3aba8296e595: [clangd] Add a missing early return in getTypeHierarchy() (authored by nridge).
[clangd] Add a missing early return in getTypeHierarchy()
Jul 11 2019, 5:26 PM
nridge committed rL365849: [clangd] Add a missing early return in getTypeHierarchy().
[clangd] Add a missing early return in getTypeHierarchy()
Jul 11 2019, 5:25 PM
nridge closed D64307: [clangd] Add a missing early return in getTypeHierarchy().
Jul 11 2019, 5:25 PM · Restricted Project, Restricted Project

Jul 9 2019

nridge added a comment to D64257: [clangd] Added highlighting for class and enum types.

@jvikstrom out of curiosity, are you testing these patches against a client-side implementation of semantic highlighting? If so, which one?

Jul 9 2019, 5:04 PM · Restricted Project, Restricted Project

Jul 7 2019

nridge added a comment to D64308: [clangd] Implement typeHierarchy/resolve for subtypes.

This was an oversight on my part: I forgot that, when we didn't implement typeHierarchy/resolve, it was only supertypes that didn't need it; subtypes do.

Jul 7 2019, 10:20 PM · Restricted Project, Restricted Project
nridge created D64308: [clangd] Implement typeHierarchy/resolve for subtypes.
Jul 7 2019, 10:18 PM · Restricted Project, Restricted Project
nridge created D64307: [clangd] Add a missing early return in getTypeHierarchy().
Jul 7 2019, 10:17 PM · Restricted Project, Restricted Project

Jun 19 2019

nridge committed rG8df5f444a281: [clangd] Include the diagnostics's code when comparing diagnostics (authored by nridge).
[clangd] Include the diagnostics's code when comparing diagnostics
Jun 19 2019, 4:12 PM
nridge committed rL363889: [clangd] Include the diagnostics's code when comparing diagnostics.
[clangd] Include the diagnostics's code when comparing diagnostics
Jun 19 2019, 4:07 PM
nridge closed D63316: [clangd] Include the diagnostics's code when comparing diagnostics.
Jun 19 2019, 4:07 PM · Restricted Project, Restricted Project
nridge updated the diff for D63316: [clangd] Include the diagnostics's code when comparing diagnostics.

Add requested test case

Jun 19 2019, 4:01 PM · Restricted Project, Restricted Project

Jun 15 2019

nridge updated the diff for D63316: [clangd] Include the diagnostics's code when comparing diagnostics.

Revise fix and add test

Jun 15 2019, 10:11 PM · Restricted Project, Restricted Project
nridge added a comment to D63316: [clangd] Include the diagnostics's code when comparing diagnostics.

The fix actually broke another lit test, because in that test the client was not sending the diagnostic's code back in the codeAction request, resulting in a mismatch with the new comparison function.

Jun 15 2019, 10:11 PM · Restricted Project, Restricted Project
nridge committed rGa552508841ad: [clangd] Type hierarchy subtypes (authored by nridge).
[clangd] Type hierarchy subtypes
Jun 15 2019, 7:30 PM
nridge committed rL363506: [clangd] Type hierarchy subtypes.
[clangd] Type hierarchy subtypes
Jun 15 2019, 7:28 PM
nridge closed D58880: [clangd] Type hierarchy subtypes.
Jun 15 2019, 7:28 PM · Restricted Project, Restricted Project
nridge added inline comments to D58880: [clangd] Type hierarchy subtypes.
Jun 15 2019, 7:28 PM · Restricted Project, Restricted Project
nridge updated the diff for D58880: [clangd] Type hierarchy subtypes.

Address remaining review comments

Jun 15 2019, 7:28 PM · Restricted Project, Restricted Project
nridge added a comment to D63331: [clangd] WIP/RFC: Prototype for semantic highlighting proposal.

To avoid multiple people working on the same feature, I think the plan is that @jvikstrom will pick up the current stuff, and continue working/improving it.

Jun 15 2019, 7:00 PM · Restricted Project
nridge added a comment to D62839: [clangd] Index API and implementations for relations.

Thanks for fixing that!

Jun 15 2019, 6:38 PM · Restricted Project, Restricted Project

Jun 14 2019

nridge committed rGf1e6f5713caa: [clangd] Index API and implementations for relations (authored by nridge).
[clangd] Index API and implementations for relations
Jun 14 2019, 7:24 PM
nridge committed rL363481: [clangd] Index API and implementations for relations.
[clangd] Index API and implementations for relations
Jun 14 2019, 7:23 PM
nridge closed D62839: [clangd] Index API and implementations for relations.
Jun 14 2019, 7:23 PM · Restricted Project, Restricted Project

Jun 13 2019

nridge created D63316: [clangd] Include the diagnostics's code when comparing diagnostics.
Jun 13 2019, 10:55 PM · Restricted Project, Restricted Project
nridge added inline comments to D58880: [clangd] Type hierarchy subtypes.
Jun 13 2019, 10:02 PM · Restricted Project, Restricted Project
nridge updated the diff for D58880: [clangd] Type hierarchy subtypes.

Address review comments

Jun 13 2019, 10:00 PM · Restricted Project, Restricted Project
nridge updated the diff for D62839: [clangd] Index API and implementations for relations.

Address latest review comments

Jun 13 2019, 9:14 PM · Restricted Project, Restricted Project
nridge added inline comments to D62839: [clangd] Index API and implementations for relations.
Jun 13 2019, 9:14 PM · Restricted Project, Restricted Project

Jun 12 2019

nridge added inline comments to D62839: [clangd] Index API and implementations for relations.
Jun 12 2019, 8:16 PM · Restricted Project, Restricted Project

Jun 11 2019

nridge updated the diff for D58880: [clangd] Type hierarchy subtypes.

Get disabled tests passing

Jun 11 2019, 7:41 PM · Restricted Project, Restricted Project
nridge retitled D58880: [clangd] Type hierarchy subtypes from [WIP] [clangd] Type hierarchy subtypes to [clangd] Type hierarchy subtypes.
Jun 11 2019, 6:32 PM · Restricted Project, Restricted Project
nridge updated the diff for D58880: [clangd] Type hierarchy subtypes.

Rebase, add lit test, and post for review

Jun 11 2019, 6:32 PM · Restricted Project, Restricted Project
nridge added inline comments to D62839: [clangd] Index API and implementations for relations.
Jun 11 2019, 4:31 PM · Restricted Project, Restricted Project
nridge updated the diff for D62839: [clangd] Index API and implementations for relations.

Address remaining review comments

Jun 11 2019, 4:31 PM · Restricted Project, Restricted Project

Jun 6 2019

nridge added inline comments to D62839: [clangd] Index API and implementations for relations.
Jun 6 2019, 10:32 PM · Restricted Project, Restricted Project
nridge updated the diff for D62839: [clangd] Index API and implementations for relations.

Addressed most review comments, also added some tests

Jun 6 2019, 10:28 PM · Restricted Project, Restricted Project

Jun 4 2019

nridge updated the summary of D58880: [clangd] Type hierarchy subtypes.
Jun 4 2019, 10:15 PM · Restricted Project, Restricted Project