Page MenuHomePhabricator

nridge (Nathan Ridge)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 4 2018, 8:41 PM (200 w, 2 d)

Recent Activity

Mon, Nov 29

nridge accepted D114667: [clangd] Add fixes for clang "include <foo.h>" diagnostics.

Thanks, this is nice low-hanging fruit.

Mon, Nov 29, 12:50 AM · Restricted Project

Sun, Nov 28

nridge committed rG5233ad17e77e: Compilation Database: Point Bazel users to a solution (authored by nridge).
Compilation Database: Point Bazel users to a solution
Sun, Nov 28, 4:30 PM

Fri, Nov 26

nridge added a comment to D105177: [clangd] Implemented indexing of standard library.

What is the status of this -- is it ready to be merged?

Fri, Nov 26, 6:21 PM · Restricted Project

Wed, Nov 24

nridge added a comment to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

thanks, lgtm! let me know of your email address (for commit attribution) if you want me to land this for you.

Wed, Nov 24, 10:57 PM · Restricted Project, Restricted Project

Sun, Nov 21

nridge added a comment to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

I have a couple of nits about the test changes, but with those I think this is good to merged.

Sun, Nov 21, 11:44 PM · Restricted Project, Restricted Project

Wed, Nov 17

nridge committed rG7a8c7946fc3a: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing (authored by nridge).
[clang] Allocate 2 bits to store the constexpr specifier kind when serializing
Wed, Nov 17, 1:57 PM
nridge closed D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.
Wed, Nov 17, 1:57 PM · Restricted Project, Restricted Project
nridge added a comment to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

Thanks for the patch.

Wed, Nov 17, 1:12 AM · Restricted Project, Restricted Project

Sat, Nov 13

nridge requested review of D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.

Sorry for the delay here.

Sat, Nov 13, 8:36 PM · Restricted Project, Restricted Project
nridge updated the diff for D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.

Reworked test to use the framework in clang/test/AST

Sat, Nov 13, 8:35 PM · Restricted Project, Restricted Project

Oct 25 2021

nridge committed rGe6a971b1baec: [clangd] Respect diagnostic suppression during preamble build (authored by nridge).
[clangd] Respect diagnostic suppression during preamble build
Oct 25 2021, 2:40 PM
nridge closed D112403: [clangd] Respect diagnostic suppression during preamble build.
Oct 25 2021, 2:40 PM · Restricted Project
nridge abandoned D111120: [clangd] Find explicit references in the base-specifier of an enum decl.

Yep, thanks very much for the more complete fix!

Oct 25 2021, 8:27 AM · Restricted Project

Oct 24 2021

nridge requested review of D112403: [clangd] Respect diagnostic suppression during preamble build.
Oct 24 2021, 11:42 PM · Restricted Project

Oct 17 2021

nridge added a comment to D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.

Not sure if clangd is the best place to test this. I'm open to other suggestions.

Oct 17 2021, 8:32 PM · Restricted Project, Restricted Project
nridge added a reviewer for D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing: adamcz.
Oct 17 2021, 8:31 PM · Restricted Project, Restricted Project
nridge updated the summary of D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.
Oct 17 2021, 8:31 PM · Restricted Project, Restricted Project
nridge requested review of D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing.
Oct 17 2021, 8:30 PM · Restricted Project, Restricted Project

Oct 13 2021

nridge accepted D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args..

Thanks for fixing this!

Oct 13 2021, 12:25 AM · Restricted Project

Oct 4 2021

nridge retitled D111120: [clangd] Find explicit references in the base-specifier of an enum decl from [clangd] Find explicit references in the base-specifier of an enum decl Partially fixes https://github.com/clangd/clangd/issues/878 to [clangd] Find explicit references in the base-specifier of an enum decl.
Oct 4 2021, 11:51 PM · Restricted Project
nridge requested review of D111120: [clangd] Find explicit references in the base-specifier of an enum decl.
Oct 4 2021, 11:50 PM · Restricted Project

Sep 27 2021

nridge added inline comments to D110216: [clang] retain type sugar in auto / template argument deduction.
Sep 27 2021, 5:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
nridge added inline comments to D110216: [clang] retain type sugar in auto / template argument deduction.
Sep 27 2021, 5:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 26 2021

nridge added inline comments to D110216: [clang] retain type sugar in auto / template argument deduction.
Sep 26 2021, 11:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 23 2021

nridge committed rG4223195de3ea: [clangd] Ensure lambda init-capture gets semantic token (authored by nridge).
[clangd] Ensure lambda init-capture gets semantic token
Sep 23 2021, 12:52 AM
nridge closed D110130: [clangd] Ensure lambda init-capture gets semantic token.
Sep 23 2021, 12:51 AM · Restricted Project
nridge updated the diff for D110130: [clangd] Ensure lambda init-capture gets semantic token.

address review comments

Sep 23 2021, 12:50 AM · Restricted Project

Sep 22 2021

nridge added a comment to D110130: [clangd] Ensure lambda init-capture gets semantic token.

Naming of the patch is a little bit confusing. We're actually dropping the semantic highlighting for the type of lambdacaptures, which was showing up in the declarator names since there was no explicit type spelled in the source code. This turns on highlighting for the capture variables because we're left with a single token now.

Can you reword the description to reflect that?

Sep 22 2021, 12:25 AM · Restricted Project
nridge retitled D110130: [clangd] Ensure lambda init-capture gets semantic token from [clangd] Semantic highlighting for lambda init-capture to [clangd] Ensure lambda init-capture gets semantic token.
Sep 22 2021, 12:24 AM · Restricted Project
nridge updated the diff for D110130: [clangd] Ensure lambda init-capture gets semantic token.

address review comments

Sep 22 2021, 12:23 AM · Restricted Project

Sep 21 2021

nridge added inline comments to D110130: [clangd] Ensure lambda init-capture gets semantic token.
Sep 21 2021, 12:44 AM · Restricted Project
nridge requested review of D110130: [clangd] Ensure lambda init-capture gets semantic token.
Sep 21 2021, 12:43 AM · Restricted Project
nridge committed rGd87d1aa07612: [clangd] Deduplicate inlay hints (authored by nridge).
[clangd] Deduplicate inlay hints
Sep 21 2021, 12:22 AM
nridge closed D110051: [clangd] Deduplicate inlay hints.
Sep 21 2021, 12:22 AM · Restricted Project

Sep 20 2021

nridge updated the diff for D110051: [clangd] Deduplicate inlay hints.

address nit

Sep 20 2021, 11:02 PM · Restricted Project
nridge added a comment to D110051: [clangd] Deduplicate inlay hints.

I am not aware of how the intersecting hints are handled in the implementation on the client side nor in the proposal today. After this patch we might still produce them if for whatever reason there are different kinds of hints for the same range. Is this OK?

Sep 20 2021, 10:58 PM · Restricted Project
nridge added a comment to D110051: [clangd] Deduplicate inlay hints.

I will note that I considered handling this in a way specific to explicit template instantiations.

Sep 20 2021, 12:36 AM · Restricted Project

Sep 19 2021

nridge requested review of D110051: [clangd] Deduplicate inlay hints.
Sep 19 2021, 11:28 PM · Restricted Project

Sep 12 2021

nridge added a comment to D108320: Add semantic token modifier for non-const reference parameter.

Apologies, forgot about this. Commited now :)

Sep 12 2021, 9:51 PM · Restricted Project
nridge committed rG5a85f9b1d48c: Add semantic token modifier for non-const reference parameter (authored by tom-anders).
Add semantic token modifier for non-const reference parameter
Sep 12 2021, 9:51 PM
nridge closed D108320: Add semantic token modifier for non-const reference parameter.
Sep 12 2021, 9:50 PM · Restricted Project

Sep 8 2021

nridge added a comment to D108320: Add semantic token modifier for non-const reference parameter.

I'm happy to commit it. Did you want to make the SmallVector<1> --> uint32_t change, or should I just commit it as is?

Sep 8 2021, 12:04 AM · Restricted Project

Sep 6 2021

nridge committed rG3e03d92e2f4a: [clangd] Omit default template arguments from type hints (authored by nridge).
[clangd] Omit default template arguments from type hints
Sep 6 2021, 11:38 PM
nridge closed D108975: [clangd] Omit default template arguments from type hints.
Sep 6 2021, 11:38 PM · Restricted Project
nridge updated the diff for D108975: [clangd] Omit default template arguments from type hints.

Address review comment

Sep 6 2021, 11:37 PM · Restricted Project
nridge committed rGc2810f2c1655: [clangd] Omit type hints that are too long (authored by nridge).
[clangd] Omit type hints that are too long
Sep 6 2021, 11:33 PM
nridge closed D108972: [clangd] Omit type hints that are too long.
Sep 6 2021, 11:33 PM · Restricted Project

Sep 3 2021

nridge added a comment to D108972: [clangd] Omit type hints that are too long.

A stepping stone would be to just truncate all the template arguments (e.g. tuple<foo<x>, foo<y>> becomes tuple<...> even if tuple<foo<...>, foo<...>> could fit under the limit).

Sep 3 2021, 10:44 AM · Restricted Project

Aug 31 2021

nridge requested review of D108975: [clangd] Omit default template arguments from type hints.
Aug 31 2021, 1:34 AM · Restricted Project
nridge added a comment to D108972: [clangd] Omit type hints that are too long.

(The relevant issue is https://github.com/clangd/clangd/issues/824)

Aug 31 2021, 12:57 AM · Restricted Project
nridge added inline comments to D108972: [clangd] Omit type hints that are too long.
Aug 31 2021, 12:57 AM · Restricted Project
nridge requested review of D108972: [clangd] Omit type hints that are too long.
Aug 31 2021, 12:56 AM · Restricted Project

Aug 28 2021

nridge added a comment to D108320: Add semantic token modifier for non-const reference parameter.

Thanks for the updates! LGTM from my side.

Aug 28 2021, 11:44 AM · Restricted Project

Aug 24 2021

nridge added a comment to D108320: Add semantic token modifier for non-const reference parameter.

Thanks for the update! Looks pretty good, just a few minor comments from me. Will leave approval to Sam.

Aug 24 2021, 1:03 AM · Restricted Project

Aug 19 2021

nridge added inline comments to D108320: Add semantic token modifier for non-const reference parameter.
Aug 19 2021, 5:52 PM · Restricted Project
nridge added inline comments to D105177: [clangd] Implemented indexing of standard library.
Aug 19 2021, 11:08 AM · Restricted Project
nridge added inline comments to D108320: Add semantic token modifier for non-const reference parameter.
Aug 19 2021, 10:57 AM · Restricted Project

Aug 18 2021

nridge added a comment to D108320: Add semantic token modifier for non-const reference parameter.

Thanks -- this patch is looking great so far!

Aug 18 2021, 10:53 PM · Restricted Project

Aug 17 2021

nridge added inline comments to D105177: [clangd] Implemented indexing of standard library.
Aug 17 2021, 12:34 PM · Restricted Project

Aug 15 2021

nridge committed rG47d9d55c6660: [clangd] Do not show inlay hints pertaining to code in other files (authored by nridge).
[clangd] Do not show inlay hints pertaining to code in other files
Aug 15 2021, 10:59 PM
nridge closed D106934: [clangd] Do not inlay hints pertaining to code in other files.
Aug 15 2021, 10:58 PM · Restricted Project
nridge updated the diff for D106934: [clangd] Do not inlay hints pertaining to code in other files.

Address review comment

Aug 15 2021, 10:57 PM · Restricted Project

Jul 27 2021

nridge requested review of D106934: [clangd] Do not inlay hints pertaining to code in other files.
Jul 27 2021, 11:00 PM · Restricted Project

Jul 22 2021

nridge committed rGf443793d26c3: [clangd] Ensure Ref::Container refers to an indexed symbol (authored by nridge).
[clangd] Ensure Ref::Container refers to an indexed symbol
Jul 22 2021, 12:34 AM
nridge closed D105083: [clangd] Ensure Ref::Container refers to an indexed symbol.
Jul 22 2021, 12:34 AM · Restricted Project
nridge updated the diff for D105083: [clangd] Ensure Ref::Container refers to an indexed symbol.

Address review comments

Jul 22 2021, 12:31 AM · Restricted Project

Jul 19 2021

nridge committed rG08b289867b5a: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id (authored by nridge).
[clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id
Jul 19 2021, 2:32 PM
nridge closed D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id.
Jul 19 2021, 2:32 PM · Restricted Project
nridge added a comment to D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id.

@dblaikie now that the dependent patch has been merged and (presumably) stuck, do you think we can proceed with this one?

Jul 19 2021, 1:57 AM · Restricted Project

Jul 14 2021

nridge added a comment to D105457: [clang] Refactor AST printing tests to share more infrastructure.

@dyung I appreciate the help tracking this down!

Jul 14 2021, 4:45 PM · Restricted Project
nridge committed rG9cfec72ffeec: [clang] Refactor AST printing tests to share more infrastructure (authored by nridge).
[clang] Refactor AST printing tests to share more infrastructure
Jul 14 2021, 4:44 PM
nridge closed D105457: [clang] Refactor AST printing tests to share more infrastructure.
Jul 14 2021, 4:44 PM · Restricted Project
nridge added a comment to D105457: [clang] Refactor AST printing tests to share more infrastructure.

Interesting. If you can get me an updated patch, I can give it a try on my machine with 7.5 to verify if you like.

Jul 14 2021, 2:17 PM · Restricted Project
nridge updated the diff for D105457: [clang] Refactor AST printing tests to share more infrastructure.

Work around a gcc 7 bug

Jul 14 2021, 2:15 PM · Restricted Project
nridge reopened D105457: [clang] Refactor AST printing tests to share more infrastructure.
Jul 14 2021, 2:15 PM · Restricted Project
nridge added a comment to D105457: [clang] Refactor AST printing tests to share more infrastructure.

Making the default argument a non-lambda seems to be sufficient to avoid the error:

Jul 14 2021, 2:04 PM · Restricted Project
nridge added a comment to D105457: [clang] Refactor AST printing tests to share more infrastructure.

Thanks! I reduced it further to:

Jul 14 2021, 2:01 PM · Restricted Project
Herald added a project to D91186: [clangd] Add documentation for building and testing clangd: Restricted Project.

I wonder, should these instructions be in an easier-to-find place, such as the clangd repo's own README (https://github.com/clangd/clangd/blob/master/README.md), or even a section of the clangd website (clangd.llvm.org)?

Jul 14 2021, 9:13 AM · Restricted Project, Restricted Project

Jul 13 2021

nridge added a comment to D105457: [clang] Refactor AST printing tests to share more infrastructure.

To be honest, I don't really understand this error. It seems to come from a compile step (not a link step), and it comes from the assembler and says "symbol ... is already defined"? I don't think I've seen an error like that before. (Typically, errors about duplicate definitions would come from the linker.)

Jul 13 2021, 11:07 AM · Restricted Project

Jul 12 2021

nridge committed rG20176bc7dd3f: [clang] Refactor AST printing tests to share more infrastructure (authored by nridge).
[clang] Refactor AST printing tests to share more infrastructure
Jul 12 2021, 10:49 PM
nridge closed D105457: [clang] Refactor AST printing tests to share more infrastructure.
Jul 12 2021, 10:48 PM · Restricted Project
nridge added a comment to D105679: [clangd] Add CMake option to (not) link in clang-tidy checks.

Will building with this option just prevent linking the clang-tidy checks into clangd, or will it also prevent building them in the first place?

Jul 12 2021, 10:46 PM · Restricted Project

Jul 11 2021

nridge updated the diff for D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id.

Rebase on top of refactor patch changes

Jul 11 2021, 7:15 PM · Restricted Project
nridge added inline comments to D105457: [clang] Refactor AST printing tests to share more infrastructure.
Jul 11 2021, 7:14 PM · Restricted Project
nridge updated the diff for D105457: [clang] Refactor AST printing tests to share more infrastructure.

Address review comments

Jul 11 2021, 7:14 PM · Restricted Project
nridge added inline comments to D105083: [clangd] Ensure Ref::Container refers to an indexed symbol.
Jul 11 2021, 6:39 PM · Restricted Project
nridge updated the diff for D105083: [clangd] Ensure Ref::Container refers to an indexed symbol.

Address review comments

Jul 11 2021, 6:38 PM · Restricted Project

Jul 6 2021

nridge added inline comments to D105083: [clangd] Ensure Ref::Container refers to an indexed symbol.
Jul 6 2021, 11:27 PM · Restricted Project

Jul 5 2021

nridge updated the diff for D105457: [clang] Refactor AST printing tests to share more infrastructure.

Move a piece of Decl-specific code into DeclPrinterTest.cpp

Jul 5 2021, 11:14 PM · Restricted Project
nridge added a comment to D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id.

If there's already some duplication, perhaps a pre-patch to generalize that functionality, then using that functionality in this patch?

Jul 5 2021, 10:53 PM · Restricted Project
nridge updated the diff for D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id.

Rebase on top of refactor patch

Jul 5 2021, 10:53 PM · Restricted Project
nridge added a comment to D105457: [clang] Refactor AST printing tests to share more infrastructure.

This is the refactor patch discussed in https://reviews.llvm.org/D104619#2846262.

Jul 5 2021, 10:52 PM · Restricted Project
nridge requested review of D105457: [clang] Refactor AST printing tests to share more infrastructure.
Jul 5 2021, 10:52 PM · Restricted Project

Jul 4 2021

nridge updated the diff for D105083: [clangd] Ensure Ref::Container refers to an indexed symbol.

Addressed review comments, except for the one about using ContainerDC, for the reason explained

Jul 4 2021, 9:44 PM · Restricted Project
nridge added inline comments to D105083: [clangd] Ensure Ref::Container refers to an indexed symbol.
Jul 4 2021, 9:33 PM · Restricted Project
nridge committed rGa15adbcddd07: [clangd] Type hints for structured bindings (authored by nridge).
[clangd] Type hints for structured bindings
Jul 4 2021, 6:54 PM
nridge closed D104617: [clangd] Type hints for structured bindings.
Jul 4 2021, 6:54 PM · Restricted Project
nridge updated the diff for D104617: [clangd] Type hints for structured bindings.

Address review comments

Jul 4 2021, 6:52 PM · Restricted Project

Jul 3 2021

nridge accepted D105400: [clangd][iwyu] explicitly includes `<atomic>`.

Thanks!

Jul 3 2021, 9:43 PM · Restricted Project

Jun 28 2021

nridge planned changes to D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id.

If there's already some duplication, perhaps a pre-patch to generalize that functionality, then using that functionality in this patch?

Jun 28 2021, 11:26 PM · Restricted Project