This is an archive of the discontinued LLVM Phabricator instance.

[LLD] NFC: Fixed GCC warning in ELF/Arch/RISCV.cpp
ClosedPublic

Authored by dendibakh on Jul 8 2019, 4:24 PM.

Reviewers

MaskRay
• espindola

Summary

GCC emits warning on this line:
error: enumeral and non-enumeral type in conditional
expression [-Werror=extra]

Herald added a project: Restricted Project. · View Herald Transcript

This revision is now accepted and ready to land.Jul 8 2019, 5:29 PM

Path

Size

lld/

ELF/

Arch/

3 lines

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines	void RISCV::writePlt(uint8_t *Buf, uint64_t GotPltEntryAddr,
uint32_t Offset = GotPltEntryAddr - PltEntryAddr;		uint32_t Offset = GotPltEntryAddr - PltEntryAddr;
write32le(Buf + 0, utype(AUIPC, X_T3, hi20(Offset)));		write32le(Buf + 0, utype(AUIPC, X_T3, hi20(Offset)));
write32le(Buf + 4, itype(Config->Is64 ? LD : LW, X_T3, X_T3, lo12(Offset)));		write32le(Buf + 4, itype(Config->Is64 ? LD : LW, X_T3, X_T3, lo12(Offset)));
write32le(Buf + 8, itype(JALR, X_T1, X_T3, 0));		write32le(Buf + 8, itype(JALR, X_T1, X_T3, 0));
write32le(Buf + 12, itype(ADDI, 0, 0, 0));		write32le(Buf + 12, itype(ADDI, 0, 0, 0));
}		}

RelType RISCV::getDynRel(RelType Type) const {		RelType RISCV::getDynRel(RelType Type) const {
return Type == Target->SymbolicRel ? Type : R_RISCV_NONE;		return Type == Target->SymbolicRel ? Type
		: static_cast<RelType>(R_RISCV_NONE);
}		}

RelExpr RISCV::getRelExpr(const RelType Type, const Symbol &S,		RelExpr RISCV::getRelExpr(const RelType Type, const Symbol &S,
const uint8_t *Loc) const {		const uint8_t *Loc) const {
switch (Type) {		switch (Type) {
case R_RISCV_ADD8:		case R_RISCV_ADD8:
case R_RISCV_ADD16:		case R_RISCV_ADD16:
case R_RISCV_ADD32:		case R_RISCV_ADD32:
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines