Page MenuHomePhabricator

dendibakh (Denis Bakhvalov)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 18 2018, 12:43 AM (59 w, 6 d)

Recent Activity

Thu, Nov 7

dendibakh added a comment to D69865: [IR] PR27065: Part2. Fix BasicBlock::removePredecessor to not break SSA form..

I'm not arguing that passes should not look into unreachable code.

Thu, Nov 7, 10:47 AM · Restricted Project
dendibakh added a comment to D69865: [IR] PR27065: Part2. Fix BasicBlock::removePredecessor to not break SSA form..

A same/similar question about this code in BasicBlock was raised on llvm-dev here:
http://lists.llvm.org/pipermail/llvm-dev/2015-August/089091.html

Unfortunately, I don't think the legality of the invalid SSA is documented anywhere. But as we can see, it passes the IR verifier.

As noted in D69823, I've made several patches to other passes to work-around the issue. It would be great if we didn't have to do that, but AFAIK, we're stuck.

Thu, Nov 7, 9:05 AM · Restricted Project

Wed, Nov 6

dendibakh added a comment to D69865: [IR] PR27065: Part2. Fix BasicBlock::removePredecessor to not break SSA form..

Unreachable code is generally allowed to be in non-SSA form.

Wed, Nov 6, 2:59 PM · Restricted Project
dendibakh retitled D69823: [IR] [NFC] PR27065: Added tests for BasicBlock::removePredecessor. from [IR] PR27065: Added tests for BasicBlock::removePredecessor. to [IR] [NFC] PR27065: Added tests for BasicBlock::removePredecessor..
Wed, Nov 6, 8:17 AM · Restricted Project
dendibakh added a comment to D69823: [IR] [NFC] PR27065: Added tests for BasicBlock::removePredecessor..

Here are the 2 follow-up patches: D69862, D69865

Wed, Nov 6, 8:17 AM · Restricted Project

Tue, Nov 5

dendibakh created D69865: [IR] PR27065: Part2. Fix BasicBlock::removePredecessor to not break SSA form..
Tue, Nov 5, 11:34 AM · Restricted Project
dendibakh created D69862: [IR] PR27065: Part1. Fix BasicBlock::removePredecessor to not break SSA form..
Tue, Nov 5, 11:25 AM · Restricted Project
dendibakh added inline comments to D69823: [IR] [NFC] PR27065: Added tests for BasicBlock::removePredecessor..
Tue, Nov 5, 9:05 AM · Restricted Project

Mon, Nov 4

dendibakh added inline comments to D69823: [IR] [NFC] PR27065: Added tests for BasicBlock::removePredecessor..
Mon, Nov 4, 3:03 PM · Restricted Project
dendibakh created D69823: [IR] [NFC] PR27065: Added tests for BasicBlock::removePredecessor..
Mon, Nov 4, 1:28 PM · Restricted Project

Sep 19 2019

dendibakh added a reviewer for D67234: [MergedLoadStoreMotion] Sink stores if they have common GEP: efriedma.
Sep 19 2019, 9:08 AM · Restricted Project

Sep 18 2019

dendibakh added a reviewer for D67234: [MergedLoadStoreMotion] Sink stores if they have common GEP: Gerolf.
Sep 18 2019, 12:50 PM · Restricted Project
dendibakh added a comment to D67234: [MergedLoadStoreMotion] Sink stores if they have common GEP.

Thanks for getting back to this.
GVNSink and SimplifyCFG only sink common tails of 2 BBs. I.e. they will not cherry-pick any individual stores from the middle of a BB.
That was the motivation for a little improvement. According to my testing it doesn't have measurable performance impact. I saw fluctuations within 1% which I think is caused by code placement.
I will try to find someone to review.

Sep 18 2019, 11:49 AM · Restricted Project

Sep 17 2019

dendibakh committed rL372176: Request commit access for dendibakh ++.
Request commit access for dendibakh ++
Sep 17 2019, 1:11 PM
dendibakh committed rL372175: Request commit access for dendibakh.
Request commit access for dendibakh
Sep 17 2019, 1:09 PM
dendibakh added a comment to D67234: [MergedLoadStoreMotion] Sink stores if they have common GEP.

Kind reminder. @bjope , please review.

Sep 17 2019, 10:52 AM · Restricted Project

Sep 11 2019

dendibakh added a comment to D67234: [MergedLoadStoreMotion] Sink stores if they have common GEP.

Kind reminder. @bjope , please review.

Sep 11 2019, 3:48 PM · Restricted Project

Sep 5 2019

dendibakh created D67234: [MergedLoadStoreMotion] Sink stores if they have common GEP.
Sep 5 2019, 11:04 AM · Restricted Project
dendibakh updated the summary of D67234: [MergedLoadStoreMotion] Sink stores if they have common GEP.
Sep 5 2019, 11:04 AM · Restricted Project
dendibakh committed rG58f172f05ae0: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors (authored by dendibakh).
[MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors
Sep 5 2019, 10:01 AM
dendibakh committed rL371089: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.
[MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors
Sep 5 2019, 9:59 AM

Sep 4 2019

dendibakh added inline comments to D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.
Sep 4 2019, 4:27 PM · Restricted Project
dendibakh added a comment to D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.

@bjope, please review.

Sep 4 2019, 9:44 AM · Restricted Project

Aug 30 2019

dendibakh added a comment to D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.

Ping.

Aug 30 2019, 9:55 AM · Restricted Project

Aug 27 2019

dendibakh updated the diff for D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.

I introduced an option that controls splitting the footer BB which is disabled by default.
So, no functional change at the moment.

Aug 27 2019, 11:19 AM · Restricted Project

Aug 15 2019

dendibakh updated the diff for D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.

Fixed Bjorn's comments.

Aug 15 2019, 3:15 PM · Restricted Project

Aug 14 2019

dendibakh updated the summary of D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.
Aug 14 2019, 11:17 AM · Restricted Project
dendibakh updated the diff for D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.

Ran update_test_checks.py

Aug 14 2019, 11:17 AM · Restricted Project
dendibakh added inline comments to D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.
Aug 14 2019, 11:01 AM · Restricted Project
dendibakh created D66234: [MergedLoadStoreMotion] Sink stores to BB with more than 2 predecessors.
Aug 14 2019, 10:56 AM · Restricted Project

Jul 19 2019

dendibakh committed rGa29002e59b52: [NFC] Remove unused variable (authored by dendibakh).
[NFC] Remove unused variable
Jul 19 2019, 3:02 PM
dendibakh committed rL366620: [NFC] Remove unused variable.
[NFC] Remove unused variable
Jul 19 2019, 3:01 PM

Jul 17 2019

dendibakh closed D64887: [llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or destruction'.

Closed by rL366387

Jul 17 2019, 4:39 PM · Restricted Project
dendibakh committed rG3eab4819f25a: [llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or… (authored by dendibakh).
[llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or…
Jul 17 2019, 4:31 PM
dendibakh committed rL366387: [llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or….
[llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or…
Jul 17 2019, 4:31 PM
dendibakh added a comment to D64887: [llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or destruction'.

LGTM, thanks! Not sure how I missed this test.

Jul 17 2019, 2:57 PM · Restricted Project
dendibakh created D64887: [llvm-bcanalyzer] Fixed error 'Expected<T> must be checked before access or destruction'.
Jul 17 2019, 2:41 PM · Restricted Project

Jul 8 2019

dendibakh closed D64379: [LLD] NFC: Fixed GCC warning in ELF/Arch/RISCV.cpp.

Closed by https://reviews.llvm.org/rG92fb5f2e479e

Jul 8 2019, 9:05 PM · Restricted Project
dendibakh committed rG92fb5f2e479e: [LLD] NFC: Fixed GCC warning in ELF/Arch/RISCV.cpp (authored by dendibakh).
[LLD] NFC: Fixed GCC warning in ELF/Arch/RISCV.cpp
Jul 8 2019, 8:58 PM
dendibakh committed rL365434: [LLD] NFC: Fixed GCC warning in ELF/Arch/RISCV.cpp.
[LLD] NFC: Fixed GCC warning in ELF/Arch/RISCV.cpp
Jul 8 2019, 8:58 PM
dendibakh created D64379: [LLD] NFC: Fixed GCC warning in ELF/Arch/RISCV.cpp.
Jul 8 2019, 4:24 PM · Restricted Project
dendibakh closed D64372: [LLD] NFC: Fixed GCC warning in wasm/OutputSections.cpp.
Jul 8 2019, 4:12 PM · Restricted Project
dendibakh created D64372: [LLD] NFC: Fixed GCC warning in wasm/OutputSections.cpp.
Jul 8 2019, 3:25 PM · Restricted Project
dendibakh committed rG74be349bcff4: [SCEV] Fix for PR42397. SCEVExpander wrongly adds nsw to shl instruction. (authored by dendibakh).
[SCEV] Fix for PR42397. SCEVExpander wrongly adds nsw to shl instruction.
Jul 8 2019, 11:06 AM
dendibakh committed rL365363: [SCEV] Fix for PR42397. SCEVExpander wrongly adds nsw to shl instruction..
[SCEV] Fix for PR42397. SCEVExpander wrongly adds nsw to shl instruction.
Jul 8 2019, 11:05 AM

Jul 3 2019

dendibakh created D64122: Fix for PR42397. SCEVExpander wrongly adds nsw to shl instruction..
Jul 3 2019, 1:07 AM · Restricted Project

Jun 20 2019

dendibakh added a comment to D62625: LFTR for multiple exit loops.

There should be also positive impact on LSR pass from this change, since LSR likes equality comparisons.

Jun 20 2019, 2:06 PM · Restricted Project

Jun 6 2019

Herald added a project to D44244: [LLVM] Add -git-commit-after-all option: Restricted Project.
Jun 6 2019, 10:49 PM · Restricted Project

Apr 17 2019

dendibakh committed rGcfd25a4b0e57: Test commit by Denis Bakhvalov (authored by dendibakh).
Test commit by Denis Bakhvalov
Apr 17 2019, 3:26 PM
dendibakh committed rL358619: Test commit by Denis Bakhvalov.
Test commit by Denis Bakhvalov
Apr 17 2019, 3:25 PM

Apr 15 2019

dendibakh added a comment to D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..

@qcolombet , can you please commit this patch on my behalf?

Apr 15 2019, 2:30 PM · Restricted Project
dendibakh added inline comments to D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..
Apr 15 2019, 12:36 PM · Restricted Project
dendibakh updated the diff for D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..

Fixed comments.

Apr 15 2019, 12:36 PM · Restricted Project
dendibakh added a comment to D60726: Fixed -Wconversion-null warning in GCC..

@reuk , can you please commit this patch on my behalf?

Apr 15 2019, 11:57 AM · Restricted Project, Restricted Project
dendibakh created D60726: Fixed -Wconversion-null warning in GCC..
Apr 15 2019, 10:39 AM · Restricted Project, Restricted Project

Apr 12 2019

dendibakh created D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge..
Apr 12 2019, 10:00 PM · Restricted Project

Apr 5 2019

dendibakh added a comment to rL357777: Add documentation for PDB TPI/IPI Stream..

I think "LINKER Stream" formatting doesn't look as intended now:
https://llvm.org/docs/PDB/index.html

Apr 5 2019, 12:14 PM

Mar 29 2019

dendibakh added a comment to D51584: [IndVars] Smart hard uses detection.

I also found performance regression as a result of this commit:
http://lists.llvm.org/pipermail/llvm-dev/2019-March/131308.html

Mar 29 2019, 2:34 PM

Jan 2 2019

dendibakh updated the diff for D56114: [gold] emit assembly listing from gold plugin on LTO stage.

Added "-m elf_x86_64" to the gold invocation.

Jan 2 2019, 2:16 PM
dendibakh updated the diff for D56114: [gold] emit assembly listing from gold plugin on LTO stage.

Updated title, added test and removed copying files.
I decided not to add '.s' to the filename, because then user can also name it as "out.s" and it will be "out.s.s" which seems unnatural.

Jan 2 2019, 1:56 PM

Dec 27 2018

dendibakh created D56114: [gold] emit assembly listing from gold plugin on LTO stage.
Dec 27 2018, 3:00 PM

Nov 6 2018

dendibakh added a comment to D54115: [InstCombine] do not shrink switch conditions to illegal types (PR29009).

@spatel, @lebedev.ri, if no other objections, can you please commit it on my behalf?

Nov 6 2018, 11:22 AM
dendibakh updated the diff for D54115: [InstCombine] do not shrink switch conditions to illegal types (PR29009).

Fixed comments.

Nov 6 2018, 10:22 AM

Nov 5 2018

dendibakh updated the diff for D54115: [InstCombine] do not shrink switch conditions to illegal types (PR29009).

Changed the comment.

Nov 5 2018, 10:58 AM
dendibakh added inline comments to D54115: [InstCombine] do not shrink switch conditions to illegal types (PR29009).
Nov 5 2018, 10:42 AM
dendibakh created D54115: [InstCombine] do not shrink switch conditions to illegal types (PR29009).
Nov 5 2018, 10:25 AM