User Details
- User Since
- Sep 18 2018, 12:43 AM (122 w, 3 d)
Dec 12 2019
Updated according to comments by Sanjay.
Dec 9 2019
Fixed comments by David.
@spatel, do you think I should add more reviewers?
Dec 6 2019
Nov 7 2019
I'm not arguing that passes should not look into unreachable code.
A same/similar question about this code in BasicBlock was raised on llvm-dev here:
http://lists.llvm.org/pipermail/llvm-dev/2015-August/089091.htmlUnfortunately, I don't think the legality of the invalid SSA is documented anywhere. But as we can see, it passes the IR verifier.
As noted in D69823, I've made several patches to other passes to work-around the issue. It would be great if we didn't have to do that, but AFAIK, we're stuck.
Nov 6 2019
Nov 5 2019
Nov 4 2019
Sep 19 2019
Sep 18 2019
Thanks for getting back to this.
GVNSink and SimplifyCFG only sink common tails of 2 BBs. I.e. they will not cherry-pick any individual stores from the middle of a BB.
That was the motivation for a little improvement. According to my testing it doesn't have measurable performance impact. I saw fluctuations within 1% which I think is caused by code placement.
I will try to find someone to review.
Sep 17 2019
Kind reminder. @bjope , please review.
Sep 11 2019
Kind reminder. @bjope , please review.
Sep 5 2019
Sep 4 2019
@bjope, please review.
Aug 30 2019
Ping.
Aug 27 2019
I introduced an option that controls splitting the footer BB which is disabled by default.
So, no functional change at the moment.
Aug 15 2019
Fixed Bjorn's comments.
Aug 14 2019
Ran update_test_checks.py
Jul 19 2019
Jul 17 2019
Closed by rL366387
Jul 8 2019
Closed by https://reviews.llvm.org/rG92fb5f2e479e
Jul 3 2019
Jun 20 2019
There should be also positive impact on LSR pass from this change, since LSR likes equality comparisons.
Jun 6 2019
Apr 17 2019
Apr 15 2019
@qcolombet , can you please commit this patch on my behalf?
Fixed comments.
@reuk , can you please commit this patch on my behalf?
Apr 12 2019
Apr 5 2019
I think "LINKER Stream" formatting doesn't look as intended now:
https://llvm.org/docs/PDB/index.html
Mar 29 2019
I also found performance regression as a result of this commit:
http://lists.llvm.org/pipermail/llvm-dev/2019-March/131308.html
Jan 2 2019
Added "-m elf_x86_64" to the gold invocation.
Updated title, added test and removed copying files.
I decided not to add '.s' to the filename, because then user can also name it as "out.s" and it will be "out.s.s" which seems unnatural.
Dec 27 2018
Nov 6 2018
@spatel, @lebedev.ri, if no other objections, can you please commit it on my behalf?
Fixed comments.
Nov 5 2018
Changed the comment.