This is an archive of the discontinued LLVM Phabricator instance.

Differential D61847

[lldb] NFC modernize codebase with modernize-use-nullptr
ClosedPublic

Authored by kwk on May 13 2019, 1:27 AM.

Details

Reviewers
• espindola
shafik
JDevlieghere
martong
Group Reviewers
Restricted Project
Commits
rG248a13057a4a: [lldb] NFC modernize codebase with modernize-use-nullptr
rL361484: [lldb] NFC modernize codebase with modernize-use-nullptr
rLLDB361484: [lldb] NFC modernize codebase with modernize-use-nullptr
Summary

NFC = Non functional change

This commit is the result of modernizing the LLDB codebase by using
nullptr instread of 0 or NULL. See
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html
for more information.

This is the command I ran and I to fix and format the code base:

run-clang-tidy.py \
	-header-filter='.*' \
	-checks='-*,modernize-use-nullptr' \
	-fix ~/dev/llvm-project/lldb/.* \
	-format \
	-style LLVM \
	-p ~/llvm-builds/debug-ninja-gcc
NOTE: There were also changes to llvm/utils/unittest but I did not include them because I felt that maybe this library shall be updated in isolation somehow.
NOTE: I know this is a rather large commit but it is a nobrainer in most parts.

Diff Detail

Event Timeline

kwk created this revision.May 13 2019, 1:27 AM
Herald added a reviewer: martong. · View Herald TranscriptMay 13 2019, 1:27 AM
Herald added a reviewer: • espindola. · View Herald Transcript
Herald added a reviewer: shafik. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, lldb-commits, jdoerfert and 14 others. · View Herald Transcript
Harbormaster completed remote builds in B31807: Diff 199211.May 13 2019, 1:29 AM
Herald added a subscriber: rnkovacs. · View Herald TranscriptMay 13 2019, 1:29 AM
teemperor added a reviewer: Restricted Project.May 13 2019, 1:53 AM
teemperor added a subscriber: teemperor.
teemperor added inline comments.
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
76

Can you revert the auto-formatting here?

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
114

Can you revert the auto-formatting here (and in the next option definition)?

lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
603–654

Could you also revert the unrelated whitespace changes here? Phabricator doesn't really display the whitespace changes well, but this patch effectively reformats this whole INIT_BOOL chain (The reformatting itself is fine, but it should be it's own commit).

martong resigned from this revision.May 13 2019, 2:15 AM
kwk added inline comments.May 13 2019, 2:22 AM
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
76

@teemperor I sure could or if you want I can sourround this section with // clang-format off and // clang-format on to prevent it from being ever formatted again.

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
114

@teemperor sure but same question: shall I use // clang-format off and // clang-format on here for the entire section?

lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
603–654

@teemperor sure.

teemperor added inline comments.May 13 2019, 2:30 AM
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
76

I wouldn't do it in this patch, but in general that sounds like a good idea to add this to all the g_properties sections. I'll probably replace most of these sections with some tablegen soon(TM), so be aware that that work might only be short-lived :)

kwk updated this revision to Diff 199253.May 13 2019, 5:14 AM
Harbormaster completed remote builds in B31819: Diff 199253.May 13 2019, 5:14 AM
kwk added a comment.May 13 2019, 5:21 AM

@teemperor I've addressed all of your comments. Can you please have another look?

kwk retitled this revision from [lldb] modernize codebase with modernize-use-nullptr to [lldb] NFC modernize codebase with modernize-use-nullptr.May 13 2019, 5:30 AM
kwk edited the summary of this revision. (Show Details)
JDevlieghere accepted this revision as: JDevlieghere.May 13 2019, 1:36 PM
JDevlieghere added a subscriber: JDevlieghere.

I had a quick glance over the changes and they all look correct. It appears that the spurious formatting changes have been addressed as well. Just to be sure I applied the patch locally and it built and passed the test suite.

So this LGTM.

This revision is now accepted and ready to land.May 13 2019, 1:36 PM
kwk added a comment.May 15 2019, 5:02 AM

@JDevlieghere can you please commit this in my name? I don't have commit access yet. I've filed an email an hope to get it soon.

kwk added a comment.May 22 2019, 7:11 AM

@JDevlieghere I have commit access now. I'm currently working on rebasing my changes and resolving conflicts in these files where my patch wasn't rebaseable.

lldb/source/Core/ValueObject.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
kwk updated this revision to Diff 200886.May 23 2019, 1:46 AM
  • Ran git clang-format HEAD^ and picked changes by hand using git add -p
  • Remove left-overs from unfinished rebase before
Herald added subscribers: hiraditya, nhaehnle, jvesely, arsenm. · View Herald TranscriptMay 23 2019, 1:46 AM
Harbormaster completed remote builds in B32361: Diff 200886.May 23 2019, 1:46 AM
kwk updated this revision to Diff 200916.May 23 2019, 3:07 AM

Unchanged commit

Harbormaster completed remote builds in B32368: Diff 200916.May 23 2019, 3:07 AM
kwk updated this revision to Diff 200918.May 23 2019, 3:25 AM

Rebased onto master

kwk updated this revision to Diff 200925.May 23 2019, 4:00 AM

Rebase onto master

Harbormaster completed remote builds in B32371: Diff 200925.May 23 2019, 4:03 AM
Closed by commit rLLDB361484: [lldb] NFC modernize codebase with modernize-use-nullptr (authored by kwk). · Explain WhyMay 23 2019, 4:15 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: abidh. · View Herald TranscriptMay 23 2019, 4:15 AM

Large Diff

This large diff affects 257 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
lldb/
include/
lldb/
Breakpoint/
2 lines
source/
API/
6 lines
12 lines
6 lines
19 lines
12 lines
10 lines
10 lines
2 lines
9 lines
6 lines
16 lines
5 lines
13 lines
8 lines
2 lines
20 lines
23 lines
28 lines
10 lines
4 lines
2 lines
4 lines
2 lines
10 lines
10 lines
18 lines
17 lines
4 lines
54 lines
22 lines
2 lines
4 lines
16 lines
4 lines
6 lines
4 lines
2 lines
8 lines
4 lines
4 lines
26 lines
4 lines
4 lines
Breakpoint/
2 lines
2 lines
4 lines
4 lines
Commands/
2 lines
Core/
2 lines
4 lines
2 lines
14 lines
10 lines
30 lines
67 lines
20 lines
2 lines
20 lines
8 lines
DataFormatters/
2 lines
12 lines
2 lines
8 lines
2 lines
18 lines
7 lines
Expression/
12 lines
2 lines
21 lines
8 lines
2 lines
2 lines
4 lines
6 lines
Host/
common/
16 lines
8 lines
8 lines
8 lines
6 lines
2 lines
6 lines
4 lines
2 lines
6 lines
2 lines
2 lines
linux/
8 lines
3 lines
posix/
2 lines
2 lines
Interpreter/
6 lines
6 lines
Plugins/
ABI/
SysV-arm/
6 lines
Disassembler/
llvm/
16 lines
DynamicLoader/
Darwin-Kernel/
42 lines
Hexagon-DYLD/
4 lines
MacOSX-DYLD/
29 lines
4 lines
14 lines
POSIX-DYLD/
6 lines
Static/
2 lines
ExpressionParser/
Clang/
2 lines
18 lines
12 lines
6 lines
55 lines
15 lines
39 lines
2 lines
8 lines
2 lines
4 lines
2 lines
2 lines
55 lines
Instruction/
ARM/
14 lines
14 lines
ARM64/
4 lines
MIPS/
10 lines
MIPS64/
10 lines
InstrumentationRuntime/
ASan/
2 lines
TSan/
2 lines
LanguageRuntime/
CPlusPlus/
ItaniumABI/
10 lines
ObjC/
AppleObjCRuntime/
27 lines
10 lines
4 lines
28 lines
5 lines
16 lines
4 lines
MemoryHistory/
asan/
2 lines
ObjectContainer/
BSD-Archive/
2 lines
10 lines
Universal-Mach-O/
2 lines
ObjectFile/
ELF/
32 lines
30 lines
JIT/
12 lines
Mach-O/
298 lines
PECOFF/
10 lines
OperatingSystem/
Python/
16 lines
Platform/
FreeBSD/
4 lines
Linux/
4 lines
MacOSX/
16 lines
4 lines
24 lines
NetBSD/
4 lines
POSIX/
22 lines
gdb-server/
23 lines
Process/
Linux/
10 lines
4 lines
POSIX/
2 lines
Utility/
20 lines
2 lines
6 lines
102 lines
4 lines
28 lines
38 lines
8 lines
2 lines
2 lines
8 lines
20 lines
6 lines
2 lines
4 lines
2 lines
6 lines
6 lines
2 lines
4 lines
4 lines
6 lines
6 lines
4 lines
2 lines
2 lines
2 lines
8 lines
12 lines
8 lines
elf-core/
10 lines
2 lines
gdb-remote/
4 lines
18 lines
10 lines
37 lines
93 lines
mach-core/
14 lines
minidump/
3 lines
ScriptInterpreter/
Python/
2 lines
SymbolFile/
DWARF/
70 lines
4 lines
2 lines
4 lines
4 lines
23 lines
34 lines
2 lines
2 lines
2 lines
4 lines
2 lines
6 lines
4 lines
11 lines
6 lines
10 lines
2 lines
125 lines
56 lines
4 lines
Symtab/
12 lines
SymbolVendor/
ELF/
12 lines
SystemRuntime/
MacOSX/
2 lines
4 lines
4 lines
2 lines
17 lines
UnwindAssembly/
InstEmulation/
2 lines
10 lines
x86/
2 lines
Symbol/
12 lines
12 lines
2 lines
4 lines
7 lines
2 lines
2 lines
2 lines
Target/
2 lines
6 lines
2 lines
2 lines
2 lines
tools/
lldb-mi/
4 lines
2 lines
2 lines
4 lines
2 lines
4 lines
2 lines
2 lines
lldb-server/
20 lines
18 lines
unittests/
Utility/
2 lines
tools/
lldb-server/
inferior/
2 lines
tests/
8 lines
llvm/
include/
llvm/
ADT/
2 lines
Demangle/
2 lines
lib/
Target/
AMDGPU/
AsmParser/
66 lines
test/
MC/
AMDGPU/
130 lines
31 lines
38 lines
tools/
llvm-exegesis/
lib/
40 lines
9 lines

Diff 200886

lldb/include/lldb/Breakpoint/BreakpointResolver.h

lldb/source/API/SBAddress.cpp

lldb/source/API/SBBlock.cpp

lldb/source/API/SBBreakpointLocation.cpp

lldb/source/API/SBBroadcaster.cpp

lldb/source/API/SBCommunication.cpp

lldb/source/API/SBCompileUnit.cpp

lldb/source/API/SBData.cpp

lldb/source/API/SBDeclaration.cpp

lldb/source/API/SBError.cpp

lldb/source/API/SBEvent.cpp

lldb/source/API/SBFunction.cpp

lldb/source/API/SBHostOS.cpp

lldb/source/API/SBInstruction.cpp

lldb/source/API/SBInstructionList.cpp

lldb/source/API/SBLineEntry.cpp

lldb/source/API/SBListener.cpp

lldb/source/API/SBModule.cpp

lldb/source/API/SBPlatform.cpp

lldb/source/API/SBProcess.cpp

lldb/source/API/SBQueue.cpp

lldb/source/API/SBQueueItem.cpp

lldb/source/API/SBSection.cpp

lldb/source/API/SBSourceManager.cpp

lldb/source/API/SBStream.cpp

lldb/source/API/SBStringList.cpp

lldb/source/API/SBSymbol.cpp

lldb/source/API/SBSymbolContext.cpp

lldb/source/API/SBSymbolContextList.cpp

lldb/source/API/SBTarget.cpp

lldb/source/API/SBThread.cpp

lldb/source/API/SBThreadCollection.cpp

lldb/source/API/SBThreadPlan.cpp

lldb/source/API/SBType.cpp

lldb/source/API/SBTypeCategory.cpp

lldb/source/API/SBTypeEnumMember.cpp

lldb/source/API/SBTypeFilter.cpp

lldb/source/API/SBTypeFormat.cpp

lldb/source/API/SBTypeNameSpecifier.cpp

lldb/source/API/SBTypeSummary.cpp

lldb/source/API/SBTypeSynthetic.cpp

lldb/source/API/SBValue.cpp

lldb/source/API/SBValueList.cpp

lldb/source/API/SBWatchpoint.cpp

lldb/source/Breakpoint/BreakpointResolverAddress.cpp

lldb/source/Breakpoint/BreakpointResolverFileLine.cpp

lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp

lldb/source/Breakpoint/BreakpointResolverScripted.cpp

lldb/source/Commands/CommandObjectExpression.h

lldb/source/Core/Communication.cpp

lldb/source/Core/Debugger.cpp

lldb/source/Core/Mangled.cpp

lldb/source/Core/Section.cpp

lldb/source/Core/SourceManager.cpp

lldb/source/Core/Value.cpp

lldb/source/Core/ValueObject.cpp

lldb/source/Core/ValueObjectConstResultImpl.cpp

lldb/source/Core/ValueObjectMemory.cpp

lldb/source/Core/ValueObjectRegister.cpp

lldb/source/Core/ValueObjectVariable.cpp

lldb/source/DataFormatters/DataVisualization.cpp

lldb/source/DataFormatters/FormatManager.cpp

lldb/source/DataFormatters/FormattersHelpers.cpp

lldb/source/DataFormatters/StringPrinter.cpp

lldb/source/DataFormatters/TypeFormat.cpp

lldb/source/DataFormatters/TypeSynthetic.cpp

lldb/source/DataFormatters/ValueObjectPrinter.cpp

lldb/source/Expression/DWARFExpression.cpp

lldb/source/Expression/ExpressionVariable.cpp

lldb/source/Expression/FunctionCaller.cpp

lldb/source/Expression/IRExecutionUnit.cpp

lldb/source/Expression/IRInterpreter.cpp

lldb/source/Expression/IRMemoryMap.cpp

lldb/source/Expression/LLVMUserExpression.cpp

lldb/source/Expression/UserExpression.cpp

lldb/source/Host/common/Editline.cpp

lldb/source/Host/common/File.cpp

lldb/source/Host/common/Host.cpp

lldb/source/Host/common/HostNativeThreadBase.cpp

lldb/source/Host/common/OptionParser.cpp

lldb/source/Host/common/ProcessRunLock.cpp

lldb/source/Host/common/SocketAddress.cpp

lldb/source/Host/common/TCPSocket.cpp

lldb/source/Host/common/TaskPool.cpp

lldb/source/Host/common/Terminal.cpp

lldb/source/Host/common/ThreadLauncher.cpp

lldb/source/Host/common/XML.cpp

lldb/source/Host/linux/Host.cpp

lldb/source/Host/linux/HostInfoLinux.cpp

lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp

lldb/source/Host/posix/HostThreadPosix.cpp

lldb/source/Interpreter/CommandInterpreter.cpp

lldb/source/Interpreter/OptionValue.cpp

lldb/source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp

lldb/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp

lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines "Do not read memory looking for a Darwin kernel when attaching."},
"(boot-args=debug) only."}, "(boot-args=debug) only."},
{eKASLRScanNearPC, "fast-scan", "Scan near the pc value on attach to find " {eKASLRScanNearPC, "fast-scan", "Scan near the pc value on attach to find "
"the Darwin kernel's load address."}, "the Darwin kernel's load address."},
{eKASLRScanExhaustiveScan, "exhaustive-scan", {eKASLRScanExhaustiveScan, "exhaustive-scan",
"Scan through the entire potential address range of Darwin kernel (only " "Scan through the entire potential address range of Darwin kernel (only "
"on 32-bit targets)."}}; "on 32-bit targets)."}};
static constexpr PropertyDefinition g_properties[] = { static constexpr PropertyDefinition g_properties[] = {
{"load-kexts", OptionValue::eTypeBoolean, true, true, NULL, {}, {"load-kexts", OptionValue::eTypeBoolean, true, true, nullptr, {},
teemperorUnsubmitted
Not Done
ReplyInline Actions

Can you revert the auto-formatting here?

teemperor: Can you revert the auto-formatting here?
kwkAuthorUnsubmitted
Not Done
ReplyInline Actions

@teemperor I sure could or if you want I can sourround this section with // clang-format off and // clang-format on to prevent it from being ever formatted again.

kwk: @teemperor I sure could or if you want I can sourround this section with ` // clang-format off`…
teemperorUnsubmitted
Not Done
ReplyInline Actions

I wouldn't do it in this patch, but in general that sounds like a good idea to add this to all the g_properties sections. I'll probably replace most of these sections with some tablegen soon(TM), so be aware that that work might only be short-lived :)

teemperor: I wouldn't do it in this patch, but in general that sounds like a good idea to add this to all…
"Automatically loads kext images when attaching to a kernel."}, "Automatically loads kext images when attaching to a kernel."},
{"scan-type", OptionValue::eTypeEnum, true, eKASLRScanNearPC, NULL, {"scan-type", OptionValue::eTypeEnum, true, eKASLRScanNearPC, nullptr,
OptionEnumValues(g_kaslr_kernel_scan_enum_values), OptionEnumValues(g_kaslr_kernel_scan_enum_values),
"Control how many reads lldb will make while searching for a Darwin " "Control how many reads lldb will make while searching for a Darwin "
"kernel on attach."}}; "kernel on attach."}};
enum { ePropertyLoadKexts, ePropertyScanType }; enum { ePropertyLoadKexts, ePropertyScanType };
class DynamicLoaderDarwinKernelProperties : public Properties { class DynamicLoaderDarwinKernelProperties : public Properties {
public: public:
static ConstString &GetSettingName() { static ConstString &GetSettingName() {
static ConstString g_setting_name("darwin-kernel"); static ConstString g_setting_name("darwin-kernel");
return g_setting_name; return g_setting_name;
} }
DynamicLoaderDarwinKernelProperties() : Properties() { DynamicLoaderDarwinKernelProperties() : Properties() {
m_collection_sp = std::make_shared<OptionValueProperties>(GetSettingName()); m_collection_sp = std::make_shared<OptionValueProperties>(GetSettingName());
m_collection_sp->Initialize(g_properties); m_collection_sp->Initialize(g_properties);
} }
~DynamicLoaderDarwinKernelProperties() override {} ~DynamicLoaderDarwinKernelProperties() override {}
bool GetLoadKexts() const { bool GetLoadKexts() const {
const uint32_t idx = ePropertyLoadKexts; const uint32_t idx = ePropertyLoadKexts;
return m_collection_sp->GetPropertyAtIndexAsBoolean( return m_collection_sp->GetPropertyAtIndexAsBoolean(
NULL, idx, g_properties[idx].default_uint_value != 0); nullptr, idx, g_properties[idx].default_uint_value != 0);
} }
KASLRScanType GetScanType() const { KASLRScanType GetScanType() const {
const uint32_t idx = ePropertyScanType; const uint32_t idx = ePropertyScanType;
return (KASLRScanType)m_collection_sp->GetPropertyAtIndexAsEnumeration( return (KASLRScanType)m_collection_sp->GetPropertyAtIndexAsEnumeration(
NULL, idx, g_properties[idx].default_uint_value); nullptr, idx, g_properties[idx].default_uint_value);
} }
}; };
typedef std::shared_ptr<DynamicLoaderDarwinKernelProperties> typedef std::shared_ptr<DynamicLoaderDarwinKernelProperties>
DynamicLoaderDarwinKernelPropertiesSP; DynamicLoaderDarwinKernelPropertiesSP;
static const DynamicLoaderDarwinKernelPropertiesSP &GetGlobalProperties() { static const DynamicLoaderDarwinKernelPropertiesSP &GetGlobalProperties() {
static DynamicLoaderDarwinKernelPropertiesSP g_settings_sp; static DynamicLoaderDarwinKernelPropertiesSP g_settings_sp;
Show All 10 LinesDynamicLoader *DynamicLoaderDarwinKernel::CreateInstance(Process *process,
if (!force) { if (!force) {
// If the user provided an executable binary and it is not a kernel, this // If the user provided an executable binary and it is not a kernel, this
// plugin should not create an instance. // plugin should not create an instance.
Module *exe_module = process->GetTarget().GetExecutableModulePointer(); Module *exe_module = process->GetTarget().GetExecutableModulePointer();
if (exe_module) { if (exe_module) {
ObjectFile *object_file = exe_module->GetObjectFile(); ObjectFile *object_file = exe_module->GetObjectFile();
if (object_file) { if (object_file) {
if (object_file->GetStrata() != ObjectFile::eStrataKernel) { if (object_file->GetStrata() != ObjectFile::eStrataKernel) {
return NULL; return nullptr;
} }
} }
} }
// If the target's architecture does not look like an Apple environment, // If the target's architecture does not look like an Apple environment,
// this plugin should not create an instance. // this plugin should not create an instance.
const llvm::Triple &triple_ref = const llvm::Triple &triple_ref =
process->GetTarget().GetArchitecture().GetTriple(); process->GetTarget().GetArchitecture().GetTriple();
switch (triple_ref.getOS()) { switch (triple_ref.getOS()) {
case llvm::Triple::Darwin: case llvm::Triple::Darwin:
case llvm::Triple::MacOSX: case llvm::Triple::MacOSX:
case llvm::Triple::IOS: case llvm::Triple::IOS:
case llvm::Triple::TvOS: case llvm::Triple::TvOS:
case llvm::Triple::WatchOS: case llvm::Triple::WatchOS:
// NEED_BRIDGEOS_TRIPLE case llvm::Triple::BridgeOS: // NEED_BRIDGEOS_TRIPLE case llvm::Triple::BridgeOS:
if (triple_ref.getVendor() != llvm::Triple::Apple) { if (triple_ref.getVendor() != llvm::Triple::Apple) {
return NULL; return nullptr;
} }
break; break;
// If we have triple like armv7-unknown-unknown, we should try looking for // If we have triple like armv7-unknown-unknown, we should try looking for
// a Darwin kernel. // a Darwin kernel.
case llvm::Triple::UnknownOS: case llvm::Triple::UnknownOS:
break; break;
default: default:
return NULL; return nullptr;
break; break;
} }
} }
// At this point if there is an ExecutableModule, it is a kernel and the // At this point if there is an ExecutableModule, it is a kernel and the
// Target is some variant of an Apple system. If the Process hasn't provided // Target is some variant of an Apple system. If the Process hasn't provided
// the kernel load address, we need to look around in memory to find it. // the kernel load address, we need to look around in memory to find it.
const addr_t kernel_load_address = SearchForDarwinKernel(process); const addr_t kernel_load_address = SearchForDarwinKernel(process);
if (CheckForKernelImageAtAddress(kernel_load_address, process).IsValid()) { if (CheckForKernelImageAtAddress(kernel_load_address, process).IsValid()) {
process->SetCanRunCode(false); process->SetCanRunCode(false);
return new DynamicLoaderDarwinKernel(process, kernel_load_address); return new DynamicLoaderDarwinKernel(process, kernel_load_address);
} }
return NULL; return nullptr;
} }
lldb::addr_t lldb::addr_t
DynamicLoaderDarwinKernel::SearchForDarwinKernel(Process *process) { DynamicLoaderDarwinKernel::SearchForDarwinKernel(Process *process) {
addr_t kernel_load_address = process->GetImageInfoAddress(); addr_t kernel_load_address = process->GetImageInfoAddress();
if (kernel_load_address == LLDB_INVALID_ADDRESS) { if (kernel_load_address == LLDB_INVALID_ADDRESS) {
kernel_load_address = SearchForKernelAtSameLoadAddr(process); kernel_load_address = SearchForKernelAtSameLoadAddr(process);
if (kernel_load_address == LLDB_INVALID_ADDRESS) { if (kernel_load_address == LLDB_INVALID_ADDRESS) {
Show All 10 Lines
} }
// Check if the kernel binary is loaded in memory without a slide. First verify // Check if the kernel binary is loaded in memory without a slide. First verify
// that the ExecutableModule is a kernel before we proceed. Returns the address // that the ExecutableModule is a kernel before we proceed. Returns the address
// of the kernel if one was found, else LLDB_INVALID_ADDRESS. // of the kernel if one was found, else LLDB_INVALID_ADDRESS.
lldb::addr_t lldb::addr_t
DynamicLoaderDarwinKernel::SearchForKernelAtSameLoadAddr(Process *process) { DynamicLoaderDarwinKernel::SearchForKernelAtSameLoadAddr(Process *process) {
Module *exe_module = process->GetTarget().GetExecutableModulePointer(); Module *exe_module = process->GetTarget().GetExecutableModulePointer();
if (exe_module == NULL) if (exe_module == nullptr)
return LLDB_INVALID_ADDRESS; return LLDB_INVALID_ADDRESS;
ObjectFile *exe_objfile = exe_module->GetObjectFile(); ObjectFile *exe_objfile = exe_module->GetObjectFile();
if (exe_objfile == NULL) if (exe_objfile == nullptr)
return LLDB_INVALID_ADDRESS; return LLDB_INVALID_ADDRESS;
if (exe_objfile->GetType() != ObjectFile::eTypeExecutable || if (exe_objfile->GetType() != ObjectFile::eTypeExecutable ||
exe_objfile->GetStrata() != ObjectFile::eStrataKernel) exe_objfile->GetStrata() != ObjectFile::eStrataKernel)
return LLDB_INVALID_ADDRESS; return LLDB_INVALID_ADDRESS;
if (!exe_objfile->GetBaseAddress().IsValid()) if (!exe_objfile->GetBaseAddress().IsValid())
return LLDB_INVALID_ADDRESS; return LLDB_INVALID_ADDRESS;
▲ Show 20 Lines • Show All 63 Lines • ▼ Show 20 Lines
lldb::addr_t lldb::addr_t
DynamicLoaderDarwinKernel::SearchForKernelNearPC(Process *process) { DynamicLoaderDarwinKernel::SearchForKernelNearPC(Process *process) {
if (GetGlobalProperties()->GetScanType() == eKASLRScanNone || if (GetGlobalProperties()->GetScanType() == eKASLRScanNone ||
GetGlobalProperties()->GetScanType() == eKASLRScanLowgloAddresses) { GetGlobalProperties()->GetScanType() == eKASLRScanLowgloAddresses) {
return LLDB_INVALID_ADDRESS; return LLDB_INVALID_ADDRESS;
} }
ThreadSP thread = process->GetThreadList().GetSelectedThread(); ThreadSP thread = process->GetThreadList().GetSelectedThread();
if (thread.get() == NULL) if (thread.get() == nullptr)
return LLDB_INVALID_ADDRESS; return LLDB_INVALID_ADDRESS;
addr_t pc = thread->GetRegisterContext()->GetPC(LLDB_INVALID_ADDRESS); addr_t pc = thread->GetRegisterContext()->GetPC(LLDB_INVALID_ADDRESS);
int ptrsize = process->GetTarget().GetArchitecture().GetAddressByteSize(); int ptrsize = process->GetTarget().GetArchitecture().GetAddressByteSize();
// The kernel is always loaded in high memory, if the top bit is zero, // The kernel is always loaded in high memory, if the top bit is zero,
// this isn't a kernel. // this isn't a kernel.
if (ptrsize == 8) { if (ptrsize == 8) {
▲ Show 20 Lines • Show All 155 Lines • ▼ Show 20 Lines if (header.filetype == llvm::MachO::MH_EXECUTE &&
(header.flags & llvm::MachO::MH_DYLDLINK) == 0) { (header.flags & llvm::MachO::MH_DYLDLINK) == 0) {
// Create a full module to get the UUID // Create a full module to get the UUID
ModuleSP memory_module_sp = ModuleSP memory_module_sp =
process->ReadModuleFromMemory(FileSpec("temp_mach_kernel"), addr); process->ReadModuleFromMemory(FileSpec("temp_mach_kernel"), addr);
if (!memory_module_sp.get()) if (!memory_module_sp.get())
return UUID(); return UUID();
ObjectFile *exe_objfile = memory_module_sp->GetObjectFile(); ObjectFile *exe_objfile = memory_module_sp->GetObjectFile();
if (exe_objfile == NULL) { if (exe_objfile == nullptr) {
if (log) if (log)
log->Printf("DynamicLoaderDarwinKernel::CheckForKernelImageAtAddress " log->Printf("DynamicLoaderDarwinKernel::CheckForKernelImageAtAddress "
"found a binary at 0x%" PRIx64 "found a binary at 0x%" PRIx64
" but could not create an object file from memory", " but could not create an object file from memory",
addr); addr);
return UUID(); return UUID();
} }
▲ Show 20 Lines • Show All 70 Lines • ▼ Show 20 Lines
// Clear out the state of this class. // Clear out the state of this class.
void DynamicLoaderDarwinKernel::Clear(bool clear_process) { void DynamicLoaderDarwinKernel::Clear(bool clear_process) {
std::lock_guard<std::recursive_mutex> guard(m_mutex); std::lock_guard<std::recursive_mutex> guard(m_mutex);
if (m_process->IsAlive() && LLDB_BREAK_ID_IS_VALID(m_break_id)) if (m_process->IsAlive() && LLDB_BREAK_ID_IS_VALID(m_break_id))
m_process->ClearBreakpointSiteByID(m_break_id); m_process->ClearBreakpointSiteByID(m_break_id);
if (clear_process) if (clear_process)
m_process = NULL; m_process = nullptr;
m_kernel.Clear(); m_kernel.Clear();
m_known_kexts.clear(); m_known_kexts.clear();
m_kext_summary_header_ptr_addr.Clear(); m_kext_summary_header_ptr_addr.Clear();
m_kext_summary_header_addr.Clear(); m_kext_summary_header_addr.Clear();
m_break_id = LLDB_INVALID_BREAK_ID; m_break_id = LLDB_INVALID_BREAK_ID;
} }
bool DynamicLoaderDarwinKernel::KextImageInfo::LoadImageAtFileAddress( bool DynamicLoaderDarwinKernel::KextImageInfo::LoadImageAtFileAddress(
▲ Show 20 Lines • Show All 80 Lines • ▼ Show 20 Lines
// an in-memory Module at that address. Require that the MemoryModule have a // an in-memory Module at that address. Require that the MemoryModule have a
// matching UUID and detect if this MemoryModule is a kernel or a kext. // matching UUID and detect if this MemoryModule is a kernel or a kext.
// //
// Returns true if m_memory_module_sp is now set to a valid Module. // Returns true if m_memory_module_sp is now set to a valid Module.
bool DynamicLoaderDarwinKernel::KextImageInfo::ReadMemoryModule( bool DynamicLoaderDarwinKernel::KextImageInfo::ReadMemoryModule(
Process *process) { Process *process) {
Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST); Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST);
if (m_memory_module_sp.get() != NULL) if (m_memory_module_sp.get() != nullptr)
return true; return true;
if (m_load_address == LLDB_INVALID_ADDRESS) if (m_load_address == LLDB_INVALID_ADDRESS)
return false; return false;
FileSpec file_spec(m_name.c_str()); FileSpec file_spec(m_name.c_str());
llvm::MachO::mach_header mh; llvm::MachO::mach_header mh;
size_t size_to_read = 512; size_t size_to_read = 512;
if (ReadMachHeader(m_load_address, process, mh)) { if (ReadMachHeader(m_load_address, process, mh)) {
if (mh.magic == llvm::MachO::MH_CIGAM || mh.magic == llvm::MachO::MH_MAGIC) if (mh.magic == llvm::MachO::MH_CIGAM || mh.magic == llvm::MachO::MH_MAGIC)
size_to_read = sizeof(llvm::MachO::mach_header) + mh.sizeofcmds; size_to_read = sizeof(llvm::MachO::mach_header) + mh.sizeofcmds;
if (mh.magic == llvm::MachO::MH_CIGAM_64 || if (mh.magic == llvm::MachO::MH_CIGAM_64 ||
mh.magic == llvm::MachO::MH_MAGIC_64) mh.magic == llvm::MachO::MH_MAGIC_64)
size_to_read = sizeof(llvm::MachO::mach_header_64) + mh.sizeofcmds; size_to_read = sizeof(llvm::MachO::mach_header_64) + mh.sizeofcmds;
} }
ModuleSP memory_module_sp = ModuleSP memory_module_sp =
process->ReadModuleFromMemory(file_spec, m_load_address, size_to_read); process->ReadModuleFromMemory(file_spec, m_load_address, size_to_read);
if (memory_module_sp.get() == NULL) if (memory_module_sp.get() == nullptr)
return false; return false;
bool is_kernel = false; bool is_kernel = false;
if (memory_module_sp->GetObjectFile()) { if (memory_module_sp->GetObjectFile()) {
if (memory_module_sp->GetObjectFile()->GetType() == if (memory_module_sp->GetObjectFile()->GetType() ==
ObjectFile::eTypeExecutable && ObjectFile::eTypeExecutable &&
memory_module_sp->GetObjectFile()->GetStrata() == memory_module_sp->GetObjectFile()->GetStrata() ==
ObjectFile::eStrataKernel) { ObjectFile::eStrataKernel) {
▲ Show 20 Lines • Show All 131 Lines • ▼ Show 20 Lines if (!m_module_sp && m_uuid.IsValid()) {
ConstString platform_name(platform_sp->GetPluginName()); ConstString platform_name(platform_sp->GetPluginName());
static ConstString g_platform_name( static ConstString g_platform_name(
PlatformDarwinKernel::GetPluginNameStatic()); PlatformDarwinKernel::GetPluginNameStatic());
if (platform_name == g_platform_name) { if (platform_name == g_platform_name) {
ModuleSpec kext_bundle_module_spec(module_spec); ModuleSpec kext_bundle_module_spec(module_spec);
FileSpec kext_filespec(m_name.c_str()); FileSpec kext_filespec(m_name.c_str());
FileSpecList search_paths = target.GetExecutableSearchPaths(); FileSpecList search_paths = target.GetExecutableSearchPaths();
kext_bundle_module_spec.GetFileSpec() = kext_filespec; kext_bundle_module_spec.GetFileSpec() = kext_filespec;
platform_sp->GetSharedModule( platform_sp->GetSharedModule(kext_bundle_module_spec, process,
kext_bundle_module_spec, process, m_module_sp, m_module_sp, &search_paths, nullptr,
&search_paths, NULL, NULL); nullptr);
} }
} }
// Ask the Target to find this file on the local system, if possible. // Ask the Target to find this file on the local system, if possible.
// This will search in the list of currently-loaded files, look in the // This will search in the list of currently-loaded files, look in the
// standard search paths on the system, and on a Mac it will try calling // standard search paths on the system, and on a Mac it will try calling
// the DebugSymbols framework with the UUID to find the binary via its // the DebugSymbols framework with the UUID to find the binary via its
// search methods. // search methods.
▲ Show 20 Lines • Show All 553 Lines • ▼ Show 20 Lines if (bytes_read == count) {
for (uint32_t kext_summary_offset = 0; for (uint32_t kext_summary_offset = 0;
i < image_infos.size() && i < image_infos.size() &&
extractor.ValidOffsetForDataOfSize(kext_summary_offset, extractor.ValidOffsetForDataOfSize(kext_summary_offset,
m_kext_summary_header.entry_size); m_kext_summary_header.entry_size);
++i, kext_summary_offset += m_kext_summary_header.entry_size) { ++i, kext_summary_offset += m_kext_summary_header.entry_size) {
lldb::offset_t offset = kext_summary_offset; lldb::offset_t offset = kext_summary_offset;
const void *name_data = const void *name_data =
extractor.GetData(&offset, KERNEL_MODULE_MAX_NAME); extractor.GetData(&offset, KERNEL_MODULE_MAX_NAME);
if (name_data == NULL) if (name_data == nullptr)
break; break;
image_infos[i].SetName((const char *)name_data); image_infos[i].SetName((const char *)name_data);
UUID uuid = UUID::fromOptionalData(extractor.GetData(&offset, 16), 16); UUID uuid = UUID::fromOptionalData(extractor.GetData(&offset, 16), 16);
image_infos[i].SetUUID(uuid); image_infos[i].SetUUID(uuid);
image_infos[i].SetLoadAddress(extractor.GetU64(&offset)); image_infos[i].SetLoadAddress(extractor.GetU64(&offset));
image_infos[i].SetSize(extractor.GetU64(&offset)); image_infos[i].SetSize(extractor.GetU64(&offset));
} }
if (i < image_infos.size()) if (i < image_infos.size())
Show All 31 Lines if (m_load_address == LLDB_INVALID_ADDRESS) {
LLDB_LOG(log, "addr={0:x+16} size={1:x+16} uuid={2} name=\"{3}\"", LLDB_LOG(log, "addr={0:x+16} size={1:x+16} uuid={2} name=\"{3}\"",
m_load_address, m_size, m_uuid.GetAsString(), m_name); m_load_address, m_size, m_uuid.GetAsString(), m_name);
} }
} }
// Dump the _dyld_all_image_infos members and all current image infos that we // Dump the _dyld_all_image_infos members and all current image infos that we
// have parsed to the file handle provided. // have parsed to the file handle provided.
void DynamicLoaderDarwinKernel::PutToLog(Log *log) const { void DynamicLoaderDarwinKernel::PutToLog(Log *log) const {
if (log == NULL) if (log == nullptr)
return; return;
std::lock_guard<std::recursive_mutex> guard(m_mutex); std::lock_guard<std::recursive_mutex> guard(m_mutex);
log->Printf("gLoadedKextSummaries = 0x%16.16" PRIx64 log->Printf("gLoadedKextSummaries = 0x%16.16" PRIx64
" { version=%u, entry_size=%u, entry_count=%u }", " { version=%u, entry_size=%u, entry_count=%u }",
m_kext_summary_header_addr.GetFileAddress(), m_kext_summary_header_addr.GetFileAddress(),
m_kext_summary_header.version, m_kext_summary_header.entry_size, m_kext_summary_header.version, m_kext_summary_header.entry_size,
m_kext_summary_header.entry_count); m_kext_summary_header.entry_count);
Show All 21 Lines if (m_break_id == LLDB_INVALID_BREAK_ID && m_kernel.GetModule()) {
const bool internal_bp = true; const bool internal_bp = true;
const bool hardware = false; const bool hardware = false;
const LazyBool skip_prologue = eLazyBoolNo; const LazyBool skip_prologue = eLazyBoolNo;
FileSpecList module_spec_list; FileSpecList module_spec_list;
module_spec_list.Append(m_kernel.GetModule()->GetFileSpec()); module_spec_list.Append(m_kernel.GetModule()->GetFileSpec());
Breakpoint *bp = Breakpoint *bp =
m_process->GetTarget() m_process->GetTarget()
.CreateBreakpoint(&module_spec_list, NULL, .CreateBreakpoint(&module_spec_list, nullptr,
"OSKextLoadedKextSummariesUpdated", "OSKextLoadedKextSummariesUpdated",
eFunctionNameTypeFull, eLanguageTypeUnknown, 0, eFunctionNameTypeFull, eLanguageTypeUnknown, 0,
skip_prologue, internal_bp, hardware) skip_prologue, internal_bp, hardware)
.get(); .get();
bp->SetCallback(DynamicLoaderDarwinKernel::BreakpointHitCallback, this, bp->SetCallback(DynamicLoaderDarwinKernel::BreakpointHitCallback, this,
true); true);
m_break_id = bp->GetID(); m_break_id = bp->GetID();
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines

lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp

lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp

lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

lldb/source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.cpp

lldb/source/Plugins/ExpressionParser/Clang/ASTDumper.cpp

lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp

lldb/source/Plugins/ExpressionParser/Clang/ASTStructExtractor.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.h

lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionVariable.h

lldb/source/Plugins/ExpressionParser/Clang/ClangFunctionCaller.h

lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp

lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp

lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp

lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp

lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp

lldb/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp

lldb/source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.cpp

lldb/source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.cpp

lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCDeclVendor.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.h

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp

lldb/source/Plugins/MemoryHistory/asan/MemoryHistoryASan.cpp

lldb/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.h

lldb/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp

lldb/source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp

lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

lldb/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp

lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp

lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp

lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp

lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp

lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp

lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp

lldb/source/Plugins/Process/Linux/ProcessorTrace.cpp

lldb/source/Plugins/Process/POSIX/ProcessMessage.cpp

lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp

lldb/source/Plugins/Process/Utility/HistoryThread.cpp

lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDarwin_i386.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDarwin_x86_64.cpp

lldb/source/Plugins/Process/Utility/RegisterContextDummy.cpp

lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_i386.cpp

lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_powerpc.cpp

lldb/source/Plugins/Process/Utility/RegisterContextHistory.cpp

lldb/source/Plugins/Process/Utility/RegisterContextLLDB.cpp

lldb/source/Plugins/Process/Utility/RegisterContextLinux_i386.cpp

lldb/source/Plugins/Process/Utility/RegisterContextLinux_mips.cpp

lldb/source/Plugins/Process/Utility/RegisterContextLinux_x86_64.cpp

lldb/source/Plugins/Process/Utility/RegisterContextOpenBSD_i386.cpp

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm.cpp

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.cpp

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_s390x.cpp

lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp

lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.cpp

lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm.cpp

lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.cpp

lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_ppc64le.cpp

lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp

lldb/source/Plugins/Process/Utility/UnwindLLDB.cpp

lldb/source/Plugins/Process/Utility/UnwindMacOSXFrameBackchain.cpp

lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Show First 20 Lines • Show All 105 Lines • ▼ Show 20 Linesvoid DumpProcessGDBRemotePacketHistory(void *p, const char *path) {
if (error.Success()) if (error.Success())
((ProcessGDBRemote *)p)->GetGDBRemote().DumpHistory(strm); ((ProcessGDBRemote *)p)->GetGDBRemote().DumpHistory(strm);
} }
} // namespace lldb } // namespace lldb
namespace { namespace {
static constexpr PropertyDefinition g_properties[] = { static constexpr PropertyDefinition g_properties[] = {
{"packet-timeout", OptionValue::eTypeUInt64, true, 5 {"packet-timeout", OptionValue::eTypeUInt64, true, 5
teemperorUnsubmitted
Not Done
ReplyInline Actions

Can you revert the auto-formatting here (and in the next option definition)?

teemperor: Can you revert the auto-formatting here (and in the next option definition)?
kwkAuthorUnsubmitted
Not Done
ReplyInline Actions

@teemperor sure but same question: shall I use // clang-format off and // clang-format on here for the entire section?

kwk: @teemperor sure but same question: shall I use ` // clang-format off` and ` // clang-format on`…
#if defined(__has_feature) #if defined(__has_feature)
#if __has_feature(address_sanitizer) #if __has_feature(address_sanitizer)
* 2 * 2
#endif #endif
#endif #endif
, NULL, {}, , nullptr, {},
"Specify the default packet timeout in seconds."}, "Specify the default packet timeout in seconds."},
{"target-definition-file", OptionValue::eTypeFileSpec, true, 0, NULL, {}, {"target-definition-file", OptionValue::eTypeFileSpec, true, 0, nullptr, {},
"The file that provides the description for remote target registers."}}; "The file that provides the description for remote target registers."}};
enum { ePropertyPacketTimeout, ePropertyTargetDefinitionFile }; enum { ePropertyPacketTimeout, ePropertyTargetDefinitionFile };
class PluginProperties : public Properties { class PluginProperties : public Properties {
public: public:
static ConstString GetSettingName() { static ConstString GetSettingName() {
return ProcessGDBRemote::GetPluginNameStatic(); return ProcessGDBRemote::GetPluginNameStatic();
} }
PluginProperties() : Properties() { PluginProperties() : Properties() {
m_collection_sp = std::make_shared<OptionValueProperties>(GetSettingName()); m_collection_sp = std::make_shared<OptionValueProperties>(GetSettingName());
m_collection_sp->Initialize(g_properties); m_collection_sp->Initialize(g_properties);
} }
~PluginProperties() override {} ~PluginProperties() override {}
uint64_t GetPacketTimeout() { uint64_t GetPacketTimeout() {
const uint32_t idx = ePropertyPacketTimeout; const uint32_t idx = ePropertyPacketTimeout;
return m_collection_sp->GetPropertyAtIndexAsUInt64( return m_collection_sp->GetPropertyAtIndexAsUInt64(
NULL, idx, g_properties[idx].default_uint_value); nullptr, idx, g_properties[idx].default_uint_value);
} }
bool SetPacketTimeout(uint64_t timeout) { bool SetPacketTimeout(uint64_t timeout) {
const uint32_t idx = ePropertyPacketTimeout; const uint32_t idx = ePropertyPacketTimeout;
return m_collection_sp->SetPropertyAtIndexAsUInt64(NULL, idx, timeout); return m_collection_sp->SetPropertyAtIndexAsUInt64(nullptr, idx, timeout);
} }
FileSpec GetTargetDefinitionFile() const { FileSpec GetTargetDefinitionFile() const {
const uint32_t idx = ePropertyTargetDefinitionFile; const uint32_t idx = ePropertyTargetDefinitionFile;
return m_collection_sp->GetPropertyAtIndexAsFileSpec(NULL, idx); return m_collection_sp->GetPropertyAtIndexAsFileSpec(nullptr, idx);
} }
}; };
typedef std::shared_ptr<PluginProperties> ProcessKDPPropertiesSP; typedef std::shared_ptr<PluginProperties> ProcessKDPPropertiesSP;
static const ProcessKDPPropertiesSP &GetGlobalPluginProperties() { static const ProcessKDPPropertiesSP &GetGlobalPluginProperties() {
static ProcessKDPPropertiesSP g_settings_sp; static ProcessKDPPropertiesSP g_settings_sp;
if (!g_settings_sp) if (!g_settings_sp)
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Linesvoid ProcessGDBRemote::Terminate() {
PluginManager::UnregisterPlugin(ProcessGDBRemote::CreateInstance); PluginManager::UnregisterPlugin(ProcessGDBRemote::CreateInstance);
} }
lldb::ProcessSP lldb::ProcessSP
ProcessGDBRemote::CreateInstance(lldb::TargetSP target_sp, ProcessGDBRemote::CreateInstance(lldb::TargetSP target_sp,
ListenerSP listener_sp, ListenerSP listener_sp,
const FileSpec *crash_file_path) { const FileSpec *crash_file_path) {
lldb::ProcessSP process_sp; lldb::ProcessSP process_sp;
if (crash_file_path == NULL) if (crash_file_path == nullptr)
process_sp = std::make_shared<ProcessGDBRemote>(target_sp, listener_sp); process_sp = std::make_shared<ProcessGDBRemote>(target_sp, listener_sp);
return process_sp; return process_sp;
} }
bool ProcessGDBRemote::CanDebug(lldb::TargetSP target_sp, bool ProcessGDBRemote::CanDebug(lldb::TargetSP target_sp,
bool plugin_specified_by_name) { bool plugin_specified_by_name) {
if (plugin_specified_by_name) if (plugin_specified_by_name)
return true; return true;
Show All 25 Lines
} }
// ProcessGDBRemote constructor // ProcessGDBRemote constructor
ProcessGDBRemote::ProcessGDBRemote(lldb::TargetSP target_sp, ProcessGDBRemote::ProcessGDBRemote(lldb::TargetSP target_sp,
ListenerSP listener_sp) ListenerSP listener_sp)
: Process(target_sp, listener_sp), : Process(target_sp, listener_sp),
m_debugserver_pid(LLDB_INVALID_PROCESS_ID), m_last_stop_packet_mutex(), m_debugserver_pid(LLDB_INVALID_PROCESS_ID), m_last_stop_packet_mutex(),
m_register_info(), m_register_info(),
m_async_broadcaster(NULL, "lldb.process.gdb-remote.async-broadcaster"), m_async_broadcaster(nullptr, "lldb.process.gdb-remote.async-broadcaster"),
m_async_listener_sp( m_async_listener_sp(
Listener::MakeListener("lldb.process.gdb-remote.async-listener")), Listener::MakeListener("lldb.process.gdb-remote.async-listener")),
m_async_thread_state_mutex(), m_thread_ids(), m_thread_pcs(), m_async_thread_state_mutex(), m_thread_ids(), m_thread_pcs(),
m_jstopinfo_sp(), m_jthreadsinfo_sp(), m_continue_c_tids(), m_jstopinfo_sp(), m_jthreadsinfo_sp(), m_continue_c_tids(),
m_continue_C_tids(), m_continue_s_tids(), m_continue_S_tids(), m_continue_C_tids(), m_continue_s_tids(), m_continue_S_tids(),
m_max_memory_size(0), m_remote_stub_max_memory_size(0), m_max_memory_size(0), m_remote_stub_max_memory_size(0),
m_addr_to_mmap_size(), m_thread_create_bp_sp(), m_addr_to_mmap_size(), m_thread_create_bp_sp(),
m_waiting_for_attach(false), m_destroy_tried_resuming(false), m_waiting_for_attach(false), m_destroy_tried_resuming(false),
▲ Show 20 Lines • Show All 236 Lines • ▼ Show 20 Lines if (m_gdb_comm.SendPacketAndWaitForResponse(packet, response, false) ==
llvm::StringRef value; llvm::StringRef value;
ConstString reg_name; ConstString reg_name;
ConstString alt_name; ConstString alt_name;
ConstString set_name; ConstString set_name;
std::vector<uint32_t> value_regs; std::vector<uint32_t> value_regs;
std::vector<uint32_t> invalidate_regs; std::vector<uint32_t> invalidate_regs;
std::vector<uint8_t> dwarf_opcode_bytes; std::vector<uint8_t> dwarf_opcode_bytes;
RegisterInfo reg_info = { RegisterInfo reg_info = {
NULL, // Name nullptr, // Name
NULL, // Alt name nullptr, // Alt name
0, // byte size 0, // byte size
reg_offset, // offset reg_offset, // offset
eEncodingUint, // encoding eEncodingUint, // encoding
eFormatHex, // format eFormatHex, // format
{ {
LLDB_INVALID_REGNUM, // eh_frame reg num LLDB_INVALID_REGNUM, // eh_frame reg num
LLDB_INVALID_REGNUM, // DWARF reg num LLDB_INVALID_REGNUM, // DWARF reg num
LLDB_INVALID_REGNUM, // generic reg num LLDB_INVALID_REGNUM, // generic reg num
reg_num, // process plugin reg num reg_num, // process plugin reg num
reg_num // native register number reg_num // native register number
}, },
NULL, nullptr,
NULL, nullptr,
NULL, // Dwarf expression opcode bytes pointer nullptr, // Dwarf expression opcode bytes pointer
0 // Dwarf expression opcode bytes length 0 // Dwarf expression opcode bytes length
}; };
while (response.GetNameColonValue(name, value)) { while (response.GetNameColonValue(name, value)) {
if (name.equals("name")) { if (name.equals("name")) {
reg_name.SetString(value); reg_name.SetString(value);
} else if (name.equals("alt-name")) { } else if (name.equals("alt-name")) {
alt_name.SetString(value); alt_name.SetString(value);
} else if (name.equals("bitsize")) { } else if (name.equals("bitsize")) {
value.getAsInteger(0, reg_info.byte_size); value.getAsInteger(0, reg_info.byte_size);
reg_info.byte_size /= CHAR_BIT; reg_info.byte_size /= CHAR_BIT;
} else if (name.equals("offset")) { } else if (name.equals("offset")) {
if (value.getAsInteger(0, reg_offset)) if (value.getAsInteger(0, reg_offset))
reg_offset = UINT32_MAX; reg_offset = UINT32_MAX;
} else if (name.equals("encoding")) { } else if (name.equals("encoding")) {
const Encoding encoding = Args::StringToEncoding(value); const Encoding encoding = Args::StringToEncoding(value);
if (encoding != eEncodingInvalid) if (encoding != eEncodingInvalid)
reg_info.encoding = encoding; reg_info.encoding = encoding;
} else if (name.equals("format")) { } else if (name.equals("format")) {
Format format = eFormatInvalid; Format format = eFormatInvalid;
if (OptionArgParser::ToFormat(value.str().c_str(), format, NULL) if (OptionArgParser::ToFormat(value.str().c_str(), format, nullptr)
.Success()) .Success())
reg_info.format = format; reg_info.format = format;
else { else {
reg_info.format = reg_info.format =
llvm::StringSwitch<Format>(value) llvm::StringSwitch<Format>(value)
.Case("binary", eFormatBinary) .Case("binary", eFormatBinary)
.Case("decimal", eFormatDecimal) .Case("decimal", eFormatDecimal)
.Case("hex", eFormatHex) .Case("hex", eFormatHex)
▲ Show 20 Lines • Show All 288 Lines • ▼ Show 20 Lines if (error.Success()) {
stderr_file_spec.SetFile(FileSystem::DEV_NULL, stderr_file_spec.SetFile(FileSystem::DEV_NULL,
FileSpec::Style::native); FileSpec::Style::native);
} else if (platform_sp && platform_sp->IsHost()) { } else if (platform_sp && platform_sp->IsHost()) {
// If the debugserver is local and we aren't disabling STDIO, lets use // If the debugserver is local and we aren't disabling STDIO, lets use
// a pseudo terminal to instead of relying on the 'O' packets for stdio // a pseudo terminal to instead of relying on the 'O' packets for stdio
// since 'O' packets can really slow down debugging if the inferior // since 'O' packets can really slow down debugging if the inferior
// does a lot of output. // does a lot of output.
if ((!stdin_file_spec || !stdout_file_spec || !stderr_file_spec) && if ((!stdin_file_spec || !stdout_file_spec || !stderr_file_spec) &&
pty.OpenFirstAvailableMaster(O_RDWR | O_NOCTTY, NULL, 0)) { pty.OpenFirstAvailableMaster(O_RDWR | O_NOCTTY, nullptr, 0)) {
FileSpec slave_name{pty.GetSlaveName(NULL, 0)}; FileSpec slave_name{pty.GetSlaveName(nullptr, 0)};
if (!stdin_file_spec) if (!stdin_file_spec)
stdin_file_spec = slave_name; stdin_file_spec = slave_name;
if (!stdout_file_spec) if (!stdout_file_spec)
stdout_file_spec = slave_name; stdout_file_spec = slave_name;
if (!stderr_file_spec) if (!stderr_file_spec)
Show All 27 Lines if (error.Success()) {
m_gdb_comm.SetDisableASLR(launch_flags & eLaunchFlagDisableASLR); m_gdb_comm.SetDisableASLR(launch_flags & eLaunchFlagDisableASLR);
m_gdb_comm.SetDetachOnError(launch_flags & eLaunchFlagDetachOnError); m_gdb_comm.SetDetachOnError(launch_flags & eLaunchFlagDetachOnError);
m_gdb_comm.SendLaunchArchPacket( m_gdb_comm.SendLaunchArchPacket(
GetTarget().GetArchitecture().GetArchitectureName()); GetTarget().GetArchitecture().GetArchitectureName());
const char *launch_event_data = launch_info.GetLaunchEventData(); const char *launch_event_data = launch_info.GetLaunchEventData();
if (launch_event_data != NULL && *launch_event_data != '\0') if (launch_event_data != nullptr && *launch_event_data != '\0')
m_gdb_comm.SendLaunchEventDataPacket(launch_event_data); m_gdb_comm.SendLaunchEventDataPacket(launch_event_data);
if (working_dir) { if (working_dir) {
m_gdb_comm.SetWorkingDir(working_dir); m_gdb_comm.SetWorkingDir(working_dir);
} }
// Send the environment and the program + arguments after we connect // Send the environment and the program + arguments after we connect
m_gdb_comm.SendEnvironment(launch_info.GetEnvironment()); m_gdb_comm.SendEnvironment(launch_info.GetEnvironment());
▲ Show 20 Lines • Show All 897 Lines • ▼ Show 20 Lines if (thread_sp) {
StringExtractor reg_value_extractor; StringExtractor reg_value_extractor;
reg_value_extractor.GetStringRef() = pair.second; reg_value_extractor.GetStringRef() = pair.second;
DataBufferSP buffer_sp(new DataBufferHeap( DataBufferSP buffer_sp(new DataBufferHeap(
reg_value_extractor.GetStringRef().size() / 2, 0)); reg_value_extractor.GetStringRef().size() / 2, 0));
reg_value_extractor.GetHexBytes(buffer_sp->GetData(), '\xcc'); reg_value_extractor.GetHexBytes(buffer_sp->GetData(), '\xcc');
gdb_thread->PrivateSetRegisterValue(pair.first, buffer_sp->GetData()); gdb_thread->PrivateSetRegisterValue(pair.first, buffer_sp->GetData());
} }
thread_sp->SetName(thread_name.empty() ? NULL : thread_name.c_str()); thread_sp->SetName(thread_name.empty() ? nullptr : thread_name.c_str());
gdb_thread->SetThreadDispatchQAddr(thread_dispatch_qaddr); gdb_thread->SetThreadDispatchQAddr(thread_dispatch_qaddr);
// Check if the GDB server was able to provide the queue name, kind and // Check if the GDB server was able to provide the queue name, kind and
// serial number // serial number
if (queue_vars_valid) if (queue_vars_valid)
gdb_thread->SetQueueInfo(std::move(queue_name), queue_kind, gdb_thread->SetQueueInfo(std::move(queue_name), queue_kind,
queue_serial, dispatch_queue_t, queue_serial, dispatch_queue_t,
associated_with_dispatch_queue); associated_with_dispatch_queue);
▲ Show 20 Lines • Show All 1,262 Lines • ▼ Show 20 LinesStatus ProcessGDBRemote::DoDeallocateMemory(lldb::addr_t addr) {
return error; return error;
} }
// Process STDIO // Process STDIO
size_t ProcessGDBRemote::PutSTDIN(const char *src, size_t src_len, size_t ProcessGDBRemote::PutSTDIN(const char *src, size_t src_len,
Status &error) { Status &error) {
if (m_stdio_communication.IsConnected()) { if (m_stdio_communication.IsConnected()) {
ConnectionStatus status; ConnectionStatus status;
m_stdio_communication.Write(src, src_len, status, NULL); m_stdio_communication.Write(src, src_len, status, nullptr);
} else if (m_stdin_forward) { } else if (m_stdin_forward) {
m_gdb_comm.SendStdinNotification(src, src_len); m_gdb_comm.SendStdinNotification(src, src_len);
} }
return 0; return 0;
} }
Status ProcessGDBRemote::EnableBreakpointSite(BreakpointSite *bp_site) { Status ProcessGDBRemote::EnableBreakpointSite(BreakpointSite *bp_site) {
Status error; Status error;
assert(bp_site != NULL); assert(bp_site != nullptr);
// Get logging info // Get logging info
Log *log(ProcessGDBRemoteLog::GetLogIfAllCategoriesSet(GDBR_LOG_BREAKPOINTS)); Log *log(ProcessGDBRemoteLog::GetLogIfAllCategoriesSet(GDBR_LOG_BREAKPOINTS));
user_id_t site_id = bp_site->GetID(); user_id_t site_id = bp_site->GetID();
// Get the breakpoint address // Get the breakpoint address
const addr_t addr = bp_site->GetLoadAddress(); const addr_t addr = bp_site->GetLoadAddress();
▲ Show 20 Lines • Show All 109 Lines • ▼ Show 20 LinesStatus ProcessGDBRemote::EnableBreakpointSite(BreakpointSite *bp_site) {
// As a last resort we want to place a manual breakpoint. An instruction is // As a last resort we want to place a manual breakpoint. An instruction is
// placed into the process memory using memory write packets. // placed into the process memory using memory write packets.
return EnableSoftwareBreakpoint(bp_site); return EnableSoftwareBreakpoint(bp_site);
} }
Status ProcessGDBRemote::DisableBreakpointSite(BreakpointSite *bp_site) { Status ProcessGDBRemote::DisableBreakpointSite(BreakpointSite *bp_site) {
Status error; Status error;
assert(bp_site != NULL); assert(bp_site != nullptr);
addr_t addr = bp_site->GetLoadAddress(); addr_t addr = bp_site->GetLoadAddress();
user_id_t site_id = bp_site->GetID(); user_id_t site_id = bp_site->GetID();
Log *log(ProcessGDBRemoteLog::GetLogIfAllCategoriesSet(GDBR_LOG_BREAKPOINTS)); Log *log(ProcessGDBRemoteLog::GetLogIfAllCategoriesSet(GDBR_LOG_BREAKPOINTS));
if (log) if (log)
log->Printf("ProcessGDBRemote::DisableBreakpointSite (site_id = %" PRIu64 log->Printf("ProcessGDBRemote::DisableBreakpointSite (site_id = %" PRIu64
") addr = 0x%8.8" PRIx64, ") addr = 0x%8.8" PRIx64,
site_id, (uint64_t)addr); site_id, (uint64_t)addr);
▲ Show 20 Lines • Show All 394 Lines • ▼ Show 20 Linesbool ProcessGDBRemote::StartAsyncThread() {
if (log) if (log)
log->Printf("ProcessGDBRemote::%s ()", __FUNCTION__); log->Printf("ProcessGDBRemote::%s ()", __FUNCTION__);
std::lock_guard<std::recursive_mutex> guard(m_async_thread_state_mutex); std::lock_guard<std::recursive_mutex> guard(m_async_thread_state_mutex);
if (!m_async_thread.IsJoinable()) { if (!m_async_thread.IsJoinable()) {
// Create a thread that watches our internal state and controls which // Create a thread that watches our internal state and controls which
// events make it to clients (into the DCProcess event queue). // events make it to clients (into the DCProcess event queue).
m_async_thread = m_async_thread = ThreadLauncher::LaunchThread(
ThreadLauncher::LaunchThread("<lldb.process.gdb-remote.async>", "<lldb.process.gdb-remote.async>", ProcessGDBRemote::AsyncThread, this,
ProcessGDBRemote::AsyncThread, this, NULL); nullptr);
} else if (log) } else if (log)
log->Printf("ProcessGDBRemote::%s () - Called when Async thread was " log->Printf("ProcessGDBRemote::%s () - Called when Async thread was "
"already running.", "already running.",
__FUNCTION__); __FUNCTION__);
return m_async_thread.IsJoinable(); return m_async_thread.IsJoinable();
} }
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines if (process->m_async_listener_sp->GetEvent(event_sp, llvm::None)) {
const char *continue_cstr = const char *continue_cstr =
(const char *)continue_packet->GetBytes(); (const char *)continue_packet->GetBytes();
const size_t continue_cstr_len = continue_packet->GetByteSize(); const size_t continue_cstr_len = continue_packet->GetByteSize();
if (log) if (log)
log->Printf("ProcessGDBRemote::%s (arg = %p, pid = %" PRIu64 log->Printf("ProcessGDBRemote::%s (arg = %p, pid = %" PRIu64
") got eBroadcastBitAsyncContinue: %s", ") got eBroadcastBitAsyncContinue: %s",
__FUNCTION__, arg, process->GetID(), continue_cstr); __FUNCTION__, arg, process->GetID(), continue_cstr);
if (::strstr(continue_cstr, "vAttach") == NULL) if (::strstr(continue_cstr, "vAttach") == nullptr)
process->SetPrivateState(eStateRunning); process->SetPrivateState(eStateRunning);
StringExtractorGDBRemote response; StringExtractorGDBRemote response;
// If in Non-Stop-Mode // If in Non-Stop-Mode
if (process->GetTarget().GetNonStopModeEnabled()) { if (process->GetTarget().GetNonStopModeEnabled()) {
// send the vCont packet // send the vCont packet
if (!process->GetGDBRemote().SendvContPacket( if (!process->GetGDBRemote().SendvContPacket(
llvm::StringRef(continue_cstr, continue_cstr_len), llvm::StringRef(continue_cstr, continue_cstr_len),
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Lines if (process->m_async_listener_sp->GetEvent(event_sp, llvm::None)) {
done = true; done = true;
break; break;
} }
case eStateInvalid: { case eStateInvalid: {
// Check to see if we were trying to attach and if we got back // Check to see if we were trying to attach and if we got back
// the "E87" error code from debugserver -- this indicates that // the "E87" error code from debugserver -- this indicates that
// the process is not debuggable. Return a slightly more // the process is not debuggable. Return a slightly more
// helpful error message about why the attach failed. // helpful error message about why the attach failed.
if (::strstr(continue_cstr, "vAttach") != NULL && if (::strstr(continue_cstr, "vAttach") != nullptr &&
response.GetError() == 0x87) { response.GetError() == 0x87) {
process->SetExitStatus(-1, "cannot attach to process due to " process->SetExitStatus(-1, "cannot attach to process due to "
"System Integrity Protection"); "System Integrity Protection");
} else if (::strstr(continue_cstr, "vAttach") != NULL && } else if (::strstr(continue_cstr, "vAttach") != nullptr &&
response.GetStatus().Fail()) { response.GetStatus().Fail()) {
process->SetExitStatus(-1, response.GetStatus().AsCString()); process->SetExitStatus(-1, response.GetStatus().AsCString());
} else { } else {
process->SetExitStatus(-1, "lost connection"); process->SetExitStatus(-1, "lost connection");
} }
break; break;
} }
▲ Show 20 Lines • Show All 58 Lines • ▼ Show 20 Lines while (!done) {
} }
} }
if (log) if (log)
log->Printf("ProcessGDBRemote::%s (arg = %p, pid = %" PRIu64 log->Printf("ProcessGDBRemote::%s (arg = %p, pid = %" PRIu64
") thread exiting...", ") thread exiting...",
__FUNCTION__, arg, process->GetID()); __FUNCTION__, arg, process->GetID());
return NULL; return nullptr;
} }
// uint32_t // uint32_t
// ProcessGDBRemote::ListProcessesMatchingName (const char *name, StringList // ProcessGDBRemote::ListProcessesMatchingName (const char *name, StringList
// &matches, std::vector<lldb::pid_t> &pids) // &matches, std::vector<lldb::pid_t> &pids)
//{ //{
// // If we are planning to launch the debugserver remotely, then we need to // // If we are planning to launch the debugserver remotely, then we need to
// fire up a debugserver // fire up a debugserver
▲ Show 20 Lines • Show All 79 Lines • ▼ Show 20 Lines if (platform_sp) {
m_thread_create_bp_sp->SetCallback( m_thread_create_bp_sp->SetCallback(
ProcessGDBRemote::NewThreadNotifyBreakpointHit, this, true); ProcessGDBRemote::NewThreadNotifyBreakpointHit, this, true);
} else { } else {
if (log) if (log)
log->Printf("Failed to create new thread notification breakpoint."); log->Printf("Failed to create new thread notification breakpoint.");
} }
} }
} }
return m_thread_create_bp_sp.get() != NULL; return m_thread_create_bp_sp.get() != nullptr;
} }
bool ProcessGDBRemote::StopNoticingNewThreads() { bool ProcessGDBRemote::StopNoticingNewThreads() {
Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_STEP)); Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_STEP));
if (log && log->GetVerbose()) if (log && log->GetVerbose())
log->Printf("Disabling new thread notification breakpoint."); log->Printf("Disabling new thread notification breakpoint.");
if (m_thread_create_bp_sp) if (m_thread_create_bp_sp)
m_thread_create_bp_sp->SetEnabled(false); m_thread_create_bp_sp->SetEnabled(false);
return true; return true;
} }
DynamicLoader *ProcessGDBRemote::GetDynamicLoader() { DynamicLoader *ProcessGDBRemote::GetDynamicLoader() {
if (m_dyld_up.get() == NULL) if (m_dyld_up.get() == nullptr)
m_dyld_up.reset(DynamicLoader::FindPlugin(this, NULL)); m_dyld_up.reset(DynamicLoader::FindPlugin(this, nullptr));
return m_dyld_up.get(); return m_dyld_up.get();
} }
Status ProcessGDBRemote::SendEventData(const char *data) { Status ProcessGDBRemote::SendEventData(const char *data) {
int return_value; int return_value;
bool was_supported; bool was_supported;
Status error; Status error;
▲ Show 20 Lines • Show All 324 Lines • ▼ Show 20 Lines feature_node.ForEachChildElementWithName(
ConstString alt_name; ConstString alt_name;
ConstString set_name; ConstString set_name;
std::vector<uint32_t> value_regs; std::vector<uint32_t> value_regs;
std::vector<uint32_t> invalidate_regs; std::vector<uint32_t> invalidate_regs;
std::vector<uint8_t> dwarf_opcode_bytes; std::vector<uint8_t> dwarf_opcode_bytes;
bool encoding_set = false; bool encoding_set = false;
bool format_set = false; bool format_set = false;
RegisterInfo reg_info = { RegisterInfo reg_info = {
NULL, // Name nullptr, // Name
NULL, // Alt name nullptr, // Alt name
0, // byte size 0, // byte size
reg_offset, // offset reg_offset, // offset
eEncodingUint, // encoding eEncodingUint, // encoding
eFormatHex, // format eFormatHex, // format
{ {
LLDB_INVALID_REGNUM, // eh_frame reg num LLDB_INVALID_REGNUM, // eh_frame reg num
LLDB_INVALID_REGNUM, // DWARF reg num LLDB_INVALID_REGNUM, // DWARF reg num
LLDB_INVALID_REGNUM, // generic reg num LLDB_INVALID_REGNUM, // generic reg num
cur_reg_num, // process plugin reg num cur_reg_num, // process plugin reg num
cur_reg_num // native register number cur_reg_num // native register number
}, },
NULL, nullptr,
NULL, nullptr,
NULL, // Dwarf Expression opcode bytes pointer nullptr, // Dwarf Expression opcode bytes pointer
0 // Dwarf Expression opcode bytes length 0 // Dwarf Expression opcode bytes length
}; };
reg_node.ForEachAttribute([&target_info, &gdb_group, &gdb_type, reg_node.ForEachAttribute([&target_info, &gdb_group, &gdb_type,
&reg_name, &alt_name, &set_name, &value_regs, &reg_name, &alt_name, &set_name, &value_regs,
&invalidate_regs, &encoding_set, &format_set, &invalidate_regs, &encoding_set, &format_set,
&reg_info, &reg_offset, &dwarf_opcode_bytes]( &reg_info, &reg_offset, &dwarf_opcode_bytes](
const llvm::StringRef &name, const llvm::StringRef &name,
const llvm::StringRef &value) -> bool { const llvm::StringRef &value) -> bool {
Show All 17 Lines feature_node.ForEachChildElementWithName(
} else if (name == "altname") { } else if (name == "altname") {
alt_name.SetString(value); alt_name.SetString(value);
} else if (name == "encoding") { } else if (name == "encoding") {
encoding_set = true; encoding_set = true;
reg_info.encoding = Args::StringToEncoding(value, eEncodingUint); reg_info.encoding = Args::StringToEncoding(value, eEncodingUint);
} else if (name == "format") { } else if (name == "format") {
format_set = true; format_set = true;
Format format = eFormatInvalid; Format format = eFormatInvalid;
if (OptionArgParser::ToFormat(value.data(), format, NULL).Success()) if (OptionArgParser::ToFormat(value.data(), format, nullptr)
.Success())
reg_info.format = format; reg_info.format = format;
else if (value == "vector-sint8") else if (value == "vector-sint8")
reg_info.format = eFormatVectorOfSInt8; reg_info.format = eFormatVectorOfSInt8;
else if (value == "vector-uint8") else if (value == "vector-uint8")
reg_info.format = eFormatVectorOfUInt8; reg_info.format = eFormatVectorOfUInt8;
else if (value == "vector-sint16") else if (value == "vector-sint16")
reg_info.format = eFormatVectorOfSInt16; reg_info.format = eFormatVectorOfSInt16;
else if (value == "vector-uint16") else if (value == "vector-uint16")
▲ Show 20 Lines • Show All 700 Lines • ▼ Show 20 Lines
class CommandObjectProcessGDBRemoteSpeedTest : public CommandObjectParsed { class CommandObjectProcessGDBRemoteSpeedTest : public CommandObjectParsed {
public: public:
CommandObjectProcessGDBRemoteSpeedTest(CommandInterpreter &interpreter) CommandObjectProcessGDBRemoteSpeedTest(CommandInterpreter &interpreter)
: CommandObjectParsed(interpreter, "process plugin packet speed-test", : CommandObjectParsed(interpreter, "process plugin packet speed-test",
"Tests packet speeds of various sizes to determine " "Tests packet speeds of various sizes to determine "
"the performance characteristics of the GDB remote " "the performance characteristics of the GDB remote "
"connection. ", "connection. ",
NULL), nullptr),
m_option_group(), m_option_group(),
m_num_packets(LLDB_OPT_SET_1, false, "count", 'c', 0, eArgTypeCount, m_num_packets(LLDB_OPT_SET_1, false, "count", 'c', 0, eArgTypeCount,
"The number of packets to send of each varying size " "The number of packets to send of each varying size "
"(default is 1000).", "(default is 1000).",
1000), 1000),
m_max_send(LLDB_OPT_SET_1, false, "max-send", 's', 0, eArgTypeCount, m_max_send(LLDB_OPT_SET_1, false, "max-send", 's', 0, eArgTypeCount,
"The maximum number of bytes to send in a packet. Sizes " "The maximum number of bytes to send in a packet. Sizes "
"increase in powers of 2 while the size is less than or " "increase in powers of 2 while the size is less than or "
▲ Show 20 Lines • Show All 57 Lines • ▼ Show 20 Linesprotected:
OptionGroupBoolean m_json; OptionGroupBoolean m_json;
}; };
class CommandObjectProcessGDBRemotePacketHistory : public CommandObjectParsed { class CommandObjectProcessGDBRemotePacketHistory : public CommandObjectParsed {
private: private:
public: public:
CommandObjectProcessGDBRemotePacketHistory(CommandInterpreter &interpreter) CommandObjectProcessGDBRemotePacketHistory(CommandInterpreter &interpreter)
: CommandObjectParsed(interpreter, "process plugin packet history", : CommandObjectParsed(interpreter, "process plugin packet history",
"Dumps the packet history buffer. ", NULL) {} "Dumps the packet history buffer. ", nullptr) {}
~CommandObjectProcessGDBRemotePacketHistory() override {} ~CommandObjectProcessGDBRemotePacketHistory() override {}
bool DoExecute(Args &command, CommandReturnObject &result) override { bool DoExecute(Args &command, CommandReturnObject &result) override {
const size_t argc = command.GetArgumentCount(); const size_t argc = command.GetArgumentCount();
if (argc == 0) { if (argc == 0) {
ProcessGDBRemote *process = ProcessGDBRemote *process =
(ProcessGDBRemote *)m_interpreter.GetExecutionContext() (ProcessGDBRemote *)m_interpreter.GetExecutionContext()
Show All 14 Lines
class CommandObjectProcessGDBRemotePacketXferSize : public CommandObjectParsed { class CommandObjectProcessGDBRemotePacketXferSize : public CommandObjectParsed {
private: private:
public: public:
CommandObjectProcessGDBRemotePacketXferSize(CommandInterpreter &interpreter) CommandObjectProcessGDBRemotePacketXferSize(CommandInterpreter &interpreter)
: CommandObjectParsed( : CommandObjectParsed(
interpreter, "process plugin packet xfer-size", interpreter, "process plugin packet xfer-size",
"Maximum size that lldb will try to read/write one one chunk.", "Maximum size that lldb will try to read/write one one chunk.",
NULL) {} nullptr) {}
~CommandObjectProcessGDBRemotePacketXferSize() override {} ~CommandObjectProcessGDBRemotePacketXferSize() override {}
bool DoExecute(Args &command, CommandReturnObject &result) override { bool DoExecute(Args &command, CommandReturnObject &result) override {
const size_t argc = command.GetArgumentCount(); const size_t argc = command.GetArgumentCount();
if (argc == 0) { if (argc == 0) {
result.AppendErrorWithFormat("'%s' takes an argument to specify the max " result.AppendErrorWithFormat("'%s' takes an argument to specify the max "
"amount to be transferred when " "amount to be transferred when "
"reading/writing", "reading/writing",
m_cmd_name.c_str()); m_cmd_name.c_str());
result.SetStatus(eReturnStatusFailed); result.SetStatus(eReturnStatusFailed);
return false; return false;
} }
ProcessGDBRemote *process = ProcessGDBRemote *process =
(ProcessGDBRemote *)m_interpreter.GetExecutionContext().GetProcessPtr(); (ProcessGDBRemote *)m_interpreter.GetExecutionContext().GetProcessPtr();
if (process) { if (process) {
const char *packet_size = command.GetArgumentAtIndex(0); const char *packet_size = command.GetArgumentAtIndex(0);
errno = 0; errno = 0;
uint64_t user_specified_max = strtoul(packet_size, NULL, 10); uint64_t user_specified_max = strtoul(packet_size, nullptr, 10);
if (errno == 0 && user_specified_max != 0) { if (errno == 0 && user_specified_max != 0) {
process->SetUserSpecifiedMaxMemoryTransferSize(user_specified_max); process->SetUserSpecifiedMaxMemoryTransferSize(user_specified_max);
result.SetStatus(eReturnStatusSuccessFinishResult); result.SetStatus(eReturnStatusSuccessFinishResult);
return true; return true;
} }
} }
result.SetStatus(eReturnStatusFailed); result.SetStatus(eReturnStatusFailed);
return false; return false;
} }
}; };
class CommandObjectProcessGDBRemotePacketSend : public CommandObjectParsed { class CommandObjectProcessGDBRemotePacketSend : public CommandObjectParsed {
private: private:
public: public:
CommandObjectProcessGDBRemotePacketSend(CommandInterpreter &interpreter) CommandObjectProcessGDBRemotePacketSend(CommandInterpreter &interpreter)
: CommandObjectParsed(interpreter, "process plugin packet send", : CommandObjectParsed(interpreter, "process plugin packet send",
"Send a custom packet through the GDB remote " "Send a custom packet through the GDB remote "
"protocol and print the answer. " "protocol and print the answer. "
"The packet header and footer will automatically " "The packet header and footer will automatically "
"be added to the packet prior to sending and " "be added to the packet prior to sending and "
"stripped from the result.", "stripped from the result.",
NULL) {} nullptr) {}
~CommandObjectProcessGDBRemotePacketSend() override {} ~CommandObjectProcessGDBRemotePacketSend() override {}
bool DoExecute(Args &command, CommandReturnObject &result) override { bool DoExecute(Args &command, CommandReturnObject &result) override {
const size_t argc = command.GetArgumentCount(); const size_t argc = command.GetArgumentCount();
if (argc == 0) { if (argc == 0) {
result.AppendErrorWithFormat( result.AppendErrorWithFormat(
"'%s' takes a one or more packet content arguments", "'%s' takes a one or more packet content arguments",
Show All 11 Lines if (process) {
StringExtractorGDBRemote response; StringExtractorGDBRemote response;
process->GetGDBRemote().SendPacketAndWaitForResponse( process->GetGDBRemote().SendPacketAndWaitForResponse(
packet_cstr, response, send_async); packet_cstr, response, send_async);
result.SetStatus(eReturnStatusSuccessFinishResult); result.SetStatus(eReturnStatusSuccessFinishResult);
Stream &output_strm = result.GetOutputStream(); Stream &output_strm = result.GetOutputStream();
output_strm.Printf(" packet: %s\n", packet_cstr); output_strm.Printf(" packet: %s\n", packet_cstr);
std::string &response_str = response.GetStringRef(); std::string &response_str = response.GetStringRef();
if (strstr(packet_cstr, "qGetProfileData") != NULL) { if (strstr(packet_cstr, "qGetProfileData") != nullptr) {
response_str = process->HarmonizeThreadIdsForProfileData(response); response_str = process->HarmonizeThreadIdsForProfileData(response);
} }
if (response_str.empty()) if (response_str.empty())
output_strm.PutCString("response: \nerror: UNIMPLEMENTED\n"); output_strm.PutCString("response: \nerror: UNIMPLEMENTED\n");
else else
output_strm.Printf("response: %s\n", response.GetStringRef().c_str()); output_strm.Printf("response: %s\n", response.GetStringRef().c_str());
} }
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
}; };
class CommandObjectProcessGDBRemotePacket : public CommandObjectMultiword { class CommandObjectProcessGDBRemotePacket : public CommandObjectMultiword {
private: private:
public: public:
CommandObjectProcessGDBRemotePacket(CommandInterpreter &interpreter) CommandObjectProcessGDBRemotePacket(CommandInterpreter &interpreter)
: CommandObjectMultiword(interpreter, "process plugin packet", : CommandObjectMultiword(interpreter, "process plugin packet",
"Commands that deal with GDB remote packets.", "Commands that deal with GDB remote packets.",
NULL) { nullptr) {
LoadSubCommand( LoadSubCommand(
"history", "history",
CommandObjectSP( CommandObjectSP(
new CommandObjectProcessGDBRemotePacketHistory(interpreter))); new CommandObjectProcessGDBRemotePacketHistory(interpreter)));
LoadSubCommand( LoadSubCommand(
"send", CommandObjectSP( "send", CommandObjectSP(
new CommandObjectProcessGDBRemotePacketSend(interpreter))); new CommandObjectProcessGDBRemotePacketSend(interpreter)));
LoadSubCommand( LoadSubCommand(
Show All 36 Lines

lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp

lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp

Show First 20 Lines • Show All 594 Lines • ▼ Show 20 Linesprivate:
} }
bool DumpFacebookThreadName() const { bool DumpFacebookThreadName() const {
return DumpFacebook() || m_fb_thread.GetOptionValue().GetCurrentValue(); return DumpFacebook() || m_fb_thread.GetOptionValue().GetCurrentValue();
} }
bool DumpFacebookLogcat() const { bool DumpFacebookLogcat() const {
return DumpFacebook() || m_fb_logcat.GetOptionValue().GetCurrentValue(); return DumpFacebook() || m_fb_logcat.GetOptionValue().GetCurrentValue();
} }
public: public:
CommandObjectProcessMinidumpDump(CommandInterpreter &interpreter) CommandObjectProcessMinidumpDump(CommandInterpreter &interpreter)
: CommandObjectParsed(interpreter, "process plugin dump", : CommandObjectParsed(interpreter, "process plugin dump",
"Dump information from the minidump file.", NULL), "Dump information from the minidump file.", nullptr),
m_option_group(), m_option_group(),
INIT_BOOL(m_dump_all, "all", 'a', INIT_BOOL(m_dump_all, "all", 'a',
"Dump the everything in the minidump."), "Dump the everything in the minidump."),
INIT_BOOL(m_dump_directory, "directory", 'd', INIT_BOOL(m_dump_directory, "directory", 'd',
"Dump the minidump directory map."), "Dump the minidump directory map."),
INIT_BOOL(m_dump_linux_cpuinfo, "cpuinfo", 'C', INIT_BOOL(m_dump_linux_cpuinfo, "cpuinfo", 'C',
"Dump linux /proc/cpuinfo."), "Dump linux /proc/cpuinfo."),
INIT_BOOL(m_dump_linux_proc_status, "status", 's', INIT_BOOL(m_dump_linux_proc_status, "status", 's',
"Dump linux /proc/<pid>/status."), "Dump linux /proc/<pid>/status."),
INIT_BOOL(m_dump_linux_lsb_release, "lsb-release", 'r', INIT_BOOL(m_dump_linux_lsb_release, "lsb-release", 'r',
"Dump linux /etc/lsb-release."), "Dump linux /etc/lsb-release."),
INIT_BOOL(m_dump_linux_cmdline, "cmdline", 'c', INIT_BOOL(m_dump_linux_cmdline, "cmdline", 'c',
"Dump linux /proc/<pid>/cmdline."), "Dump linux /proc/<pid>/cmdline."),
INIT_BOOL(m_dump_linux_environ, "environ", 'e', INIT_BOOL(m_dump_linux_environ, "environ", 'e',
"Dump linux /proc/<pid>/environ."), "Dump linux /proc/<pid>/environ."),
INIT_BOOL(m_dump_linux_auxv, "auxv", 'x', INIT_BOOL(m_dump_linux_auxv, "auxv", 'x',
"Dump linux /proc/<pid>/auxv."), "Dump linux /proc/<pid>/auxv."),
INIT_BOOL(m_dump_linux_maps, "maps", 'm', INIT_BOOL(m_dump_linux_maps, "maps", 'm',
"Dump linux /proc/<pid>/maps."), "Dump linux /proc/<pid>/maps."),
INIT_BOOL(m_dump_linux_proc_stat, "stat", 'S', INIT_BOOL(m_dump_linux_proc_stat, "stat", 'S',
"Dump linux /proc/<pid>/stat."), "Dump linux /proc/<pid>/stat."),
INIT_BOOL(m_dump_linux_proc_uptime, "uptime", 'u', INIT_BOOL(m_dump_linux_proc_uptime, "uptime", 'u',
"Dump linux process uptime."), "Dump linux process uptime."),
INIT_BOOL(m_dump_linux_proc_fd, "fd", 'f', INIT_BOOL(m_dump_linux_proc_fd, "fd", 'f',
"Dump linux /proc/<pid>/fd."), "Dump linux /proc/<pid>/fd."),
INIT_BOOL(m_dump_linux_all, "linux", 'l', INIT_BOOL(m_dump_linux_all, "linux", 'l',
"Dump all linux streams."), "Dump all linux streams."),
INIT_BOOL(m_fb_app_data, "fb-app-data", 1, INIT_BOOL(m_fb_app_data, "fb-app-data", 1,
"Dump Facebook application custom data."), "Dump Facebook application custom data."),
INIT_BOOL(m_fb_build_id, "fb-build-id", 2, INIT_BOOL(m_fb_build_id, "fb-build-id", 2,
"Dump the Facebook build ID."), "Dump the Facebook build ID."),
INIT_BOOL(m_fb_version, "fb-version", 3, INIT_BOOL(m_fb_version, "fb-version", 3,
"Dump Facebook application version string."), "Dump Facebook application version string."),
INIT_BOOL(m_fb_java_stack, "fb-java-stack", 4, INIT_BOOL(m_fb_java_stack, "fb-java-stack", 4,
"Dump Facebook java stack."), "Dump Facebook java stack."),
INIT_BOOL(m_fb_dalvik, "fb-dalvik-info", 5, INIT_BOOL(m_fb_dalvik, "fb-dalvik-info", 5,
"Dump Facebook Dalvik info."), "Dump Facebook Dalvik info."),
INIT_BOOL(m_fb_unwind, "fb-unwind-symbols", 6, INIT_BOOL(m_fb_unwind, "fb-unwind-symbols", 6,
"Dump Facebook unwind symbols."), "Dump Facebook unwind symbols."),
INIT_BOOL(m_fb_error_log, "fb-error-log", 7, INIT_BOOL(m_fb_error_log, "fb-error-log", 7,
"Dump Facebook error log."), "Dump Facebook error log."),
INIT_BOOL(m_fb_app_state, "fb-app-state-log", 8, INIT_BOOL(m_fb_app_state, "fb-app-state-log", 8,
"Dump Facebook java stack."), "Dump Facebook java stack."),
INIT_BOOL(m_fb_abort, "fb-abort-reason", 9, INIT_BOOL(m_fb_abort, "fb-abort-reason", 9,
"Dump Facebook abort reason."), "Dump Facebook abort reason."),
INIT_BOOL(m_fb_thread, "fb-thread-name", 10, INIT_BOOL(m_fb_thread, "fb-thread-name", 10,
"Dump Facebook thread name."), "Dump Facebook thread name."),
INIT_BOOL(m_fb_logcat, "fb-logcat", 11, INIT_BOOL(m_fb_logcat, "fb-logcat", 11,
"Dump Facebook logcat."), "Dump Facebook logcat."),
teemperorUnsubmitted
Not Done
ReplyInline Actions

Could you also revert the unrelated whitespace changes here? Phabricator doesn't really display the whitespace changes well, but this patch effectively reformats this whole INIT_BOOL chain (The reformatting itself is fine, but it should be it's own commit).

teemperor: Could you also revert the unrelated whitespace changes here? Phabricator doesn't really display…
kwkAuthorUnsubmitted
Not Done
ReplyInline Actions

@teemperor sure.

kwk: @teemperor sure.
INIT_BOOL(m_fb_all, "facebook", 12, "Dump all Facebook streams.") { INIT_BOOL(m_fb_all, "facebook", 12, "Dump all Facebook streams.") {
APPEND_OPT(m_dump_all); APPEND_OPT(m_dump_all);
APPEND_OPT(m_dump_directory); APPEND_OPT(m_dump_directory);
APPEND_OPT(m_dump_linux_cpuinfo); APPEND_OPT(m_dump_linux_cpuinfo);
APPEND_OPT(m_dump_linux_proc_status); APPEND_OPT(m_dump_linux_proc_status);
APPEND_OPT(m_dump_linux_lsb_release); APPEND_OPT(m_dump_linux_lsb_release);
APPEND_OPT(m_dump_linux_cmdline); APPEND_OPT(m_dump_linux_cmdline);
APPEND_OPT(m_dump_linux_environ); APPEND_OPT(m_dump_linux_environ);
▲ Show 20 Lines • Show All 160 Lines • Show Last 20 Lines

lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.h

lldb/source/Plugins/SymbolFile/DWARF/DWARFDeclContext.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.h

lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp

lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h

lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp

lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp

lldb/source/Plugins/SymbolFile/DWARF/UniqueDWARFASTType.cpp

lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.cpp

lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetQueuesHandler.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetThreadItemInfoHandler.cpp

lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp

lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.h

lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp

lldb/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp

lldb/source/Symbol/ClangASTContext.cpp

lldb/source/Symbol/ClangASTImporter.cpp

lldb/source/Symbol/CompactUnwindInfo.cpp

lldb/source/Symbol/CompilerType.cpp

lldb/source/Symbol/LocateSymbolFile.cpp

lldb/source/Symbol/SymbolContext.cpp

lldb/source/Symbol/Symtab.cpp

lldb/source/Symbol/Type.cpp

lldb/source/Target/CPPLanguageRuntime.cpp

lldb/source/Target/Process.cpp

lldb/source/Target/SectionLoadHistory.cpp

lldb/source/Target/StopInfo.cpp

lldb/source/Target/ThreadPlanShouldStopHere.cpp

lldb/tools/lldb-mi/MICmdCmdExec.cpp

lldb/tools/lldb-mi/MICmdCmdTarget.cpp

lldb/tools/lldb-mi/MICmnBase.cpp

lldb/tools/lldb-mi/MICmnMIOutOfBandRecord.cpp

lldb/tools/lldb-mi/MICmnMIResultRecord.cpp

lldb/tools/lldb-mi/MIDriver.cpp

lldb/tools/lldb-mi/MIDriverBase.cpp

lldb/tools/lldb-mi/MIDriverMgr.cpp

lldb/tools/lldb-server/lldb-gdbserver.cpp

lldb/tools/lldb-server/lldb-platform.cpp

lldb/unittests/Utility/StringExtractorTest.cpp

lldb/unittests/tools/lldb-server/inferior/thread_inferior.cpp

lldb/unittests/tools/lldb-server/tests/MessageObjects.cpp

llvm/include/llvm/ADT/DenseMap.h

llvm/include/llvm/Demangle/MicrosoftDemangleNodes.h

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

llvm/test/MC/AMDGPU/dl-insts-err.s

llvm/test/MC/AMDGPU/expressions-gfx9.s

llvm/test/MC/AMDGPU/vop3p-err.s

llvm/tools/llvm-exegesis/lib/TargetSelect.h

llvm/tools/llvm-exegesis/llvm-exegesis.cpp