Page MenuHomePhabricator

abidh (Hafiz Abid Qadeer)
User

Projects

User does not belong to any projects.

User Details

User Since
May 27 2014, 3:19 AM (264 w, 2 d)

Recent Activity

Mar 25 2019

abidh accepted D59015: [lldb-mi] Include full path in the -data-disassemble response.

Looks ok but I would like a testcase to go with the change.

Mar 25 2019, 4:40 AM · Restricted Project, Restricted Project
abidh committed rLLDB356876: Fix a broken comment line. NFC..
Fix a broken comment line. NFC.
Mar 25 2019, 2:44 AM
abidh committed rGde9d73649561: Fix a broken comment line. NFC. (authored by abidh).
Fix a broken comment line. NFC.
Mar 25 2019, 2:41 AM
abidh committed rL356876: Fix a broken comment line. NFC..
Fix a broken comment line. NFC.
Mar 25 2019, 2:41 AM

Feb 25 2019

abidh accepted D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment.

The lldb-mi bits look ok to me.

Feb 25 2019, 3:57 AM · Restricted Project

Nov 15 2017

abidh added inline comments to D39969: Set error status in ObjectFile::LoadInMemory if it is not set .
Nov 15 2017, 2:59 AM

Nov 14 2017

abidh accepted D40022: Remove extra minuses from command option.
Nov 14 2017, 9:07 AM

Aug 30 2017

abidh added a comment to D37154: lldb-mi: -var-update can hang when traversing complex types with pointers.

This check used to be there above the loop and was removed when you reported that changes in pointers are not being tracked in
http://lists.llvm.org/pipermail/lldb-dev/2017-May/012428.html

Aug 30 2017, 2:08 AM

Aug 10 2017

abidh committed rL310607: [ELF, LinkerScript] Support ! operator in linker script..
[ELF, LinkerScript] Support ! operator in linker script.
Aug 10 2017, 8:26 AM
abidh closed D36451: [ELF, LinkerScript] Support ! operator in linker script..
Aug 10 2017, 8:26 AM
abidh added inline comments to D36451: [ELF, LinkerScript] Support ! operator in linker script..
Aug 10 2017, 2:02 AM
abidh updated the diff for D36451: [ELF, LinkerScript] Support ! operator in linker script..

Fix case pointed out in review comments.

Aug 10 2017, 1:59 AM

Aug 9 2017

abidh updated the diff for D36451: [ELF, LinkerScript] Support ! operator in linker script..
Aug 9 2017, 7:55 AM
abidh added inline comments to D36451: [ELF, LinkerScript] Support ! operator in linker script..
Aug 9 2017, 2:32 AM
abidh updated the diff for D36451: [ELF, LinkerScript] Support ! operator in linker script..

Handle review comments.

Aug 9 2017, 2:29 AM

Aug 8 2017

abidh created D36451: [ELF, LinkerScript] Support ! operator in linker script..
Aug 8 2017, 12:51 AM

Jun 1 2017

abidh committed rL304400: Fix a small issue with -var-update..
Fix a small issue with -var-update.
Jun 1 2017, 3:33 AM

May 25 2017

abidh closed D33504: Fix FDE indexing while scan debug_info section.

@tatyana-krasnukha Please make sure that patch is generated from the top level lldb directory.

May 25 2017, 3:23 AM
abidh committed rL303847: Fix FDE indexing while scan debug_info section..
Fix FDE indexing while scan debug_info section.
May 25 2017, 3:21 AM
abidh accepted D33504: Fix FDE indexing while scan debug_info section.
May 25 2017, 1:51 AM

Jan 24 2017

abidh committed rL292989: Provide option to set pc of the file loaded in memory..
Provide option to set pc of the file loaded in memory.
Jan 24 2017, 3:18 PM
abidh closed D28944: Provide option to set pc of the file loaded in memory..
Jan 24 2017, 3:18 PM
abidh committed rL292987: Fix a bug where lldb does not respect the packet size..
Fix a bug where lldb does not respect the packet size.
Jan 24 2017, 3:06 PM
abidh closed D28808: Fix a bug where lldb does not respect the packet size..
Jan 24 2017, 3:06 PM

Jan 22 2017

abidh updated the diff for D28808: Fix a bug where lldb does not respect the packet size..

Use GetLogIfAnyCategoryIsSet as advised in comments.

Jan 22 2017, 10:13 AM
abidh updated the diff for D28944: Provide option to set pc of the file loaded in memory..

Added a check for case when entry address is not valid.

Jan 22 2017, 9:44 AM

Jan 20 2017

abidh added a comment to D28808: Fix a bug where lldb does not respect the packet size..

Greg, any further comment on this patch.

Jan 20 2017, 8:59 AM
abidh created D28944: Provide option to set pc of the file loaded in memory..
Jan 20 2017, 4:28 AM
abidh committed rL292598: Fix more unused variable warnings when asserts are disabled..
Fix more unused variable warnings when asserts are disabled.
Jan 20 2017, 2:35 AM

Jan 19 2017

abidh closed D28804: Provide a substitute to load command of gdb.

Committed in 292499. Removed this bit "set PC to its entry address." before committing as it is not being done now.

Jan 19 2017, 9:46 AM
abidh committed rL292499: Provide a substitute to load command of gdb..
Provide a substitute to load command of gdb.
Jan 19 2017, 9:43 AM
abidh updated the diff for D28804: Provide a substitute to load command of gdb.

Changed the name of the option. Added LoadInMemory function to Module and ObjectFile class and moved the functionality of writing to memory there. Removed part which set the pc.

Jan 19 2017, 9:12 AM
abidh committed rL292488: Avoid unused variable warning when assert is disabled..
Avoid unused variable warning when assert is disabled.
Jan 19 2017, 7:22 AM

Jan 18 2017

abidh added inline comments to D28808: Fix a bug where lldb does not respect the packet size..
Jan 18 2017, 10:26 AM
abidh updated the diff for D28808: Fix a bug where lldb does not respect the packet size..

Updated log calls as advised.

Jan 18 2017, 10:23 AM
abidh added inline comments to D28808: Fix a bug where lldb does not respect the packet size..
Jan 18 2017, 5:13 AM
abidh updated the diff for D28808: Fix a bug where lldb does not respect the packet size..

Added the check to avoid integer underflow.

Jan 18 2017, 5:06 AM

Jan 17 2017

abidh created D28808: Fix a bug where lldb does not respect the packet size..
Jan 17 2017, 7:48 AM
abidh created D28804: Provide a substitute to load command of gdb.
Jan 17 2017, 6:24 AM

Jan 5 2017

abidh committed rL291118: Skip a test on darwin..
Skip a test on darwin.
Jan 5 2017, 7:20 AM
abidh committed rL291104: [lldb-mi] Fix implementation for a few mi commands.
[lldb-mi] Fix implementation for a few mi commands
Jan 5 2017, 5:34 AM
abidh closed D24711: [lldb-mi] Fix implementation for a few mi commands by committing rL291104: [lldb-mi] Fix implementation for a few mi commands.
Jan 5 2017, 5:34 AM · Restricted Project

Jan 4 2017

abidh added a comment to D24711: [lldb-mi] Fix implementation for a few mi commands.

What do I do next? Could you help me commit and push this? since I don't have write access.

I will commit it for you.

Jan 4 2017, 9:43 AM · Restricted Project

Jan 3 2017

abidh accepted D24711: [lldb-mi] Fix implementation for a few mi commands.

Looks good.

Jan 3 2017, 2:41 AM · Restricted Project

Dec 16 2016

abidh committed rL289947: Remove an unused type declaration..
Remove an unused type declaration.
Dec 16 2016, 6:55 AM

Dec 15 2016

abidh committed rL289821: Fix build for mingw..
Fix build for mingw.
Dec 15 2016, 7:11 AM
abidh closed D27759: Fix build for mingw..
Dec 15 2016, 7:11 AM
abidh accepted D27759: Fix build for mingw..

Accepted in email.

Dec 15 2016, 7:09 AM
abidh updated the diff for D27759: Fix build for mingw..

Replaced /D with -D as per comments.

Dec 15 2016, 7:08 AM
abidh added a comment to D27759: Fix build for mingw..

Yeah, I meant using it everywhere as a generic "am I on windows, regardless of the compiler" check. (Assuming Zach is fine with that)

Dec 15 2016, 2:16 AM

Dec 14 2016

abidh added a comment to D27759: Fix build for mingw..

BTW, I am curious, are you planning on building python with mingw as well? If you are, I'd be interested in knowing how that works out.

Dec 14 2016, 9:47 AM
abidh retitled D27759: Fix build for mingw. from to Fix build for mingw..
Dec 14 2016, 8:40 AM
abidh committed rL289644: Remove code needed for supporting old VS versions..
Remove code needed for supporting old VS versions.
Dec 14 2016, 3:23 AM
abidh closed D27707: Remove code needed for supporting old VS versions..
Dec 14 2016, 3:23 AM
abidh accepted D27707: Remove code needed for supporting old VS versions..

Accepted on email.

Dec 14 2016, 3:22 AM

Dec 13 2016

abidh retitled D27707: Remove code needed for supporting old VS versions. from to Remove code needed for supporting old VS versions..
Dec 13 2016, 2:33 AM

Nov 29 2016

abidh committed rL288118: Fix a typo..
Fix a typo.
Nov 29 2016, 1:42 AM

Nov 21 2016

abidh updated subscribers of D26908: Improve detection of global vs local variables.

Please add @clayborg as reviewer. Also paste the dwarf generated for this case from both gcc and clang.

Nov 21 2016, 5:28 AM

Oct 31 2016

abidh accepted D26124: [LLDB-MI] Escape MI output in a more consistent manner.

I have a quick look and it seems ok. Apart from fixing the issue, it is a useful clean up too. If testcases are ok then please free to commit.

Oct 31 2016, 6:36 AM

Oct 14 2016

abidh accepted D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 14 2016, 3:58 AM

Sep 21 2016

abidh added a comment to D24711: [lldb-mi] Fix implementation for a few mi commands.

Changes looks mostly Ok to me apart from some comments. Please address them and add testcases as mentioned by ilia. Also try to do one review for one fix. This review is for 3 fixes. When the changes are approved, please commit them in 3 separate commits (one per fix).

Sep 21 2016, 6:41 AM · Restricted Project
abidh updated subscribers of D24711: [lldb-mi] Fix implementation for a few mi commands.
Sep 21 2016, 5:57 AM · Restricted Project

Apr 13 2016

abidh added a comment to D18880: -thread-info in lldbmi does not conform to protocol. Should end with current thread id.

Looks fine to me. TBH I haven't seen any of the lldb-mi owners around in months, so I'm not sure if they're still active

Apr 13 2016, 4:41 AM

Dec 7 2015

abidh accepted D15168: Allow variable names to be quoted with -var-list-children.
Dec 7 2015, 3:57 AM

Nov 2 2015

abidh committed rL251793: Handle the options and parameters separator in every MI command.
Handle the options and parameters separator in every MI command
Nov 2 2015, 3:46 AM
abidh closed D14197: Handle the options and parameters separator in every MI command.
Nov 2 2015, 3:45 AM
abidh added inline comments to D14197: Handle the options and parameters separator in every MI command.
Nov 2 2015, 3:37 AM
abidh added inline comments to D14197: Handle the options and parameters separator in every MI command.
Nov 2 2015, 2:07 AM
abidh updated the diff for D14197: Handle the options and parameters separator in every MI command.

Handled review comment.

Nov 2 2015, 2:06 AM

Oct 30 2015

abidh committed rL251704: Remove 2 lines missed in earlier commit (r251636)..
Remove 2 lines missed in earlier commit (r251636).
Oct 30 2015, 9:23 AM
abidh retitled D14197: Handle the options and parameters separator in every MI command from to Handle the option and parameter separator in every command..
Oct 30 2015, 4:33 AM

Oct 29 2015

abidh committed rL251636: Better handle the arguments common to all MI commands..
Better handle the arguments common to all MI commands.
Oct 29 2015, 9:33 AM
abidh closed D14177: Better handle the arguments common to all MI commands..
Oct 29 2015, 9:33 AM
abidh added inline comments to D14177: Better handle the arguments common to all MI commands..
Oct 29 2015, 8:27 AM
abidh updated the diff for D14177: Better handle the arguments common to all MI commands..

Handled review comments.

Oct 29 2015, 8:25 AM
abidh retitled D14177: Better handle the arguments common to all MI commands. from to Better handle the arguments common to all MI commands..
Oct 29 2015, 7:45 AM

Oct 27 2015

abidh committed rL251426: Include <cstdio> to fix build errors..
Include <cstdio> to fix build errors.
Oct 27 2015, 10:58 AM
abidh committed rL251421: Add a file in Makefile build which is present in CMake build..
Add a file in Makefile build which is present in CMake build.
Oct 27 2015, 10:41 AM
abidh accepted D14060: Deprecate -m/+m dotest options in favor of test categories.
Oct 27 2015, 2:30 AM

Oct 22 2015

abidh accepted D13947: [lldb-mi] Fix expansion of anonymous structures and unions.

LGTM. Thanks for doing it. For this case, the output of the lldb-mi looks more sensible then gdb.

Oct 22 2015, 2:40 AM

Oct 20 2015

abidh accepted D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases).

Apart from some inline comments, looks ok to me.

Oct 20 2015, 10:23 AM
abidh abandoned D13866: Remove more gcc warnings..
Oct 20 2015, 1:18 AM

Oct 19 2015

abidh retitled D13866: Remove more gcc warnings. from to Remove more gcc warnings..
Oct 19 2015, 5:59 AM
abidh added a comment to D13799: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases).

Please also indicate if a revision is dependent on some other revisions that has not yet been committed as this one is on D13657.

Oct 19 2015, 3:29 AM

Oct 15 2015

abidh committed rL250380: Fix warnings in LLDBWrapPython.cpp with gcc 4.9..
Fix warnings in LLDBWrapPython.cpp with gcc 4.9.
Oct 15 2015, 1:29 AM
abidh closed D13719: Fix warnings in LLDBWrapPython.cpp with gcc 4.9..
Oct 15 2015, 1:28 AM

Oct 14 2015

abidh retitled D13719: Fix warnings in LLDBWrapPython.cpp with gcc 4.9. from to Fix warnings in LLDBWrapPython.cpp with gcc 4.9..
Oct 14 2015, 2:55 AM

Sep 25 2015

abidh accepted D13158: Allow to construct CMIUtilString using std::string directly + cleanup CMIUtilString (MI).
Sep 25 2015, 1:28 AM

Sep 17 2015

abidh accepted D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used..
Sep 17 2015, 1:36 AM

Sep 15 2015

abidh accepted D12879: [lldb-mi] Simplify CMICmnLLDBDebugSessionInfo::Shutdown..

LGTM.

Sep 15 2015, 3:33 AM
abidh requested changes to D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used..

You forgot to add the MIUtilParse.cpp to CMakeLists.txt. Please add it and then it is good to go. Thanks for doing it.

Sep 15 2015, 1:53 AM

Sep 11 2015

abidh accepted D12796: [lldb-mi] No need to call Format with no varargs..

Look good.

Sep 11 2015, 3:48 AM

Sep 10 2015

abidh requested changes to D12764: [lldb-mi] Remove MIUtilSystem*..

There is a check on m_strMediumFileDirectory in CMICmnLogMediumFile::FileFormFileNamePath which may needs to be updated. Otherwise looks ok to me.

Sep 10 2015, 9:25 AM
abidh requested changes to D12115: [LLDB-MI] Fix -data-info-line and -symbol-list-lines when Windows filenames are used..

We dont use the lldb_private stuff inside lldb-mi. Please see the discussion in the following thread.
http://lists.llvm.org/pipermail/lldb-dev/2015-March/007047.html

Sep 10 2015, 2:18 AM

Sep 9 2015

abidh committed rL247124: Remove an invalid check in DW_OP_piece processing..
Remove an invalid check in DW_OP_piece processing.
Sep 9 2015, 2:07 AM
abidh closed D12674: Remove an invalid check in DW_OP_piece processing. by committing rL247124: Remove an invalid check in DW_OP_piece processing..
Sep 9 2015, 2:07 AM

Sep 7 2015

abidh retitled D12674: Remove an invalid check in DW_OP_piece processing. from to Remove an invalid check in DW_OP_piece processing..
Sep 7 2015, 6:07 AM
abidh committed rL246965: Fix -data-evaluate-expression for array..
Fix -data-evaluate-expression for array.
Sep 7 2015, 5:02 AM
abidh closed D12634: Fix -data-evaluate-expression for array..
Sep 7 2015, 5:02 AM
abidh updated the diff for D12634: Fix -data-evaluate-expression for array..

Handle review comments.
Moved the test to data directory and put it in a separate function.

Sep 7 2015, 3:09 AM