Page MenuHomePhabricator

[llvm-objdump] Print st_other
ClosedPublic

Authored by MaskRay on May 8 2019, 11:23 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.May 8 2019, 11:23 PM
MaskRay updated this revision to Diff 198764.May 8 2019, 11:25 PM

Add a missed test

jhenderson added inline comments.May 10 2019, 3:25 AM
llvm/test/tools/llvm-objdump/elf-symbol-visibility.s
1 ↗(On Diff #198765)

I think it's more normal to put a test with such a requirement inside a PowerPC/X86 subdirectory for llvm-objdump tests, but does this need to be assembly? Can it not be built with yaml2obj?

MaskRay updated this revision to Diff 199000.May 10 2019, 4:29 AM

Use yaml2obj

MaskRay updated this revision to Diff 199002.May 10 2019, 4:32 AM

Actually use yaml2obj

(I don't use monorepo often..)

MaskRay marked 2 inline comments as done.May 10 2019, 4:34 AM
MaskRay added inline comments.
llvm/test/tools/llvm-objdump/elf-symbol-visibility.s
1 ↗(On Diff #198765)

Changed to yaml2obj. Its st_other mapping is currently a bit clumsy to use. So I switched from ppc64 to mips... I may take a look how to improve that.

sfertile accepted this revision.May 10 2019, 6:49 AM

LGTM.

This revision is now accepted and ready to land.May 10 2019, 6:49 AM
Closed by commit rL360439: [llvm-objdump] Print st_other (authored by MaskRay, committed by ). · Explain WhyMay 10 2019, 9:23 AM
This revision was automatically updated to reflect the committed changes.
MaskRay marked an inline comment as done.