Page MenuHomePhabricator

adalava (Alfredo Dal'Ava Júnior)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 13 2018, 6:34 AM (27 w, 6 d)

Recent Activity

Thu, Jun 6

adalava added a comment to D62464: [PPC32] Improve the 32-bit PowerPC port.

Great job, @MaskRay !!

Thu, Jun 6, 7:09 AM · Restricted Project

May 16 2019

adalava added a comment to D61950: [PowerPC64] adds ABI parsing when specified on target triple.

Will FreeBSD 13 or future releases support ELFv1? If not, it may be cleaner to not invent -elfv2 -elfv1 triples, but rather dispatch on the major version, e.g. powerpc64-unknown-freebsd13.0 could mean ELFv2.

May 16 2019, 6:28 AM · Restricted Project, Restricted Project

May 15 2019

adalava added inline comments to D61950: [PowerPC64] adds ABI parsing when specified on target triple.
May 15 2019, 10:24 AM · Restricted Project, Restricted Project
adalava updated the diff for D61950: [PowerPC64] adds ABI parsing when specified on target triple.
  • remove redundant comment
May 15 2019, 10:20 AM · Restricted Project, Restricted Project
adalava added inline comments to D61950: [PowerPC64] adds ABI parsing when specified on target triple.
May 15 2019, 10:10 AM · Restricted Project, Restricted Project
adalava retitled D61950: [PowerPC64] adds ABI parsing when specified on target triple from [PowerPC64] recognize target triplet with ABI info (i.e. powerpc64-unknown-freebsd13-elfv2) to [PowerPC64] adds ABI parsing when specified on target triple.
May 15 2019, 8:49 AM · Restricted Project, Restricted Project
adalava created D61950: [PowerPC64] adds ABI parsing when specified on target triple.
May 15 2019, 8:33 AM · Restricted Project, Restricted Project

May 9 2019

adalava added a parent revision for D59436: [ELF] Fix missing ELF st_other field on versioned symbols: D61718: [llvm-objdump] Print st_other.
May 9 2019, 9:46 AM · Restricted Project
adalava added a child revision for D61718: [llvm-objdump] Print st_other: D59436: [ELF] Fix missing ELF st_other field on versioned symbols.
May 9 2019, 9:46 AM · Restricted Project
adalava abandoned D61610: [PPC64] implement Thunk Section Spacing.

@adalava We care about the link time. I need to do some testing to ensure this doesn't cause regression. I've created https://reviews.llvm.org/D61720, fixed the tests and added ppc64-long-branch-init.s that I think captures the idea of the fix. Hope you don't mind my commandeering the change :)

May 9 2019, 9:24 AM · Restricted Project
adalava added a parent revision for D61720: [PPC64] Define getThunkSectionSpacing() based on the range of R_PPC64_REL24: D61610: [PPC64] implement Thunk Section Spacing.
May 9 2019, 9:24 AM · Restricted Project
adalava added a child revision for D61610: [PPC64] implement Thunk Section Spacing: D61720: [PPC64] Define getThunkSectionSpacing() based on the range of R_PPC64_REL24.
May 9 2019, 9:24 AM · Restricted Project
adalava abandoned D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.

See https://reviews.llvm.org/D61718 , not many tests need updating. The dump still diverges from GNU objdump in a few ways, e.g. the width of the size field, the number of spaces, the 'g' symbol etc

May 9 2019, 8:55 AM · Restricted Project

May 8 2019

adalava added inline comments to D61610: [PPC64] implement Thunk Section Spacing.
May 8 2019, 10:18 AM · Restricted Project
adalava updated the diff for D61610: [PPC64] implement Thunk Section Spacing.

update testcase to use readelf instead of objdump, so it doesn't depend on D61647 anymore

May 8 2019, 9:49 AM · Restricted Project
adalava added a comment to D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.

This change makes sense and it will improve compatibility with GNU objdump. For your tests (I've commented there), I usually prefer llvm-readelf/llvm-readobj to llvm-objdump. The output of objdump also looks very weird to me. I remember @emaste said so in one FreeBSD issue.. I can check how many tests (you should at least check ninja -C Release check-llvm check-lld; clang has <5 llvm-objdump tests; ) will be impacted by this change. If there aren't many, I can fix them and commit that for you :)

May 8 2019, 9:23 AM · Restricted Project
adalava added a comment to D59436: [ELF] Fix missing ELF st_other field on versioned symbols.

Thanks. The test contains some constructs that are not used, e.g. .symver .addrsig. And I think it is usually better to use llvm-readelf/llvm-readobj. I always find the output of llvm-objdump/objdump weird.. If you don't mind, I can rewrite/minimalize the test and commit for you.

May 8 2019, 9:13 AM · Restricted Project
adalava updated the diff for D61610: [PPC64] implement Thunk Section Spacing.

increase to PPC64_REL24 range

May 8 2019, 9:02 AM · Restricted Project

May 7 2019

adalava added a comment to D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.

This definitely seems a useful upgrade to me. Unfortunately it might affect a lot of lit tests. If we do intend to make a change we should try to match the output of the binutils objdump. I can see from the surrounding context we print out '.hidden', having a quick look it seems binutils will print out the visibility if its the only thing set, and the hex value otherwise (ie not both) here is an example:

May 7 2019, 3:30 PM · Restricted Project
adalava added a comment to D59436: [ELF] Fix missing ELF st_other field on versioned symbols.

Thank you @MaskRay, a test case was added. Please note this patch currently depends on D56586 and D61647 that need to go in first.

May 7 2019, 12:53 PM · Restricted Project
adalava added a reviewer for D59436: [ELF] Fix missing ELF st_other field on versioned symbols: MaskRay.
May 7 2019, 12:53 PM · Restricted Project
adalava updated the diff for D59436: [ELF] Fix missing ELF st_other field on versioned symbols.

add test case

May 7 2019, 12:48 PM · Restricted Project
adalava updated subscribers of D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.
May 7 2019, 12:27 PM · Restricted Project
adalava added a parent revision for D59436: [ELF] Fix missing ELF st_other field on versioned symbols: D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.
May 7 2019, 12:22 PM · Restricted Project
adalava updated the summary of D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.
May 7 2019, 12:22 PM · Restricted Project
adalava added a child revision for D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name: D59436: [ELF] Fix missing ELF st_other field on versioned symbols.
May 7 2019, 12:22 PM · Restricted Project
adalava created D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name.
May 7 2019, 12:08 PM · Restricted Project
adalava added a comment to D61610: [PPC64] implement Thunk Section Spacing.

Thank you guys. I updated the patch,;

May 7 2019, 8:36 AM · Restricted Project
adalava updated the diff for D61610: [PPC64] implement Thunk Section Spacing.

fix patch

May 7 2019, 8:32 AM · Restricted Project
adalava updated the diff for D61610: [PPC64] implement Thunk Section Spacing.
  • add space reservation, add comments and improve test
May 7 2019, 8:29 AM · Restricted Project

May 6 2019

adalava updated the summary of D61610: [PPC64] implement Thunk Section Spacing.
May 6 2019, 2:15 PM · Restricted Project
adalava created D61610: [PPC64] implement Thunk Section Spacing.
May 6 2019, 2:04 PM · Restricted Project

Apr 5 2019

adalava added a comment to rG70f25ebc6d15: luporl, adalava pending patches !!!!!!!!!.

It was brought up before.
phab for some reason counts all the commits to all the github forks of the official github llvm monorepo like this

Apr 5 2019, 5:52 AM
adalava added a comment to rG70f25ebc6d15: luporl, adalava pending patches !!!!!!!!!.

Sorry, I was in the wrong repository! It was meant to be in my private one.

Apr 5 2019, 5:45 AM
GitHub <noreply@github.com> committed rG9032b24aeae9: Merge 5efb305a998e6c80956d234452428f399100fce8 into… (authored by adalava).
Merge 5efb305a998e6c80956d234452428f399100fce8 into…
Apr 5 2019, 4:47 AM
adalava committed rG5efb305a998e: Merge branch 'next80' of github.com:PPC64/llvm-project into next80 (authored by adalava).
Merge branch 'next80' of github.com:PPC64/llvm-project into next80
Apr 5 2019, 4:45 AM
adalava committed rGa9e7e3438e4d: adalava: add comment to 9f2bdd2f7da10a49f1cece341b20a17ed97ca88b (authored by adalava).
adalava: add comment to 9f2bdd2f7da10a49f1cece341b20a17ed97ca88b
Apr 5 2019, 4:44 AM
adalava committed rG9f2bdd2f7da1: adalava - implement PPC64::getThunkSectionSpacing() as workaround to "large… (authored by adalava).
adalava - implement PPC64::getThunkSectionSpacing() as workaround to "large…
Apr 5 2019, 4:44 AM
adalava committed rG31247e381f97: adalava: change default powerpc64 ABI to ELFv2 on FreeBSD >= 13.0 (authored by adalava).
adalava: change default powerpc64 ABI to ELFv2 on FreeBSD >= 13.0
Apr 5 2019, 4:44 AM
adalava committed rG70f25ebc6d15: luporl, adalava pending patches !!!!!!!!! (authored by adalava).
luporl, adalava pending patches !!!!!!!!!
Apr 5 2019, 4:44 AM

Mar 15 2019

adalava updated the summary of D59436: [ELF] Fix missing ELF st_other field on versioned symbols.
Mar 15 2019, 3:28 PM · Restricted Project
adalava added a comment to D59436: [ELF] Fix missing ELF st_other field on versioned symbols.

Example code:

Mar 15 2019, 3:15 PM · Restricted Project
adalava retitled D59436: [ELF] Fix missing ELF st_other field on versioned symbols from Fix missing ELF st_other field on versioned symbols to [ELF] Fix missing ELF st_other field on versioned symbols.
Mar 15 2019, 3:07 PM · Restricted Project
adalava added a parent revision for D59436: [ELF] Fix missing ELF st_other field on versioned symbols: D56586: [PPC64] Update LocalEntry from assigned symbols.
Mar 15 2019, 3:00 PM · Restricted Project
adalava added a child revision for D56586: [PPC64] Update LocalEntry from assigned symbols: D59436: [ELF] Fix missing ELF st_other field on versioned symbols.
Mar 15 2019, 3:00 PM · Restricted Project
adalava created D59436: [ELF] Fix missing ELF st_other field on versioned symbols.
Mar 15 2019, 3:00 PM · Restricted Project

Jan 24 2019

adalava added a reviewer for D56782: [PPC64] Preserve LocalEntry when linking: emaste.
Jan 24 2019, 7:20 AM · Restricted Project
adalava added a reviewer for D56586: [PPC64] Update LocalEntry from assigned symbols: emaste.
Jan 24 2019, 7:17 AM · Restricted Project