User Details
- User Since
- Dec 13 2018, 6:34 AM (224 w, 2 d)
Feb 27 2023
Feb 16 2023
Nice catch!
I'm not a LLVM maintainer but from FreeBSD PowerPC side I agree with the changes, only added two suggestions that could improve code readability
Feb 6 2023
sorry for the long delay, I'm not professionally working on PPC64 since then.
Update comments
Sep 13 2022
Sep 12 2022
Jul 7 2022
Jul 5 2022
Apr 6 2022
Apr 5 2022
It's not actually a problem but tb_freq should be initialized as integer. Otherwise looks good to me!
Mar 18 2022
Feb 25 2022
LGTM, Tested on FreeBSD/powerpc 32 bit
Feb 8 2022
long long (8-bytes) can be lock free on PPC64, but it's not lock free on PPC32.
Dec 13 2021
Nov 22 2021
Nov 9 2021
fix style
add more ppc_wrappers
Nov 8 2021
Nov 4 2021
Oct 15 2021
- Simplified register number check as suggested by @MaskRay
- Added test for powerpcle (32 bits LE)
Oct 14 2021
@sfertile is this last version still good for you? (after removing isPPC64 from if clause)
add tests for FreeBSD
Oct 13 2021
It's now avoiding a copy relocation for '__stack_chk_guard':
Update patch to avoid setting dso_local for any FreeBSD target since symbol is defined on libc.so.7.
Sep 20 2021
Sep 9 2021
Sep 1 2021
rebased from stable/13.x to main branch
Jul 3 2020
This was already commited, but for the record , I tested it on FreeBSD 13/powerpc64
May 18 2020
I confirmed it fixes the case Piotr Kubaj reported. Thank you!
Feb 10 2020
fix typo found by @dim
Jan 23 2020
Updated comment
Jan 13 2020
Jan 9 2020
Jan 7 2020
LGTM. Just a comment regarding FreeBSD 11.x.
Jan 6 2020
Dec 17 2019
Nov 19 2019
As I'm not a commiter, may someone commit it, if it's the case, please?
Sep 19 2019
update fixing the typo found during review.
Sep 4 2019
Aug 29 2019
This solution works for me.
Validated it on FreeBSD13-CURRENT/powerpc64, with 32 bit compatibility libraries built using this patch over LLVM9.
Jun 6 2019
Great job, @MaskRay !!
May 16 2019
May 15 2019
- remove redundant comment
May 9 2019
May 8 2019
update testcase to use readelf instead of objdump, so it doesn't depend on D61647 anymore
increase to PPC64_REL24 range
May 7 2019
Thank you @MaskRay, a test case was added. Please note this patch currently depends on D56586 and D61647 that need to go in first.
add test case
Thank you guys. I updated the patch,;
fix patch
- add space reservation, add comments and improve test
May 6 2019
Apr 5 2019
Sorry, I was in the wrong repository! It was meant to be in my private one.
Mar 15 2019
Example code: