Page MenuHomePhabricator

luporl (Leandro Lupori)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2017, 3:07 AM (103 w, 1 d)

Recent Activity

Aug 5 2019

luporl accepted D65755: [ELF][PPC] Don't relax ifunc toc-indirect accesses to toc-relative.

Nice, I've confirmed that it fixes PR42759 on FreeBSD.

Aug 5 2019, 10:03 AM · Restricted Project

May 20 2019

luporl added a comment to D56586: [PPC64] Update LocalEntry from assigned symbols.

@MaskRay, this change should be good to go now, the last revision should address your last comments.

May 20 2019, 5:55 AM · Restricted Project

May 15 2019

luporl added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.

Thanks for the reviews @compnerd, @nemanjai, and @mclow.lists.
As I don't have permission to commit this to LLVM repository, can anyone commit this change for me?

May 15 2019, 7:05 AM · Restricted Project, Restricted Project

May 13 2019

luporl added inline comments to D61792: [PPC] Fix 32-bit build of libunwind.
May 13 2019, 11:38 AM · Restricted Project, Restricted Project
luporl added a comment to D61792: [PPC] Fix 32-bit build of libunwind.

As far as I can tell, this should have no effects - is that correct?
If so, this looks fine to me.

May 13 2019, 11:31 AM · Restricted Project, Restricted Project
luporl added inline comments to D61792: [PPC] Fix 32-bit build of libunwind.
May 13 2019, 7:00 AM · Restricted Project, Restricted Project
luporl added a comment to D56586: [PPC64] Update LocalEntry from assigned symbols.

Thanks for the review @MaskRay.
I've moved the test case to ppc64-localentry-symver.s, but then I thought it was better to rename it to ppc64-localentry-symbols.s, as now the test scope is broader than .symver testing.

May 13 2019, 6:37 AM · Restricted Project
luporl updated the diff for D56586: [PPC64] Update LocalEntry from assigned symbols.
  • Addressed MaskRay review comments
May 13 2019, 6:31 AM · Restricted Project

May 10 2019

luporl added a comment to D56586: [PPC64] Update LocalEntry from assigned symbols.

Any update on this?

May 10 2019, 9:45 AM · Restricted Project
luporl updated subscribers of D61792: [PPC] Fix 32-bit build of libunwind.
May 10 2019, 9:45 AM · Restricted Project, Restricted Project
luporl added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.

Any update on this?

May 10 2019, 9:40 AM · Restricted Project, Restricted Project
luporl added reviewers for D61792: [PPC] Fix 32-bit build of libunwind: mstorsjo, nemanjai, compnerd.
May 10 2019, 9:37 AM · Restricted Project, Restricted Project
luporl created D61792: [PPC] Fix 32-bit build of libunwind.
May 10 2019, 9:29 AM · Restricted Project, Restricted Project

May 9 2019

luporl added a reviewer for D56586: [PPC64] Update LocalEntry from assigned symbols: MaskRay.
May 9 2019, 9:39 AM · Restricted Project

Apr 26 2019

luporl updated the diff for D56586: [PPC64] Update LocalEntry from assigned symbols.
  • [PPC64] Update LocalEntry from assigned symbols
  • Addressed review's comments
  • Added a test case for the fix
Apr 26 2019, 9:25 AM · Restricted Project

Apr 25 2019

luporl added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.

Sorry, could you please rebase to latest? It does not apply cleanly for me (assembly.h does not apply).

Apr 25 2019, 7:15 AM · Restricted Project, Restricted Project
luporl updated the diff for D59694: [PPC64][libunwind] Fix r2 not properly restored.

Rebasing with latest master

Apr 25 2019, 7:13 AM · Restricted Project, Restricted Project

Apr 23 2019

luporl added inline comments to D56586: [PPC64] Update LocalEntry from assigned symbols.
Apr 23 2019, 11:59 AM · Restricted Project
luporl added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.

@nemanjai, I've included a test case in the last revision. Do you think this is ok now?
Also, if there are no further issues, could you please check this in for me?

Apr 23 2019, 10:49 AM · Restricted Project, Restricted Project

Apr 5 2019

luporl committed rGa994896d2bd3: Fixed regression and ELFv1 ASM functions (authored by luporl).
Fixed regression and ELFv1 ASM functions
Apr 5 2019, 4:44 AM
luporl committed rG46ef3712016d: Merge branch 'next80' of github.com:PPC64/llvm-project into next80 (authored by luporl).
Merge branch 'next80' of github.com:PPC64/llvm-project into next80
Apr 5 2019, 4:44 AM
luporl committed rG2b112d8216ca: Addressed review comments (authored by luporl).
Addressed review comments
Apr 5 2019, 4:44 AM
luporl committed rG6b293b18528e: [PPC64][libunwind] Fix r2 not properly restored (authored by luporl).
[PPC64][libunwind] Fix r2 not properly restored
Apr 5 2019, 4:44 AM

Apr 3 2019

luporl updated the summary of D59694: [PPC64][libunwind] Fix r2 not properly restored.
Apr 3 2019, 2:45 PM · Restricted Project, Restricted Project
luporl updated the diff for D59694: [PPC64][libunwind] Fix r2 not properly restored.
  • Test libunwind exception handling fix for PPC64
Apr 3 2019, 2:03 PM · Restricted Project, Restricted Project

Mar 29 2019

luporl added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.

Sorry for the delay, I ran into some issues.
This change addresses the review comments.
It also fixes assembly functions when targeting PowerPC64 with the ELFv1 ABI, as it requires an entry in .opd section for each function.
The compiler usually does this, but it must be inserted by hand for assembly functions.

Mar 29 2019, 1:11 PM · Restricted Project, Restricted Project
luporl updated the diff for D59694: [PPC64][libunwind] Fix r2 not properly restored.
  • Addressed review comments
  • Fixed ELFv1 ASM functions
Mar 29 2019, 1:00 PM · Restricted Project, Restricted Project

Mar 22 2019

luporl updated the summary of D59694: [PPC64][libunwind] Fix r2 not properly restored.
Mar 22 2019, 7:00 AM · Restricted Project, Restricted Project
luporl added reviewers for D59694: [PPC64][libunwind] Fix r2 not properly restored: mstorsjo, nemanjai.
Mar 22 2019, 7:00 AM · Restricted Project, Restricted Project
luporl created D59694: [PPC64][libunwind] Fix r2 not properly restored.
Mar 22 2019, 6:55 AM · Restricted Project, Restricted Project

Feb 15 2019

luporl added a comment to D56782: [PPC64] Preserve LocalEntry when linking.

Thank you @ruiu. Can you commit this change for me?

Feb 15 2019, 8:06 AM · Restricted Project

Feb 14 2019

luporl added a comment to D56782: [PPC64] Preserve LocalEntry when linking.

Sorry for the belated response. I missed this one for some reason.

Can you add a test?

Feb 14 2019, 6:54 AM · Restricted Project
luporl updated the diff for D56782: [PPC64] Preserve LocalEntry when linking.
  • Addressed review's comments
  • Added a test for the fix
Feb 14 2019, 6:54 AM · Restricted Project

Jan 24 2019

luporl added a reviewer for D56586: [PPC64] Update LocalEntry from assigned symbols: joerg.
Jan 24 2019, 7:25 AM · Restricted Project

Jan 16 2019

luporl retitled D56782: [PPC64] Preserve LocalEntry when linking from [PPC64] Preserve LocalEntry when linking On PowerPC64, it is necessary to keep the LocalEntry bits in st_other, especially when -r is used. Otherwise, when the resulting object is used in a posterior linking, LocalEntry info will be unavailable... to [PPC64] Preserve LocalEntry when linking.
Jan 16 2019, 6:27 AM · Restricted Project
luporl created D56782: [PPC64] Preserve LocalEntry when linking.
Jan 16 2019, 6:24 AM · Restricted Project

Jan 11 2019

luporl updated subscribers of D56586: [PPC64] Update LocalEntry from assigned symbols.

I suggest having this reviewed by the PPC target owner in llvm.

Jan 11 2019, 4:21 AM · Restricted Project
luporl edited reviewers for D56586: [PPC64] Update LocalEntry from assigned symbols, added: hfinkel; removed: labath, clayborg.
Jan 11 2019, 4:21 AM · Restricted Project
luporl added a comment to D44437: Avoid GEP when creating a breakpoint.

@clayborg, it seems this change ended up forgotten here. Can you check this in when you have the time? Thanks.

Jan 11 2019, 4:00 AM
luporl updated the summary of D56586: [PPC64] Update LocalEntry from assigned symbols.
Jan 11 2019, 3:48 AM · Restricted Project
luporl created D56586: [PPC64] Update LocalEntry from assigned symbols.
Jan 11 2019, 3:26 AM · Restricted Project

Oct 17 2018

luporl added a comment to D44437: Avoid GEP when creating a breakpoint.

ping

Oct 17 2018, 2:07 PM

Oct 4 2018

luporl added a comment to D44437: Avoid GEP when creating a breakpoint.

Is there anything pending on this yet?
It seems that we just need someone with write access to check in the changes, right?

Oct 4 2018, 8:45 AM

Sep 24 2018

luporl added a comment to D44437: Avoid GEP when creating a breakpoint.

Thanks @clayborg! Can you please commit this change for me?

Sep 24 2018, 7:20 AM

Sep 18 2018

luporl updated the diff for D44437: Avoid GEP when creating a breakpoint.
  • Changed parameter: Symbol -> SymbolContext
Sep 18 2018, 11:06 AM
luporl commandeered D44437: Avoid GEP when creating a breakpoint.

@lbianc is no longer working on this. I'll continue his work from where he left it.

Sep 18 2018, 11:01 AM

Aug 30 2018

luporl added a comment to D44437: Avoid GEP when creating a breakpoint.

Hello @clayborg, any update on this?

Is it clear why, at least on PPC64, the SymbolContext is not needed, as the needed info is at the symbol, and only at the symbol?

It is fine for PPC64 to only require a symbol, but for other architectures, it might be able to use the function. Since we are designing APIs for all architectures here, we should send an entire symbol context just in case. It is fine for the PPC64 version to require just the symbol. but it should be grabbed from the symbol context

Aug 30 2018, 10:48 AM
luporl added a comment to D44437: Avoid GEP when creating a breakpoint.

Hello @clayborg, any update on this?

Aug 30 2018, 7:02 AM

Aug 10 2018

luporl updated the summary of D44437: Avoid GEP when creating a breakpoint.
Aug 10 2018, 11:58 AM
luporl added inline comments to D44437: Avoid GEP when creating a breakpoint.
Aug 10 2018, 11:53 AM
luporl added a comment to D44437: Avoid GEP when creating a breakpoint.

Any update on this?
It seems it only need Greg or Jim to take a look at the final result, right?

Aug 10 2018, 9:16 AM

Mar 23 2018

luporl added a comment to D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.

Thanks @labath.
Could you please commit this patch?

Mar 23 2018, 6:33 AM

Mar 16 2018

luporl closed D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.

Closed by commit rL327331: Re-add change for https://reviews.llvm.org/D42582 with added directories.

Mar 16 2018, 5:27 AM
luporl added a comment to D44022: [LLDB] Fix TestTargetXMLArch's expected arch.

Thanks @labath. Can you check this in for me?

Mar 16 2018, 5:18 AM

Mar 15 2018

luporl added a comment to D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.

I don't know much about this special PPC64 key. I just noticed that it is used multiple times in PPC's auxvec, which breaks current test's logic.

Mar 15 2018, 1:01 PM
luporl updated the diff for D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.
  • Added description about ignored PPC auxvec key
Mar 15 2018, 12:57 PM

Mar 14 2018

luporl added a comment to D44022: [LLDB] Fix TestTargetXMLArch's expected arch.

@labath, @jasonmolenda, any updates on this? Can we just change the assert for now?

Mar 14 2018, 9:11 AM
luporl added a comment to D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.

@labath, @clayborg, can you commit this change for me?

Mar 14 2018, 9:11 AM

Mar 9 2018

luporl added a comment to D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.

Thank you @labath, @clayborg and @jingham. Can you please check this in for me?

Mar 9 2018, 6:08 AM

Mar 7 2018

luporl updated the summary of D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
Mar 7 2018, 8:09 AM
luporl updated the summary of D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
Mar 7 2018, 8:05 AM
luporl updated the summary of D43768: [LLDB][PPC64] Fix single step and LldbGdbServer tests.
Mar 7 2018, 7:45 AM
luporl added a comment to D43768: [LLDB][PPC64] Fix single step and LldbGdbServer tests.

Thank you @labath. Can you check this in for me?

Mar 7 2018, 6:22 AM
luporl added a comment to D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.

Thank you @clayborg. Can you check this in for me?

Mar 7 2018, 6:20 AM
luporl added a comment to D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.

@jingham, I think this needs your approval to go ahead, right?

Mar 7 2018, 6:19 AM

Mar 6 2018

luporl updated the diff for D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
  • Merge branch 'master' into fix-step-in
  • Improved ppc64 local entry point test
Mar 6 2018, 5:20 AM
luporl added inline comments to D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
Mar 6 2018, 4:50 AM

Mar 5 2018

luporl added a comment to D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.

@labath, did you have a chance to look at the breakpoint test, and the new "where" line in lldb-test?

Mar 5 2018, 9:56 AM
luporl added a comment to D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.

@clayborg, do you think it is ok now?

Mar 5 2018, 9:45 AM
luporl updated the diff for D43768: [LLDB][PPC64] Fix single step and LldbGdbServer tests.
  • Merge branch 'master' into fix-tests-brkpts
Mar 5 2018, 9:10 AM
luporl added a comment to D43767: [LLDB][PPC64] Fixed issues with expedited registers.

@labath, @clayborg, can you check this in for me?

Mar 5 2018, 5:12 AM
luporl added a comment to D44022: [LLDB] Fix TestTargetXMLArch's expected arch.

BTW, why is failure expected in i386?

Mar 5 2018, 5:08 AM
luporl added a comment to D44022: [LLDB] Fix TestTargetXMLArch's expected arch.

Pavel raises a good point, but I don't know if the onerous should be on this patch author to work out a better way to test this.

The question I have is -- what is the target triple on your linux system? Is the vendor field of the triple empty? To be honest, we could test for .startswith('x86_64-') here and that's all we really need to be doing. If the host platform is "infecting" the triple with a vendor or OS, that's not what the test is intended to check.

Mar 5 2018, 5:05 AM

Mar 2 2018

luporl added reviewers for D44022: [LLDB] Fix TestTargetXMLArch's expected arch: clayborg, labath.
Mar 2 2018, 9:07 AM
luporl created D44022: [LLDB] Fix TestTargetXMLArch's expected arch.
Mar 2 2018, 9:06 AM

Feb 27 2018

luporl updated the diff for D43768: [LLDB][PPC64] Fix single step and LldbGdbServer tests.
  • Merge branch 'master' into fix-tests-brkpts
  • Forcing PPC64 to use function global entry point
Feb 27 2018, 11:32 AM
luporl updated the diff for D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.
  • Merge branch 'master' into fix-auxv-test
  • Addressed review's comments
Feb 27 2018, 10:22 AM
luporl added a comment to D43345: [LLDB] Initial version of PPC64 InstEmulation.

Thanks @labath. Can you check this in for me?

Feb 27 2018, 10:01 AM
luporl updated the diff for D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
  • Merge branch 'master' into fix-step-in
  • Added break in function local entry point test
Feb 27 2018, 7:25 AM

Feb 26 2018

luporl updated the summary of D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.
Feb 26 2018, 11:19 AM
luporl created D43771: [LLDB][PPC64] Fix TestGdbRemoteAuxvSupport.
Feb 26 2018, 11:18 AM
luporl added a comment to D43768: [LLDB][PPC64] Fix single step and LldbGdbServer tests.

I think we should find some other way to fix this. Is there a way to force the inferior to go through the global entry point? Would putting the function in a different compilation unit help? Or calling it through a function pointer?

Feb 26 2018, 10:18 AM
luporl added reviewers for D43768: [LLDB][PPC64] Fix single step and LldbGdbServer tests: clayborg, labath.
Feb 26 2018, 9:25 AM
luporl created D43768: [LLDB][PPC64] Fix single step and LldbGdbServer tests.
Feb 26 2018, 9:24 AM
luporl added reviewers for D43767: [LLDB][PPC64] Fixed issues with expedited registers: labath, clayborg.
Feb 26 2018, 9:13 AM
luporl created D43767: [LLDB][PPC64] Fixed issues with expedited registers.
Feb 26 2018, 9:12 AM
luporl updated the diff for D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
  • Improved GetBytesToSkip() interface
  • Performed requested changes
Feb 26 2018, 9:02 AM
luporl added a comment to D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.

GetBytesToSkip strikes me as an odd function. It takes a thread but implicitly acts on the PC of frame 0 of that thread. That makes it feel overly specific and requires a process when you don't really need one to do the calculation. Plus you already have the pc & symbol but you end up re-looking them up. You could do all the calculations you do in GetBytesToSkip if you passed in the symbol and the pc as an Address. That would allow you to get the file address for the PC, and you can compare that directly to the symbol's address.

You can get an Address from a load address (which curr_addr is) by calling target->GetSectionLoadList()->ResolveLoadAddress(curr_addr, ReturnedAddress). Then you can use the file address from the ReturnedAddress to compare against the FileAddress of the symbol.

The way you are using these is fine, BTW. I'm just quibbling about the interface of GetBytesToSkip.

Feb 26 2018, 8:24 AM
luporl added inline comments to D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
Feb 26 2018, 7:47 AM
luporl added a comment to D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.

I don't think I know enough about this, so I'll defer to Jim to comment on the design. I just have some comments about the implementation.

Also, it looks like at least the breakpoint-setting part should be easy to test in a freestanding environment: make a .s file which sets up the function, llvm-mc it, load it up in lldb, set a breakpoint, verify it got moved to the right offset. I've been playing around with a patch that should make this easier for you. I'll see if I can clean it up and upload today...

Feb 26 2018, 7:32 AM

Feb 22 2018

luporl updated the diff for D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
  • Restored PPC64 Architecture Plugin
  • Restored/refactored GetBytesToSkip() method, to present a cleaner API (this replaces the trampoline code attempt, that didn't work very well)
  • Added an AdjustBreakpointAddress method, to fix issues with setting breakpoints in functions with multiple entry points
Feb 22 2018, 2:09 PM

Feb 21 2018

luporl added a comment to D43344: [LLDB][PPC64] Fixed next blocked forever at same line.

Thanks @clayborg and @labath! Can you please commit this patch for me?

Feb 21 2018, 1:19 PM
luporl updated the diff for D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line.
  • Revert "Changed GetBytesToSkip comment to focus on the API"
  • Revert "Fixed ArchitecturePPC64 initialization"
  • Revert "Moved changes to new ArchitecturePPC64 plugin"
  • Revert "Fixed step-in stopping in the wrong line in PPC64"
  • Handling PPC64 local entry point with extra symbol
  • Merge branch 'master' into fix-step-in2
Feb 21 2018, 11:23 AM

Feb 20 2018

luporl updated the diff for D43345: [LLDB] Initial version of PPC64 InstEmulation.
  • Changed the plugin to not store the Log pointer
Feb 20 2018, 8:55 AM

Feb 19 2018

luporl updated the diff for D43345: [LLDB] Initial version of PPC64 InstEmulation.
  • Changed debug printfs to log messages
Feb 19 2018, 10:52 AM
luporl added a comment to D43345: [LLDB] Initial version of PPC64 InstEmulation.

How would you feel about replacing the custom debug printfs with standard logging messages?

That way, you can always have them available without recompiling (and it's always nice to have more uniformity).

Feb 19 2018, 8:52 AM

Feb 16 2018

luporl updated the diff for D43345: [LLDB] Initial version of PPC64 InstEmulation.
  • Merge branch 'master' into ppc64-inst-emu2
  • Addressed review comments
Feb 16 2018, 8:31 AM
luporl added a comment to D43345: [LLDB] Initial version of PPC64 InstEmulation.

This FileCheck-style test seems to be easier to write and understand.
In fact, I wrote a gtest-style test because:
1- I didn't know I could write a FileCheck-style test instead.
2- This was inspired by the ARM64 plugin, that seemed like the simplest one to understand and follow.

Feb 16 2018, 3:21 AM

Feb 15 2018

luporl added inline comments to D43345: [LLDB] Initial version of PPC64 InstEmulation.
Feb 15 2018, 11:50 AM
luporl added reviewers for D43345: [LLDB] Initial version of PPC64 InstEmulation: clayborg, labath.
Feb 15 2018, 11:19 AM