User Details
- User Since
- Dec 19 2017, 3:07 AM (266 w, 5 d)
Wed, Jan 25
Make EnvironmentVariables.Basic test compare only lengths again, to avoid errors with long PATH variables.
Tue, Jan 24
AFAIU, having a single entry point for GET_ENVIRONMENT_VARIABLE intrinsic makes it easier to handle dynamically optional arguments correctly.
Feb 21 2022
It makes sense. Besides, the corresponding code in src/UnwindRegistersRestore.S doesn't read the saved VRSave register anymore, when __ALTIVEC__ isn't defined.
Nov 23 2020
Looks good to me. I guess I didn't know about __VSX__ back when I added PPC64_HAS_VMX.
Apr 15 2020
Clearing UpdateOther in finish() seems correct.
I've not considered the reuse of PPCTargetELFStreamer objects in the .localentry fix.
Dec 13 2019
LGTM. It seems I did not consider that Symbol could change its type between when it was added in emitAssignment() and when processed in finish().
Aug 5 2019
Nice, I've confirmed that it fixes PR42759 on FreeBSD.
May 20 2019
@MaskRay, this change should be good to go now, the last revision should address your last comments.
May 15 2019
Thanks for the reviews @compnerd, @nemanjai, and @mclow.lists.
As I don't have permission to commit this to LLVM repository, can anyone commit this change for me?
May 13 2019
Thanks for the review @MaskRay.
I've moved the test case to ppc64-localentry-symver.s, but then I thought it was better to rename it to ppc64-localentry-symbols.s, as now the test scope is broader than .symver testing.
- Addressed MaskRay review comments
May 10 2019
Any update on this?
Any update on this?
May 9 2019
Apr 26 2019
- [PPC64] Update LocalEntry from assigned symbols
- Addressed review's comments
- Added a test case for the fix
Apr 25 2019
Rebasing with latest master
Apr 23 2019
@nemanjai, I've included a test case in the last revision. Do you think this is ok now?
Also, if there are no further issues, could you please check this in for me?
Apr 5 2019
Apr 3 2019
- Test libunwind exception handling fix for PPC64
Mar 29 2019
Sorry for the delay, I ran into some issues.
This change addresses the review comments.
It also fixes assembly functions when targeting PowerPC64 with the ELFv1 ABI, as it requires an entry in .opd section for each function.
The compiler usually does this, but it must be inserted by hand for assembly functions.
- Addressed review comments
- Fixed ELFv1 ASM functions
Mar 22 2019
Feb 15 2019
Thank you @ruiu. Can you commit this change for me?
Feb 14 2019
- Addressed review's comments
- Added a test for the fix
Jan 24 2019
Jan 16 2019
Jan 11 2019
@clayborg, it seems this change ended up forgotten here. Can you check this in when you have the time? Thanks.
Oct 17 2018
Oct 4 2018
Is there anything pending on this yet?
It seems that we just need someone with write access to check in the changes, right?
Sep 24 2018
Thanks @clayborg! Can you please commit this change for me?
Sep 18 2018
- Changed parameter: Symbol -> SymbolContext
@lbianc is no longer working on this. I'll continue his work from where he left it.
Aug 30 2018
Hello @clayborg, any update on this?
Aug 10 2018
Any update on this?
It seems it only need Greg or Jim to take a look at the final result, right?
Mar 23 2018
Thanks @labath.
Could you please commit this patch?
Mar 16 2018
Closed by commit rL327331: Re-add change for https://reviews.llvm.org/D42582 with added directories.
Thanks @labath. Can you check this in for me?
Mar 15 2018
I don't know much about this special PPC64 key. I just noticed that it is used multiple times in PPC's auxvec, which breaks current test's logic.
- Added description about ignored PPC auxvec key
Mar 14 2018
@labath, @jasonmolenda, any updates on this? Can we just change the assert for now?
Mar 9 2018
Mar 7 2018
Thank you @labath. Can you check this in for me?
Thank you @clayborg. Can you check this in for me?
@jingham, I think this needs your approval to go ahead, right?
Mar 6 2018
- Merge branch 'master' into fix-step-in
- Improved ppc64 local entry point test
Mar 5 2018
@labath, did you have a chance to look at the breakpoint test, and the new "where" line in lldb-test?
@clayborg, do you think it is ok now?
- Merge branch 'master' into fix-tests-brkpts
BTW, why is failure expected in i386?
Mar 2 2018
Feb 27 2018
- Merge branch 'master' into fix-tests-brkpts
- Forcing PPC64 to use function global entry point
- Merge branch 'master' into fix-auxv-test
- Addressed review's comments
Thanks @labath. Can you check this in for me?
- Merge branch 'master' into fix-step-in
- Added break in function local entry point test
Feb 26 2018
- Improved GetBytesToSkip() interface
- Performed requested changes
Feb 22 2018
- Restored PPC64 Architecture Plugin
- Restored/refactored GetBytesToSkip() method, to present a cleaner API (this replaces the trampoline code attempt, that didn't work very well)
- Added an AdjustBreakpointAddress method, to fix issues with setting breakpoints in functions with multiple entry points
Feb 21 2018
- Revert "Changed GetBytesToSkip comment to focus on the API"
- Revert "Fixed ArchitecturePPC64 initialization"
- Revert "Moved changes to new ArchitecturePPC64 plugin"
- Revert "Fixed step-in stopping in the wrong line in PPC64"
- Handling PPC64 local entry point with extra symbol
- Merge branch 'master' into fix-step-in2