Page MenuHomePhabricator

[AArch64][SVE] Added GPR64shifted and GPR64NoXZRshifted register classes.

Authored by sdesmalen on Apr 16 2018, 7:34 AM.

Diff Detail


Event Timeline

sdesmalen created this revision.Apr 16 2018, 7:34 AM
sdesmalen updated this revision to Diff 142775.Apr 17 2018, 7:49 AM

Minor clean-up of patch:

  • Removed template argument from 'printRegWithShiftExtend'
  • Added unused attribute to DecodeGPR64commonRegisterClass (will be removed in next patch, but avoids breaking buildbot).
  • Rephrased diagnostic to say 'xzr' instead of 'x31'.
sdesmalen edited the summary of this revision. (Show Details)Apr 19 2018, 12:26 AM
SjoerdMeijer accepted this revision.Apr 19 2018, 1:07 AM

Looks good to me, just one nit inlined.

972 ↗(On Diff #142775)

Nit: SignExtend and DoShift can be booleans?

989 ↗(On Diff #142775)

Same here?

This revision is now accepted and ready to land.Apr 19 2018, 1:07 AM
sdesmalen added inline comments.Apr 19 2018, 6:42 AM
972 ↗(On Diff #142775)

Yes they can! I will change that before I commit, thanks for pointing out!

This revision was automatically updated to reflect the committed changes.