This is an archive of the discontinued LLVM Phabricator instance.

[ARM, Asm] Change grammar of immediate operand diagnostics

Authored by olista01 on Aug 14 2017, 9:07 AM.



Currently, our diagnostics for assembly operands are not consistent.
Some start with (for example) "immediate operand must be ...",
and some with "operand must be an immediate ...". I think the latter
form is preferable for a few reasons:

  • It's unambiguous that it is referring to the expected type of operand, not the type the user provided. For example, the user could provide an register operand, and get a message taking about an operand is if it is already an immediate, just not in the accepted range.
  • It allows us to have a consistent style once we add diagnostics for operands that could take two forms, for example a label or pc-relative memory operand.

Diff Detail