[RISCV 3/10] Add stub backend

[asb]

Summary

This contains just enough for lib/Target/RISCV to compile. Notably a basic RISCVTargetMachine and RISCVTargetInfo. At this point you can attempt llc -march=riscv32 myinput.ll and will find it fails due to the lack of MCAsmInfo.

[t.p.northover]

lib/Target/RISCV/TargetInfo/RISCVTargetInfo.cpp

20

Does it support JIT? I'd have thought you'd flip this when implementing the pseudo-linker under lib/ExecutionEngine.

[asb]

Address review comment from @t.p.northover

lib/Target/RISCV/TargetInfo/RISCVTargetInfo.cpp

20

That's an error - good catch! Thanks.

[jyknight]

lib/Target/RISCV/RISCVTargetMachine.cpp

40

Default model is expected to be PIC instead of static? That's different from most general purpose targets. Perhaps deserves a comment? Or a note in the nonexistent psABI doc. :)

[asb]

Address review comment from @jyknight, match RISC-V gcc's behaviour in defaulting to Reloc::Static.

[reames]

lib/Target/RISCV/TargetInfo/RISCVTargetInfo.cpp

28

Might want to add an assert(false && "not yet implemented").

[asb]

Add a link to the RISC-V ISA docs in CompilerWriterInfo.rst

lib/Target/RISCV/TargetInfo/RISCVTargetInfo.cpp

28

llvm_unreachable would be even better. However in this specific case we actually need to define LLVMInitializeRISCVTargetMC as a no-op. llc will call the initialisation functions for all backends that were compiled in, so if this function is made to assert it means that all codegen tests for other archs will fail.

I've modified the comment to be clear it's not purely a matter of being present for linking.

[theraven]

A couple of small nits inline.

CMakeLists.txt

275

Not really an objection, but MIPS and SPARC are both capitalised as if they were words. It would be more consistent to call the back end RiscV, though this would be ugly.

docs/CompilerWriterInfo.rst

86 ↗

(On Diff #69347)

Please also add a link to the ABI spec here.

lib/Target/RISCV/RISCVTargetMachine.cpp

35

Please assert TT.isArch32Bit() here, so that we catch fire if someone tries to use this back end for the 128-bit RISC-V variant in the future.

[asb]

assert if trying to compile for RV128 (or at least, a RISC-V that is neither 32-bit or 64-bit).

CMakeLists.txt

275

Yes, after considering the alternatives I decided RISCV would be least ugly. Plus ARM of course goes for all caps too.

docs/CompilerWriterInfo.rst

86 ↗

(On Diff #69347)

What exists of the ABI spec is contained within the user-level ISA specification (chapter 20). The separate ABI doc was an extract from the user-level ISA that was put out because the ABI supported by the tools was changed in-between ISA releases. The v2.1 spec contains the most up to date and complete ABI specification.

[t.p.northover]

I think everything here looks reasonable now. I only had a minor comment though so it may be good to check others are happy.

[asb]

Refresh patch to follow the changes made to other backends in rL283702, moving TheRISCV32Target and TheRISCV64Target behind an accessor function.

CMakeLists.txt

set(LLVM_ALL_TARGETS
   AMDGPU
   ARM
   BPF
   Hexagon
   Mips
   MSP430
   NVPTX
   PowerPC
+  RISCV
   Sparc
   SystemZ
   X86
   XCore
   )
 
 # List of targets with JIT support:
 set(LLVM_TARGETS_WITH_JIT X86 PowerPC AArch64 ARM Mips SystemZ)

lib/Target/LLVMBuild.txt

  AVR
  BPF
  Lanai
  Hexagon
  MSP430
  NVPTX
  Mips
  PowerPC
+ RISCV
  Sparc
  SystemZ
  WebAssembly
  X86
  XCore
 
 ; This is a special group whose required libraries are extended (by llvm-build)
 ; with the best execution engine (the native JIT, if available, or the

lib/Target/RISCV/CMakeLists.txt

+add_llvm_target(RISCVCodeGen
+  RISCVTargetMachine.cpp
+  )
+
+add_subdirectory(TargetInfo)

lib/Target/RISCV/LLVMBuild.txt

+;===- ./lib/Target/RISCV/LLVMBuild.txt -------------------------*- Conf -*--===;
+;
+;                     The LLVM Compiler Infrastructure
+;
+; This file is distributed under the University of Illinois Open Source
+; License. See LICENSE.TXT for details.
+;
+;===------------------------------------------------------------------------===;
+;
+; This is an LLVMBuild description file for the components in this subdirectory.
+;
+; For more information on the LLVMBuild system, please see:
+;
+;   http://llvm.org/docs/LLVMBuild.html
+;
+;===------------------------------------------------------------------------===;
+
+[common]
+subdirectories = TargetInfo
+
+[component_0]
+type = TargetGroup
+name = RISCV
+parent = Target
+
+[component_1]
+type = Library
+name = RISCVCodeGen
+parent = RISCV
+required_libraries = Core CodeGen RISCVInfo Support Target
+add_to_library_groups = RISCV

lib/Target/RISCV/RISCVTargetMachine.h

+//===-- RISCVTargetMachine.h - Define TargetMachine for RISCV ---*- C++ -*-===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This file declares the RISCV specific subclass of TargetMachine.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIB_TARGET_RISCV_RISCVTARGETMACHINE_H
+#define LLVM_LIB_TARGET_RISCV_RISCVTARGETMACHINE_H
+
+#include "llvm/CodeGen/SelectionDAGTargetInfo.h"
+#include "llvm/Target/TargetMachine.h"
+#include "llvm/IR/DataLayout.h"
+
+namespace llvm {
+class RISCVTargetMachine : public LLVMTargetMachine {
+  std::unique_ptr<TargetLoweringObjectFile> TLOF;
+
+public:
+  RISCVTargetMachine(const Target &T, const Triple &TT, StringRef CPU,
+                     StringRef FS, const TargetOptions &Options,
+                     Optional<Reloc::Model> RM, CodeModel::Model CM,
+                     CodeGenOpt::Level OL);
+
+  TargetPassConfig *createPassConfig(PassManagerBase &PM) override;
+
+  TargetLoweringObjectFile *getObjFileLowering() const override {
+    return TLOF.get();
+  }
+};
+extern Target TheRISCV32Target, TheRISCV64Target;
+}
+
+#endif

lib/Target/RISCV/RISCVTargetMachine.cpp

+//===-- RISCVTargetMachine.cpp - Define TargetMachine for RISCV -----------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// Implements the info about RISCV target spec.
+//
+//===----------------------------------------------------------------------===//
+
+#include "RISCVTargetMachine.h"
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/CodeGen/TargetLoweringObjectFileImpl.h"
+#include "llvm/CodeGen/TargetPassConfig.h"
+#include "llvm/IR/LegacyPassManager.h"
+#include "llvm/CodeGen/Passes.h"
+#include "llvm/Support/FormattedStream.h"
+#include "llvm/Support/TargetRegistry.h"
+#include "llvm/Target/TargetOptions.h"
+using namespace llvm;
+
+extern "C" void LLVMInitializeRISCVTarget() {
+  RegisterTargetMachine<RISCVTargetMachine> X(TheRISCV32Target);
+  RegisterTargetMachine<RISCVTargetMachine> Y(TheRISCV64Target);
+}
+
+static std::string computeDataLayout(const Triple &TT) {
+  if (TT.isArch64Bit())
+    return "e-m:e-i64:64-n32:64-S128";
+  else
+    return "e-m:e-i64:64-n32-S128";
+}
+
+static Reloc::Model getEffectiveRelocModel(const Triple &TT,
+                                           Optional<Reloc::Model> RM) {
+  if (!RM.hasValue())
+    return Reloc::PIC_;
+  return *RM;
+}
+
+RISCVTargetMachine::RISCVTargetMachine(const Target &T, const Triple &TT,
+                                       StringRef CPU, StringRef FS,
+                                       const TargetOptions &Options,
+                                       Optional<Reloc::Model> RM,
+                                       CodeModel::Model CM,
+                                       CodeGenOpt::Level OL)
+    : LLVMTargetMachine(T, computeDataLayout(TT), TT, CPU, FS, Options,
+                        getEffectiveRelocModel(TT, RM), CM, OL),
+      TLOF(make_unique<TargetLoweringObjectFileELF>()) {}
+
+TargetPassConfig *RISCVTargetMachine::createPassConfig(PassManagerBase &PM) {
+  return new TargetPassConfig(this, PM);
+}

lib/Target/RISCV/TargetInfo/CMakeLists.txt

+add_llvm_library(LLVMRISCVInfo
+  RISCVTargetInfo.cpp
+  )

lib/Target/RISCV/TargetInfo/LLVMBuild.txt

+;===- ./lib/Target/RISCV/TargetInfo/LLVMBuild.txt --------------*- Conf -*--===;
+;
+;                     The LLVM Compiler Infrastructure
+;
+; This file is distributed under the University of Illinois Open Source
+; License. See LICENSE.TXT for details.
+;
+;===------------------------------------------------------------------------===;
+;
+; This is an LLVMBuild description file for the components in this subdirectory.
+;
+; For more information on the LLVMBuild system, please see:
+;
+;   http://llvm.org/docs/LLVMBuild.html
+;
+;===------------------------------------------------------------------------===;
+
+[component_0]
+type = Library
+name = RISCVInfo
+parent = RISCV
+required_libraries = Support
+add_to_library_groups = RISCV

lib/Target/RISCV/TargetInfo/RISCVTargetInfo.cpp

+//===-- RISCVTargetInfo.cpp - RISCV Target Implementation -----------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/Support/TargetRegistry.h"
+using namespace llvm;
+
+namespace llvm {
+Target TheRISCV32Target;
+Target TheRISCV64Target;
+}
+
+extern "C" void LLVMInitializeRISCVTargetInfo() {
+  RegisterTarget<Triple::riscv32> X(TheRISCV32Target, "riscv32",
+                                    "32-bit RISC-V");
+  RegisterTarget<Triple::riscv64> Y(TheRISCV64Target, "riscv64",
+                                    "64-bit RISC-V");
+}
+
+// FIXME: Temporary stub - this function must be defined for linking
+// to succeed. Remove once this function is properly implemented.
+extern "C" void LLVMInitializeRISCVTargetMC() {}