Page MenuHomePhabricator

Remove RISCV from LLVM_ALL_TARGETS in CMakeLists.txt
ClosedPublic

Authored by asb on Aug 9 2017, 12:07 PM.

Details

Summary

It was mistakenly added to that list in D23560 (committed in rL285712). RISCV is an experimental backend and should never have been in that list, I mistakenly interpreted LLVM_ALL_TARGETS as a list of all targets rather than targets to build by default. Unfortunately, because of this the RISCV backend has been building by default when it shouldn't be.

Please see my message to llvm-dev for more info and analysis.

Diff Detail

Repository
rL LLVM

Event Timeline

asb created this revision.Aug 9 2017, 12:07 PM
asb edited the summary of this revision. (Show Details)Aug 9 2017, 12:15 PM
emaste added a subscriber: emaste.Aug 9 2017, 12:16 PM

Adding the comment above the list seems like a good idea to me.

seems very reasonable to me

hans accepted this revision.Aug 9 2017, 12:51 PM

Looks good to me.

This revision is now accepted and ready to land.Aug 9 2017, 12:51 PM
This revision was automatically updated to reflect the committed changes.