We should not optimize it in D158062. This adds the test coverage.
And unneeded attributes nonnull and inbounds are removed.
Paths
| Differential D159530
[RISCV] Add tests for memory constraint A ClosedPublic Authored by wangpc on Sep 18 2023, 10:25 PM.
Details Summary We should not optimize it in D158062. This adds the test coverage. And unneeded attributes nonnull and inbounds are removed.
Diff Detail
Event Timelinewangpc added a child revision: D158062: [RISCV] Teach RISCVMergeBaseOffset to handle inline asm.Sep 18 2023, 10:25 PM Comment Actions LGTM, one minor nit. You're consistent with other tests in this file with using nonnull and inbounds, but I'd typically drop any attributes that don't alter the output of the test. This revision is now accepted and ready to land.Sep 19 2023, 4:19 AM This revision was landed with ongoing or failed builds.Sep 19 2023, 4:56 AM Closed by commit rG61d819dd52f8: [RISCV] Add tests for memory constraint A (authored by wangpc). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions Read the banner at the top of every Phabricator page. New revisions should be submitted via GitHub. Comment Actions
Yes, but I think this was posted here rather than as a PR as it's a pre-requisite for a patch that had already started review on Phabricator. So it seems reasonable enough in this instance. Comment Actions
Oh, I thought I had checked for the Stack button as I guessed that might be the case, but seems I managed to miss it. My bad.
Revision Contents
Diff 557032 llvm/test/CodeGen/RISCV/inline-asm-mem-constraint.ll
|