This is an archive of the discontinued LLVM Phabricator instance.

Differential D159004

[libc++abi][VE] Support VE in long double demangler
ClosedPublic

Authored by kaz7 on Aug 28 2023, 9:32 AM.

Details

Reviewers
efocht
MaskRay
jdoerfert
awarzynski
ldionne
libcxx-commits
Group Reviewers
Restricted Project
Commits
rGe0c54a2e7b9c: [libc++abi][VE] Support VE in long double demangler
Summary

Support VE in long double demangler. This patch corrects
libcxxabi/test/test_demangle.pass.cpp on VE.

Diff Detail

Event Timeline

kaz7 created this revision.Aug 28 2023, 9:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 9:32 AM
Herald added subscribers: s.egerton, simoncook, asb. · View Herald Transcript
kaz7 requested review of this revision.Aug 28 2023, 9:32 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2023, 9:32 AM
Herald added subscribers: libcxx-commits, wangpc, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B255248: Diff 553967.Aug 28 2023, 11:56 AM
kaz7 updated this revision to Diff 555585.Sep 2 2023, 4:54 AM

Add [libc++abi]

kaz7 retitled this revision from [VE] Support VE in long double demangler to [libc++abi][VE] Support VE in long double demangler.Sep 2 2023, 4:55 AM
kaz7 added reviewers: ldionne, libcxx-commits.
MaskRay accepted this revision.Sep 3 2023, 4:41 PM

llvm/include/llvm/Demangle/ItaniumDemangle.h has a copy of struct FloatData<long double> that should be changed as well.

kaz7 added a comment.Sep 4 2023, 5:22 PM
In D159004#4636421, @MaskRay wrote:

llvm/include/llvm/Demangle/ItaniumDemangle.h has a copy of struct FloatData<long double> that should be changed as well.

Thank you so much. I didn't notice that.

kaz7 updated this revision to Diff 555780.Sep 4 2023, 5:23 PM

Update llvm/include/llvm/Demangle/ItaniumDemangle.h too.

Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2023, 5:23 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kaz7 added a comment.Sep 12 2023, 7:13 PM

ping. Is it possible to get approval from libc++abi group? Thanks in advance.

ldionne accepted this revision.Sep 13 2023, 3:25 PM
This revision is now accepted and ready to land.Sep 13 2023, 3:25 PM
This revision was landed with ongoing or failed builds.Sep 13 2023, 4:12 PM
Closed by commit rGe0c54a2e7b9c: [libc++abi][VE] Support VE in long double demangler (authored by kaz7). · Explain Why
This revision was automatically updated to reflect the committed changes.
kaz7 added a commit: rGe0c54a2e7b9c: [libc++abi][VE] Support VE in long double demangler.

Revision Contents

PathSize
libcxxabi/
src/
demangle/
3 lines
llvm/
include/
llvm/
Demangle/
3 lines

Diff 556730

libcxxabi/src/demangle/ItaniumDemangle.h

Show First 20 Lines • Show All 5,128 Lines • ▼ Show 20 Linesstruct FloatData<double>
static const size_t max_demangled_size = 32; static const size_t max_demangled_size = 32;
static constexpr const char* spec = "%a"; static constexpr const char* spec = "%a";
}; };
template <> template <>
struct FloatData<long double> struct FloatData<long double>
{ {
#if defined(__mips__) && defined(__mips_n64) || defined(__aarch64__) || \ #if defined(__mips__) && defined(__mips_n64) || defined(__aarch64__) || \
defined(__wasm__) || defined(__riscv) || defined(__loongarch__) defined(__wasm__) || defined(__riscv) || defined(__loongarch__) || \
defined(__ve__)
static const size_t mangled_size = 32; static const size_t mangled_size = 32;
#elif defined(__arm__) || defined(__mips__) || defined(__hexagon__) #elif defined(__arm__) || defined(__mips__) || defined(__hexagon__)
static const size_t mangled_size = 16; static const size_t mangled_size = 16;
#else #else
static const size_t mangled_size = 20; // May need to be adjusted to 16 or 24 on other platforms static const size_t mangled_size = 20; // May need to be adjusted to 16 or 24 on other platforms
#endif #endif
// `-0x1.ffffffffffffffffffffffffffffp+16383` + 'L' + '\0' == 42 bytes. // `-0x1.ffffffffffffffffffffffffffffp+16383` + 'L' + '\0' == 42 bytes.
// 28 'f's * 4 bits == 112 bits, which is the number of mantissa bits. // 28 'f's * 4 bits == 112 bits, which is the number of mantissa bits.
▲ Show 20 Lines • Show All 375 Lines • Show Last 20 Lines

llvm/include/llvm/Demangle/ItaniumDemangle.h

Show First 20 Lines • Show All 5,123 Lines • ▼ Show 20 Linesstruct FloatData<double>
static const size_t max_demangled_size = 32; static const size_t max_demangled_size = 32;
static constexpr const char* spec = "%a"; static constexpr const char* spec = "%a";
}; };
template <> template <>
struct FloatData<long double> struct FloatData<long double>
{ {
#if defined(__mips__) && defined(__mips_n64) || defined(__aarch64__) || \ #if defined(__mips__) && defined(__mips_n64) || defined(__aarch64__) || \
defined(__wasm__) || defined(__riscv) || defined(__loongarch__) defined(__wasm__) || defined(__riscv) || defined(__loongarch__) || \
defined(__ve__)
static const size_t mangled_size = 32; static const size_t mangled_size = 32;
#elif defined(__arm__) || defined(__mips__) || defined(__hexagon__) #elif defined(__arm__) || defined(__mips__) || defined(__hexagon__)
static const size_t mangled_size = 16; static const size_t mangled_size = 16;
#else #else
static const size_t mangled_size = 20; // May need to be adjusted to 16 or 24 on other platforms static const size_t mangled_size = 20; // May need to be adjusted to 16 or 24 on other platforms
#endif #endif
// `-0x1.ffffffffffffffffffffffffffffp+16383` + 'L' + '\0' == 42 bytes. // `-0x1.ffffffffffffffffffffffffffffp+16383` + 'L' + '\0' == 42 bytes.
// 28 'f's * 4 bits == 112 bits, which is the number of mantissa bits. // 28 'f's * 4 bits == 112 bits, which is the number of mantissa bits.
▲ Show 20 Lines • Show All 371 Lines • Show Last 20 Lines