Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

[libc++abi][VE] Support VE in long double demangler
ClosedPublic
Actions

Authored by kaz7 on Aug 28 2023, 9:32 AM.

Details

Reviewers

efocht
MaskRay
jdoerfert
awarzynski
ldionne
libcxx-commits

Group Reviewers

Restricted Project

Commits

rGe0c54a2e7b9c: [libc++abi][VE] Support VE in long double demangler

Summary

Support VE in long double demangler. This patch corrects
libcxxabi/test/test_demangle.pass.cpp on VE.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kaz7 created this revision.Aug 28 2023, 9:32 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 9:32 AM

Herald added subscribers: s.egerton, simoncook, asb. · View Herald Transcript

kaz7 requested review of this revision.Aug 28 2023, 9:32 AM

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2023, 9:32 AM

Herald added subscribers: libcxx-commits, wangpc, aheejin. · View Herald Transcript

Harbormaster completed remote builds in B255248: Diff 553967.Aug 28 2023, 11:56 AM

Add [libc++abi]

kaz7 retitled this revision from [VE] Support VE in long double demangler to [libc++abi][VE] Support VE in long double demangler.Sep 2 2023, 4:55 AM

kaz7 added reviewers: ldionne, libcxx-commits.

llvm/include/llvm/Demangle/ItaniumDemangle.h has a copy of struct FloatData<long double> that should be changed as well.

In D159004#4636421, @MaskRay wrote:

llvm/include/llvm/Demangle/ItaniumDemangle.h has a copy of struct FloatData<long double> that should be changed as well.

Thank you so much. I didn't notice that.

Update llvm/include/llvm/Demangle/ItaniumDemangle.h too.

Herald added a project: Restricted Project. · View Herald TranscriptMon, Sep 4, 5:23 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

ping. Is it possible to get approval from libc++abi group? Thanks in advance.

ldionne accepted this revision.Wed, Sep 13, 3:25 PM

This revision is now accepted and ready to land.Wed, Sep 13, 3:25 PM

This revision was landed with ongoing or failed builds.Wed, Sep 13, 4:12 PM

Closed by commit rGe0c54a2e7b9c: [libc++abi][VE] Support VE in long double demangler (authored by kaz7). · Explain Why

This revision was automatically updated to reflect the committed changes.

kaz7 added a commit: rGe0c54a2e7b9c: [libc++abi][VE] Support VE in long double demangler.

Revision Contents
Changeset List

Path

Size

libcxxabi/

src/

demangle/

ItaniumDemangle.h

3 lines

llvm/

include/

llvm/

Demangle/

ItaniumDemangle.h

3 lines

Diff 556730

View Options

libcxxabi/src/demangle/ItaniumDemangle.h