Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[libc++abi][VE] Support VE in long double demangler
ClosedPublic

Authored by kaz7 on Aug 28 2023, 9:32 AM.

Details

Summary

Support VE in long double demangler. This patch corrects
libcxxabi/test/test_demangle.pass.cpp on VE.

Diff Detail

Event Timeline

kaz7 created this revision.Aug 28 2023, 9:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2023, 9:32 AM
kaz7 requested review of this revision.Aug 28 2023, 9:32 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2023, 9:32 AM
kaz7 updated this revision to Diff 555585.Sep 2 2023, 4:54 AM

Add [libc++abi]

kaz7 retitled this revision from [VE] Support VE in long double demangler to [libc++abi][VE] Support VE in long double demangler.Sep 2 2023, 4:55 AM
kaz7 added reviewers: ldionne, libcxx-commits.
MaskRay accepted this revision.Sep 3 2023, 4:41 PM

llvm/include/llvm/Demangle/ItaniumDemangle.h has a copy of struct FloatData<long double> that should be changed as well.

kaz7 added a comment.Mon, Sep 4, 5:22 PM

llvm/include/llvm/Demangle/ItaniumDemangle.h has a copy of struct FloatData<long double> that should be changed as well.

Thank you so much. I didn't notice that.

kaz7 updated this revision to Diff 555780.Mon, Sep 4, 5:23 PM

Update llvm/include/llvm/Demangle/ItaniumDemangle.h too.

Herald added a project: Restricted Project. · View Herald TranscriptMon, Sep 4, 5:23 PM
kaz7 added a comment.Tue, Sep 12, 7:13 PM

ping. Is it possible to get approval from libc++abi group? Thanks in advance.

ldionne accepted this revision.Wed, Sep 13, 3:25 PM
This revision is now accepted and ready to land.Wed, Sep 13, 3:25 PM
This revision was landed with ongoing or failed builds.Wed, Sep 13, 4:12 PM
This revision was automatically updated to reflect the committed changes.