This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy][readability] add Leading_upper_snake_case
ClosedPublic

Authored by MasterCopy8GB on Aug 24 2023, 3:19 PM.

Details

Summary

Add Leading_upper_snake_case to IdentifierNamingCheck naming convention.

Fixes #42451

Diff Detail

Event Timeline

MasterCopy8GB created this revision.Aug 24 2023, 3:19 PM
Herald added a project: Restricted Project. · View Herald Transcript
MasterCopy8GB requested review of this revision.Aug 24 2023, 3:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 3:19 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
  • Missing documentation entry about this style.
  • Missing release notes entry
  • Commit title / description should be more in line with style used in project
MasterCopy8GB retitled this revision from llvm-project/issues/42451 to [clang-tidy].Aug 24 2023, 3:40 PM
MasterCopy8GB edited the summary of this revision. (Show Details)
MasterCopy8GB retitled this revision from [clang-tidy] to [clang-tidy][readability] add Leading_upper_snake_case.Aug 24 2023, 4:06 PM
MasterCopy8GB edited the summary of this revision. (Show Details)

Update documentation

PiotrZSL added inline comments.Aug 25 2023, 12:28 AM
clang-tools-extra/docs/ReleaseNotes.rst
116–118

Wrong section, add it under "Changes in existing checks".
Leading_upper_snake_case -> Leading_upper_snake_case.
allow for -> support

clang-tools-extra/docs/clang-tidy/checks/readability/identifier-naming.rst
2107

do not change this, this (an changes in line ~2121) is for a lower_case scenario...
Add some other example or explanation around line 33.

And add reference to issue in commit description.

Eugene.Zelenko set the repository for this revision to rG LLVM Github Monorepo.
MasterCopy8GB retitled this revision from [clang-tidy][readability] add Leading_upper_snake_case to [clang-tidy][readability] add Leading_upper_snake_case issue 42451.Aug 25 2023, 8:02 AM
MasterCopy8GB edited the summary of this revision. (Show Details)

Update documentation for issue 42451

Update diff with complete patch

Upload full path to avoid "Context not available."

clang-tools-extra/docs/ReleaseNotes.rst
256

put this entry in alphabetical order

257

wrong name, such file does not exist

257–258

this message now says nothing... rephrase tis correctly... instead of just blindly copying text.

clang-tools-extra/docs/clang-tidy/checks/readability/identifier-naming.rst
34

put name into double `

PiotrZSL retitled this revision from [clang-tidy][readability] add Leading_upper_snake_case issue 42451 to [clang-tidy][readability] add Leading_upper_snake_case.Aug 25 2023, 9:38 AM
PiotrZSL edited the summary of this revision. (Show Details)
PiotrZSL set the repository for this revision to rG LLVM Github Monorepo.

Fix documentation comments

PiotrZSL added inline comments.Aug 25 2023, 1:14 PM
clang-tools-extra/docs/ReleaseNotes.rst
240–245

There is already entry for this check, so just add it to previous:

warnings when a type forward declaration precedes its definition and
added support for ``Leading_upper_snake_case`` naming convention.
PiotrZSL accepted this revision.Aug 25 2023, 1:15 PM

After you update release notes entry, it could land...

This revision is now accepted and ready to land.Aug 25 2023, 1:15 PM

Combine readability-identifier-naming improvements in release notes

PiotrZSL accepted this revision.Aug 25 2023, 1:29 PM
MasterCopy8GB accepted this revision.Aug 28 2023, 8:33 AM

Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort!

Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort!

Under which user ? Name / Email ?

Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort!

Under which user ? Name / Email ?

MasterCopy8GB / gdayman007@hotmail.com Please

This revision was automatically updated to reflect the committed changes.