[clang-tidy][readability] add Leading_upper_snake_case

[MasterCopy8GB]

Summary

Add Leading_upper_snake_case to IdentifierNamingCheck naming convention.

Fixes #42451

[PiotrZSL]

• Missing documentation entry about this style.
• Missing release notes entry
• Commit title / description should be more in line with style used in project

[MasterCopy8GB]

Update documentation

[PiotrZSL]

clang-tools-extra/docs/ReleaseNotes.rst

116–118

Wrong section, add it under "Changes in existing checks".
Leading_upper_snake_case -> Leading_upper_snake_case.
allow for -> support

clang-tools-extra/docs/clang-tidy/checks/readability/identifier-naming.rst

2107

do not change this, this (an changes in line ~2121) is for a lower_case scenario...
Add some other example or explanation around line 33.

[PiotrZSL]

And add reference to issue in commit description.

[MasterCopy8GB]

Update documentation for issue 42451

[MasterCopy8GB]

Update diff with complete patch

[PiotrZSL]

Upload full path to avoid "Context not available."

clang-tools-extra/docs/ReleaseNotes.rst

256

put this entry in alphabetical order

257

wrong name, such file does not exist

257–258

this message now says nothing... rephrase tis correctly... instead of just blindly copying text.

clang-tools-extra/docs/clang-tidy/checks/readability/identifier-naming.rst

34

put name into double `

[MasterCopy8GB]

Fix documentation comments

[PiotrZSL]

clang-tools-extra/docs/ReleaseNotes.rst

240–245

There is already entry for this check, so just add it to previous:

warnings when a type forward declaration precedes its definition and
added support for ``Leading_upper_snake_case`` naming convention.

[PiotrZSL]

After you update release notes entry, it could land...

[MasterCopy8GB]

Combine readability-identifier-naming improvements in release notes

[MasterCopy8GB]

Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort!

[PiotrZSL]

In D158787#4621587, @MasterCopy8GB wrote:

Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort!

Under which user ? Name / Email ?

[MasterCopy8GB]

In D158787#4621915, @PiotrZSL wrote:

In D158787#4621587, @MasterCopy8GB wrote:

Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort!

Under which user ? Name / Email ?

MasterCopy8GB / [e-mail] Please

clang-tools-extra/docs/ReleaseNotes.rst

- Preprocessor-level module header parsing is now disabled by default due to
   functionality using the newly added command line option
   `--enable-module-headers-parsing`.
 
 - Remove configuration option `AnalyzeTemporaryDestructors`, which was deprecated since
   :program:`clang-tidy` 16.
 
 - Improved `--dump-config` to print check options in alphabetical order.
 
-- Improved :doc:`readability-identifier-naming
-  <clang-tidy/checks/readability/IdentifierNamingCheck>` check to allow for
-  Leading_upper_snake_case naming convention.
-
 New checks
 ^^^^^^^^^^
 
 - New :doc:`bugprone-inc-dec-in-conditions
   <clang-tidy/checks/bugprone/inc-dec-in-conditions>` check.
 
   Detects when a variable is both incremented/decremented and referenced inside
   a complex condition and suggests moving them outside to avoid ambiguity in
   the variable's value.
 
 - New :doc:`bugprone-incorrect-enable-if
- Improved :doc:`readability-braces-around-statements
   <clang-tidy/checks/readability/braces-around-statements>` check to
   ignore false-positive for ``if constexpr`` in lambda expression.
 
 - Improved :doc:`readability-container-size-empty
   <clang-tidy/checks/readability/container-size-empty>` check to
   detect comparison between string and empty string literals.
 
 - Improved :doc:`readability-identifier-naming
   <clang-tidy/checks/readability/identifier-naming>` check to emit proper
   warnings when a type forward declaration precedes its definition.
 
 - Improved :doc:`readability-implicit-bool-conversion
   <clang-tidy/checks/readability/implicit-bool-conversion>` check to take
   do-while loops into account for the `AllowIntegerConditions` and
   `AllowPointerConditions` options.
 
 - Improved :doc:`readability-non-const-parameter
   <clang-tidy/checks/readability/non-const-parameter>` check to ignore
   false-positives in initializer list of record.
 
 - Improved :doc:`readability-static-accessed-through-instance
   <clang-tidy/checks/readability/static-accessed-through-instance>` check to
   identify calls to static member functions with out-of-class inline definitions.
 
+- Improved :doc:`readability-identifier-naming
+  <clang-tidy/checks/readability/IdentifierNamingCheck>` Leading_upper_snake_case ->
+  Leading_upper_snake_case. allow for -> support
+
 Removed checks
 ^^^^^^^^^^^^^^
 
 Improvements to include-fixer
 -----------------------------
 
 The improvements are...
 

clang-tools-extra/docs/clang-tidy/checks/readability/identifier-naming.rst

 Many configuration options are available, in order to be able to create
 different rules for different kinds of identifiers. In general, the rules are
 falling back to a more generic rule if the specific case is not configured.
 
 The naming of virtual methods is reported where they occur in the base class,
 but not where they are overridden, as it can't be fixed locally there.
 This also applies for pseudo-override patterns like CRTP.
 
+Leading_upper_snake_case is a naming convention where the first word is capitalized
+followed by lower case word(s) seperated by underscore(s) '_'. Examples include:
+Cap_snake_case, Cobra_case, Foo_bar_baz, and Master_copy_8gb.
+
 Options
 -------
 
 The following options are described below:
 
  - :option:`AbstractClassCase`, :option:`AbstractClassPrefix`, :option:`AbstractClassSuffix`, :option:`AbstractClassIgnoredRegexp`, :option:`AbstractClassHungarianPrefix`
  - :option:`AggressiveDependentMemberLookup`
  - :option:`ClassCase`, :option:`ClassPrefix`, :option:`ClassSuffix`, :option:`ClassIgnoredRegexp`, :option:`ClassHungarianPrefix`

 
 .. option:: StructSuffix
 
     When defined, the check will ensure struct names will add the
     suffix with the given value (regardless of casing).
 
 For example using values of:
 
-   - StructCase of ``Leading_upper_snake_case``
+   - StructCase of ``lower_case``
    - StructPrefix of ``pre_``
    - StructSuffix of ``_post``
 
 Identifies and/or transforms struct names as follows:
 
 Before:
 
 .. code-block:: c++
 
     struct FOO {
       FOO();
       ~FOO();
     };
 
 After:
 
 .. code-block:: c++
 
-    struct pre_Foo_post {
-      pre_Foo_post();
-      ~pre_Foo_post();
+    struct pre_foo_post {
+      pre_foo_post();
+      ~pre_foo_post();
     };
 
 .. option:: TemplateParameterCase
 
     When defined, the check will ensure template parameter names conform to the
     selected casing.
 
 .. option:: TemplateParameterPrefix