This is an archive of the discontinued LLVM Phabricator instance.

[flang] Fix testing and checking for endianness for PPC vector intrinsics
ClosedPublic

Authored by kkwli0 on Aug 17 2023, 8:21 AM.

Details

Diff Detail

Event Timeline

kkwli0 created this revision.Aug 17 2023, 8:21 AM
kkwli0 requested review of this revision.Aug 17 2023, 8:21 AM
DanielCChen added inline comments.Aug 17 2023, 8:43 AM
flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
2606–2607

This should use the triple checking too.

flang/test/Lower/PowerPC/ppc-vec-extract-elem-order.f90
1–2

Nit: for the rest of the test, the %s is after -emit-fir

2

Nit: for the rest of the test, the %s is after -emit-llvm

flang/test/Lower/PowerPC/ppc-vec-insert-elem-order.f90
2

Nit: for the rest of the test, the %s is after -emit-llvm

kkwli0 marked 4 inline comments as done.Aug 17 2023, 2:21 PM
kkwli0 added inline comments.
flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
2606–2607

Will change it.

kkwli0 updated this revision to Diff 551267.Aug 17 2023, 2:21 PM
kkwli0 marked an inline comment as done.

Address review comments

This revision is now accepted and ready to land.Aug 18 2023, 5:35 AM
flang/test/Lower/PowerPC/ppc-vec-merge-elem-order.f90