In D154869#4628847, @efriedma wrote:

Maybe split the changes to reformat the unittests into a separate patch?

Otherwise, I'm happy with the current state of this patch, but probably someone more active in flang should approve.

Using the Project_SOURCE_DIR variable in cmake instead of setting a new variable

Pinging for review. I will be taking over this patch from Paul, but Paul will still be around to answer any questions.

Thanks for the review, addressing review comments.

Ping.

This patch focuses on the lowering required to support cray pointer, a quick look at cray pointer use in module indicated that lowering sequence will not need to be changed but the getPointer method will need to look at the pointer-pointee map in the module scope. We will submit a separate patch for the module support if the reviewers are okay with it.

Ping

Fix Clang-Format Issues

Spelling out auto as suggested.

Thanks for the review.

addressing style mismatch in flang/include/flang/Tools/CLOptions.inc

Bug Fix for failing test cases

clang-format issue in ExternalNameConversion.cpp

Addressing the review comments relating to the test case. Thanks for the catch!

Rebase, as well as bug fix relating to the ExternalNameConversion pass option that was exposed by the requested fir-opt test case. The pass option was being overwritten by default value whenever it was called through fir-opt.

Addressing review comment

Implementing functionality to control just the trailing underscore for external names to achieve similar functionality to the option in gfortran, as well as rebase and address review comments.

Rebase.

Ping.

Add the new triple to flang/test/Fir/target-rewrite-complex.fir as requested. Changed the existing PPC label to be PPC64le and added PPC64 label for the new triple. This is to avoid future confusion with ppc 32 bit.

Adding comment as requested

AIX was not on the target list for flang so it had to be added before answering your question. If those functions are required at compile time it results in a semantic error as these float bessel functions cannot be folded. If these functions are required at runtime it results in a undefined symbol linker error as it looks for jnf but cannot resolve it as it was taken out in order to be able to build.

Addressed latest comment

Addressing review comments and clang-format

I need some help to commit this change as I do not have commit access as of now.

Adding comment in gcc-flag-compatibility.c indicating that testing for AIX is done in gcc-flag-compatibility-aix.c as suggested