[clang-tidy]mark record initList as non-const param

[HerrCai0907]

Summary

struct XY {
  int *x;
  int *y;
};
void recordInitList(int *x) {
  XY xy = {x, nullptr};
}

x cannot be const int* becase it in a initialize list which only accept int*

[HerrCai0907]

add release note

[Eugene.Zelenko]

clang-tools-extra/docs/ReleaseNotes.rst

252

Please keep alphabetical order (by check name) in this section.

[HerrCai0907]

update release note

[PiotrZSL]

clang-tools-extra/docs/ReleaseNotes.rst

244

[HerrCai0907]

fix typo

[PiotrZSL]

LGTM, but note that type aliases may not work properly, but that more a legacy issue that got source in line 104, simply because we should use canonical type there.

clang-tools-extra/test/clang-tidy/checkers/readability/non-const-parameter.cpp

235

Add a test with XYConst hidden behind typedef.
like

typedef XYConst XYConstTypedef;
XYConstTypedef yz = {x};

[HerrCai0907]

add test

clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp

if (const auto *Parm = Result.Nodes.getNodeAs<ParmVarDecl>("Parm")) {
     } else if (const auto *R = dyn_cast<ReturnStmt>(S)) {
       markCanNotBeConst(R->getRetValue(), true);
     } else if (const auto *U = dyn_cast<UnaryOperator>(S)) {
       markCanNotBeConst(U, true);
     }
   } else if (const auto *VD = Result.Nodes.getNodeAs<VarDecl>("Mark")) {
     const QualType T = VD->getType();
     if ((T->isPointerType() && !T->getPointeeType().isConstQualified()) ||
-        T->isArrayType())
+        T->isArrayType() || T->isRecordType())
       markCanNotBeConst(VD->getInit(), true);
     else if (T->isLValueReferenceType() &&
              !T->getPointeeType().isConstQualified())
       markCanNotBeConst(VD->getInit(), false);
   }
 }
 
 void NonConstParameterCheck::addParm(const ParmVarDecl *Parm) {

clang-tools-extra/docs/ReleaseNotes.rst

- Improved :doc:`readability-identifier-naming
   <clang-tidy/checks/readability/identifier-naming>` check to emit proper
   warnings when a type forward declaration precedes its definition.
 
 - Improved :doc:`readability-implicit-bool-conversion
   <clang-tidy/checks/readability/implicit-bool-conversion>` check to take
   do-while loops into account for the `AllowIntegerConditions` and
   `AllowPointerConditions` options.
 
+- Improved :doc:`readability-non-const-parameter
+  <clang-tidy/checks/readability/non-const-parameter>` check to ignore
+  false-positives in initializer list of record.
+
 - Improved :doc:`readability-static-accessed-through-instance
   <clang-tidy/checks/readability/static-accessed-through-instance>` check to
   identify calls to static member functions with out-of-class inline definitions.
 
 Removed checks
 ^^^^^^^^^^^^^^
 
 Improvements to include-fixer
 -----------------------------
 
 The improvements are...
 
 Improvements to clang-include-fixer

clang-tools-extra/test/clang-tidy/checkers/readability/non-const-parameter.cpp

 // Don't warn about nonconst record pointers that can be const.
 struct XY {
   int *x;
   int *y;
 };
 void recordpointer(struct XY *xy) {
   *(xy->x) = 0;
 }
+void recordInitList(int *x) {
+  XY xy = {x, nullptr};
+}
+
+struct XYConst {
+  int const *x;
+};
+// CHECK-MESSAGES: :[[@LINE+1]]:30: warning: pointer parameter 'x' can be pointer to const
+void recordInitListDiag(int *x) {
+  // CHECK-FIXES: {{^}}void recordInitListDiag(const int *x) {{{$}}
+  XYConst xy = {x};
+}
+typedef XYConst XYConstAlias;
+// CHECK-MESSAGES: :[[@LINE+1]]:35: warning: pointer parameter 'x' can be pointer to const
+void recordInitListAliasDiag(int *x) {
+  // CHECK-FIXES: {{^}}void recordInitListAliasDiag(const int *x) {{{$}}
+  XYConstAlias xy = {x};
+}
 
 class C {
 public:
   C(int *p) : p(p) {}
 
 private:
   int *p;
 };