Page MenuHomePhabricator

HerrCai0907 (Congcong Cai)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 31 2022, 12:06 AM (28 w, 6 d)

Recent Activity

Today

HerrCai0907 committed rG696fdece49e5: [WebAssembly] Fix i64_i64_func_i64_i64_i32 type signature when multivalue… (authored by HerrCai0907).
[WebAssembly] Fix i64_i64_func_i64_i64_i32 type signature when multivalue…
Tue, Mar 21, 3:54 PM · Restricted Project, Restricted Project
HerrCai0907 closed D146533: [WebAssembly] Fix i64_i64_func_i64_i64_i32 type signature when multivalue feature is enabled.
Tue, Mar 21, 3:54 PM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D146533: [WebAssembly] Fix i64_i64_func_i64_i64_i32 type signature when multivalue feature is enabled.

rebase

Tue, Mar 21, 9:19 AM · Restricted Project, Restricted Project
HerrCai0907 committed rGec2a726a63e4: [Webassembly][multivalue] update libcall signature for f128 when multivalue… (authored by HerrCai0907).
[Webassembly][multivalue] update libcall signature for f128 when multivalue…
Tue, Mar 21, 9:17 AM · Restricted Project, Restricted Project
HerrCai0907 closed D146499: [Webassembly][multivalue] update libcall signature for f128 when multivalue feature enabled.
Tue, Mar 21, 9:17 AM · Restricted Project, Restricted Project
HerrCai0907 added a reviewer for D146533: [WebAssembly] Fix i64_i64_func_i64_i64_i32 type signature when multivalue feature is enabled: tlively.
Tue, Mar 21, 9:10 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D146533: [WebAssembly] Fix i64_i64_func_i64_i64_i32 type signature when multivalue feature is enabled.

add testcase

Tue, Mar 21, 9:03 AM · Restricted Project, Restricted Project
HerrCai0907 requested review of D146533: [WebAssembly] Fix i64_i64_func_i64_i64_i32 type signature when multivalue feature is enabled.
Tue, Mar 21, 8:36 AM · Restricted Project, Restricted Project

Yesterday

HerrCai0907 requested review of D146499: [Webassembly][multivalue] update libcall signature for f128 when multivalue feature enabled.
Mon, Mar 20, 10:43 PM · Restricted Project, Restricted Project
HerrCai0907 committed rGff937a82f175: [Webassembly][NFC] Fix typo in comment (authored by HerrCai0907).
[Webassembly][NFC] Fix typo in comment
Mon, Mar 20, 10:21 PM · Restricted Project, Restricted Project
HerrCai0907 committed rGd9661d79f466: [Webassembly][multivalue] update libcall signature when multivalue feature… (authored by HerrCai0907).
[Webassembly][multivalue] update libcall signature when multivalue feature…
Mon, Mar 20, 9:26 PM · Restricted Project, Restricted Project
HerrCai0907 closed D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.
Mon, Mar 20, 9:26 PM · Restricted Project, Restricted Project

Sun, Mar 19

HerrCai0907 committed rGfb066c4622c8: [sancov] fix coverage-report-server cannot display coverage detail (authored by HerrCai0907).
[sancov] fix coverage-report-server cannot display coverage detail
Sun, Mar 19, 6:11 AM · Restricted Project, Restricted Project
HerrCai0907 closed D146010: [sancov] fix coverage-report-server cannot display coverage detail.
Sun, Mar 19, 6:10 AM · Restricted Project, Restricted Project

Fri, Mar 17

HerrCai0907 added a reviewer for D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled: tlively.
Fri, Mar 17, 4:15 PM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.

update testcase using utils/update_llc_test_checks.py

Fri, Mar 17, 4:04 PM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.

update comment in testcase

Fri, Mar 17, 8:42 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.

update test, remove description in release note

Fri, Mar 17, 8:39 AM · Restricted Project, Restricted Project

Thu, Mar 16

HerrCai0907 added reviewers for D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled: asb, sbc100.
Thu, Mar 16, 8:43 PM · Restricted Project, Restricted Project
HerrCai0907 requested review of D146271: [Webassembly][multivalue] update libcall signature when multivalue feature enabled.
Thu, Mar 16, 8:19 PM · Restricted Project, Restricted Project
HerrCai0907 added a reviewer for D146010: [sancov] fix coverage-report-server cannot display coverage detail: lattner.
Thu, Mar 16, 5:50 AM · Restricted Project, Restricted Project

Tue, Mar 14

HerrCai0907 updated the diff for D146010: [sancov] fix coverage-report-server cannot display coverage detail.

rebase to main

Tue, Mar 14, 8:19 PM · Restricted Project, Restricted Project
HerrCai0907 added a reviewer for D146010: [sancov] fix coverage-report-server cannot display coverage detail: klimek.
Tue, Mar 14, 4:26 PM · Restricted Project, Restricted Project
HerrCai0907 committed rGe417f02b5159: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag (authored by HerrCai0907).
[SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag
Tue, Mar 14, 10:10 AM · Restricted Project, Restricted Project
HerrCai0907 closed D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.
Tue, Mar 14, 10:10 AM · Restricted Project, Restricted Project
HerrCai0907 added a comment to D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

Hello Erichkeane, I have the access now, maybe I can push it by myself. Thanks again!

Tue, Mar 14, 9:38 AM · Restricted Project, Restricted Project
HerrCai0907 added a comment to D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

HerrCai0907 and congcongcai0907@163.com

Tue, Mar 14, 9:23 AM · Restricted Project, Restricted Project
HerrCai0907 added a comment to D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

I don't have write access now. Could you kindly help me to commit it?

Tue, Mar 14, 9:10 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

rebase to main

Tue, Mar 14, 9:05 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.
Tue, Mar 14, 9:00 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.
Tue, Mar 14, 8:54 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.
Tue, Mar 14, 8:50 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.
Tue, Mar 14, 8:21 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

add release note

Tue, Mar 14, 8:09 AM · Restricted Project, Restricted Project
HerrCai0907 added a comment to D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

Should I add release note in clang/docs/ReleaseNotes.rst or any other way?

Tue, Mar 14, 8:01 AM · Restricted Project, Restricted Project
HerrCai0907 updated the diff for D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

add more testcase

Tue, Mar 14, 7:52 AM · Restricted Project, Restricted Project
HerrCai0907 added a comment to D146010: [sancov] fix coverage-report-server cannot display coverage detail.

I guess ut failed is not related with this PR?

Tue, Mar 14, 2:01 AM · Restricted Project, Restricted Project

Mon, Mar 13

HerrCai0907 requested review of D146010: [sancov] fix coverage-report-server cannot display coverage detail.
Mon, Mar 13, 11:34 PM · Restricted Project, Restricted Project
HerrCai0907 updated the summary of D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.
Mon, Mar 13, 4:59 PM · Restricted Project, Restricted Project
HerrCai0907 added a comment to D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

I cannot find an example that throw error: expression contains unexpanded parameter pack 'T' in fold expression because code like (foo<T>(10 + (static_cast<U>(1))) + ...); can be unpack both T and U in same ... operator

Mon, Mar 13, 4:28 PM · Restricted Project, Restricted Project
HerrCai0907 added a comment to D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.

The idea is that:

  1. If function return an invalid ExprResult, this error should be handled in the callee
  2. If function return valid Expr, the potential error should be handled in the caller, in this case, is ActOnExprStmt. If callee handles error, when caller find some error and want to output error message, the error in this expression has been processed and cause crash.
Mon, Mar 13, 9:08 AM · Restricted Project, Restricted Project
HerrCai0907 added a comment to D145834: typo statment to statement.

Thanks, you can use my name HerrCai0907 (congcongcai0907@163.com) as patch attribution.

Mon, Mar 13, 8:45 AM · Restricted Project, Restricted Project

Sun, Mar 12

HerrCai0907 requested review of D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag.
Sun, Mar 12, 8:01 PM · Restricted Project, Restricted Project

Fri, Mar 10

HerrCai0907 requested review of D145834: typo statment to statement.
Fri, Mar 10, 5:30 PM · Restricted Project, Restricted Project