This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder
ClosedPublic

Authored by TIFitis on Aug 15 2023, 9:34 AM.

Details

Summary

Migrate createForStaticInitFunction, createDispatchInitFunction, createDispatchNextFunction and createDispatchFiniFunction from Clang CodeGen to OMPIRBuilder.

Diff Detail

Event Timeline

TIFitis created this revision.Aug 15 2023, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 9:34 AM
TIFitis requested review of this revision.Aug 15 2023, 9:34 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 15 2023, 9:34 AM
TIFitis added inline comments.Aug 15 2023, 9:40 AM
llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
532 ↗(On Diff #550365)

Clang test llvm/clang/test/OpenMP/ordered_codegen.cpp complains about the presence of NoUnwind attribute for the __kmpc_dispatch_* functions.

This change doesn't seem to break any other test, although I am not sure if we should be creating a new Attr group for the __kmpc_dispatch functions and remove the NoUnwind Attr only there.

jdoerfert accepted this revision.Aug 15 2023, 12:59 PM

LG, but do not remove the Attribute from our set, add it to the tests. The functions are nounwind.

llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
532 ↗(On Diff #550365)

Add nounwind to the tests?

This revision is now accepted and ready to land.Aug 15 2023, 12:59 PM
TIFitis updated this revision to Diff 550729.Aug 16 2023, 6:36 AM

Updated test with correct function attributes.