This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Initialize pointer field
ClosedPublic

Authored by Manna on Aug 15 2023, 7:58 AM.

Diff Detail

Event Timeline

Manna created this revision.Aug 15 2023, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 7:58 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Manna requested review of this revision.Aug 15 2023, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 7:58 AM
tahonermann accepted this revision.Aug 15 2023, 8:27 AM

Looks good to me. I see that OpenMPIRBuilder::emitTargetKernel() can return without having assigned the Return parameter.

This revision is now accepted and ready to land.Aug 15 2023, 8:27 AM
Manna added a comment.Aug 15 2023, 8:38 AM

Thank you @tahonermann for reviews and feedbacks.

This revision was automatically updated to reflect the committed changes.