[NFC] Initialize member pointers to nullptr.

[aaron.ballman]

clang/include/clang/AST/Stmt.h

2606–2607 ↗

(On Diff #552230)

I don't think this initialization is necessary. The constructor for ForStmt initializes all of the valid elements: https://github.com/llvm/llvm-project/blob/87c5a3e203ae3643bc13c9a13917b92a657f4358/clang/lib/AST/Stmt.cpp#L1024

The EmptyShell constructor does not initialize anything but that's because it is piecemeal initialized by the AST importer, but all of its fields are also initialized: https://github.com/llvm/llvm-project/blob/87c5a3e203ae3643bc13c9a13917b92a657f4358/clang/lib/Serialization/ASTReaderStmt.cpp#L296

llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

934

This is necessary to initialize because emitTargetKernel() has an early return which does not initialize the passed reference to this object.

[tahonermann]

clang/include/clang/AST/Stmt.h

2606–2607 ↗

(On Diff #552230)

Declarations like this are common in the AST. I'm curious while static analysis flagged this one in particular. Perhaps it identified a path where one or more of the elements don't get initialized? If so, this would be a good find and a fix should be applied to that path.

[schittir]

clang/include/clang/AST/Stmt.h

2606–2607 ↗

(On Diff #552230)

I will follow-up with this one more and open a different PR if necessary. Removing this change.

2606–2607 ↗

(On Diff #552230)

Thank you for this analysis!

[schittir]

Remove unnecessary initialization.

[tahonermann]

Looks good to me.

llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

934

Return is passed to Builder.CreateIsNotNull(). I briefly inspected and it looks like it handles a null argument, so I agree this looks like the right fix.

[Manna]

This has already been addressed by https://reviews.llvm.org/D157989

[schittir]

In D158488#4607754, @Manna wrote:

This has already been addressed by https://reviews.llvm.org/D157989

Thank you for letting me know. Abandoning this change.

llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::emitKernelLaunch(
   // compiler doesn't need to keep that, and could therefore inline the host
   // function if proven worthwhile during optimization.
 
   // From this point on, we need to have an ID of the target region defined.
   assert(OutlinedFnID && "Invalid outlined function ID!");
   (void)OutlinedFnID;
 
   // Return value of the runtime offloading call.
-  Value *Return;
+  Value *Return = nullptr;
 
   // Arguments for the target kernel.
   SmallVector<Value *> ArgsVector;
   getKernelArgsVector(Args, Builder, ArgsVector);
 
   // The target region is an outlined function launched by the runtime
   // via calls to __tgt_target_kernel().
   //