Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People Manna

Manna (Soumi Manna)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2017, 8:52 AM (312 w, 5 d)

Recent Activity
View All

Tue, Sep 12

Manna added a comment to D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto.

Thank you @tahonermann for reviews and feedbacks.

Tue, Sep 12, 1:43 PM · Restricted Project, Restricted Project

Fri, Sep 8

Manna updated the diff for D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto.
Fri, Sep 8, 9:17 AM · Restricted Project, Restricted Project

Wed, Sep 6

Manna requested review of D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto.
Wed, Sep 6, 2:32 PM · Restricted Project, Restricted Project

Tue, Sep 5

Manna added a comment to D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
In D158293#4629232, @tahonermann wrote:

Thanks, Soumi, looks good to me!

Tue, Sep 5, 12:49 PM · Restricted Project, Restricted Project, Restricted Project
Manna committed rG33b02d766eb8: [NFC][Clang] Fix static code analyzer concern about null value dereference (authored by Manna).
[NFC][Clang] Fix static code analyzer concern about null value dereference
Tue, Sep 5, 12:49 PM · Restricted Project, Restricted Project
Manna closed D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
Tue, Sep 5, 12:49 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Aug 30

Manna added inline comments to D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
Wed, Aug 30, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
Manna updated the diff for D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.

This patch splits all predicates and updates assert messages.

Wed, Aug 30, 12:55 PM · Restricted Project, Restricted Project, Restricted Project
Manna updated the diff for D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.

Thanks @tahonermann for review and feedback. I have added an assert separately to tell which predicate failed if a failure occurs in future.

Wed, Aug 30, 9:52 AM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2023

Manna added a comment to D158227: [clang] EditedSource::applyRewrites - useless call.
In D158227#4610219, @dyung wrote:
In D158227#4610097, @Manna wrote:

The failure seems unrelated to my change.

Hi @Manna, I'm not sure which failure you are referring to, but there is a test failure on at least 2 build bots that seems to have been caused by your change. Can you take a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/48141
https://lab.llvm.org/buildbot/#/builders/216/builds/26116

Aug 23 2023, 8:37 AM · Restricted Project, Restricted Project
Manna added a reverting change for rG9e150adaea7b: [NFC][clang] EditedSource::applyRewrites - useless call: rG969df3ba1076: Revert "[NFC][clang] EditedSource::applyRewrites - useless call".
Aug 23 2023, 8:35 AM · Restricted Project, Restricted Project
Manna committed rG969df3ba1076: Revert "[NFC][clang] EditedSource::applyRewrites - useless call" (authored by Manna).
Revert "[NFC][clang] EditedSource::applyRewrites - useless call"
Aug 23 2023, 8:34 AM · Restricted Project, Restricted Project
Manna added a reverting change for D158227: [clang] EditedSource::applyRewrites - useless call: rG969df3ba1076: Revert "[NFC][clang] EditedSource::applyRewrites - useless call".
Aug 23 2023, 8:34 AM · Restricted Project, Restricted Project
Manna committed rG30c60ec52f15: [NFC][CLANG] Fix static analyzer bugs about large copy by values (authored by Manna).
[NFC][CLANG] Fix static analyzer bugs about large copy by values
Aug 23 2023, 7:58 AM · Restricted Project, Restricted Project
Manna closed D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values.
Aug 23 2023, 7:58 AM · Restricted Project, Restricted Project
Manna added a comment to D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values.

Failure is unrelated to my patch.

Aug 23 2023, 7:54 AM · Restricted Project, Restricted Project
Manna added a comment to D158227: [clang] EditedSource::applyRewrites - useless call.

The failure seems unrelated to my change.

Aug 23 2023, 7:40 AM · Restricted Project, Restricted Project
Manna committed rG9e150adaea7b: [NFC][clang] EditedSource::applyRewrites - useless call (authored by Manna).
[NFC][clang] EditedSource::applyRewrites - useless call
Aug 23 2023, 7:40 AM · Restricted Project, Restricted Project
Manna closed D158227: [clang] EditedSource::applyRewrites - useless call.
Aug 23 2023, 7:39 AM · Restricted Project, Restricted Project
Manna added inline comments to D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
Aug 23 2023, 7:34 AM · Restricted Project, Restricted Project, Restricted Project
Manna updated the diff for D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
Aug 23 2023, 7:31 AM · Restricted Project, Restricted Project, Restricted Project

Aug 22 2023

Manna added a comment to D158488: [NFC] Initialize member pointers to nullptr. .

This has already been addressed by https://reviews.llvm.org/D157989

Aug 22 2023, 12:02 PM · Restricted Project, Restricted Project, Restricted Project
Manna added a comment to D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values.
In D158522#4607628, @tahonermann wrote:

Looks fine to me!

Aug 22 2023, 11:26 AM · Restricted Project, Restricted Project
Manna updated the diff for D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values.

Fix build errors. I have updated CodeGenFunction.h as well.

Aug 22 2023, 10:41 AM · Restricted Project, Restricted Project
Manna added a comment to D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values.
In D158522#4607054, @sdesmalen wrote:

It indeed makes sense to pass these by reference.

Aug 22 2023, 8:52 AM · Restricted Project, Restricted Project
Manna requested review of D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values.
Aug 22 2023, 8:44 AM · Restricted Project, Restricted Project
Manna added a comment to D158227: [clang] EditedSource::applyRewrites - useless call.

Thank you @aaron.ballman for reviews and feedbacks.

Aug 22 2023, 7:29 AM · Restricted Project, Restricted Project
Manna added inline comments to D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
Aug 22 2023, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
Manna updated the summary of D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
Aug 22 2023, 7:23 AM · Restricted Project, Restricted Project, Restricted Project
Manna updated the diff for D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
Aug 22 2023, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2023

Manna requested review of D158295: [NFC][clang][analyzer] Avoid potential dereferencing of null pointer value.
Aug 18 2023, 10:34 AM · Restricted Project, Restricted Project
Manna requested review of D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference.
Aug 18 2023, 9:35 AM · Restricted Project, Restricted Project, Restricted Project
Manna requested review of D158285: [NFC][CLANG] Fix wrong orders of function arguments positions.
Aug 18 2023, 8:07 AM · Restricted Project, Restricted Project

Aug 17 2023

Manna requested review of D158227: [clang] EditedSource::applyRewrites - useless call.
Aug 17 2023, 3:45 PM · Restricted Project, Restricted Project

Aug 16 2023

Manna committed rGbd1ddc5850b1: [NFC][OpenMP] Initialize pointer field (authored by Manna).
[NFC][OpenMP] Initialize pointer field
Aug 16 2023, 7:48 AM · Restricted Project, Restricted Project
Manna closed D157989: [NFC] Initialize pointer field.
Aug 16 2023, 7:48 AM · Restricted Project, Restricted Project

Aug 15 2023

Manna added a comment to D157989: [NFC] Initialize pointer field.

Thank you @tahonermann for reviews and feedbacks.

Aug 15 2023, 8:38 AM · Restricted Project, Restricted Project
Manna requested review of D157989: [NFC] Initialize pointer field.
Aug 15 2023, 7:58 AM · Restricted Project, Restricted Project

Jun 28 2023

Manna committed rGa806ec4857c2: [analyzer] Refactor codes in findMethodDecl() (authored by Manna).
[analyzer] Refactor codes in findMethodDecl()
Jun 28 2023, 8:41 PM · Restricted Project, Restricted Project
Manna closed D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool.
Jun 28 2023, 8:40 PM · Restricted Project, Restricted Project
Manna committed rG7372c0d46d21: [CLANG] Fix potential integer overflow value in getRVVTypeSize() (authored by Manna).
[CLANG] Fix potential integer overflow value in getRVVTypeSize()
Jun 28 2023, 7:30 PM · Restricted Project, Restricted Project
Manna closed D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize().
Jun 28 2023, 7:30 PM · Restricted Project, Restricted Project

Jun 22 2023

Manna committed rG213709e7be03: [CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in… (authored by Manna).
[CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in…
Jun 22 2023, 1:30 PM · Restricted Project, Restricted Project
Manna closed D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID().
Jun 22 2023, 1:30 PM · Restricted Project, Restricted Project
Manna added a comment to D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID().

Thank you @tahonermann and @tra for reviews and comments!

Jun 22 2023, 1:22 PM · Restricted Project, Restricted Project
Manna abandoned D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands().
Jun 22 2023, 1:06 PM · Restricted Project, Restricted Project
Manna added inline comments to D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands().
Jun 22 2023, 1:06 PM · Restricted Project, Restricted Project
Manna committed rG982a87ab74d8: [CLANG] Fix potential null pointer dereference bugs (authored by Manna).
[CLANG] Fix potential null pointer dereference bugs
Jun 22 2023, 1:01 PM · Restricted Project, Restricted Project
Manna closed D153033: [CLANG]Fix potential null pointer dereference bugs.
Jun 22 2023, 1:00 PM · Restricted Project, Restricted Project
Manna added a comment to D153033: [CLANG]Fix potential null pointer dereference bugs.

Thank you for reviews @aaron.ballman!

Jun 22 2023, 12:44 PM · Restricted Project, Restricted Project
Manna committed rG11528fceac6b: [Clang] Fix Static Code Analysis Concerns with copy without assign (authored by Manna).
[Clang] Fix Static Code Analysis Concerns with copy without assign
Jun 22 2023, 12:37 PM · Restricted Project, Restricted Project
Manna closed D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign.
Jun 22 2023, 12:37 PM · Restricted Project, Restricted Project
Manna added a comment to D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign.

Thank you @tahonermann and @aaronpuchert for reviews and comments!

Jun 22 2023, 12:23 PM · Restricted Project, Restricted Project
Manna committed rG5e12f5ab2df1: [CLANG] Fix uninitialized scalar field issues (authored by Manna).
[CLANG] Fix uninitialized scalar field issues
Jun 22 2023, 12:10 PM · Restricted Project, Restricted Project
Manna added a comment to D150744: [NFC][CLANG] Fix uninitialized scalar field issues.

Thank you everyone for reviews!

Jun 22 2023, 12:10 PM · Restricted Project, Restricted Project
Manna closed D150744: [NFC][CLANG] Fix uninitialized scalar field issues.
Jun 22 2023, 12:10 PM · Restricted Project, Restricted Project
Manna updated the diff for D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize().

Thank you @erichkeane for review and comments. I have changed the types of variables MinElts and EltSize to uint64_t instead of the cast.

Jun 22 2023, 7:02 AM · Restricted Project, Restricted Project
Manna added a comment to D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign.

ping @tahonermann

Jun 22 2023, 6:33 AM · Restricted Project, Restricted Project
Manna added a comment to D153033: [CLANG]Fix potential null pointer dereference bugs.

ping @aaron.ballman

Jun 22 2023, 6:31 AM · Restricted Project, Restricted Project

Jun 16 2023

Manna requested review of D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize().
Jun 16 2023, 8:25 AM · Restricted Project, Restricted Project
Manna added inline comments to D153033: [CLANG]Fix potential null pointer dereference bugs.
Jun 16 2023, 7:09 AM · Restricted Project, Restricted Project
Manna updated the diff for D153033: [CLANG]Fix potential null pointer dereference bugs.

Address review comment.

Jun 16 2023, 7:08 AM · Restricted Project, Restricted Project

Jun 15 2023

Manna added a comment to D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool.

Thank you @erichkeane and @steakhal for reviews and comments.

Jun 15 2023, 9:01 PM · Restricted Project, Restricted Project
Manna added reviewers for D153033: [CLANG]Fix potential null pointer dereference bugs: aaron.ballman, tahonermann, aaronpuchert.
Jun 15 2023, 8:52 PM · Restricted Project, Restricted Project
Manna added inline comments to D153033: [CLANG]Fix potential null pointer dereference bugs.
Jun 15 2023, 8:52 PM · Restricted Project, Restricted Project
Manna updated the diff for D153033: [CLANG]Fix potential null pointer dereference bugs.

Address review comment and update patch

Jun 15 2023, 8:50 PM · Restricted Project, Restricted Project
Manna updated the diff for D153033: [CLANG]Fix potential null pointer dereference bugs.

Update patch

Jun 15 2023, 8:40 AM · Restricted Project, Restricted Project
Manna updated the diff for D153033: [CLANG]Fix potential null pointer dereference bugs.

Fix build error

Jun 15 2023, 8:21 AM · Restricted Project, Restricted Project
Manna requested review of D153033: [CLANG]Fix potential null pointer dereference bugs.
Jun 15 2023, 7:57 AM · Restricted Project, Restricted Project

Jun 6 2023

Manna added inline comments to D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands().
Jun 6 2023, 8:14 PM · Restricted Project, Restricted Project
Manna set the repository for D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands() to rG LLVM Github Monorepo.
Jun 6 2023, 8:07 PM · Restricted Project, Restricted Project
Manna added a reviewer for D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands(): sdesmalen.
Jun 6 2023, 8:07 PM · Restricted Project, Restricted Project
Manna updated the diff for D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands().

Thank you @erichkeane and @sdesmalen for reviews and feedbacks.

Jun 6 2023, 8:06 PM · Restricted Project, Restricted Project
Manna updated the summary of D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool.
Jun 6 2023, 7:47 PM · Restricted Project, Restricted Project
Manna updated the diff for D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool.

Thank you @erichkeane and @steakhal for reviews and feedbacks. I have updated patch to address your review comments.

Jun 6 2023, 7:45 PM · Restricted Project, Restricted Project

Jun 5 2023

Manna retitled D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands() from [NFC][CLANG] Fix static analyzer bugs with dereference after null check to [NFC][CLANG] Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands().
Jun 5 2023, 1:46 PM · Restricted Project, Restricted Project
Manna requested review of D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands().
Jun 5 2023, 1:44 PM · Restricted Project, Restricted Project
Manna added inline comments to D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool.
Jun 5 2023, 1:32 PM · Restricted Project, Restricted Project
Manna requested review of D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool.
Jun 5 2023, 1:28 PM · Restricted Project, Restricted Project
Manna committed rG3581e6b857f4: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift() (authored by Manna).
[NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()
Jun 5 2023, 8:13 AM · Restricted Project, Restricted Project
Manna closed D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift().
Jun 5 2023, 8:13 AM · Restricted Project, Restricted Project
Manna added a comment to D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift().

Thank you @erichkeane for reviews!

Jun 5 2023, 8:10 AM · Restricted Project, Restricted Project

Jun 4 2023

Manna requested review of D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift().
Jun 4 2023, 10:18 AM · Restricted Project, Restricted Project
Manna abandoned D151010: [NFC][CLANG] Fix bug with dereference null return value found by static analyzer tool.

This is False Positive. We are correctly matching the type. Closing the PR.

Jun 4 2023, 9:56 AM · Restricted Project, Restricted Project
Manna reclaimed D151010: [NFC][CLANG] Fix bug with dereference null return value found by static analyzer tool.
Jun 4 2023, 9:47 AM · Restricted Project, Restricted Project
Manna retitled D151010: [NFC][CLANG] Fix bug with dereference null return value found by static analyzer tool from [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool to [NFC][CLANG] Fix bug with dereference null return value found by static analyzer tool.
Jun 4 2023, 9:46 AM · Restricted Project, Restricted Project
Manna committed rGb0525f66988e: [NFC][CLANG] [NFC][CLANG] Fix nullptr dereference issue in… (authored by Manna).
[NFC][CLANG] [NFC][CLANG] Fix nullptr dereference issue in…
Jun 4 2023, 9:41 AM · Restricted Project, Restricted Project
Manna closed D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind().
Jun 4 2023, 9:41 AM · Restricted Project, Restricted Project
Manna committed rGc7550310738b: [NFC][CLANG] Fix Static Code Analyzer Concerns (authored by Manna).
[NFC][CLANG] Fix Static Code Analyzer Concerns
Jun 4 2023, 9:11 AM · Restricted Project, Restricted Project
Manna closed D151947: [NFC][CLANG] Fix Static Code Analyzer Concerns.
Jun 4 2023, 9:11 AM · Restricted Project, Restricted Project

Jun 2 2023

Manna committed rG82659941ccb8: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return… (authored by Manna).
[NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return…
Jun 2 2023, 1:48 PM · Restricted Project, Restricted Project
Manna closed D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs().
Jun 2 2023, 1:48 PM · Restricted Project, Restricted Project
Manna committed rG02ce49afb9a0: [NFC][CLANG] Fix bug with dereference null return value in… (authored by Manna).
[NFC][CLANG] Fix bug with dereference null return value in…
Jun 2 2023, 1:28 PM · Restricted Project, Restricted Project
Manna closed D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable().
Jun 2 2023, 1:28 PM · Restricted Project, Restricted Project
Manna added inline comments to D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs().
Jun 2 2023, 6:51 AM · Restricted Project, Restricted Project
Manna added a comment to D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable().

Thank you @erichkeane for reviews!

Jun 2 2023, 6:48 AM · Restricted Project, Restricted Project
Manna added a comment to D151947: [NFC][CLANG] Fix Static Code Analyzer Concerns.

Thank you @erichkeane for reviews!

Jun 2 2023, 6:46 AM · Restricted Project, Restricted Project
Manna added a comment to D151928: [NFC][CLANG] Fix nullptr dereference issue in ConvertQualTypeToKind().

Thank you @erichkeane for reviews!

Jun 2 2023, 6:44 AM · Restricted Project, Restricted Project

Jun 1 2023

Manna requested review of D151964: [NFC][CLANG] Fix Static Code Analyzer Concerns with dereference null return value in applyObjCTypeArgs().
Jun 1 2023, 7:45 PM · Restricted Project, Restricted Project
Manna updated the summary of D151957: [NFC][CLANG] Fix bug with dereference null return value in GetFunctionTypeForVTable().
Jun 1 2023, 6:16 PM · Restricted Project, Restricted Project