This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Remove fixed length lmul max restriction from build_vector tests. NFC
ClosedPublic

Authored by luke on Aug 15 2023, 5:58 AM.

Details

Summary

I'm not sure why the flag was added initially but I find the tests a bit easier
to read with it off, and it matches the default behaviour.

Diff Detail

Event Timeline

luke created this revision.Aug 15 2023, 5:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 5:58 AM
luke requested review of this revision.Aug 15 2023, 5:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 5:58 AM
reames accepted this revision.Aug 16 2023, 2:00 PM

LGTM

This was present in the original test file from https://reviews.llvm.org/D96332. From the review discussion there, this was added before fixed length vectors were mature, and thus probably isn't particularly relevant today.

This revision is now accepted and ready to land.Aug 16 2023, 2:00 PM