This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Split up structs in buildvec tests. NFC
ClosedPublic

Authored by luke on Aug 15 2023, 5:59 AM.

Details

Summary

Some of these tests have multiple vid sequence build_vectors in them, and machine CSE tidies up their output.
But now that small build_vectors are sometimes lowered to scalar vmv.x.ss, the output is harder to read with no CSE, e.g. see buildvec_no_vid_v4i8.

This patch splits them up into separate functions to address this, and also makes the diff in D157976 more clear since it causes vmv.x.s to be lowered to more frequently.

Diff Detail

Event Timeline

luke created this revision.Aug 15 2023, 5:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 5:59 AM
luke requested review of this revision.Aug 15 2023, 5:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 5:59 AM
reames requested changes to this revision.Aug 16 2023, 1:53 PM

Can you rework the change description to describe what's going on here a bit more clearly? In particular, I don't see how this connects to store legalization since none of the tests involve stores?

This revision now requires changes to proceed.Aug 16 2023, 1:53 PM
luke edited the summary of this revision. (Show Details)Aug 17 2023, 3:38 AM
reames accepted this revision.Aug 21 2023, 3:05 PM

LGTM

This revision is now accepted and ready to land.Aug 21 2023, 3:05 PM
This revision was landed with ongoing or failed builds.Aug 22 2023, 3:13 AM
This revision was automatically updated to reflect the committed changes.