This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add test for constant build_vector that could use vid. NFC
ClosedPublic

Authored by luke on Aug 15 2023, 5:59 AM.

Details

Summary

We currently don't lower this to a vid because the addend doesn't fit into a
vadd.vi immediate. An extra li here seems like a small cost to pay for a
constant pool load.

Diff Detail

Event Timeline

luke created this revision.Aug 15 2023, 5:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 5:59 AM
luke requested review of this revision.Aug 15 2023, 5:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2023, 5:59 AM
reames accepted this revision.Aug 16 2023, 1:48 PM

LGTM

This revision is now accepted and ready to land.Aug 16 2023, 1:48 PM
This revision was landed with ongoing or failed builds.Aug 22 2023, 3:13 AM
This revision was automatically updated to reflect the committed changes.