This is an archive of the discontinued LLVM Phabricator instance.

[flang] Add PowerPC vec_lxv, vec_lvsl, vec_lvsr, vec_xl, vec_xl_be and vec_xlds intrinsic
ClosedPublic

Authored by kkwli0 on Aug 14 2023, 2:46 PM.

Details

Summary

This patch is to add PowerPC vec_lxv, vec_lvsl, vec_lvsr, vec_xl, vec_xl_be and vec_xlds intrinsics.

Diff Detail

Event Timeline

kkwli0 created this revision.Aug 14 2023, 2:46 PM
kkwli0 requested review of this revision.Aug 14 2023, 2:46 PM
DanielCChen added inline comments.Aug 17 2023, 9:10 AM
flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
1876

This should be checking the "new" triple now.

kkwli0 marked an inline comment as done.Aug 17 2023, 1:37 PM
kkwli0 added inline comments.
flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
1876

Yes, I will change to check the triple instead.

kkwli0 updated this revision to Diff 551250.Aug 17 2023, 1:38 PM
kkwli0 marked an inline comment as done.

Address comment

DanielCChen added inline comments.Aug 18 2023, 5:33 AM
flang/test/Lower/PowerPC/ppc-vec-load.f90
782

vec_lxvp should be in p10 test file?

kkwli0 marked an inline comment as done.Aug 18 2023, 8:10 AM
kkwli0 added inline comments.
flang/test/Lower/PowerPC/ppc-vec-load.f90
782

Yes, the vec_lxvp test is already in ppc-pwr10-vec-intrinsics.f90. I will remove the test here.

kkwli0 updated this revision to Diff 551520.Aug 18 2023, 8:15 AM
kkwli0 marked an inline comment as done.
  • Address review comment - remove vec_lxvp test from ppc-vec-load.f90 as those tests already exist in ppc-pwr10-vec-intrinsics.f90
  • Rebase
This revision is now accepted and ready to land.Aug 18 2023, 8:18 AM