This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Make mapping symbols SF_FormatSpecific
ClosedPublic

Authored by jobnoorman on Jul 25 2023, 6:44 AM.

Details

Summary

This ensures that llvm-symbolizer ignores them for symbolization.

Note: unlike aarch64-mapping-symbol.s, the test included here does not
test if the mapping symbols are actually in the symbol table. The reason
is that llvm-mc support for RISC-V mapping symbols (D153260) has not
landed yet, so the mapping symbols simply aren't there. However, D153260
would like to depend on this patch together with D156190 to avoid having
to update a large amount of tests.

Diff Detail

Event Timeline

jobnoorman created this revision.Jul 25 2023, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2023, 6:44 AM
jobnoorman requested review of this revision.Jul 25 2023, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2023, 6:44 AM
MaskRay accepted this revision.Jul 27 2023, 12:48 PM
This revision is now accepted and ready to land.Jul 27 2023, 12:48 PM
MaskRay added inline comments.Jul 27 2023, 8:20 PM
llvm/test/DebugInfo/Symbolize/ELF/riscv-mapping-symbol.s
4

llvm-nm verification for other architectures is useful.

Due to how the llvm-nm code is currently constructed, consider adding tools/llvm-nm/special-syms-riscv.test as well.

jhenderson added inline comments.Jul 27 2023, 11:58 PM
llvm/test/DebugInfo/Symbolize/ELF/riscv-mapping-symbol.s
2
jobnoorman marked an inline comment as done.Jul 28 2023, 1:16 AM

Due to how the llvm-nm code is currently constructed, consider adding tools/llvm-nm/special-syms-riscv.test as well.

I've opened D156514 for this as some changes to llvm-nm were needed.

llvm/test/DebugInfo/Symbolize/ELF/riscv-mapping-symbol.s
4

I'm not entirely sure what you mean by this. Are you talking about the special-syms test for llvm-nm?

This revision was landed with ongoing or failed builds.Jul 28 2023, 1:22 AM
This revision was automatically updated to reflect the committed changes.