For an explanation of these patches see D154153.
Commit message:
This patch adds the GPUTargetAttrInterface attribute interface, this interface
is meant to be used as an opaque interface for serializing GPU modules into
binary strings.
Paths
| Differential D154104
[mlir][gpu] Add GPU target attribute interface. ClosedPublic Authored by fmorac on Jun 29 2023, 9:06 AM.
Details Summary For an explanation of these patches see D154153. Commit message:
Diff Detail
Event Timelinefmorac added a child revision: D154108: [mlir][gpu] Add the GPU offloading handler attribute interface..Jun 29 2023, 9:43 AM fmorac added a child revision: D154113: [mlir][gpu] Add target attribute to GPU modules..Jun 29 2023, 10:12 AM fmorac removed a child revision: D154108: [mlir][gpu] Add the GPU offloading handler attribute interface..Jun 29 2023, 1:25 PM fmorac added a child revision: D154108: [mlir][gpu] Add the GPU offloading handler attribute interface..Jun 29 2023, 5:40 PM fmorac removed a child revision: D154108: [mlir][gpu] Add the GPU offloading handler attribute interface..Jun 29 2023, 5:42 PM Comment Actions This has memory safety issues.
This revision now requires changes to proceed.Jul 13 2023, 12:03 PM
This revision is now accepted and ready to land.Jul 24 2023, 7:07 AM Comment Actions Moved the compilation attributes from GPUDialect.h to CompilationInterfaces.h so they can be used by any dialect without including GPUDialect.h. Comment Actions Changed the error in the default implementation. There's a bug on tablegen, it crashes with: code ... = [{ #ifdef ... #endif }]; because of a lexing error when included from another file. Comment Actions Added cmdOptions to TargetOptions for passing raw command line options. Added a CompilationTarget option for specifying the final represation of the process (LLVM, Assembly, Binary). Closed by commit rG86c4dfa209b5: [mlir][gpu] Add GPU target attribute interface. (authored by fmorac). · Explain WhyAug 8 2023, 6:11 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 548182 mlir/include/mlir/Dialect/GPU/IR/CMakeLists.txt
mlir/include/mlir/Dialect/GPU/IR/CompilationAttrInterfaces.td
mlir/include/mlir/Dialect/GPU/IR/CompilationInterfaces.h
mlir/include/mlir/Dialect/GPU/IR/GPUDialect.h
mlir/lib/Dialect/GPU/CMakeLists.txt
mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
|
Seems implied by the fact that there is no default implementation?