Several headers that are included by the modular headers are missing from the module map, add those in.
The either/or implementation headers <__algorithm/pstl_backends/cpu_backends/serial.h>/<__algorithm/pstl_backends/cpu_backends/thread.h> need to be textual, as does <__undef_macros>.
Details
- Reviewers
ldionne Mordante philnik Bigcheese - Group Reviewers
Restricted Project - Commits
- rG6f05da6cf8b9: [libc++][Modules] Add missing submodules
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/include/__algorithm/pstl_replace.h | ||
---|---|---|
15 | This include is necessary once pstl_replace.h gets a module because pstl_transform.h isn't even transitively included from this file. It works as a textual header only if the included includes pstl_transform.h first, but as a modular header it requires the include. | |
15 | only if the *includer* includes pstl_transform.h |
libcxx/utils/libcxx/test/header_information.py | ||
---|---|---|
73–86 | What happens if you just drop this diff entirely? Does libcxx/test/libcxx/private_headers.gen.py start failing (and how)? |
libcxx/utils/libcxx/test/header_information.py | ||
---|---|---|
73–86 | Let me see, it was originally failing with __iterator/readable_traits.h on an earlier version of the stack and I just added these later. |
Restore the changes to header_information.py, but pare it down to just the headers that newly got modules and aren't standalone.
This include is necessary once pstl_replace.h gets a module because pstl_transform.h isn't even transitively included from this file. It works as a textual header only if the included includes pstl_transform.h first, but as a modular header it requires the include.