This is an archive of the discontinued LLVM Phabricator instance.

[libc++][PSTL] Make the PSTL submodules only have one header
ClosedPublic

Authored by iana on May 12 2023, 6:37 PM.

Details

Summary

Module map generation for the private detail headers is easier done if each private header is by itself in a submodule. Move the __algorithm/pstl_backends into their own submodules.

Diff Detail

Event Timeline

iana created this revision.May 12 2023, 6:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2023, 6:37 PM
Herald added a subscriber: ributzka. · View Herald Transcript
iana requested review of this revision.May 12 2023, 6:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2023, 6:37 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
iana added inline comments.May 12 2023, 6:38 PM
libcxx/test/libcxx/lint/lint_modulemap.sh.py
32

This isn't a perfect regex, it's only matching backend.h instead of cpu_backend.h. It's probably ok enough?

iana added inline comments.May 13 2023, 2:11 PM
libcxx/test/libcxx/lint/lint_modulemap.sh.py
32

It's also about to not matter because the private submodules are going to be generated.

philnik accepted this revision.May 13 2023, 3:54 PM
This revision is now accepted and ready to land.May 13 2023, 3:54 PM
iana updated this revision to Diff 521970.May 13 2023, 11:01 PM

Add one more export

This revision was landed with ongoing or failed builds.May 13 2023, 11:02 PM
This revision was automatically updated to reflect the committed changes.