This is an archive of the discontinued LLVM Phabricator instance.

[libc++][PSTL] Add missing includes to PSTL headers
ClosedPublic

Authored by iana on May 7 2023, 9:41 PM.

Details

Summary

Several PSTL headers included by <algorithm> are missing includes for things they use.
Switch some quoted includes to angle includes.

(Issues found from running check-cxx with https://reviews.llvm.org/D144322)

Diff Detail

Event Timeline

iana created this revision.May 7 2023, 9:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 9:41 PM
iana requested review of this revision.May 7 2023, 9:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 9:41 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 10 2023, 9:32 AM

LGTM but this needs to be rebased onto main.

This revision is now accepted and ready to land.May 10 2023, 9:32 AM
iana edited the summary of this revision. (Show Details)May 10 2023, 10:07 AM
ldionne accepted this revision.May 10 2023, 10:35 AM
This revision was automatically updated to reflect the committed changes.