This is an archive of the discontinued LLVM Phabricator instance.

Revert "[libc++] Remove the type_traits includes from limits and new"
ClosedPublic

Authored by iana on Jul 7 2023, 2:15 PM.

Details

Summary

type_traits doesn't need to include __type_traits/noexcept_move_assign_container.h, so there is no include cycle from <limits> or <new>. Restore their includes of type_traits to preserve compatibility.

This reverts commit 2af6d79c7e38675a184280a2d6a92550702581f7.

Diff Detail

Event Timeline

iana created this revision.Jul 7 2023, 2:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2023, 2:15 PM
Herald added a subscriber: ributzka. · View Herald Transcript
iana requested review of this revision.Jul 7 2023, 2:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2023, 2:15 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jul 7 2023, 2:18 PM

LGTM if CI passes. This will make LLVM 17 less breaking for users.

This revision is now accepted and ready to land.Jul 7 2023, 2:18 PM
iana edited the summary of this revision. (Show Details)Jul 7 2023, 2:52 PM